Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4559

Make leader elector and zk store share the same curator client

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      After YARN-4438, we can reuse the same curator client for leader elector and zk store

      1. YARN-4559.1.patch
        26 kB
        Jian He
      2. YARN-4559.2.patch
        26 kB
        Jian He
      3. YARN-4559.3.patch
        28 kB
        Jian He
      4. YARN-4559.4.patch
        28 kB
        Jian He

        Issue Links

          Activity

          Hide
          kasha Karthik Kambatla added a comment -

          Just pulled this back into branch-2.8 as well.

          Show
          kasha Karthik Kambatla added a comment - Just pulled this back into branch-2.8 as well.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9143 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9143/)
          YARN-4559. Make leader elector and zk store share the same curator (xgong: rev 890a2ebd1af51d24ccbbc5d1d65d17b24ad8ab9b)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStoreZKClientConnections.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/LeaderElectorService.java
          • hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStorePerf.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9143 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9143/ ) YARN-4559 . Make leader elector and zk store share the same curator (xgong: rev 890a2ebd1af51d24ccbbc5d1d65d17b24ad8ab9b) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStoreZKClientConnections.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/LeaderElectorService.java hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestZKRMStateStorePerf.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
          Hide
          xgong Xuan Gong added a comment -

          Committed into trunk/branch-2. Thanks, Jian

          Show
          xgong Xuan Gong added a comment - Committed into trunk/branch-2. Thanks, Jian
          Hide
          xgong Xuan Gong added a comment -

          +1 lgtm. checking this in

          Show
          xgong Xuan Gong added a comment - +1 lgtm. checking this in
          Hide
          jianhe Jian He added a comment -

          the test failures are not related.

          Show
          jianhe Jian He added a comment - the test failures are not related.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 40s Maven dependency ordering for branch
          +1 mvninstall 7m 45s trunk passed
          +1 compile 1m 46s trunk passed with JDK v1.8.0_66
          +1 compile 2m 7s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 3m 15s trunk passed
          +1 mvneclipse 0m 36s trunk passed
          0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 1m 10s trunk passed
          +1 javadoc 2m 16s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 53s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 2m 40s the patch passed
          +1 compile 1m 44s the patch passed with JDK v1.8.0_66
          +1 javac 1m 44s the patch passed
          +1 compile 2m 5s the patch passed with JDK v1.7.0_91
          +1 javac 2m 5s the patch passed
          -1 checkstyle 0m 27s hadoop-yarn-project/hadoop-yarn: patch generated 5 new + 105 unchanged - 1 fixed = 110 total (was 106)
          +1 mvnsite 3m 9s the patch passed
          +1 mvneclipse 0m 32s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 1m 22s the patch passed
          +1 javadoc 2m 5s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 50s the patch passed with JDK v1.7.0_91
          -1 unit 81m 17s hadoop-yarn in the patch failed with JDK v1.8.0_66.
          -1 unit 65m 16s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 83m 50s hadoop-yarn in the patch failed with JDK v1.7.0_91.
          -1 unit 66m 17s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          342m 20s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782626/YARN-4559.4.patch
          JIRA Issue YARN-4559
          Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
          uname Linux ae74e2a4f601 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a44ce3f
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10324/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10324/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 40s Maven dependency ordering for branch +1 mvninstall 7m 45s trunk passed +1 compile 1m 46s trunk passed with JDK v1.8.0_66 +1 compile 2m 7s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 28s trunk passed +1 mvnsite 3m 15s trunk passed +1 mvneclipse 0m 36s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 10s trunk passed +1 javadoc 2m 16s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 53s trunk passed with JDK v1.7.0_91 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 2m 40s the patch passed +1 compile 1m 44s the patch passed with JDK v1.8.0_66 +1 javac 1m 44s the patch passed +1 compile 2m 5s the patch passed with JDK v1.7.0_91 +1 javac 2m 5s the patch passed -1 checkstyle 0m 27s hadoop-yarn-project/hadoop-yarn: patch generated 5 new + 105 unchanged - 1 fixed = 110 total (was 106) +1 mvnsite 3m 9s the patch passed +1 mvneclipse 0m 32s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 22s the patch passed +1 javadoc 2m 5s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 50s the patch passed with JDK v1.7.0_91 -1 unit 81m 17s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 65m 16s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 83m 50s hadoop-yarn in the patch failed with JDK v1.7.0_91. -1 unit 66m 17s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 342m 20s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782626/YARN-4559.4.patch JIRA Issue YARN-4559 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux ae74e2a4f601 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a44ce3f Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10324/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10324/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10324/console This message was automatically generated.
          Hide
          xgong Xuan Gong added a comment -

          The last patch looks good to me.

          Looks like the test cases failures are not related. Manually kick the Jenkins again.

          Karthik Kambatla Do you have any other comments ?

          Show
          xgong Xuan Gong added a comment - The last patch looks good to me. Looks like the test cases failures are not related. Manually kick the Jenkins again. Karthik Kambatla Do you have any other comments ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 29s Maven dependency ordering for branch
          +1 mvninstall 8m 32s trunk passed
          +1 compile 2m 7s trunk passed with JDK v1.8.0_66
          +1 compile 2m 17s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 3m 38s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 1m 19s trunk passed
          +1 javadoc 2m 38s trunk passed with JDK v1.8.0_66
          +1 javadoc 5m 9s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 20s Maven dependency ordering for patch
          +1 mvninstall 2m 52s the patch passed
          +1 compile 1m 59s the patch passed with JDK v1.8.0_66
          +1 javac 1m 59s the patch passed
          +1 compile 2m 11s the patch passed with JDK v1.7.0_91
          +1 javac 2m 11s the patch passed
          -1 checkstyle 0m 30s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 106, now 110).
          +1 mvnsite 3m 24s the patch passed
          +1 mvneclipse 0m 36s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 1m 27s the patch passed
          +1 javadoc 2m 38s the patch passed with JDK v1.8.0_66
          +1 javadoc 5m 21s the patch passed with JDK v1.7.0_91
          -1 unit 87m 25s hadoop-yarn in the patch failed with JDK v1.8.0_66.
          -1 unit 64m 18s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 83m 42s hadoop-yarn in the patch failed with JDK v1.7.0_91.
          -1 unit 65m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          351m 22s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782626/YARN-4559.4.patch
          JIRA Issue YARN-4559
          Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
          uname Linux b519e18f38c8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2a30386
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10309/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10309/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 29s Maven dependency ordering for branch +1 mvninstall 8m 32s trunk passed +1 compile 2m 7s trunk passed with JDK v1.8.0_66 +1 compile 2m 17s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 29s trunk passed +1 mvnsite 3m 38s trunk passed +1 mvneclipse 0m 42s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 19s trunk passed +1 javadoc 2m 38s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 9s trunk passed with JDK v1.7.0_91 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 2m 52s the patch passed +1 compile 1m 59s the patch passed with JDK v1.8.0_66 +1 javac 1m 59s the patch passed +1 compile 2m 11s the patch passed with JDK v1.7.0_91 +1 javac 2m 11s the patch passed -1 checkstyle 0m 30s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 106, now 110). +1 mvnsite 3m 24s the patch passed +1 mvneclipse 0m 36s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 27s the patch passed +1 javadoc 2m 38s the patch passed with JDK v1.8.0_66 +1 javadoc 5m 21s the patch passed with JDK v1.7.0_91 -1 unit 87m 25s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 64m 18s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 83m 42s hadoop-yarn in the patch failed with JDK v1.7.0_91. -1 unit 65m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 351m 22s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782626/YARN-4559.4.patch JIRA Issue YARN-4559 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux b519e18f38c8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2a30386 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10309/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10309/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10309/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          0 mvndep 0m 44s Maven dependency ordering for branch
          +1 mvninstall 9m 28s trunk passed
          +1 compile 2m 12s trunk passed with JDK v1.8.0_66
          +1 compile 2m 17s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 31s trunk passed
          +1 mvnsite 3m 25s trunk passed
          +1 mvneclipse 0m 37s trunk passed
          0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 1m 18s trunk passed
          +1 javadoc 2m 22s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 57s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 20s Maven dependency ordering for patch
          +1 mvninstall 2m 45s the patch passed
          +1 compile 1m 56s the patch passed with JDK v1.8.0_66
          +1 javac 1m 56s the patch passed
          +1 compile 2m 12s the patch passed with JDK v1.7.0_91
          +1 javac 2m 12s the patch passed
          -1 checkstyle 0m 31s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 108, now 112).
          +1 mvnsite 3m 17s the patch passed
          +1 mvneclipse 0m 33s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn
          -1 findbugs 1m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 1 new FindBugs issues.
          +1 javadoc 2m 17s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 59s the patch passed with JDK v1.7.0_91
          -1 unit 76m 56s hadoop-yarn in the patch failed with JDK v1.8.0_66.
          -1 unit 60m 57s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 78m 3s hadoop-yarn in the patch failed with JDK v1.7.0_91.
          -1 unit 61m 55s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          327m 40s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.RMStateStore.resourceManager; locked 60% of time Unsynchronized access at RMStateStore.java:60% of time Unsynchronized access at RMStateStore.java:[line 1183]
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782475/YARN-4559.3.patch
          JIRA Issue YARN-4559
          Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
          uname Linux 74d57500a4b9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1da762c
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10299/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10299/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 44s Maven dependency ordering for branch +1 mvninstall 9m 28s trunk passed +1 compile 2m 12s trunk passed with JDK v1.8.0_66 +1 compile 2m 17s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 31s trunk passed +1 mvnsite 3m 25s trunk passed +1 mvneclipse 0m 37s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 18s trunk passed +1 javadoc 2m 22s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 57s trunk passed with JDK v1.7.0_91 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 2m 45s the patch passed +1 compile 1m 56s the patch passed with JDK v1.8.0_66 +1 javac 1m 56s the patch passed +1 compile 2m 12s the patch passed with JDK v1.7.0_91 +1 javac 2m 12s the patch passed -1 checkstyle 0m 31s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 108, now 112). +1 mvnsite 3m 17s the patch passed +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn -1 findbugs 1m 25s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 1 new FindBugs issues. +1 javadoc 2m 17s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 59s the patch passed with JDK v1.7.0_91 -1 unit 76m 56s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 60m 57s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 78m 3s hadoop-yarn in the patch failed with JDK v1.7.0_91. -1 unit 61m 55s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 327m 40s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.RMStateStore.resourceManager; locked 60% of time Unsynchronized access at RMStateStore.java:60% of time Unsynchronized access at RMStateStore.java: [line 1183] JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782475/YARN-4559.3.patch JIRA Issue YARN-4559 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux 74d57500a4b9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1da762c Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html unit https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10299/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10299/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10299/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 7m 48s trunk passed
          +1 compile 0m 31s trunk passed with JDK v1.8.0_66
          +1 compile 0m 32s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 0m 39s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 1m 14s trunk passed
          +1 javadoc 0m 24s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 27s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 31s the patch passed
          +1 compile 0m 26s the patch passed with JDK v1.8.0_66
          +1 javac 0m 26s the patch passed
          +1 compile 0m 27s the patch passed with JDK v1.7.0_91
          +1 javac 0m 27s the patch passed
          -1 checkstyle 0m 14s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager (total was 108, now 112).
          +1 mvnsite 0m 35s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 1m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 1 new FindBugs issues.
          +1 javadoc 0m 19s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 25s the patch passed with JDK v1.7.0_91
          -1 unit 60m 45s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 61m 40s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          140m 29s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.RMStateStore.resourceManager; locked 60% of time Unsynchronized access at RMStateStore.java:60% of time Unsynchronized access at RMStateStore.java:[line 1183]
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782389/YARN-4559.2.patch
          JIRA Issue YARN-4559
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1b857970f645 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / cdf8895
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10295/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10295/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10295/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10295/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10295/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10295/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10295/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10295/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 48s trunk passed +1 compile 0m 31s trunk passed with JDK v1.8.0_66 +1 compile 0m 32s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 14s trunk passed +1 javadoc 0m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 27s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 31s the patch passed +1 compile 0m 26s the patch passed with JDK v1.8.0_66 +1 javac 0m 26s the patch passed +1 compile 0m 27s the patch passed with JDK v1.7.0_91 +1 javac 0m 27s the patch passed -1 checkstyle 0m 14s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager (total was 108, now 112). +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 1m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 1 new FindBugs issues. +1 javadoc 0m 19s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 25s the patch passed with JDK v1.7.0_91 -1 unit 60m 45s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 61m 40s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 140m 29s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   Inconsistent synchronization of org.apache.hadoop.yarn.server.resourcemanager.recovery.RMStateStore.resourceManager; locked 60% of time Unsynchronized access at RMStateStore.java:60% of time Unsynchronized access at RMStateStore.java: [line 1183] JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStorePerf   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782389/YARN-4559.2.patch JIRA Issue YARN-4559 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1b857970f645 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cdf8895 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10295/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10295/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html unit https://builds.apache.org/job/PreCommit-YARN-Build/10295/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10295/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10295/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10295/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10295/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10295/console This message was automatically generated.
          Hide
          kasha Karthik Kambatla added a comment -

          There "could" be other stores that provide the same guarantees as zk-store.

          Show
          kasha Karthik Kambatla added a comment - There "could" be other stores that provide the same guarantees as zk-store.
          Hide
          jianhe Jian He added a comment -

          ZK-leader election with a different store.

          I think currently only zk-store supports fencing, which means user must use zk-store for failover ?

          Show
          jianhe Jian He added a comment - ZK-leader election with a different store. I think currently only zk-store supports fencing, which means user must use zk-store for failover ?
          Hide
          kasha Karthik Kambatla added a comment -

          I think the best way is just to merge the LeaderElectorService logic into ZKRMStateStore itself.

          I am not sure that is a good idea. Users might want to use ZK-leader election with a different store.

          Show
          kasha Karthik Kambatla added a comment - I think the best way is just to merge the LeaderElectorService logic into ZKRMStateStore itself. I am not sure that is a good idea. Users might want to use ZK-leader election with a different store.
          Hide
          jianhe Jian He added a comment -

          new patch moved the curator#close in RM#serviceStop.

          I cannot move the curator client creation into to LeaderElectorService because LeaderElectorService will not be created if HA is not enabled.
          I think the best way is just to merge the LeaderElectorService logic into ZKRMStateStore itself. But that requires more refactoring on ZKRMStateStore because ZKRMStateStore is not an alwaysOn service.

          Show
          jianhe Jian He added a comment - new patch moved the curator#close in RM#serviceStop. I cannot move the curator client creation into to LeaderElectorService because LeaderElectorService will not be created if HA is not enabled. I think the best way is just to merge the LeaderElectorService logic into ZKRMStateStore itself. But that requires more refactoring on ZKRMStateStore because ZKRMStateStore is not an alwaysOn service.
          Hide
          xgong Xuan Gong added a comment -

          Thanks, Jian for working on this, and Thanks, Karithik for the review.

          The patch looks good overall. I do not have any other comments other than Karithik's previous comment.

          But I have one general concern for this:
          1. Can we move ResourceManager#createAndStartCurator() from ResourceManager into LeaderElectorService ? Otherwise, it looks like we only support ZK as leaderElector Service. Currently, it is true. But I still think that we can add one more level abstraction for the LeaderElector Service, and let current LeaderElectorService extends/inherent from it ? Basically, move all the curator related code from ResourceManager.java to LeaderElectorService.java.

          Show
          xgong Xuan Gong added a comment - Thanks, Jian for working on this, and Thanks, Karithik for the review. The patch looks good overall. I do not have any other comments other than Karithik's previous comment. But I have one general concern for this: 1. Can we move ResourceManager#createAndStartCurator() from ResourceManager into LeaderElectorService ? Otherwise, it looks like we only support ZK as leaderElector Service. Currently, it is true. But I still think that we can add one more level abstraction for the LeaderElector Service, and let current LeaderElectorService extends/inherent from it ? Basically, move all the curator related code from ResourceManager.java to LeaderElectorService.java.
          Hide
          jianhe Jian He added a comment -

          My preference would be for doing it in the RM

          yep, I can move the close into RM#ServiceStop

          The ZK-store specific configs

          That's my original intention too, but the problem is that the curator client creation depends on the RM username:password.

          Show
          jianhe Jian He added a comment - My preference would be for doing it in the RM yep, I can move the close into RM#ServiceStop The ZK-store specific configs That's my original intention too, but the problem is that the curator client creation depends on the RM username:password.
          Hide
          kasha Karthik Kambatla added a comment -

          Quickly skimmed through the patch. High-level comments:

          1. Curator start and close should be in the same class. Let us do that both in the RM or both in the elector service. My preference would be for doing it in the RM. Is there any reason that wouldn't work?
          2. The ZK-store specific configs - adding the RM username:password for exclusivity should likely be done in the serviceInit of the store.
          Show
          kasha Karthik Kambatla added a comment - Quickly skimmed through the patch. High-level comments: Curator start and close should be in the same class. Let us do that both in the RM or both in the elector service. My preference would be for doing it in the RM. Is there any reason that wouldn't work? The ZK-store specific configs - adding the RM username:password for exclusivity should likely be done in the serviceInit of the store.

            People

            • Assignee:
              jianhe Jian He
              Reporter:
              jianhe Jian He
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development