Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4551

Address the duplication between StatusUpdateWhenHealthy and StatusUpdateWhenUnhealthy transitions

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      sunilg Sunil G added a comment -

      Thank you Karthik Kambatla for the review and commit!

      Show
      sunilg Sunil G added a comment - Thank you Karthik Kambatla for the review and commit!
      Hide
      kasha Karthik Kambatla added a comment -

      Thanks for working on this, Sunil G. Just committed this to trunk and branch-2.

      Show
      kasha Karthik Kambatla added a comment - Thanks for working on this, Sunil G . Just committed this to trunk and branch-2.
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-trunk-Commit #9101 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9101/)
      YARN-4551. Address the duplication between StatusUpdateWhenHealthy and (kasha: rev 321072ba8114ed5ad2e9c5c2cfd7e1a54def6ebe)

      • hadoop-yarn-project/CHANGES.txt
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9101 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9101/ ) YARN-4551 . Address the duplication between StatusUpdateWhenHealthy and (kasha: rev 321072ba8114ed5ad2e9c5c2cfd7e1a54def6ebe) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
      Hide
      kasha Karthik Kambatla added a comment -

      +1

      Show
      kasha Karthik Kambatla added a comment - +1
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 0s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 7m 34s trunk passed
      +1 compile 0m 28s trunk passed with JDK v1.8.0_66
      +1 compile 0m 31s trunk passed with JDK v1.7.0_91
      +1 checkstyle 0m 14s trunk passed
      +1 mvnsite 0m 37s trunk passed
      +1 mvneclipse 0m 15s trunk passed
      +1 findbugs 1m 13s trunk passed
      +1 javadoc 0m 22s trunk passed with JDK v1.8.0_66
      +1 javadoc 0m 27s trunk passed with JDK v1.7.0_91
      +1 mvninstall 0m 32s the patch passed
      +1 compile 0m 24s the patch passed with JDK v1.8.0_66
      +1 javac 0m 24s the patch passed
      +1 compile 0m 28s the patch passed with JDK v1.7.0_91
      +1 javac 0m 28s the patch passed
      +1 checkstyle 0m 13s the patch passed
      +1 mvnsite 0m 35s the patch passed
      +1 mvneclipse 0m 12s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      +1 findbugs 1m 15s the patch passed
      +1 javadoc 0m 19s the patch passed with JDK v1.8.0_66
      +1 javadoc 0m 25s the patch passed with JDK v1.7.0_91
      -1 unit 65m 18s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
      -1 unit 69m 17s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
      +1 asflicense 0m 18s Patch does not generate ASF License warnings.
      152m 3s



      Reason Tests
      JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization
      JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:0ca8df7
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781252/0001-YARN-4551.patch
      JIRA Issue YARN-4551
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 894dacf75608 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / c0537bc
      Default Java 1.7.0_91
      Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
      findbugs v3.0.0
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10261/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/10261/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10261/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10261/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
      JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10261/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
      Max memory used 76MB
      Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/10261/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 34s trunk passed +1 compile 0m 28s trunk passed with JDK v1.8.0_66 +1 compile 0m 31s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 13s trunk passed +1 javadoc 0m 22s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 27s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 32s the patch passed +1 compile 0m 24s the patch passed with JDK v1.8.0_66 +1 javac 0m 24s the patch passed +1 compile 0m 28s the patch passed with JDK v1.7.0_91 +1 javac 0m 28s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 15s the patch passed +1 javadoc 0m 19s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 25s the patch passed with JDK v1.7.0_91 -1 unit 65m 18s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 69m 17s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 152m 3s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781252/0001-YARN-4551.patch JIRA Issue YARN-4551 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 894dacf75608 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c0537bc Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10261/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10261/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10261/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10261/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10261/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10261/console This message was automatically generated.
      Hide
      sunilg Sunil G added a comment -

      Attaching a patch after cleaning up the StatusHealthy/UnHealthy transitions.

      Show
      sunilg Sunil G added a comment - Attaching a patch after cleaning up the StatusHealthy/UnHealthy transitions.
      Hide
      sunilg Sunil G added a comment -

      Yes Karthik Kambatla , This will definitely clean up some code there. I could help here if you are not planning.

      Show
      sunilg Sunil G added a comment - Yes Karthik Kambatla , This will definitely clean up some code there. I could help here if you are not planning.

        People

        • Assignee:
          sunilg Sunil G
          Reporter:
          kasha Karthik Kambatla
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development