[YARN-4547] LeafQueue#getApplications() is read-only interface, but it provides reference to caller

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Done
• Component/s: capacity scheduler
• Assignee: Rohith Sharma K S
• Reporter: Rohith Sharma K S
• Created: 06/Jan/16 05:53
• Updated: 17/Feb/16 08:22
• Resolved: 17/Feb/16 06:10

Description

The below API is read-only interface, but returning reference to the caller. This causing caller to modify the orderingPolicy entities. If required reference of ordering policy, caller can use LeagQueue#getOrderingPolicy()#getSchedulableEntities()

The returning object should be clone of orderingPolicy.getSchedulableEntities()

  /**
   * Obtain (read-only) collection of active applications.
   */
  public Collection<FiCaSchedulerApp> getApplications() {
    return orderingPolicy.getSchedulableEntities();
  }