[YARN-4543] TestNodeStatusUpdater.testStopReentrant fails + JUnit misusage

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: nodemanager
• Hadoop Flags: Reviewed
• Assignee: Akihiro Suda
• Reporter: Akihiro Suda
• Created: 05/Jan/16 10:27
• Updated: 03/Oct/16 16:08
• Resolved: 29/Jan/16 07:02

Description

TestNodeStatusUpdater.testStopReentrant:1269 expected:<0> but was:<1>

https://github.com/apache/hadoop/blob/4ac6799d4a8b071e0d367c2d709e84d8ea06942d/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNodeStatusUpdater.java#L1269

The corresponding JUnit assertion code is:

Assert.assertEquals(numCleanups.get(), 1);

It seems that the 1st arg and the 2nd one should be swapped.

Issue Links

• is related to: HADOOP-12693 Many misusages of assertEquals(expected, actual)