Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-1963 Support priorities across applications within the same queue
  3. YARN-4537

Pull out priority comparison from fifocomparator and use compound comparator for FifoOrdering policy

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Currently, priority comparison is integrated with FifoComparator. There should be a separate comparator defined for priority comparison so that down the line if any new ordering policy wants to integrate priority, they can use compound comparator where priority will be high preference.

      The following changes are expected to be done as part of this JIRA

      1. Pull out priority comparison from FifoComparator
      2. Define new priority comparator
      3. Use compound comparator for FifoOrderingPolicy. Oder of preference is Priority,FIFO
      1. 0001-YARN-4537.patch
        9 kB
        Rohith Sharma K S
      2. 0002-YARN-4537.patch
        12 kB
        Rohith Sharma K S
      3. 0003-YARN-4537.patch
        8 kB
        Rohith Sharma K S
      4. 0003-YARN-4537.patch
        8 kB
        Rohith Sharma K S

        Activity

        Hide
        sunilg Sunil G added a comment -

        Thanks Rohith Sharma K S for sharing the patch.
        Generally patch looks good.

        Few minor nits:
        1.

        private CompoundComparator fifoComparator;
        

        I feel this variable is not needed in FifoOrderingPolicy

        2. Also in PriorityComparator if needed we can remove the temporary variable res.
        3. TestFifoOrderingPolicy, could u pls add a case where priority is null too. Since we have a comparator, its good we have a case for all corner cases.

        Show
        sunilg Sunil G added a comment - Thanks Rohith Sharma K S for sharing the patch. Generally patch looks good. Few minor nits: 1. private CompoundComparator fifoComparator; I feel this variable is not needed in FifoOrderingPolicy 2. Also in PriorityComparator if needed we can remove the temporary variable res . 3. TestFifoOrderingPolicy , could u pls add a case where priority is null too. Since we have a comparator, its good we have a case for all corner cases.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        updated the patch fixing comments

        Show
        rohithsharma Rohith Sharma K S added a comment - updated the patch fixing comments
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 41s trunk passed
        +1 compile 1m 45s trunk passed with JDK v1.8.0_66
        +1 compile 2m 11s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 2m 33s trunk passed
        +1 mvneclipse 0m 20s trunk passed
        -1 findbugs 6m 20s branch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml)
        +1 javadoc 1m 53s trunk passed with JDK v1.8.0_66
        +1 javadoc 4m 17s trunk passed with JDK v1.7.0_91
        +1 mvninstall 2m 1s the patch passed
        +1 compile 1m 45s the patch passed with JDK v1.8.0_66
        +1 javac 1m 45s the patch passed
        +1 compile 2m 4s the patch passed with JDK v1.7.0_91
        +1 javac 2m 4s the patch passed
        +1 checkstyle 0m 28s the patch passed
        +1 mvnsite 2m 33s the patch passed
        +1 mvneclipse 0m 19s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        -1 findbugs 6m 16s patch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml)
        +1 javadoc 1m 44s the patch passed with JDK v1.8.0_66
        +1 javadoc 4m 14s the patch passed with JDK v1.7.0_91
        -1 unit 80m 5s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 unit 82m 43s hadoop-yarn in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        212m 56s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780302/0001-YARN-4537.patch
        JIRA Issue YARN-4537
        Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
        uname Linux bab2f4eb2e04 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1af2917
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10143/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10143/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10143/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10143/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10143/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10143/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Max memory used 75MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10143/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 41s trunk passed +1 compile 1m 45s trunk passed with JDK v1.8.0_66 +1 compile 2m 11s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 27s trunk passed +1 mvnsite 2m 33s trunk passed +1 mvneclipse 0m 20s trunk passed -1 findbugs 6m 20s branch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml) +1 javadoc 1m 53s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 17s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 1s the patch passed +1 compile 1m 45s the patch passed with JDK v1.8.0_66 +1 javac 1m 45s the patch passed +1 compile 2m 4s the patch passed with JDK v1.7.0_91 +1 javac 2m 4s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 2m 33s the patch passed +1 mvneclipse 0m 19s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 0s The patch has no ill-formed XML file. -1 findbugs 6m 16s patch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml) +1 javadoc 1m 44s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 14s the patch passed with JDK v1.7.0_91 -1 unit 80m 5s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 82m 43s hadoop-yarn in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 212m 56s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780302/0001-YARN-4537.patch JIRA Issue YARN-4537 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux bab2f4eb2e04 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1af2917 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10143/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10143/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10143/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10143/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10143/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10143/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10143/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 30s trunk passed
        +1 compile 1m 47s trunk passed with JDK v1.8.0_66
        +1 compile 2m 7s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 2m 34s trunk passed
        +1 mvneclipse 0m 19s trunk passed
        -1 findbugs 6m 25s branch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml)
        +1 javadoc 1m 45s trunk passed with JDK v1.8.0_66
        +1 javadoc 4m 17s trunk passed with JDK v1.7.0_91
        +1 mvninstall 2m 3s the patch passed
        +1 compile 1m 45s the patch passed with JDK v1.8.0_66
        +1 javac 1m 45s the patch passed
        +1 compile 2m 4s the patch passed with JDK v1.7.0_91
        +1 javac 2m 4s the patch passed
        +1 checkstyle 0m 27s the patch passed
        +1 mvnsite 2m 33s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        -1 findbugs 6m 31s patch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml)
        +1 javadoc 1m 46s the patch passed with JDK v1.8.0_66
        +1 javadoc 4m 20s the patch passed with JDK v1.7.0_91
        -1 unit 72m 51s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 unit 75m 53s hadoop-yarn in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        198m 58s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780309/0002-YARN-4537.patch
        JIRA Issue YARN-4537
        Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
        uname Linux 547e16723370 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1af2917
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10145/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10145/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10145/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10145/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10145/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Max memory used 75MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10145/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 30s trunk passed +1 compile 1m 47s trunk passed with JDK v1.8.0_66 +1 compile 2m 7s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 28s trunk passed +1 mvnsite 2m 34s trunk passed +1 mvneclipse 0m 19s trunk passed -1 findbugs 6m 25s branch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml) +1 javadoc 1m 45s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 17s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 3s the patch passed +1 compile 1m 45s the patch passed with JDK v1.8.0_66 +1 javac 1m 45s the patch passed +1 compile 2m 4s the patch passed with JDK v1.7.0_91 +1 javac 2m 4s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 2m 33s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. -1 findbugs 6m 31s patch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml) +1 javadoc 1m 46s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 20s the patch passed with JDK v1.7.0_91 -1 unit 72m 51s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 75m 53s hadoop-yarn in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 198m 58s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780309/0002-YARN-4537.patch JIRA Issue YARN-4537 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux 547e16723370 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1af2917 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 unit https://builds.apache.org/job/PreCommit-YARN-Build/10145/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10145/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10145/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10145/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10145/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10145/console This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Rohith Sharma K S,
        +1 for the approach,
        Few nits in the patch :

        • formatting has happened for the lines which are not modified also ?
        • instead of !(p2 == null) we can use p2 != null ?
        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Rohith Sharma K S , +1 for the approach, Few nits in the patch : formatting has happened for the lines which are not modified also ? instead of !(p2 == null) we can use p2 != null ?
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updating the patch fixing comments..Kindly review the patch

        Show
        rohithsharma Rohith Sharma K S added a comment - Updating the patch fixing comments..Kindly review the patch
        Hide
        sunilg Sunil G added a comment -

        +1. Looks good.

        Show
        sunilg Sunil G added a comment - +1. Looks good.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Sunil G I updated patch avoiding expression evaluation which can be performance improved.

        Show
        rohithsharma Rohith Sharma K S added a comment - Sunil G I updated patch avoiding expression evaluation which can be performance improved.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        One small update I have done and updated it.

        Show
        rohithsharma Rohith Sharma K S added a comment - One small update I have done and updated it.
        Hide
        sunilg Sunil G added a comment -

        Thanks Rohith. Yes, Its fine.

        Show
        sunilg Sunil G added a comment - Thanks Rohith. Yes, Its fine.
        Hide
        sunilg Sunil G added a comment -

        Thanks Rohith. Yes, Its fine.

        Show
        sunilg Sunil G added a comment - Thanks Rohith. Yes, Its fine.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 33s trunk passed
        +1 compile 1m 53s trunk passed with JDK v1.8.0_66
        +1 compile 2m 15s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 2m 36s trunk passed
        +1 mvneclipse 0m 20s trunk passed
        -1 findbugs 6m 22s branch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml)
        +1 javadoc 1m 56s trunk passed with JDK v1.8.0_66
        +1 javadoc 4m 20s trunk passed with JDK v1.7.0_91
        +1 mvninstall 2m 2s the patch passed
        +1 compile 1m 49s the patch passed with JDK v1.8.0_66
        +1 javac 1m 49s the patch passed
        +1 compile 2m 9s the patch passed with JDK v1.7.0_91
        +1 javac 2m 9s the patch passed
        -1 checkstyle 0m 27s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 9, now 9).
        +1 mvnsite 2m 37s the patch passed
        +1 mvneclipse 0m 19s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        -1 findbugs 6m 14s patch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml)
        +1 javadoc 1m 41s the patch passed with JDK v1.8.0_66
        +1 javadoc 4m 23s the patch passed with JDK v1.7.0_91
        -1 unit 80m 22s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 unit 82m 31s hadoop-yarn in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 19s Patch does not generate ASF License warnings.
        213m 41s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780546/0003-YARN-4537.patch
        JIRA Issue YARN-4537
        Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
        uname Linux 0aee79427f8b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 96d8f1d
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10152/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10152/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10152/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10152/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10152/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10152/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Max memory used 75MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10152/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 33s trunk passed +1 compile 1m 53s trunk passed with JDK v1.8.0_66 +1 compile 2m 15s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 28s trunk passed +1 mvnsite 2m 36s trunk passed +1 mvneclipse 0m 20s trunk passed -1 findbugs 6m 22s branch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml) +1 javadoc 1m 56s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 20s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 2s the patch passed +1 compile 1m 49s the patch passed with JDK v1.8.0_66 +1 javac 1m 49s the patch passed +1 compile 2m 9s the patch passed with JDK v1.7.0_91 +1 javac 2m 9s the patch passed -1 checkstyle 0m 27s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 9, now 9). +1 mvnsite 2m 37s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 findbugs 6m 14s patch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml) +1 javadoc 1m 41s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 23s the patch passed with JDK v1.7.0_91 -1 unit 80m 22s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 82m 31s hadoop-yarn in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 213m 41s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780546/0003-YARN-4537.patch JIRA Issue YARN-4537 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux 0aee79427f8b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 96d8f1d Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10152/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10152/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10152/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10152/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10152/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10152/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10152/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 9m 10s trunk passed
        +1 compile 2m 32s trunk passed with JDK v1.8.0_66
        +1 compile 2m 37s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 34s trunk passed
        +1 mvnsite 3m 8s trunk passed
        +1 mvneclipse 0m 22s trunk passed
        -1 findbugs 7m 58s branch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml)
        +1 javadoc 2m 17s trunk passed with JDK v1.8.0_66
        +1 javadoc 5m 0s trunk passed with JDK v1.7.0_91
        +1 mvninstall 2m 38s the patch passed
        +1 compile 2m 37s the patch passed with JDK v1.8.0_66
        +1 javac 2m 37s the patch passed
        +1 compile 2m 33s the patch passed with JDK v1.7.0_91
        +1 javac 2m 33s the patch passed
        +1 checkstyle 0m 34s the patch passed
        +1 mvnsite 3m 9s the patch passed
        +1 mvneclipse 0m 20s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        -1 findbugs 7m 43s patch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml)
        +1 javadoc 2m 30s the patch passed with JDK v1.8.0_66
        +1 javadoc 5m 2s the patch passed with JDK v1.7.0_91
        -1 unit 76m 2s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 unit 78m 40s hadoop-yarn in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        216m 58s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780570/0003-YARN-4537.patch
        JIRA Issue YARN-4537
        Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
        uname Linux 5b39388e5c3b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 96d8f1d
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10156/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10156/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10156/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10156/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10156/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10156/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 10s trunk passed +1 compile 2m 32s trunk passed with JDK v1.8.0_66 +1 compile 2m 37s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 34s trunk passed +1 mvnsite 3m 8s trunk passed +1 mvneclipse 0m 22s trunk passed -1 findbugs 7m 58s branch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml) +1 javadoc 2m 17s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 0s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 38s the patch passed +1 compile 2m 37s the patch passed with JDK v1.8.0_66 +1 javac 2m 37s the patch passed +1 compile 2m 33s the patch passed with JDK v1.7.0_91 +1 javac 2m 33s the patch passed +1 checkstyle 0m 34s the patch passed +1 mvnsite 3m 9s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 findbugs 7m 43s patch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml) +1 javadoc 2m 30s the patch passed with JDK v1.8.0_66 +1 javadoc 5m 2s the patch passed with JDK v1.7.0_91 -1 unit 76m 2s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 78m 40s hadoop-yarn in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 216m 58s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780570/0003-YARN-4537.patch JIRA Issue YARN-4537 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux 5b39388e5c3b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 96d8f1d Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 unit https://builds.apache.org/job/PreCommit-YARN-Build/10156/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10156/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10156/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10156/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10156/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10156/console This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        test case failures are handled in YARN-4306,

        Show
        rohithsharma Rohith Sharma K S added a comment - test case failures are handled in YARN-4306 ,
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        +1 LGTM

        Show
        Naganarasimha Naganarasimha G R added a comment - +1 LGTM
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        For findbug, red mark is due to file not found. I think it is an issue in HadoopQA.

        Show
        rohithsharma Rohith Sharma K S added a comment - For findbug, red mark is due to file not found. I think it is an issue in HadoopQA.
        Hide
        jianhe Jian He added a comment -

        Committed to trunk, branch-2, branch-2.8.

        Thanks Rohith Sharma K S !
        Thanks Sunil G, Naganarasimha G R for the review !

        Show
        jianhe Jian He added a comment - Committed to trunk, branch-2, branch-2.8. Thanks Rohith Sharma K S ! Thanks Sunil G , Naganarasimha G R for the review !
        Hide
        drankye Kai Zheng added a comment -

        Note YARN-4580 was opened for a building failure issue. Would you help take a look? Thanks.

        Show
        drankye Kai Zheng added a comment - Note YARN-4580 was opened for a building failure issue. Would you help take a look? Thanks.
        Hide
        jianhe Jian He added a comment -

        thanks for pointing out. missed a new file, sorry for any inconvenience

        Show
        jianhe Jian He added a comment - thanks for pointing out. missed a new file, sorry for any inconvenience
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9087 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9087/)
        YARN-4537. Pull out priority comparison from fifocomparator and use (jianhe: rev b8942be888e1f6f7049398f3d0322602a58ee312)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/TestFifoOrderingPolicy.java
        • hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/FifoOrderingPolicy.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/FifoComparator.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9087 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9087/ ) YARN-4537 . Pull out priority comparison from fifocomparator and use (jianhe: rev b8942be888e1f6f7049398f3d0322602a58ee312) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/TestFifoOrderingPolicy.java hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/FifoOrderingPolicy.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/FifoComparator.java

          People

          • Assignee:
            rohithsharma Rohith Sharma K S
            Reporter:
            rohithsharma Rohith Sharma K S
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development