Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: yarn
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      We need nodes page added to next generation web UI, similar to existing RM/nodes page.

      1. YARN-4517-YARN-3368.02.patch
        174 kB
        Varun Saxena
      2. Screenshot_after_4709_1.png
        62 kB
        Varun Saxena
      3. Screenshot_after_4709.png
        55 kB
        Varun Saxena
      4. YARN-4517-YARN-3368.01.patch
        96 kB
        Varun Saxena
      5. (21-Feb-2016)yarn-ui-screenshots.zip
        1.32 MB
        Varun Saxena

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 11m 49s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 asflicense 0m 32s Patch generated 96 ASF License warnings.
          12m 59s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788900/YARN-4517-YARN-3368.01.patch
          JIRA Issue YARN-4517
          Optional Tests asflicense
          uname Linux ba2e99b9610e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-3368 / 37455e7
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10588/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10588/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 11m 49s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s Patch has no whitespace issues. -1 asflicense 0m 32s Patch generated 96 ASF License warnings. 12m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788900/YARN-4517-YARN-3368.01.patch JIRA Issue YARN-4517 Optional Tests asflicense uname Linux ba2e99b9610e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / 37455e7 asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10588/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10588/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          varun_saxena Varun Saxena added a comment -

          Wangda Tan, Jian He, kindly review.
          I have attached the screenshots too.

          The patch does the following.

          1. Implements RM nodes page.
          2. Implements all NM pages, including node info page, apps page, single app page listing containers for the app, containers page, single container page and container logs page. Give exactly the same information as current web UI.
          3. Added natural sort for sorting app ids'.
          4. Global error handler to display 404 or some other error page(a basic text page, can be improved if required later). Custom error pages like 404 can be added later. We can also make other decisions based on error code as well(say, retry).
          5. Make cluster overview page as the home page i.e. we will no longer see an empty page with top level menu bar on accessing http://localhost:4200. Should cluster overview instead of queues be the leftmost tab ?
          6. Added donut graphs on Node Information page to display node resource usage. Other graphs we can discuss and add later.
          7. Also added handling for the case where server returns no apps or containers. For this, I am basically creating a dummy response from serializer. This might not be the best way to handle it in Ember but I could not come up with much else until now.
          8. Make the tabs in top level menu active based on the tab being accessed.

          Open issues/points :

          1. The JSON coming from NM for containers and container endpoint is incorrect. Because of this only one log file is seen in the logs link of containers page in UI. This is because jQuery's JSON parser, only picks up the last log file value. I have raised YARN-4709 to track this. After that goes, code here will have to be changed here to display links to all 3 log files.
          2. The heading(which shows NM IP and port i.e. NM ID) on top of left hand side menu overflows out of the panel for certain browser dimensions. If I insert a space between host and port, it works fine, but space doesnt look good. Will have to explore a bit on how to handle it.
          3. We can probably add some graphs on the app page to capture container lifecycle by returning timestamps of events like localization, launching, etc.. This can be done later.
          4. Haven't added any tests so far. Will have to explore how to add them. Will probably do after first round of review.

          The ASF license warnings are due to missing of apache header. I had added it for new files I added. Should I add it for other files too ?

          Show
          varun_saxena Varun Saxena added a comment - Wangda Tan , Jian He , kindly review. I have attached the screenshots too. The patch does the following. Implements RM nodes page. Implements all NM pages, including node info page, apps page, single app page listing containers for the app, containers page, single container page and container logs page. Give exactly the same information as current web UI. Added natural sort for sorting app ids'. Global error handler to display 404 or some other error page(a basic text page, can be improved if required later). Custom error pages like 404 can be added later. We can also make other decisions based on error code as well(say, retry). Make cluster overview page as the home page i.e. we will no longer see an empty page with top level menu bar on accessing http://localhost:4200 . Should cluster overview instead of queues be the leftmost tab ? Added donut graphs on Node Information page to display node resource usage. Other graphs we can discuss and add later. Also added handling for the case where server returns no apps or containers. For this, I am basically creating a dummy response from serializer. This might not be the best way to handle it in Ember but I could not come up with much else until now. Make the tabs in top level menu active based on the tab being accessed. Open issues/points : The JSON coming from NM for containers and container endpoint is incorrect. Because of this only one log file is seen in the logs link of containers page in UI. This is because jQuery's JSON parser, only picks up the last log file value. I have raised YARN-4709 to track this. After that goes, code here will have to be changed here to display links to all 3 log files. The heading(which shows NM IP and port i.e. NM ID) on top of left hand side menu overflows out of the panel for certain browser dimensions. If I insert a space between host and port, it works fine, but space doesnt look good. Will have to explore a bit on how to handle it. We can probably add some graphs on the app page to capture container lifecycle by returning timestamps of events like localization, launching, etc.. This can be done later. Haven't added any tests so far. Will have to explore how to add them. Will probably do after first round of review. The ASF license warnings are due to missing of apache header. I had added it for new files I added. Should I add it for other files too ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 54s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 asflicense 0m 37s Patch generated 96 ASF License warnings.
          2m 8s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788903/YARN-4517-YARN-3368.01.patch
          JIRA Issue YARN-4517
          Optional Tests asflicense
          uname Linux e920ae3f2186 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-3368 / 37455e7
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10591/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10591/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 54s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s Patch has no whitespace issues. -1 asflicense 0m 37s Patch generated 96 ASF License warnings. 2m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788903/YARN-4517-YARN-3368.01.patch JIRA Issue YARN-4517 Optional Tests asflicense uname Linux e920ae3f2186 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / 37455e7 asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10591/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10591/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          varun_saxena Varun Saxena added a comment -

          Attached a new patch.
          Wangda Tan, kindly review.
          The open points mentioned above have been fixed(except adding additional graphs which can be done in another JIRA).
          As YARN-4709 has gone in, changes have been done according to them. This patch hence is on top of changes in YARN-4709.
          The overflow on screen resizing on left hand side menu bar has been fixed as well.
          Moreover, I have added multiple unit test cases.

          Refer to https://issues.apache.org/jira/browse/YARN-4517?focusedCommentId=15155987&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15155987 to check what has been done in the JIRA.

          Wangda Tan, do you want me to raise multiple JIRAs' and break this patch ?

          Show
          varun_saxena Varun Saxena added a comment - Attached a new patch. Wangda Tan , kindly review. The open points mentioned above have been fixed(except adding additional graphs which can be done in another JIRA). As YARN-4709 has gone in, changes have been done according to them. This patch hence is on top of changes in YARN-4709 . The overflow on screen resizing on left hand side menu bar has been fixed as well. Moreover, I have added multiple unit test cases. Refer to https://issues.apache.org/jira/browse/YARN-4517?focusedCommentId=15155987&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15155987 to check what has been done in the JIRA. Wangda Tan , do you want me to raise multiple JIRAs' and break this patch ?
          Hide
          varun_saxena Varun Saxena added a comment -

          Screenshots have been attached too...

          Show
          varun_saxena Varun Saxena added a comment - Screenshots have been attached too...
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 asflicense 0m 26s Patch generated 95 ASF License warnings.
          1m 12s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790627/YARN-4517-YARN-3368.02.patch
          JIRA Issue YARN-4517
          Optional Tests asflicense
          uname Linux 024acc4740d3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-3368 / 37455e7
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10669/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10669/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s Patch has no whitespace issues. -1 asflicense 0m 26s Patch generated 95 ASF License warnings. 1m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790627/YARN-4517-YARN-3368.02.patch JIRA Issue YARN-4517 Optional Tests asflicense uname Linux 024acc4740d3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / 37455e7 asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10669/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10669/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          varun_saxena Varun Saxena added a comment -

          Sorry I had left my local host and port configurations in the patch. Updating the patch after removing them.

          Show
          varun_saxena Varun Saxena added a comment - Sorry I had left my local host and port configurations in the patch. Updating the patch after removing them.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 asflicense 0m 34s Patch generated 95 ASF License warnings.
          1m 21s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790648/YARN-4517-YARN-3368.02.patch
          JIRA Issue YARN-4517
          Optional Tests asflicense
          uname Linux 4b7d3a22c9be 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision YARN-3368 / 37455e7
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10672/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10672/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s Patch has no whitespace issues. -1 asflicense 0m 34s Patch generated 95 ASF License warnings. 1m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790648/YARN-4517-YARN-3368.02.patch JIRA Issue YARN-4517 Optional Tests asflicense uname Linux 4b7d3a22c9be 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3368 / 37455e7 asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10672/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10672/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          gtCarrera9 Li Lu added a comment -

          Thanks for the work Varun Saxena! Some comments from my side:

          One main question: maybe we want to unify all application/container views? I noticed that right now, the "application views" from the application list and from the NM are different. Ideally, we'd like to provide one unified place to show one application, no matter the user arrives from the app list, flow list, NM app list or anywhere else? We can also integrate Similar story also applies to the container view?

          Meanwhile, maybe it's time to start detailed page style designs. With unified app/container views, we need to address questions like where to put node id/app ids in the page, and how to organize all available data on the page?

          I noticed one workflow related problem: once a NM is in shutdown state, it is not possible to go into the node page. What is the assumed debug workflow on this? What if a NM is down accidentally and the user is trying to look at the NM logs/detailed status to figure out what happened?

          On my local machine, links to application logs are broken with just a 500 error. Maybe we can improve this in future.

          Seems like there's no need to show "node labels" if node label is not enabled?

          I'm not sure about the meaning of the row in node status showing "Node Health Report". This looks like some static content or the dynamic part is empty?

          Show
          gtCarrera9 Li Lu added a comment - Thanks for the work Varun Saxena ! Some comments from my side: One main question: maybe we want to unify all application/container views? I noticed that right now, the "application views" from the application list and from the NM are different. Ideally, we'd like to provide one unified place to show one application, no matter the user arrives from the app list, flow list, NM app list or anywhere else? We can also integrate Similar story also applies to the container view? Meanwhile, maybe it's time to start detailed page style designs. With unified app/container views, we need to address questions like where to put node id/app ids in the page, and how to organize all available data on the page? I noticed one workflow related problem: once a NM is in shutdown state, it is not possible to go into the node page. What is the assumed debug workflow on this? What if a NM is down accidentally and the user is trying to look at the NM logs/detailed status to figure out what happened? On my local machine, links to application logs are broken with just a 500 error. Maybe we can improve this in future. Seems like there's no need to show "node labels" if node label is not enabled? I'm not sure about the meaning of the row in node status showing "Node Health Report". This looks like some static content or the dynamic part is empty?
          Hide
          varun_saxena Varun Saxena added a comment -

          Thanks Li Lu for the review.

          One main question: maybe we want to unify all application/container views? I noticed that right now, the "application views" from the application list and from the NM are different. Ideally, we'd like to provide one unified place to show one application, no matter the user arrives from the app list, flow list, NM app list or anywhere else? We can also integrate Similar story also applies to the container view?

          The application and container states in NM will be distinct from RM.
          The applications and containers seen here are running containers(applications are seen a bit longer based on keep alive time - depends on config). This information including NM states by itself can be useful.
          However, I think we can fit some container related information(which is fetched from NM) on the main container page. We can leave out some unnecessary info too. This is more a mimic of what was there on old UI.
          Will have to discuss page layouts and organization in detail.

          Meanwhile, maybe it's time to start detailed page style designs. With unified app/container views, we need to address questions like where to put node id/app ids in the page, and how to organize all available data on the page?

          Sure. Suggestions are welcome. I agree we need to discuss this in detail and reach a consensus on what goes where. Even I have not given a great deal of thought on this. Maybe after we move this branch's code into trunk. Because this is important to go in for YARN-2928.

          I noticed one workflow related problem: once a NM is in shutdown state, it is not possible to go into the node page. What is the assumed debug workflow on this?

          The link to node page has been disabled because we cannot reach NM in this state. What information are you expecting to give here ? A way to display NM logs, for instance ?

          On my local machine, links to application logs are broken with just a 500 error. Maybe we can improve this in future.

          Where ? On the app page ?

          Seems like there's no need to show "node labels" if node label is not enabled?

          In UI, we cannot know if node labels are enabled or not(until and unless we iterate over the whole output and assume if labels are not there for any node, it means labels are not enabled). Even if labels are enabled but not attached to any node, output will be same. Maybe once we start ember from within RM(there is a JIRA for this), we can think about using these configurations. Thoughts ?

          I'm not sure about the meaning of the row in node status showing "Node Health Report".

          In NM, we can configure disk health check(true by default) and health check scripts. Node Health report will contain output from that. It will contain information about which disks are bad, for instance. In normal case, it will be empty.

          Show
          varun_saxena Varun Saxena added a comment - Thanks Li Lu for the review. One main question: maybe we want to unify all application/container views? I noticed that right now, the "application views" from the application list and from the NM are different. Ideally, we'd like to provide one unified place to show one application, no matter the user arrives from the app list, flow list, NM app list or anywhere else? We can also integrate Similar story also applies to the container view? The application and container states in NM will be distinct from RM. The applications and containers seen here are running containers(applications are seen a bit longer based on keep alive time - depends on config). This information including NM states by itself can be useful. However, I think we can fit some container related information(which is fetched from NM) on the main container page. We can leave out some unnecessary info too. This is more a mimic of what was there on old UI. Will have to discuss page layouts and organization in detail. Meanwhile, maybe it's time to start detailed page style designs. With unified app/container views, we need to address questions like where to put node id/app ids in the page, and how to organize all available data on the page? Sure. Suggestions are welcome. I agree we need to discuss this in detail and reach a consensus on what goes where. Even I have not given a great deal of thought on this. Maybe after we move this branch's code into trunk. Because this is important to go in for YARN-2928 . I noticed one workflow related problem: once a NM is in shutdown state, it is not possible to go into the node page. What is the assumed debug workflow on this? The link to node page has been disabled because we cannot reach NM in this state. What information are you expecting to give here ? A way to display NM logs, for instance ? On my local machine, links to application logs are broken with just a 500 error. Maybe we can improve this in future. Where ? On the app page ? Seems like there's no need to show "node labels" if node label is not enabled? In UI, we cannot know if node labels are enabled or not(until and unless we iterate over the whole output and assume if labels are not there for any node, it means labels are not enabled). Even if labels are enabled but not attached to any node, output will be same. Maybe once we start ember from within RM(there is a JIRA for this), we can think about using these configurations. Thoughts ? I'm not sure about the meaning of the row in node status showing "Node Health Report". In NM, we can configure disk health check(true by default) and health check scripts. Node Health report will contain output from that. It will contain information about which disks are bad, for instance. In normal case, it will be empty.
          Hide
          gtCarrera9 Li Lu added a comment -

          Hi Varun Saxena, sorry about the late reply. With regard to the app/container pages, I'm actually fine to have the current page as a placeholder, but just would like to make sure eventually we will have unified app/container pages. This said, I do not really care if the container page for nodes shows correct info or just the (only) yarn container page which shows some placeholder right now. Just don't want to distract you to build separate container/app pages.

          All other issues are rather minor as of now. If they're easy to fix, then feel free to change them. Otherwise, I'm fine with moving forward with the code infra built up for now. My only concern is on the logs: right now we don't have a way to land on the NM's webpage if the NM is down, so there's no way we can look at the NM logs for the crashed ones through webapp. However, in the new UI, when the node is shutdown, I just could not hold myself to try to find a link to the NM logs to figure out why. I think the workflow here changed slightly, hence the user experience. Some other projects like Apache Ambari may want to maintain those information as well, but in YARN, it will be great if we could provide our users a way out. Maybe something like: "You have to ssh to the missing nodes' xxxx/xxx/ dir to look for the logs" would even be helpful.

          Show
          gtCarrera9 Li Lu added a comment - Hi Varun Saxena , sorry about the late reply. With regard to the app/container pages, I'm actually fine to have the current page as a placeholder, but just would like to make sure eventually we will have unified app/container pages. This said, I do not really care if the container page for nodes shows correct info or just the (only) yarn container page which shows some placeholder right now. Just don't want to distract you to build separate container/app pages. All other issues are rather minor as of now. If they're easy to fix, then feel free to change them. Otherwise, I'm fine with moving forward with the code infra built up for now. My only concern is on the logs: right now we don't have a way to land on the NM's webpage if the NM is down, so there's no way we can look at the NM logs for the crashed ones through webapp. However, in the new UI, when the node is shutdown, I just could not hold myself to try to find a link to the NM logs to figure out why. I think the workflow here changed slightly, hence the user experience. Some other projects like Apache Ambari may want to maintain those information as well, but in YARN, it will be great if we could provide our users a way out. Maybe something like: "You have to ssh to the missing nodes' xxxx/xxx/ dir to look for the logs" would even be helpful.
          Hide
          varun_saxena Varun Saxena added a comment -

          Li Lu, as per discussion with Wangda, unification of app/container information, we can do after this branch goes into trunk. I think we can definitely unify and have a single container page. I will do this later as part of another JIRA. NM single app page, will have to see.

          Regarding this,

          However, in the new UI, when the node is shutdown, I just could not hold myself to try to find a link to the NM logs to figure out why. I think the workflow here changed slightly, hence the user experience. Some other projects like Apache Ambari may want to maintain those information as well, but in YARN, it will be great if we could provide our users a way out. Maybe something like: "You have to ssh to the missing nodes' xxxx/xxx/ dir to look for the logs" would even be helpful.

          In old UI, we did not show anything if node was shutdown. So here, the change is that we are showing even the nodes which have been SHUTDOWN. Just thought that this might be useful info for the admin.
          Now, some information regarding on which path, user can check the logs may be useful but currently this information is not available in RM. I am not sure how NM can report this to RM. You can report it in node registration but do we need to ?
          Ambari may have this information because I guess it knows exactly where installation has been done through it.

          Regarding node labels, we can add it in REST response indicating if labels are enabled or not. We can do this later because this would require another JIRA for REST changes.

          500 error I think you are encountering on app page. I will fix it while doing AM pages or as a separate JIRA.

          Show
          varun_saxena Varun Saxena added a comment - Li Lu , as per discussion with Wangda, unification of app/container information, we can do after this branch goes into trunk. I think we can definitely unify and have a single container page. I will do this later as part of another JIRA. NM single app page, will have to see. Regarding this, However, in the new UI, when the node is shutdown, I just could not hold myself to try to find a link to the NM logs to figure out why. I think the workflow here changed slightly, hence the user experience. Some other projects like Apache Ambari may want to maintain those information as well, but in YARN, it will be great if we could provide our users a way out. Maybe something like: "You have to ssh to the missing nodes' xxxx/xxx/ dir to look for the logs" would even be helpful. In old UI, we did not show anything if node was shutdown. So here, the change is that we are showing even the nodes which have been SHUTDOWN. Just thought that this might be useful info for the admin. Now, some information regarding on which path, user can check the logs may be useful but currently this information is not available in RM. I am not sure how NM can report this to RM. You can report it in node registration but do we need to ? Ambari may have this information because I guess it knows exactly where installation has been done through it. Regarding node labels, we can add it in REST response indicating if labels are enabled or not. We can do this later because this would require another JIRA for REST changes. 500 error I think you are encountering on app page. I will fix it while doing AM pages or as a separate JIRA.
          Hide
          sunilg Sunil G added a comment -

          Varun Saxena

          Regarding node labels, we can add it in REST response indicating if labels are enabled or not. We can do this later because this would require another JIRA for REST changes

          For this, I have some done changes and we can immediately know whether labels are in cluster (i am finishing up with node-label page now, will upload a patch soon). I will try and see whether we can make a unified patch for all REST changes needed for UI together. Will syncup with you offline and will share summary here.

          Maybe something like: "You have to ssh to the missing nodes' xxxx/xxx/ dir to look for the logs"

          I am +1 for giving more information's. From RM, we can get the node ip/hostname. Atleast we can give a relative patch for getting dir for logs (may be from available path from yarn-default.xml). User can changes, so message can be a possible suggestion.

          Show
          sunilg Sunil G added a comment - Varun Saxena Regarding node labels, we can add it in REST response indicating if labels are enabled or not. We can do this later because this would require another JIRA for REST changes For this, I have some done changes and we can immediately know whether labels are in cluster (i am finishing up with node-label page now, will upload a patch soon). I will try and see whether we can make a unified patch for all REST changes needed for UI together. Will syncup with you offline and will share summary here. Maybe something like: "You have to ssh to the missing nodes' xxxx/xxx/ dir to look for the logs" I am +1 for giving more information's. From RM, we can get the node ip/hostname. Atleast we can give a relative patch for getting dir for logs (may be from available path from yarn-default.xml). User can changes, so message can be a possible suggestion.
          Hide
          varun_saxena Varun Saxena added a comment -

          Sunil G,

          I will try and see whether we can make a unified patch for all REST changes needed for UI together. Will syncup with you offline and will share summary here.

          Yup. I will raise a JIRA for REST changes soon. You can update the changes you plan to make, there.

          From RM, we can get the node ip/hostname. Atleast we can give a relative patch for getting dir for logs (may be from available path from yarn-default.xml).

          Node IP will anyways be shown with the SHUTDOWN node.
          Sorry, I do not know, but which current configuration are you referring to, from which we can know where nodemanager logs are located ?
          IIUC, log file location is decided by yarn.log.dir system property(which is passed while starting NM daemon) and RM wont know about it for nodemanagers. Currently, if I am not wrong, RM wont have this info and if we need to support, code will have to be added.

          Show
          varun_saxena Varun Saxena added a comment - Sunil G , I will try and see whether we can make a unified patch for all REST changes needed for UI together. Will syncup with you offline and will share summary here. Yup. I will raise a JIRA for REST changes soon. You can update the changes you plan to make, there. From RM, we can get the node ip/hostname. Atleast we can give a relative patch for getting dir for logs (may be from available path from yarn-default.xml). Node IP will anyways be shown with the SHUTDOWN node. Sorry, I do not know, but which current configuration are you referring to, from which we can know where nodemanager logs are located ? IIUC, log file location is decided by yarn.log.dir system property(which is passed while starting NM daemon) and RM wont know about it for nodemanagers. Currently, if I am not wrong, RM wont have this info and if we need to support, code will have to be added.
          Hide
          varun_saxena Varun Saxena added a comment -

          Filed YARN-4835

          Show
          varun_saxena Varun Saxena added a comment - Filed YARN-4835
          Hide
          gtCarrera9 Li Lu added a comment -

          Hi Varun Saxena, thanks for the note! Right now I'm fine with moving forward as a POC and keep all related issues tracked in new JIRAs.

          Show
          gtCarrera9 Li Lu added a comment - Hi Varun Saxena , thanks for the note! Right now I'm fine with moving forward as a POC and keep all related issues tracked in new JIRAs.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks Varun Saxena working this JIRA and Li Lu (inactive)/Sunil G for discussions. In general it looks good.

          A couple of comments,

          • Not sure why url looks like following: http://localhost:4200/yarnNode/localhost:61236/localhost:8042, I can understand last part is nodeId.toString, but why is localhost:61236 added to URL?
          • Cannot view container logs when log aggregation is disabled
          • Format issue: pie chart - Resource - Memory (in MB) cannot be fully rendered from my browser
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/controllers/application.js typically we shouldn't put html directly to controller, ideally we should move as much as possible html code into templates. If we cannot move all of them into templates, component/helper should be fine with html code.
          • As mentioned by Li Lu (inactive), we need a unified container/application page.

          Since we're trying to merge code back to trunk soon to unblock YARN-2928, I think it will be fine to address above comments in a separated JIRA.
          To make sure we won't forget what we discussed above, could you file a ticket to fix above items?

          Show
          leftnoteasy Wangda Tan added a comment - Thanks Varun Saxena working this JIRA and Li Lu (inactive) / Sunil G for discussions. In general it looks good. A couple of comments, Not sure why url looks like following: http://localhost:4200/yarnNode/localhost:61236/localhost:8042 , I can understand last part is nodeId.toString, but why is localhost:61236 added to URL? Cannot view container logs when log aggregation is disabled Format issue: pie chart - Resource - Memory (in MB) cannot be fully rendered from my browser hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/controllers/application.js typically we shouldn't put html directly to controller, ideally we should move as much as possible html code into templates. If we cannot move all of them into templates, component/helper should be fine with html code. As mentioned by Li Lu (inactive) , we need a unified container/application page. Since we're trying to merge code back to trunk soon to unblock YARN-2928 , I think it will be fine to address above comments in a separated JIRA. To make sure we won't forget what we discussed above, could you file a ticket to fix above items?
          Hide
          varun_saxena Varun Saxena added a comment -

          Wangda Tan, thanks for the review.

          Not sure why url looks like following: http://localhost:4200/yarnNode/localhost:61236/localhost:8042, I can understand last part is nodeId.toString, but why is localhost:61236 added to URL?

          NodeId is required to query node info from RM. It has been passed around everywhere because we need to create link for left hand side menu on every page.

          Cannot view container logs when log aggregation is disabled

          With aggregation disabled ? Are you testing with latest trunk code ? We had issues before YARN-4709 went in.

          hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/controllers/application.js typically we shouldn't put html directly to controller, ideally we should move as much as possible html code into templates. If we cannot move all of them into templates, component/helper should be fine with html code.

          Ok. Moved this to controller to get hold of currentPath. Will move this code to a helper or component.

          Format issue: pie chart - Resource - Memory (in MB) cannot be fully rendered from my browser

          Ok. Will check. Even with full(not minimized) browser window ?

          Show
          varun_saxena Varun Saxena added a comment - Wangda Tan , thanks for the review. Not sure why url looks like following: http://localhost:4200/yarnNode/localhost:61236/localhost:8042 , I can understand last part is nodeId.toString, but why is localhost:61236 added to URL? NodeId is required to query node info from RM. It has been passed around everywhere because we need to create link for left hand side menu on every page. Cannot view container logs when log aggregation is disabled With aggregation disabled ? Are you testing with latest trunk code ? We had issues before YARN-4709 went in. hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/controllers/application.js typically we shouldn't put html directly to controller, ideally we should move as much as possible html code into templates. If we cannot move all of them into templates, component/helper should be fine with html code. Ok. Moved this to controller to get hold of currentPath. Will move this code to a helper or component. Format issue: pie chart - Resource - Memory (in MB) cannot be fully rendered from my browser Ok. Will check. Even with full(not minimized) browser window ?
          Hide
          varun_saxena Varun Saxena added a comment -

          Filed YARN-4848 to address above comments so that it can unblock UI merge to trunk, for YARN-2928.
          Do we need AM pages too for merge to trunk ?

          I guess we can merge regardless of it so that UI related work on YARN-2928 can speedup. Do let me know.

          Show
          varun_saxena Varun Saxena added a comment - Filed YARN-4848 to address above comments so that it can unblock UI merge to trunk, for YARN-2928 . Do we need AM pages too for merge to trunk ? I guess we can merge regardless of it so that UI related work on YARN-2928 can speedup. Do let me know.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Varun Saxena,

          With aggregation disabled ? Are you testing with latest trunk code ? We had issues before YARN-4709 went in.

          It's not latest trunk, I will try this on latest trunk.

          Ok. Will check. Even with full(not minimized) browser window ?

          Yes

          NodeId is required to query node info from RM. It has been passed around everywhere because we need to create link for left hand side menu on every page.

          Look closer to URLs. First, you can move the left side menu to yarn-node.hbs. Url can be generated by model fields like model.rmNode.id, I think you don't need a separate piece in URL like localhost:61236

          And for urls of nodes, I would suggest update URLs to:

          ../yarnNodes/<nodeId>
          

          For overview of nodes (node information)

          ../yarnNodes/<nodeId>/runningApps
          

          For running applications

          ../yarnNodes/<nodeId>/runningContainers
          

          For running containers.

          These items could be fixed together in YARN-4848.

          Do we need AM pages too for merge to trunk ?

          We may not need it. Let's try to merge infra code to trunk first.

          Show
          leftnoteasy Wangda Tan added a comment - Varun Saxena , With aggregation disabled ? Are you testing with latest trunk code ? We had issues before YARN-4709 went in. It's not latest trunk, I will try this on latest trunk. Ok. Will check. Even with full(not minimized) browser window ? Yes NodeId is required to query node info from RM. It has been passed around everywhere because we need to create link for left hand side menu on every page. Look closer to URLs. First, you can move the left side menu to yarn-node.hbs. Url can be generated by model fields like model.rmNode.id , I think you don't need a separate piece in URL like localhost:61236 And for urls of nodes, I would suggest update URLs to: ../yarnNodes/<nodeId> For overview of nodes (node information) ../yarnNodes/<nodeId>/runningApps For running applications ../yarnNodes/<nodeId>/runningContainers For running containers. These items could be fixed together in YARN-4848 . Do we need AM pages too for merge to trunk ? We may not need it. Let's try to merge infra code to trunk first.
          Hide
          leftnoteasy Wangda Tan added a comment -

          +1 to latest patch, will commit to branch soon to unblock YARN-4734. Thanks Varun Saxena and reviews from Sunil G/Li Lu.

          Show
          leftnoteasy Wangda Tan added a comment - +1 to latest patch, will commit to branch soon to unblock YARN-4734 . Thanks Varun Saxena and reviews from Sunil G / Li Lu .
          Hide
          leftnoteasy Wangda Tan added a comment -

          Committed to branch:YARN-3368, tested it locally before push.

          Show
          leftnoteasy Wangda Tan added a comment - Committed to branch: YARN-3368 , tested it locally before push.
          Hide
          varun_saxena Varun Saxena added a comment -

          Thanks Wangda Tan for the commit.
          Thanks Li Lu and Sunil G for reviews.

          Show
          varun_saxena Varun Saxena added a comment - Thanks Wangda Tan for the commit. Thanks Li Lu and Sunil G for reviews.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10778 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10778/)
          YARN-4517. Add nodes page and fix bunch of license issues. (Varun Saxena (wangda: rev 0a5f6520713fbd00a8c8ae563be8abaa2b8c868b)

          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/models/yarn-node-container-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-container-log.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/serializers/yarn-node-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/adapters/yarn-node-app-test.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-app-attempt.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-apps.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/serializers/yarn-node-container.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/models/yarn-container-log.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/serializers/yarn-container-log-test.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/cluster-metric.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/adapters/yarn-container-log-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-node-container.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-node-container-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/helpers/divide.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/utils/converter.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/adapters/yarn-node-container-test.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/router.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-node.hbs
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/config.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-node-containers-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-node-apps-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-nodes-test.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/utils/converter-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/models/yarn-rm-node-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/utils/sorter-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-node-app.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/components/simple-table.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-node-app.hbs
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-container.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/adapters/yarn-rm-node-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-node-app.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-queue.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/serializers/yarn-container-log.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/serializers/yarn-rm-node.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-container-log.hbs
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-rm-node.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-node-container.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/cluster-info.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-node-app-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/serializers/yarn-node-app-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-node-containers.hbs
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/adapters/yarn-node-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/serializers/yarn-node-app.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/serializers/yarn-node-container-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-node-apps.hbs
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/bower.json
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-node-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-node-container.hbs
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/models/yarn-node-app-test.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/models/yarn-app.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/controllers/application.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/helpers/node-menu.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/models/yarn-container-log-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-node.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/models/yarn-rm-node.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/constants.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/models/yarn-node.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/serializers/yarn-node.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/helpers/node-link.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-node-containers.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/config/environment.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-nodes.hbs
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-container-log.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-nodes.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-container-log-test.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/error.hbs
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/application.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-node-apps.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-node.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/models/yarn-node-test.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/application.hbs
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/models/yarn-node-app.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/utils/sorter.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/helpers/log-files-comma.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/notfound.hbs
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/models/yarn-node-container.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/index.js
          • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/serializers/yarn-rm-node-test.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-app.js
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-apps.hbs
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10778 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10778/ ) YARN-4517 . Add nodes page and fix bunch of license issues. (Varun Saxena (wangda: rev 0a5f6520713fbd00a8c8ae563be8abaa2b8c868b) (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/models/yarn-node-container-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-container-log.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/serializers/yarn-node-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/adapters/yarn-node-app-test.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-app-attempt.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-apps.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/serializers/yarn-node-container.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/models/yarn-container-log.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/serializers/yarn-container-log-test.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/cluster-metric.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/adapters/yarn-container-log-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-node-container.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-node-container-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/helpers/divide.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/utils/converter.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/adapters/yarn-node-container-test.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/router.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-node.hbs (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/config.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-node-containers-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-node-apps-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-nodes-test.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/utils/converter-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/models/yarn-rm-node-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/utils/sorter-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-node-app.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/components/simple-table.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-node-app.hbs (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-container.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/adapters/yarn-rm-node-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-node-app.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-queue.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/serializers/yarn-container-log.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/serializers/yarn-rm-node.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-container-log.hbs (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-rm-node.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-node-container.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/cluster-info.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-node-app-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/serializers/yarn-node-app-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-node-containers.hbs (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/adapters/yarn-node-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/serializers/yarn-node-app.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/serializers/yarn-node-container-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-node-apps.hbs (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/bower.json (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-node-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-node-container.hbs (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/models/yarn-node-app-test.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/models/yarn-app.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/controllers/application.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/helpers/node-menu.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/models/yarn-container-log-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-node.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/models/yarn-rm-node.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/constants.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/models/yarn-node.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/serializers/yarn-node.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/helpers/node-link.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-node-containers.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/config/environment.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-nodes.hbs (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-container-log.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-nodes.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/routes/yarn-container-log-test.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/error.hbs (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/application.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-node-apps.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/yarn-node.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/models/yarn-node-test.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/application.hbs (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/models/yarn-node-app.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/utils/sorter.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/helpers/log-files-comma.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/notfound.hbs (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/models/yarn-node-container.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/routes/index.js (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/tests/unit/serializers/yarn-rm-node-test.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/adapters/yarn-app.js (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/app/templates/yarn-apps.hbs

            People

            • Assignee:
              varun_saxena Varun Saxena
              Reporter:
              leftnoteasy Wangda Tan
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development