[YARN-4465] SchedulerUtils#validateRequest for Label check should happen only when nodelabel enabled

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Hadoop Flags: Reviewed
• Assignee: Bibin Chundatt
• Reporter: Bibin Chundatt
• Created: 16/Dec/15 11:21
• Updated: 06/Jun/17 15:36
• Resolved: 08/Mar/16 22:33

Description

Disable label from rm side yarn.nodelabel.enable=false
Capacity scheduler label configuration for queue is available as below
default label for queue = b1 as 3 and accessible labels as 1,3
Submit application to queue A .

Caused by: org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.yarn.exceptions.InvalidResourceRequestException): Invalid resource request, queue=b1 doesn't have permission to access all labels in resource request. labelExpression of resource request=3. Queue labels=1,3
        at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.validateResourceRequest(SchedulerUtils.java:304)
        at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.normalizeAndValidateRequest(SchedulerUtils.java:234)
        at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.normalizeAndValidateRequest(SchedulerUtils.java:216)
        at org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.validateAndCreateResourceRequest(RMAppManager.java:401)
        at org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.createAndPopulateNewRMApp(RMAppManager.java:340)
        at org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.submitApplication(RMAppManager.java:283)
        at org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.submitApplication(ClientRMService.java:602)
        at org.apache.hadoop.yarn.api.impl.pb.service.ApplicationClientProtocolPBServiceImpl.submitApplication(ApplicationClientProtocolPBServiceImpl.java:247)

1. Ignore default label expression when label is disabled or
2. NormalizeResourceRequest we can set label expression to <DEFAULT PARTITION> when node label is not enabled or
3. Improve message

Issue Links

• is related to: YARN-2492 (Clone of YARN-796) Allow for (admin) labels on nodes and resource-requests
• relates to: YARN-6031 Application recovery has failed when node label feature is turned off during RM recovery