Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4439

Clarify NMContainerStatus#toString method.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    1. YARN-4439.1.patch
      1 kB
      Jian He
    2. YARN-4439.2.patch
      2 kB
      Jian He
    3. YARN-4439.appendum-2.7.patch
      1 kB
      Xuan Gong

      Issue Links

        Activity

        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
        Hide
        zxu zhihai xu added a comment -

        Good Catch Jason Lowe! Will clean it up! thanks.

        Show
        zxu zhihai xu added a comment - Good Catch Jason Lowe ! Will clean it up! thanks.
        Hide
        jlowe Jason Lowe added a comment -

        Reverted and re-committed to branch-2.7. Thanks Xuan Gong and zhihai xu!

        As a side note, I noticed MAPREDUCE-6436 was placed in the wrong CHANGES.txt file (yarn vs. mapreduce). zhihai xu could you clean that up? Don't need a whole new JIRA, can do it under the original.

        Show
        jlowe Jason Lowe added a comment - Reverted and re-committed to branch-2.7. Thanks Xuan Gong and zhihai xu ! As a side note, I noticed MAPREDUCE-6436 was placed in the wrong CHANGES.txt file (yarn vs. mapreduce). zhihai xu could you clean that up? Don't need a whole new JIRA, can do it under the original.
        Hide
        jlowe Jason Lowe added a comment -

        +1, this is the same patch from YARN-4458. I'm going to commit this as a revert of the original followed by a commit with the original and the addendum combined. That way it's easier to pick to other releases (e.g. 2.6.x)

        Show
        jlowe Jason Lowe added a comment - +1, this is the same patch from YARN-4458 . I'm going to commit this as a revert of the original followed by a commit with the original and the addendum combined. That way it's easier to pick to other releases (e.g. 2.6.x)
        Hide
        xgong Xuan Gong added a comment -

        Thanks. Attached an addendum patch to fix the compilation issue in branch-2.7.

        Show
        xgong Xuan Gong added a comment - Thanks. Attached an addendum patch to fix the compilation issue in branch-2.7.
        Hide
        zxu zhihai xu added a comment -

        Hi Jian He, Could you revert the old patch and create a new patch for branch-2.7 to fix the compilation error?

        Show
        zxu zhihai xu added a comment - Hi Jian He , Could you revert the old patch and create a new patch for branch-2.7 to fix the compilation error?
        Hide
        jlowe Jason Lowe added a comment -

        This broke the branch-2.7 build, see YARN-4458 for details.

        Show
        jlowe Jason Lowe added a comment - This broke the branch-2.7 build, see YARN-4458 for details.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #693 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/693/)
        YARN-4439. Clarify NMContainerStatus#toString method. Contributed by (xgong: rev d8a45425eba372cdebef3be50436b6ddf1c4e192)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NMContainerStatusPBImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #693 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/693/ ) YARN-4439 . Clarify NMContainerStatus#toString method. Contributed by (xgong: rev d8a45425eba372cdebef3be50436b6ddf1c4e192) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NMContainerStatusPBImpl.java
        Hide
        xgong Xuan Gong added a comment -

        Committed into branch-2.8

        Show
        xgong Xuan Gong added a comment - Committed into branch-2.8
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8967 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8967/)
        YARN-4439. Clarify NMContainerStatus#toString method. Contributed by (xgong: rev d8a45425eba372cdebef3be50436b6ddf1c4e192)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NMContainerStatusPBImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8967 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8967/ ) YARN-4439 . Clarify NMContainerStatus#toString method. Contributed by (xgong: rev d8a45425eba372cdebef3be50436b6ddf1c4e192) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/NMContainerStatusPBImpl.java
        Hide
        xgong Xuan Gong added a comment -

        Committed into trunk/branch-2/branch-2.7.

        Show
        xgong Xuan Gong added a comment - Committed into trunk/branch-2/branch-2.7.
        Hide
        xgong Xuan Gong added a comment -

        +1 lgtm. checking this in

        Show
        xgong Xuan Gong added a comment - +1 lgtm. checking this in
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 10m 43s trunk passed
        +1 compile 0m 27s trunk passed with JDK v1.8.0_66
        +1 compile 0m 26s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 12s trunk passed
        +1 mvnsite 0m 32s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 4s trunk passed
        +1 javadoc 0m 31s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 34s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 28s the patch passed
        +1 compile 0m 27s the patch passed with JDK v1.8.0_66
        +1 javac 0m 27s the patch passed
        +1 compile 0m 27s the patch passed with JDK v1.7.0_91
        +1 javac 0m 27s the patch passed
        -1 checkstyle 0m 11s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common (total was 13, now 14).
        +1 mvnsite 0m 34s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 13s the patch passed
        +1 javadoc 0m 31s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 33s the patch passed with JDK v1.7.0_91
        +1 unit 0m 41s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_66.
        +1 unit 0m 37s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 31s Patch does not generate ASF License warnings.
        22m 57s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777240/YARN-4439.2.patch
        JIRA Issue YARN-4439
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 953b0ecf481c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1cb3299
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9974/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9974/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Max memory used 76MB
        Powered by Apache Yetus 0.1.0 http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9974/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 10m 43s trunk passed +1 compile 0m 27s trunk passed with JDK v1.8.0_66 +1 compile 0m 26s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 4s trunk passed +1 javadoc 0m 31s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 34s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 28s the patch passed +1 compile 0m 27s the patch passed with JDK v1.8.0_66 +1 javac 0m 27s the patch passed +1 compile 0m 27s the patch passed with JDK v1.7.0_91 +1 javac 0m 27s the patch passed -1 checkstyle 0m 11s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common (total was 13, now 14). +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 13s the patch passed +1 javadoc 0m 31s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 33s the patch passed with JDK v1.7.0_91 +1 unit 0m 41s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 37s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 31s Patch does not generate ASF License warnings. 22m 57s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777240/YARN-4439.2.patch JIRA Issue YARN-4439 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 953b0ecf481c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1cb3299 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9974/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9974/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Max memory used 76MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9974/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 56s trunk passed
        +1 compile 0m 17s trunk passed with JDK v1.8.0_66
        +1 compile 0m 19s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 10s trunk passed
        +1 mvnsite 0m 26s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 49s trunk passed
        +1 javadoc 0m 20s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 24s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 22s the patch passed
        +1 compile 0m 17s the patch passed with JDK v1.8.0_66
        +1 javac 0m 17s the patch passed
        +1 compile 0m 20s the patch passed with JDK v1.7.0_91
        +1 javac 0m 20s the patch passed
        -1 checkstyle 0m 9s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common (total was 13, now 14).
        +1 mvnsite 0m 24s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 57s the patch passed
        +1 javadoc 0m 19s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 24s the patch passed with JDK v1.7.0_91
        +1 unit 0m 24s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_66.
        +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        16m 36s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776680/YARN-4439.1.patch
        JIRA Issue YARN-4439
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e84412033ba0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e27fffd
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9918/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9918/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9918/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 56s trunk passed +1 compile 0m 17s trunk passed with JDK v1.8.0_66 +1 compile 0m 19s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 10s trunk passed +1 mvnsite 0m 26s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 49s trunk passed +1 javadoc 0m 20s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 24s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 22s the patch passed +1 compile 0m 17s the patch passed with JDK v1.8.0_66 +1 javac 0m 17s the patch passed +1 compile 0m 20s the patch passed with JDK v1.7.0_91 +1 javac 0m 20s the patch passed -1 checkstyle 0m 9s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common (total was 13, now 14). +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 57s the patch passed +1 javadoc 0m 19s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 24s the patch passed with JDK v1.7.0_91 +1 unit 0m 24s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 16m 36s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776680/YARN-4439.1.patch JIRA Issue YARN-4439 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e84412033ba0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e27fffd findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9918/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9918/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9918/console This message was automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Jian He should we also add Priority to the printing string?

        Show
        ozawa Tsuyoshi Ozawa added a comment - Jian He should we also add Priority to the printing string?
        Hide
        jianhe Jian He added a comment -

        upload a patch to clarify the NMContainerStatus#toString method

        Show
        jianhe Jian He added a comment - upload a patch to clarify the NMContainerStatus#toString method

          People

          • Assignee:
            jianhe Jian He
            Reporter:
            jianhe Jian He
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development