Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4395

Typo in comment in ClientServiceDelegate

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Line 337 in invoke() has the following comment:

              // if it's AM shut down, do not decrement maxClientRetry as we wait for
              // AM to be restarted.
      

      Ideally it should be:

              // If its AM shut down, do not decrement maxClientRetry while we wait
              // for its AM to be restarted.
      

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10910 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10910/)
        YARN-4395. Typo in comment in ClientServiceDelegate (Contributed by (templedf: rev 6d8b4f6c2791f861a55ac78c2950f783693e912a)

        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10910 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10910/ ) YARN-4395 . Typo in comment in ClientServiceDelegate (Contributed by (templedf: rev 6d8b4f6c2791f861a55ac78c2950f783693e912a) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ClientServiceDelegate.java
        Hide
        templedf Daniel Templeton added a comment -

        Good point. I rushed it since I knew it had no chance of failing.

        Show
        templedf Daniel Templeton added a comment - Good point. I rushed it since I knew it had no chance of failing.
        Hide
        andrew.wang Andrew Wang added a comment -

        In the future let's remember to wait for the precommit bot to run. This typo fix looks quite safe, but having contributors press "Submit Patch" and look at the precommit output helps them get used to our workflow.

        Show
        andrew.wang Andrew Wang added a comment - In the future let's remember to wait for the precommit bot to run. This typo fix looks quite safe, but having contributors press "Submit Patch" and look at the precommit output helps them get used to our workflow.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Alison Yu! Committed to trunk.

        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Alison Yu ! Committed to trunk.

          People

          • Assignee:
            alisonyu Alison Yu
            Reporter:
            templedf Daniel Templeton
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development