Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4371

"yarn application -kill" should take multiple application ids

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Currently we cannot pass multiple applications to "yarn application -kill" command. The command should take multiple application ids at the same time.

      Each entries should be separated with whitespace like:

      yarn application -kill application_1234_0001 application_1234_0007 application_1234_0012
      
      1. 0001-YARN-4371.patch
        56 kB
        Sunil G
      2. 0002-YARN-4371.patch
        12 kB
        Sunil G
      3. 0003-YARN-4371.patch
        12 kB
        Sunil G
      4. 0004-YARN-4371.patch
        13 kB
        Sunil G
      5. 0005-YARN-4371.patch
        13 kB
        Sunil G
      6. 0006-YARN-4371.patch
        13 kB
        Sunil G
      7. 0007-YARN-4371.patch
        13 kB
        Sunil G

        Activity

        Hide
        sunilg Sunil G added a comment -

        Thank you Jason Lowe for the review and commit!. Thank you Tsuyoshi Ozawa, NGarla_Unused and Rohith Sharma K S for the reviews and comments.

        Show
        sunilg Sunil G added a comment - Thank you Jason Lowe for the review and commit!. Thank you Tsuyoshi Ozawa , NGarla_Unused and Rohith Sharma K S for the reviews and comments.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9171 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9171/)
        YARN-4371. "yarn application -kill" should take multiple application (jlowe: rev e91e8b711c68273460b36557fc37fdfc86be097b)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9171 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9171/ ) YARN-4371 . "yarn application -kill" should take multiple application (jlowe: rev e91e8b711c68273460b36557fc37fdfc86be097b) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
        Hide
        jlowe Jason Lowe added a comment -

        Thanks to Sunil for the contribution and to Tsuyoshi, Rohith, and Naganarasimha for additional review! I committed this to trunk, branch-2, and branch-2.8.

        Show
        jlowe Jason Lowe added a comment - Thanks to Sunil for the contribution and to Tsuyoshi, Rohith, and Naganarasimha for additional review! I committed this to trunk, branch-2, and branch-2.8.
        Hide
        jlowe Jason Lowe added a comment -

        +1 lgtm. Committing this.

        Show
        jlowe Jason Lowe added a comment - +1 lgtm. Committing this.
        Hide
        sunilg Sunil G added a comment -

        Hi Jason Lowe
        Cud u pls help to check whether the changes are fine.
        Thank You.

        Show
        sunilg Sunil G added a comment - Hi Jason Lowe Cud u pls help to check whether the changes are fine. Thank You.
        Hide
        sunilg Sunil G added a comment -

        Test case failures are known and tracked separately. Verified tests locally and all are passing.

        Show
        sunilg Sunil G added a comment - Test case failures are known and tracked separately. Verified tests locally and all are passing.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 53s trunk passed
        +1 compile 0m 17s trunk passed with JDK v1.8.0_66
        +1 compile 0m 20s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 9s trunk passed
        +1 mvnsite 0m 24s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 35s trunk passed
        +1 javadoc 0m 16s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 18s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 20s the patch passed
        +1 compile 0m 16s the patch passed with JDK v1.8.0_66
        +1 javac 0m 16s the patch passed
        +1 compile 0m 18s the patch passed with JDK v1.7.0_91
        +1 javac 0m 18s the patch passed
        -1 checkstyle 0m 10s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 15, now 16).
        +1 mvnsite 0m 22s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 42s the patch passed
        +1 javadoc 0m 13s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 16s the patch passed with JDK v1.7.0_91
        -1 unit 64m 23s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
        -1 unit 64m 30s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        143m 33s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.client.TestGetGroups
        JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782565/0007-YARN-4371.patch
        JIRA Issue YARN-4371
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 80ecafefd7af 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9fbd579
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10304/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10304/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10304/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10304/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10304/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10304/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10304/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 53s trunk passed +1 compile 0m 17s trunk passed with JDK v1.8.0_66 +1 compile 0m 20s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 9s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 35s trunk passed +1 javadoc 0m 16s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 18s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 20s the patch passed +1 compile 0m 16s the patch passed with JDK v1.8.0_66 +1 javac 0m 16s the patch passed +1 compile 0m 18s the patch passed with JDK v1.7.0_91 +1 javac 0m 18s the patch passed -1 checkstyle 0m 10s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 15, now 16). +1 mvnsite 0m 22s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 42s the patch passed +1 javadoc 0m 13s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 16s the patch passed with JDK v1.7.0_91 -1 unit 64m 23s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 64m 30s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 143m 33s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782565/0007-YARN-4371.patch JIRA Issue YARN-4371 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 80ecafefd7af 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9fbd579 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10304/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10304/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10304/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10304/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10304/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10304/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10304/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Thank you very much Jason Lowe for the comments. Its definitely making sense, and I am adding test case too. Pls help to check the updated patch.

        Show
        sunilg Sunil G added a comment - Thank you very much Jason Lowe for the comments. Its definitely making sense, and I am adding test case too. Pls help to check the updated patch.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks for updating the patch, Sunil!

        Why aren't we simply returning whatever result comes back from killApplication? It's weird to check it against errorCode (which is basically a constant), and this will cause problems if someone later comes along and decides to change the default value of errorCode in the run method.

        This comment doesn't match the behavior of the code, as it will only return an error if it failed to kill all of the specified applications.

          // kill application has failed for one or all applications.
        

        As mentioned above, we can simply have the run method return whatever error code killApplication returned, and move the comment (updated for correctness) to the killApplication method.

        There should be a unit test checking that we are properly complaining when incompatible options are specified along with the kill.

        Show
        jlowe Jason Lowe added a comment - Thanks for updating the patch, Sunil! Why aren't we simply returning whatever result comes back from killApplication? It's weird to check it against errorCode (which is basically a constant), and this will cause problems if someone later comes along and decides to change the default value of errorCode in the run method. This comment doesn't match the behavior of the code, as it will only return an error if it failed to kill all of the specified applications. // kill application has failed for one or all applications. As mentioned above, we can simply have the run method return whatever error code killApplication returned, and move the comment (updated for correctness) to the killApplication method. There should be a unit test checking that we are properly complaining when incompatible options are specified along with the kill.
        Hide
        sunilg Sunil G added a comment -

        Test case failures are not related.

        Show
        sunilg Sunil G added a comment - Test case failures are not related.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 51s trunk passed
        +1 compile 0m 16s trunk passed with JDK v1.8.0_66
        +1 compile 0m 20s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 9s trunk passed
        +1 mvnsite 0m 24s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 35s trunk passed
        +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 18s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 20s the patch passed
        +1 compile 0m 14s the patch passed with JDK v1.8.0_66
        +1 javac 0m 14s the patch passed
        +1 compile 0m 16s the patch passed with JDK v1.7.0_91
        +1 javac 0m 16s the patch passed
        -1 checkstyle 0m 9s Patch generated 2 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 15, now 16).
        +1 mvnsite 0m 22s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 1s Patch has no whitespace issues.
        +1 findbugs 0m 39s the patch passed
        +1 javadoc 0m 12s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 16s the patch passed with JDK v1.7.0_91
        -1 unit 64m 16s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
        -1 unit 64m 26s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 19s Patch does not generate ASF License warnings.
        143m 8s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.client.TestGetGroups
        JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782334/0006-YARN-4371.patch
        JIRA Issue YARN-4371
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 315ef4c8e90c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b1ed28f
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10287/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10287/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10287/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10287/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10287/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10287/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10287/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 51s trunk passed +1 compile 0m 16s trunk passed with JDK v1.8.0_66 +1 compile 0m 20s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 9s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 35s trunk passed +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 18s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 20s the patch passed +1 compile 0m 14s the patch passed with JDK v1.8.0_66 +1 javac 0m 14s the patch passed +1 compile 0m 16s the patch passed with JDK v1.7.0_91 +1 javac 0m 16s the patch passed -1 checkstyle 0m 9s Patch generated 2 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 15, now 16). +1 mvnsite 0m 22s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 1s Patch has no whitespace issues. +1 findbugs 0m 39s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 16s the patch passed with JDK v1.7.0_91 -1 unit 64m 16s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 64m 26s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 143m 8s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782334/0006-YARN-4371.patch JIRA Issue YARN-4371 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 315ef4c8e90c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b1ed28f Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10287/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10287/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10287/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10287/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10287/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10287/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10287/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Fixing javadoc issue.

        Show
        sunilg Sunil G added a comment - Fixing javadoc issue.
        Hide
        sunilg Sunil G added a comment -

        javadoc warning is valid. I will update a new patch.

        Show
        sunilg Sunil G added a comment - javadoc warning is valid. I will update a new patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 36s trunk passed
        +1 compile 0m 17s trunk passed with JDK v1.8.0_66
        +1 compile 0m 19s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 10s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 35s trunk passed
        +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 17s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 18s the patch passed
        +1 compile 0m 14s the patch passed with JDK v1.8.0_66
        +1 javac 0m 14s the patch passed
        +1 compile 0m 15s the patch passed with JDK v1.7.0_91
        +1 javac 0m 15s the patch passed
        -1 checkstyle 0m 9s Patch generated 2 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 15, now 16).
        +1 mvnsite 0m 21s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 39s the patch passed
        +1 javadoc 0m 11s the patch passed with JDK v1.8.0_66
        -1 javadoc 1m 36s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 0, now 1).
        +1 javadoc 0m 15s the patch passed with JDK v1.7.0_91
        -1 unit 64m 16s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
        -1 unit 64m 29s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 17s Patch does not generate ASF License warnings.
        142m 45s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.client.TestGetGroups
        JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782281/0005-YARN-4371.patch
        JIRA Issue YARN-4371
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 39837d380449 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c8b80eb
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10282/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/10282/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10282/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10282/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10282/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10282/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10282/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10282/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 36s trunk passed +1 compile 0m 17s trunk passed with JDK v1.8.0_66 +1 compile 0m 19s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 10s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 35s trunk passed +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 17s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 18s the patch passed +1 compile 0m 14s the patch passed with JDK v1.8.0_66 +1 javac 0m 14s the patch passed +1 compile 0m 15s the patch passed with JDK v1.7.0_91 +1 javac 0m 15s the patch passed -1 checkstyle 0m 9s Patch generated 2 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 15, now 16). +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 39s the patch passed +1 javadoc 0m 11s the patch passed with JDK v1.8.0_66 -1 javadoc 1m 36s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 0, now 1). +1 javadoc 0m 15s the patch passed with JDK v1.7.0_91 -1 unit 64m 16s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 64m 29s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 142m 45s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782281/0005-YARN-4371.patch JIRA Issue YARN-4371 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 39837d380449 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c8b80eb Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10282/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/10282/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10282/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10282/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10282/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10282/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10282/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10282/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Thank you Jason Lowe for the comments. I have updated the patch as per same.

        Show
        sunilg Sunil G added a comment - Thank you Jason Lowe for the comments. I have updated the patch as per same.
        Hide
        jlowe Jason Lowe added a comment -

        hasAnyOtherCLIOptions was factored out but only has one very specific use. The name makes it sound generic, but it is far from it. It would be better if the method took an option as an argument and checked for anything other than the specified option by walking the options iterator or the options array from getOptions. Otherwise the method should be renamed to something like hasOptionsIncompatibleForKill to indicate the very specific use case.

        It would be much simpler and clearer if we didn't abuse exceptions to act like return codes. killApplication should simply return an exit code, and then we don't need to do the bogus throw inside killApplication nor the try/catch when it's called.

        Show
        jlowe Jason Lowe added a comment - hasAnyOtherCLIOptions was factored out but only has one very specific use. The name makes it sound generic, but it is far from it. It would be better if the method took an option as an argument and checked for anything other than the specified option by walking the options iterator or the options array from getOptions. Otherwise the method should be renamed to something like hasOptionsIncompatibleForKill to indicate the very specific use case. It would be much simpler and clearer if we didn't abuse exceptions to act like return codes. killApplication should simply return an exit code, and then we don't need to do the bogus throw inside killApplication nor the try/catch when it's called.
        Hide
        sunilg Sunil G added a comment -

        Test failures are known and not related. All are passing locally.

        Show
        sunilg Sunil G added a comment - Test failures are known and not related. All are passing locally.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 27s trunk passed
        +1 compile 0m 16s trunk passed with JDK v1.8.0_66
        +1 compile 0m 18s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 9s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 35s trunk passed
        +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 18s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 13s the patch passed with JDK v1.8.0_66
        +1 javac 0m 13s the patch passed
        +1 compile 0m 16s the patch passed with JDK v1.7.0_91
        +1 javac 0m 16s the patch passed
        -1 checkstyle 0m 9s Patch generated 3 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 15, now 17).
        +1 mvnsite 0m 21s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 39s the patch passed
        +1 javadoc 0m 12s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 16s the patch passed with JDK v1.7.0_91
        -1 unit 64m 21s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
        -1 unit 64m 25s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 16s Patch does not generate ASF License warnings.
        142m 34s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.client.TestGetGroups
        JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781870/0004-YARN-4371.patch
        JIRA Issue YARN-4371
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 48dd8eae02bc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 25051c3
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10248/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10248/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10248/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10248/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10248/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10248/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10248/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 27s trunk passed +1 compile 0m 16s trunk passed with JDK v1.8.0_66 +1 compile 0m 18s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 9s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 35s trunk passed +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 18s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 19s the patch passed +1 compile 0m 13s the patch passed with JDK v1.8.0_66 +1 javac 0m 13s the patch passed +1 compile 0m 16s the patch passed with JDK v1.7.0_91 +1 javac 0m 16s the patch passed -1 checkstyle 0m 9s Patch generated 3 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 15, now 17). +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 39s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 16s the patch passed with JDK v1.7.0_91 -1 unit 64m 21s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 64m 25s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 16s Patch does not generate ASF License warnings. 142m 34s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781870/0004-YARN-4371.patch JIRA Issue YARN-4371 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 48dd8eae02bc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 25051c3 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10248/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10248/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10248/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10248/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10248/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10248/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10248/console This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        About the log message, existing method killApplication(applicationId); prints useful message whether application is exist OR does't exist.

        Missed this part...

        Overall patch looks fine !

        Show
        Naganarasimha Naganarasimha G R added a comment - About the log message, existing method killApplication(applicationId); prints useful message whether application is exist OR does't exist. Missed this part... Overall patch looks fine !
        Hide
        sunilg Sunil G added a comment -

        Attaching an updated patch with updated validation.

        Show
        sunilg Sunil G added a comment - Attaching an updated patch with updated validation.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Looking into discussion,

        1. I agree to Jason Lowe's comment that number of argument check should be made very specific to kill. With patch, user can combine with other sub commands. I missed this part
        2. As per Jason Lowe's very fist comment, patch keeps Linux behavior that application id's are space separated values rather then comma separated values. I think it should be fine.
        3. About the log message, existing method killApplication(applicationId); prints useful message whether application is exist OR does't exist. IMO, newly added code need not to print this message again. Thoughts?
        4. With point 3rd assumption, The below code is handled to make sure to keep Linux behavior of return code. Catching application is just to make sure to continue with other applications.
          catch (ApplicationNotFoundException e) {
                  // Suppress all ApplicationNotFoundException for now.
                 continue;
               }
              }
          if (reportFailure){throw new ApplicationNotFoundException("Application doesn't exist in RM.");}

          I.e when killing multiple process and if one process is success then return code is zero.

          root1@root1-ThinkPad-T440p:~/workspace/project_home/hadoop-3.0.0-SNAPSHOT/bin$ kill 24187 12345
          bash: kill: (12345) - No such process
          root1@root1-ThinkPad-T440p:~/workspace/project_home/hadoop-3.0.0-SNAPSHOT/bin$ echo $?
          0
          
        Show
        rohithsharma Rohith Sharma K S added a comment - Looking into discussion, I agree to Jason Lowe 's comment that number of argument check should be made very specific to kill. With patch, user can combine with other sub commands. I missed this part As per Jason Lowe's very fist comment, patch keeps Linux behavior that application id's are space separated values rather then comma separated values. I think it should be fine. About the log message, existing method killApplication(applicationId); prints useful message whether application is exist OR does't exist. IMO, newly added code need not to print this message again. Thoughts? With point 3rd assumption, The below code is handled to make sure to keep Linux behavior of return code. Catching application is just to make sure to continue with other applications. catch (ApplicationNotFoundException e) { // Suppress all ApplicationNotFoundException for now. continue ; } } if (reportFailure){ throw new ApplicationNotFoundException( "Application doesn't exist in RM." );} I.e when killing multiple process and if one process is success then return code is zero. root1@root1-ThinkPad-T440p:~/workspace/project_home/hadoop-3.0.0-SNAPSHOT/bin$ kill 24187 12345 bash: kill: (12345) - No such process root1@root1-ThinkPad-T440p:~/workspace/project_home/hadoop-3.0.0-SNAPSHOT/bin$ echo $? 0
        Hide
        sunilg Sunil G added a comment -

        Yes, I missed about below code.

        +    // If one or all applications are not found, throw back exception
        +    // to return proper error code.
        +    if (reportFailure) {
        +      throw new ApplicationNotFoundException("Application doesn't exist in RM.");
        +    }
        

        Existing killApplication has the capability to throw exception if app s not found. And I have kept same code, so we will still print application not found exception correctly in console with app Ids. However, there can be cases when all apps which are given to kill are not present in RM. So console will print the error as we already have it. But we also need to send back a non-zero error code. For tht, I am rethrowing exception to return proper error code in a FULL error scenario. In partial success cases, we will return 0/

        I could return back error code rather than throwing one again. But we need to have more if check in below parser code. So the dummy message is only to handle errorCode.

            } else if (cliParser.hasOption(KILL_CMD)) {
              if (args.length < 3) {
                printUsage(title, opts);
                return exitCode;
              }
              try{
                killApplication(cliParser.getOptionValues(KILL_CMD));
              } catch (ApplicationNotFoundException e) {
                return exitCode;
              }
        
        Show
        sunilg Sunil G added a comment - Yes, I missed about below code. + // If one or all applications are not found, throw back exception + // to return proper error code. + if (reportFailure) { + throw new ApplicationNotFoundException( "Application doesn't exist in RM." ); + } Existing killApplication has the capability to throw exception if app s not found. And I have kept same code, so we will still print application not found exception correctly in console with app Ids. However, there can be cases when all apps which are given to kill are not present in RM. So console will print the error as we already have it. But we also need to send back a non-zero error code. For tht, I am rethrowing exception to return proper error code in a FULL error scenario. In partial success cases, we will return 0/ I could return back error code rather than throwing one again. But we need to have more if check in below parser code. So the dummy message is only to handle errorCode. } else if (cliParser.hasOption(KILL_CMD)) { if (args.length < 3) { printUsage(title, opts); return exitCode; } try { killApplication(cliParser.getOptionValues(KILL_CMD)); } catch (ApplicationNotFoundException e) { return exitCode; }
        Hide
        sunilg Sunil G added a comment -

        Thank you Jason Lowe for the input and thank you NGarla_Unused.

        root@sunil-Inspiron-3543:/opt/hadoop/trunk/hadoop-3.0.0-SNAPSHOT/bin# ./yarn application -kill application_1452608662572_0002 application_1452608662572_0008 application_1452608662572_0003
        
        16/01/12 20:02:12 INFO client.RMProxy: Connecting to ResourceManager at /127.0.0.1:25001
        Application application_1452608662572_0002 has already finished 
        Application with id 'application_1452608662572_0008' doesn't exist in RM.
        Killing application application_1452608662572_0003
        16/01/12 20:02:16 INFO impl.YarnClientImpl: Killed application application_1452608662572_0003
        

        Here I have tried to kill 3 apps (1 running, 1 finished and 1 invalid). As per latest patch, we can get the exact error as Application with id 'application_1452608662572_0008' doesn't exist in RM.
        Will this be fine here?

        I was just pointing out that as it is coded today users can add other options along with the kill option that are not supported, or potentially nonsensical like movetoqueu

        Yes I agree with this part, its not vulnerable to have some other co-options along with kill. More validation can be added and it can be ensured that kill will be an option which cannot be a sub-options with other commands.

        Show
        sunilg Sunil G added a comment - Thank you Jason Lowe for the input and thank you NGarla_Unused . root@sunil-Inspiron-3543:/opt/hadoop/trunk/hadoop-3.0.0-SNAPSHOT/bin# ./yarn application -kill application_1452608662572_0002 application_1452608662572_0008 application_1452608662572_0003 16/01/12 20:02:12 INFO client.RMProxy: Connecting to ResourceManager at /127.0.0.1:25001 Application application_1452608662572_0002 has already finished Application with id 'application_1452608662572_0008' doesn't exist in RM. Killing application application_1452608662572_0003 16/01/12 20:02:16 INFO impl.YarnClientImpl: Killed application application_1452608662572_0003 Here I have tried to kill 3 apps (1 running, 1 finished and 1 invalid). As per latest patch, we can get the exact error as Application with id 'application_1452608662572_0008' doesn't exist in RM. Will this be fine here? I was just pointing out that as it is coded today users can add other options along with the kill option that are not supported, or potentially nonsensical like movetoqueu Yes I agree with this part, its not vulnerable to have some other co-options along with kill. More validation can be added and it can be ensured that kill will be an option which cannot be a sub-options with other commands.
        Hide
        jlowe Jason Lowe added a comment -

        I agree that space delimiter is my preferred choice. I was just pointing out that as it is coded today users can add other options along with the kill option that are not supported, or potentially nonsensical like movetoqueue, and those other options will be totally ignored which is not ideal. This doesn't mean that we can't use spaces, it just means the code needs to check for incompatible or unsupported options being present when it is processing the kill option.

        Show
        jlowe Jason Lowe added a comment - I agree that space delimiter is my preferred choice. I was just pointing out that as it is coded today users can add other options along with the kill option that are not supported, or potentially nonsensical like movetoqueue, and those other options will be totally ignored which is not ideal. This doesn't mean that we can't use spaces, it just means the code needs to check for incompatible or unsupported options being present when it is processing the kill option.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi All,
        Sorry for jumping in late,

        It's not very helpful to say "Application doesn't exist in RM." and not report which one(s) they are.

        Even i feel the same for this point and at least when i use kill -9 <non existant PID> it reports as

        kill -9 9999 10000
        bash: kill: (9999) - No such process
        bash: kill: (10000) - No such process
        

        so would prefer to have the same behavior here too.

        I think there's also an issue where the user can specify multiple arguments and the command will silently ignore their requests. ... Since we're no longer checking for a specific number of arguments, I think the user can throw in all sorts of other options that will be silently ignored, probably to the surprise of the user.

        I agree there is this possibility, but IMO it will be much user friendly to have space as delimiter than any other character like "," and its similar to the unix kill command . Also to an extent we are taking care by checking if (args.length < 3),
        Thoughts ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi All, Sorry for jumping in late, It's not very helpful to say "Application doesn't exist in RM." and not report which one(s) they are. Even i feel the same for this point and at least when i use kill -9 <non existant PID> it reports as kill -9 9999 10000 bash: kill: (9999) - No such process bash: kill: (10000) - No such process so would prefer to have the same behavior here too. I think there's also an issue where the user can specify multiple arguments and the command will silently ignore their requests. ... Since we're no longer checking for a specific number of arguments, I think the user can throw in all sorts of other options that will be silently ignored, probably to the surprise of the user. I agree there is this possibility, but IMO it will be much user friendly to have space as delimiter than any other character like "," and its similar to the unix kill command . Also to an extent we are taking care by checking if (args.length < 3) , Thoughts ?
        Hide
        jlowe Jason Lowe added a comment -

        It's not very helpful to say "Application doesn't exist in RM." and not report which one(s) they are. If someone was looking at this exception it would be lacking critical info. Since the caller is simply ignoring the exception anyway, wouldn't it be simpler to just have the kill code ignore the missing applications and remove the try clause from the caller?

        I think there's also an issue where the user can specify multiple arguments and the command will silently ignore their requests. For example:
        yarn application -appStates RUNNING -kill app1 app2 app3

        Since we're no longer checking for a specific number of arguments, I think the user can throw in all sorts of other options that will be silently ignored, probably to the surprise of the user.

        Side note: it's a little weird to see app IDs as direct arguments to the kill option. In typical UNIX command-line processing the kill option would simply be a boolean flag option with no associated value, and the non-option arguments at the end of the command-line would be the application IDs to process based on the previous options specified, hence why space-separated is what I would expect for that app list. Not a must-fix, I just find it odd.

        Show
        jlowe Jason Lowe added a comment - It's not very helpful to say "Application doesn't exist in RM." and not report which one(s) they are. If someone was looking at this exception it would be lacking critical info. Since the caller is simply ignoring the exception anyway, wouldn't it be simpler to just have the kill code ignore the missing applications and remove the try clause from the caller? I think there's also an issue where the user can specify multiple arguments and the command will silently ignore their requests. For example: yarn application -appStates RUNNING -kill app1 app2 app3 Since we're no longer checking for a specific number of arguments, I think the user can throw in all sorts of other options that will be silently ignored, probably to the surprise of the user. Side note: it's a little weird to see app IDs as direct arguments to the kill option. In typical UNIX command-line processing the kill option would simply be a boolean flag option with no associated value, and the non-option arguments at the end of the command-line would be the application IDs to process based on the previous options specified, hence why space-separated is what I would expect for that app list. Not a must-fix, I just find it odd.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        +1 LGTM , I will wait for Jason Lowe/Tsuyoshi Ozawa for their review

        Show
        rohithsharma Rohith Sharma K S added a comment - +1 LGTM , I will wait for Jason Lowe / Tsuyoshi Ozawa for their review
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 28s trunk passed
        +1 compile 0m 15s trunk passed with JDK v1.8.0_66
        +1 compile 0m 18s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 9s trunk passed
        +1 mvnsite 0m 24s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 33s trunk passed
        +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 18s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 18s the patch passed
        +1 compile 0m 13s the patch passed with JDK v1.8.0_66
        +1 javac 0m 13s the patch passed
        +1 compile 0m 16s the patch passed with JDK v1.7.0_91
        +1 javac 0m 16s the patch passed
        -1 checkstyle 0m 9s Patch generated 3 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 15, now 17).
        +1 mvnsite 0m 20s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 37s the patch passed
        +1 javadoc 0m 11s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 15s the patch passed with JDK v1.7.0_91
        +1 unit 7m 21s hadoop-yarn-client in the patch passed with JDK v1.8.0_66.
        +1 unit 7m 38s hadoop-yarn-client in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 16s Patch does not generate ASF License warnings.
        28m 44s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780944/0003-YARN-4371.patch
        JIRA Issue YARN-4371
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0a3b5daecadb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6702e7d
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10185/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10185/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
        Max memory used 75MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10185/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 28s trunk passed +1 compile 0m 15s trunk passed with JDK v1.8.0_66 +1 compile 0m 18s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 9s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 33s trunk passed +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 18s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 18s the patch passed +1 compile 0m 13s the patch passed with JDK v1.8.0_66 +1 javac 0m 13s the patch passed +1 compile 0m 16s the patch passed with JDK v1.7.0_91 +1 javac 0m 16s the patch passed -1 checkstyle 0m 9s Patch generated 3 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 15, now 17). +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 37s the patch passed +1 javadoc 0m 11s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 15s the patch passed with JDK v1.7.0_91 +1 unit 7m 21s hadoop-yarn-client in the patch passed with JDK v1.8.0_66. +1 unit 7m 38s hadoop-yarn-client in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 16s Patch does not generate ASF License warnings. 28m 44s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780944/0003-YARN-4371.patch JIRA Issue YARN-4371 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0a3b5daecadb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6702e7d Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10185/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10185/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10185/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Thank you Rohith Sharma K S
        Attaching an updated patch as per comments. If any applications were not found, we will display or print in console.

        Show
        sunilg Sunil G added a comment - Thank you Rohith Sharma K S Attaching an updated patch as per comments. If any applications were not found, we will display or print in console.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        IIUC, as per the linux, if multiple PID's to kill and one of the pid does not exist, then it returns 0 i.e as success. I think we can keep the same behavior too.

        Show
        rohithsharma Rohith Sharma K S added a comment - IIUC, as per the linux, if multiple PID's to kill and one of the pid does not exist, then it returns 0 i.e as success. I think we can keep the same behavior too.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Going through this JIRA, really helps a lot for killing applications instead of killing one by one. Thanks Sunil G for working on this JIRA.

        Looking into patch, overall patch approach looks good.
        one comment

        1. Instead of changing existing killAplication(ApplicationId appId) API, introduce new api with arrays as an argument as you have done in patch killApplication(String[] applicationIds). Iterate for each application inside this new method. something similar to below
          killApplication(String[] applicationIds){
                for (String applicationId : applicationIds) {
                killApplication(String applicationId);
               }
          }
          
        Show
        rohithsharma Rohith Sharma K S added a comment - Going through this JIRA, really helps a lot for killing applications instead of killing one by one. Thanks Sunil G for working on this JIRA. Looking into patch, overall patch approach looks good. one comment Instead of changing existing killAplication(ApplicationId appId) API, introduce new api with arrays as an argument as you have done in patch killApplication(String[] applicationIds) . Iterate for each application inside this new method. something similar to below killApplication( String [] applicationIds){ for ( String applicationId : applicationIds) { killApplication( String applicationId); } }
        Hide
        sunilg Sunil G added a comment -

        Tsuyoshi Ozawa, could you please help to check the updated approach.

        Show
        sunilg Sunil G added a comment - Tsuyoshi Ozawa , could you please help to check the updated approach.
        Hide
        sunilg Sunil G added a comment -

        Hi Tsuyoshi Ozawa
        Could you pls help to review the patch.

        Show
        sunilg Sunil G added a comment - Hi Tsuyoshi Ozawa Could you pls help to review the patch.
        Hide
        sunilg Sunil G added a comment -

        Test case failures are not related to this patch, and it happened because of hostname problem. we can see one more report whether this same tests TestGetGroups are failing or not.

        Show
        sunilg Sunil G added a comment - Test case failures are not related to this patch, and it happened because of hostname problem. we can see one more report whether this same tests TestGetGroups are failing or not.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 40s trunk passed
        +1 compile 0m 19s trunk passed with JDK v1.8.0_66
        +1 compile 0m 21s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 10s trunk passed
        +1 mvnsite 0m 25s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 39s trunk passed
        +1 javadoc 0m 17s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 19s trunk passed with JDK v1.7.0_85
        +1 mvninstall 0m 22s the patch passed
        +1 compile 0m 19s the patch passed with JDK v1.8.0_66
        +1 javac 0m 19s the patch passed
        +1 compile 0m 21s the patch passed with JDK v1.7.0_85
        +1 javac 0m 21s the patch passed
        -1 checkstyle 0m 10s Patch generated 2 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 15, now 16).
        +1 mvnsite 0m 26s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 45s the patch passed
        +1 javadoc 0m 17s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 19s the patch passed with JDK v1.7.0_85
        -1 unit 49m 39s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
        -1 unit 49m 42s hadoop-yarn-client in the patch failed with JDK v1.7.0_85.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        115m 32s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient
        JDK v1.7.0_85 Failed junit tests hadoop.yarn.client.TestGetGroups
        JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774340/0002-YARN-4371.patch
        JIRA Issue YARN-4371
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux df6ee560ba4a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 177975e
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9794/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9794/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9794/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9794/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9794/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9794/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9794/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 40s trunk passed +1 compile 0m 19s trunk passed with JDK v1.8.0_66 +1 compile 0m 21s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 10s trunk passed +1 mvnsite 0m 25s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 39s trunk passed +1 javadoc 0m 17s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 19s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 22s the patch passed +1 compile 0m 19s the patch passed with JDK v1.8.0_66 +1 javac 0m 19s the patch passed +1 compile 0m 21s the patch passed with JDK v1.7.0_85 +1 javac 0m 21s the patch passed -1 checkstyle 0m 10s Patch generated 2 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client (total was 15, now 16). +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 45s the patch passed +1 javadoc 0m 17s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 19s the patch passed with JDK v1.7.0_85 -1 unit 49m 39s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 49m 42s hadoop-yarn-client in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 115m 32s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_85 Failed junit tests hadoop.yarn.client.TestGetGroups JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774340/0002-YARN-4371.patch JIRA Issue YARN-4371 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux df6ee560ba4a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 177975e findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9794/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9794/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9794/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9794/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9794/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9794/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9794/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Hi Tsuyoshi Ozawa
        Attaching an updated patch as per latest comment. As we call kill application one by one, we need to wait till each one is killed. I think this is fine. Kindly help to check the same.

        Show
        sunilg Sunil G added a comment - Hi Tsuyoshi Ozawa Attaching an updated patch as per latest comment. As we call kill application one by one, we need to wait till each one is killed. I think this is fine. Kindly help to check the same.
        Hide
        sunilg Sunil G added a comment -

        Thank you. Sure, I also had a similar thought, then thought of improving number of calls/response time. But as u mentioned and by seeing code, it comes with more complexity. I ll upload a patch with a looping which will kill each application one by one.

        I ll also try to see whether we can improve the sleep which we do in client side to finish kill, when multiple apps are to be killed.

        Show
        sunilg Sunil G added a comment - Thank you. Sure, I also had a similar thought, then thought of improving number of calls/response time. But as u mentioned and by seeing code, it comes with more complexity. I ll upload a patch with a looping which will kill each application one by one. I ll also try to see whether we can improve the sleep which we do in client side to finish kill, when multiple apps are to be killed.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Sunil G thank you for the initial patch. I looked over the patch and have a comment about the design.

        In the patch, a new RPC, killApplication(List<ApplicationId> applicationIds), is added. IMHO, it's better to call multiple killApplication(ApplicationId applicationId) since it's simpler and I think killApplication is not called too much. Could you update so?

        Show
        ozawa Tsuyoshi Ozawa added a comment - Sunil G thank you for the initial patch. I looked over the patch and have a comment about the design. In the patch, a new RPC, killApplication(List<ApplicationId> applicationIds) , is added. IMHO, it's better to call multiple killApplication(ApplicationId applicationId) since it's simpler and I think killApplication is not called too much. Could you update so?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
        +1 mvninstall 9m 7s trunk passed
        +1 compile 11m 20s trunk passed with JDK v1.8.0_66
        +1 compile 10m 48s trunk passed with JDK v1.7.0_85
        +1 checkstyle 1m 11s trunk passed
        +1 mvnsite 3m 21s trunk passed
        +1 mvneclipse 1m 31s trunk passed
        -1 findbugs 1m 39s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
        +1 javadoc 2m 38s trunk passed with JDK v1.8.0_66
        +1 javadoc 5m 2s trunk passed with JDK v1.7.0_85
        +1 mvninstall 3m 6s the patch passed
        +1 compile 10m 6s the patch passed with JDK v1.8.0_66
        +1 cc 10m 6s the patch passed
        -1 javac 21m 25s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 751, now 751).
        +1 javac 10m 6s the patch passed
        +1 compile 10m 24s the patch passed with JDK v1.7.0_85
        +1 cc 10m 24s the patch passed
        -1 javac 31m 51s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 745, now 745).
        +1 javac 10m 24s the patch passed
        -1 checkstyle 1m 8s Patch generated 26 new checkstyle issues in root (total was 214, now 239).
        +1 mvnsite 3m 18s the patch passed
        +1 mvneclipse 1m 28s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 7m 40s the patch passed
        -1 javadoc 0m 44s hadoop-yarn-api in the patch failed with JDK v1.8.0_66.
        -1 javadoc 9m 29s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 0, now 1).
        +1 javadoc 5m 21s the patch passed with JDK v1.7.0_85
        +1 unit 0m 28s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
        -1 unit 49m 36s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
        -1 unit 2m 9s hadoop-yarn-common in the patch failed with JDK v1.8.0_66.
        +1 unit 9m 18s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66.
        -1 unit 66m 29s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 106m 56s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
        +1 unit 0m 34s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
        -1 unit 50m 32s hadoop-yarn-client in the patch failed with JDK v1.7.0_85.
        -1 unit 2m 36s hadoop-yarn-common in the patch failed with JDK v1.7.0_85.
        +1 unit 9m 50s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_85.
        -1 unit 68m 12s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
        +1 unit 112m 21s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_85.
        -1 asflicense 0m 30s Patch generated 15 ASF License warnings.
        578m 49s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups
          hadoop.yarn.client.cli.TestYarnCLI
          hadoop.yarn.webapp.TestWebApp
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.mapreduce.v2.TestMRJobsWithProfiler
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient
        JDK v1.7.0_85 Failed junit tests hadoop.yarn.client.TestGetGroups
          hadoop.yarn.client.cli.TestYarnCLI
          hadoop.yarn.webapp.TestWebApp
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
        JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773644/0001-YARN-4371.patch
        JIRA Issue YARN-4371
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux c26db892b27f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a30eccb
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
        javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
        javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/diff-checkstyle-root.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt
        javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9755/testReport/
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
        Max memory used 75MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9755/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 9m 7s trunk passed +1 compile 11m 20s trunk passed with JDK v1.8.0_66 +1 compile 10m 48s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 11s trunk passed +1 mvnsite 3m 21s trunk passed +1 mvneclipse 1m 31s trunk passed -1 findbugs 1m 39s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 2m 38s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 2s trunk passed with JDK v1.7.0_85 +1 mvninstall 3m 6s the patch passed +1 compile 10m 6s the patch passed with JDK v1.8.0_66 +1 cc 10m 6s the patch passed -1 javac 21m 25s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 751, now 751). +1 javac 10m 6s the patch passed +1 compile 10m 24s the patch passed with JDK v1.7.0_85 +1 cc 10m 24s the patch passed -1 javac 31m 51s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 745, now 745). +1 javac 10m 24s the patch passed -1 checkstyle 1m 8s Patch generated 26 new checkstyle issues in root (total was 214, now 239). +1 mvnsite 3m 18s the patch passed +1 mvneclipse 1m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 7m 40s the patch passed -1 javadoc 0m 44s hadoop-yarn-api in the patch failed with JDK v1.8.0_66. -1 javadoc 9m 29s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 0, now 1). +1 javadoc 5m 21s the patch passed with JDK v1.7.0_85 +1 unit 0m 28s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. -1 unit 49m 36s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 2m 9s hadoop-yarn-common in the patch failed with JDK v1.8.0_66. +1 unit 9m 18s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 66m 29s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 106m 56s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 34s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. -1 unit 50m 32s hadoop-yarn-client in the patch failed with JDK v1.7.0_85. -1 unit 2m 36s hadoop-yarn-common in the patch failed with JDK v1.7.0_85. +1 unit 9m 50s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_85. -1 unit 68m 12s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. +1 unit 112m 21s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 30s Patch generated 15 ASF License warnings. 578m 49s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups   hadoop.yarn.client.cli.TestYarnCLI   hadoop.yarn.webapp.TestWebApp   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.mapreduce.v2.TestMRJobsWithProfiler JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_85 Failed junit tests hadoop.yarn.client.TestGetGroups   hadoop.yarn.client.cli.TestYarnCLI   hadoop.yarn.webapp.TestWebApp   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773644/0001-YARN-4371.patch JIRA Issue YARN-4371 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux c26db892b27f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a30eccb findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9755/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9755/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9755/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Uploading an initial patch. Tsuyoshi Ozawa, could you please help to check the same.

        Show
        sunilg Sunil G added a comment - Uploading an initial patch. Tsuyoshi Ozawa , could you please help to check the same.
        Hide
        sunilg Sunil G added a comment -

        Thank you Tsuyoshi Ozawa, I will share a patch shortly.

        Show
        sunilg Sunil G added a comment - Thank you Tsuyoshi Ozawa , I will share a patch shortly.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Jason Lowe Sunil G sounds good. Fixing description for avoiding confusion.

        Sunil, please go ahead I'll help you by reviewing patches.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Jason Lowe Sunil G sounds good. Fixing description for avoiding confusion. Sunil, please go ahead I'll help you by reviewing patches.
        Hide
        sunilg Sunil G added a comment -

        Yes. I also feel the same, it could be done by separating with space.
        Tsuyoshi Ozawa, I could help in doing this, if you havent started or planning to do. Pls reassign otherwise.

        Show
        sunilg Sunil G added a comment - Yes. I also feel the same, it could be done by separating with space. Tsuyoshi Ozawa , I could help in doing this, if you havent started or planning to do. Pls reassign otherwise.
        Hide
        jlowe Jason Lowe added a comment -

        Normally commands intended to take multiple arguments don't use commas. Instead they simply are separate arguments. For example:

        yarn application -kill application_1234_0001 application_1234_0007 application_1234_0012
        

        The kill command on most systems doesn't take a comma-separated list of pids to kill, so I don't see why we would want to do differently.

        Show
        jlowe Jason Lowe added a comment - Normally commands intended to take multiple arguments don't use commas. Instead they simply are separate arguments. For example: yarn application -kill application_1234_0001 application_1234_0007 application_1234_0012 The kill command on most systems doesn't take a comma-separated list of pids to kill, so I don't see why we would want to do differently.

          People

          • Assignee:
            sunilg Sunil G
            Reporter:
            ozawa Tsuyoshi Ozawa
          • Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development