Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      When I run the SLS, the webapp doesn't load and I see the following error:

      15/11/17 15:33:30 INFO resourcemanager.ResourceManager: Using Scheduler: org.apache.hadoop.yarn.sls.scheduler.ResourceSchedulerWrapper
      java.lang.NullPointerException
              at org.apache.hadoop.yarn.sls.web.SLSWebApp.<init>(SLSWebApp.java:87)
              at org.apache.hadoop.yarn.sls.scheduler.ResourceSchedulerWrapper.initMetrics(ResourceSchedulerWrapper.java:483)
              at org.apache.hadoop.yarn.sls.scheduler.ResourceSchedulerWrapper.setConf(ResourceSchedulerWrapper.java:181)
              at org.apache.hadoop.util.ReflectionUtils.setConf(ReflectionUtils.java:76)
              at org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:136)
              at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.createScheduler(ResourceManager.java:299)
      
      1. YARN-4367-branch-2.1.patch
        1 kB
        Karthik Kambatla
      2. YARN-4367-branch-2.2.patch
        0.7 kB
        Karthik Kambatla
      3. YARN-4367-branch-2.patch
        0.7 kB
        Karthik Kambatla

        Activity

        Hide
        kasha Karthik Kambatla added a comment -

        /cc Wei Yan

        Show
        kasha Karthik Kambatla added a comment - /cc Wei Yan
        Hide
        kasha Karthik Kambatla added a comment -

        Looks like the issue is because the html template files are not on the classpath. Posting a fairly simple patch to fix that.

        Show
        kasha Karthik Kambatla added a comment - Looks like the issue is because the html template files are not on the classpath. Posting a fairly simple patch to fix that.
        Hide
        kasha Karthik Kambatla added a comment -

        This isn't an issue on trunk. Trunk has the following:

        function calculate_classpath
        {
          hadoop_add_to_classpath_toolspath
          hadoop_debug "Injecting ${HADOOP_PREFIX}/share/hadoop/tools/sls/html into CLASSPATH"
          hadoop_add_classpath "${HADOOP_PREFIX}/share/hadoop/tools/sls/html"
        }
        
        Show
        kasha Karthik Kambatla added a comment - This isn't an issue on trunk. Trunk has the following: function calculate_classpath { hadoop_add_to_classpath_toolspath hadoop_debug "Injecting ${HADOOP_PREFIX}/share/hadoop/tools/sls/html into CLASSPATH" hadoop_add_classpath "${HADOOP_PREFIX}/share/hadoop/tools/sls/html" }
        Hide
        kasha Karthik Kambatla added a comment -

        It might make more sense to have all the changes in slsrun.sh, and have it similar to trunk.

        Show
        kasha Karthik Kambatla added a comment - It might make more sense to have all the changes in slsrun.sh, and have it similar to trunk.
        Hide
        rkanter Robert Kanter added a comment -

        +1 LGTM

        Show
        rkanter Robert Kanter added a comment - +1 LGTM
        Hide
        kasha Karthik Kambatla added a comment -

        Uploading same patch with a different name.

        Show
        kasha Karthik Kambatla added a comment - Uploading same patch with a different name.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvnsite 6m 16s branch-2 passed
        +1 mvnsite 0m 19s the patch passed
        +1 shellcheck 0m 6s There were no new shellcheck issues.
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 unit 0m 13s hadoop-sls in the patch passed with JDK v1.8.0_66.
        +1 unit 0m 13s hadoop-sls in the patch passed with JDK v1.7.0_85.
        +1 asflicense 0m 37s Patch does not generate ASF License warnings.
        8m 8s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:date2015-11-18
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772904/YARN-4367-branch-2.patch
        JIRA Issue YARN-4367
        Optional Tests asflicense mvnsite unit shellcheck
        uname Linux dab42bb49fa5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
        git revision branch-2 / 397836a
        shellcheck v0.4.1
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9719/testReport/
        modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
        Max memory used 34MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9719/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvnsite 6m 16s branch-2 passed +1 mvnsite 0m 19s the patch passed +1 shellcheck 0m 6s There were no new shellcheck issues. +1 whitespace 0m 0s Patch has no whitespace issues. +1 unit 0m 13s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 13s hadoop-sls in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 37s Patch does not generate ASF License warnings. 8m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-18 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772904/YARN-4367-branch-2.patch JIRA Issue YARN-4367 Optional Tests asflicense mvnsite unit shellcheck uname Linux dab42bb49fa5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision branch-2 / 397836a shellcheck v0.4.1 JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9719/testReport/ modules C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls Max memory used 34MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9719/console This message was automatically generated.
        Hide
        kasha Karthik Kambatla added a comment -

        Classpath fix that is hard to write a test for. SLS failing to load webapp is indication enough.

        Thanks for the review, Robert. I ll go ahead and commit this tomorrow if I don't hear any reservations.

        Show
        kasha Karthik Kambatla added a comment - Classpath fix that is hard to write a test for. SLS failing to load webapp is indication enough. Thanks for the review, Robert. I ll go ahead and commit this tomorrow if I don't hear any reservations.
        Hide
        kasha Karthik Kambatla added a comment -

        Just committed to branch-2. Thanks again for the review, Robert.

        Show
        kasha Karthik Kambatla added a comment - Just committed to branch-2. Thanks again for the review, Robert.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8872 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8872/)
        CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8872 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8872/ ) CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773) hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #711 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/711/)
        CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #711 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/711/ ) CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773) hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2654 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2654/)
        CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2654 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2654/ ) CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773) hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1444 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1444/)
        CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1444 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1444/ ) CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773) hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #723 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/723/)
        CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #723 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/723/ ) CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773) hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #636 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/636/)
        CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #636 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/636/ ) CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773) hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2574 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2574/)
        CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2574 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2574/ ) CHANGES.txt: add YARN-4367 to 2.8.0. (ozawa: rev fb0f09e46b456789ec1c7470873b6de231430773) hadoop-yarn-project/CHANGES.txt

          People

          • Assignee:
            kasha Karthik Kambatla
            Reporter:
            kasha Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development