Details

    • Hadoop Flags:
      Reviewed

      Description

      This JIRA tracks changes to the APIs of the reservation system, and enables
      querying the reservation system on which reservation exists by "time-range, reservation-id".

      YARN-4420 and YARN-2575 has a dependency on this.

      1. YARN-4340.v1.patch
        120 kB
        Sean Po
      2. YARN-4340.v10.patch
        169 kB
        Sean Po
      3. YARN-4340.v11.patch
        169 kB
        Sean Po
      4. YARN-4340.v12.patch
        169 kB
        Sean Po
      5. YARN-4340.v2.patch
        119 kB
        Sean Po
      6. YARN-4340.v3.patch
        119 kB
        Sean Po
      7. YARN-4340.v4.patch
        119 kB
        Sean Po
      8. YARN-4340.v5.patch
        151 kB
        Sean Po
      9. YARN-4340.v6.patch
        156 kB
        Sean Po
      10. YARN-4340.v7.patch
        157 kB
        Sean Po
      11. YARN-4340.v8.patch
        162 kB
        Sean Po
      12. YARN-4340.v9.patch
        169 kB
        Sean Po

        Issue Links

          Activity

          Hide
          seanpo03 Sean Po added a comment -

          I am experiencing an issue as it is where the response JSON gets improperly marshalled for single element arrays. For example, if the response data is an array of objects JSON serialization will correctly produce the following:

          [

          {...}, {...}

          ].

          If the array only contains a single response, the following will be the output of the serialization:

          {...}

          .

          I'm not sure why this problem occurs, but this effect cannot be seen when using the CapacityScheduler (ws/v1/cluster/scheduler) API. Any information will be very helpful.

          Show
          seanpo03 Sean Po added a comment - I am experiencing an issue as it is where the response JSON gets improperly marshalled for single element arrays. For example, if the response data is an array of objects JSON serialization will correctly produce the following: [ {...}, {...} ]. If the array only contains a single response, the following will be the output of the serialization: {...} . I'm not sure why this problem occurs, but this effect cannot be seen when using the CapacityScheduler (ws/v1/cluster/scheduler) API. Any information will be very helpful.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          +1 mvninstall 8m 47s trunk passed
          +1 compile 10m 34s trunk passed with JDK v1.8.0_66
          +1 compile 10m 17s trunk passed with JDK v1.7.0_85
          +1 checkstyle 1m 7s trunk passed
          +1 mvnsite 3m 0s trunk passed
          +1 mvneclipse 1m 15s trunk passed
          -1 findbugs 1m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
          +1 javadoc 2m 24s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 48s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 38s the patch passed
          +1 compile 10m 8s the patch passed with JDK v1.8.0_66
          +1 cc 10m 8s the patch passed
          -1 javac 20m 32s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 4 new issues (was 778, now 781).
          +1 javac 10m 8s the patch passed
          +1 compile 10m 6s the patch passed with JDK v1.7.0_85
          +1 cc 10m 6s the patch passed
          -1 javac 30m 39s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 4 new issues (was 772, now 775).
          +1 javac 10m 6s the patch passed
          -1 checkstyle 1m 11s Patch generated 306 new checkstyle issues in root (total was 217, now 521).
          +1 mvnsite 2m 52s the patch passed
          +1 mvneclipse 1m 13s the patch passed
          -1 whitespace 0m 0s The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 findbugs 1m 49s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 1 new FindBugs issues.
          -1 findbugs 1m 49s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 16 new FindBugs issues.
          -1 javadoc 4m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66 with JDK v1.8.0_66 generated 14 new issues (was 100, now 100).
          +1 javadoc 3m 22s the patch passed with JDK v1.8.0_66
          +1 javadoc 5m 9s the patch passed with JDK v1.7.0_85
          +1 unit 0m 30s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 9m 15s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66.
          -1 unit 62m 43s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 105m 31s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 36s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
          +1 unit 2m 28s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
          +1 unit 9m 33s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_85.
          -1 unit 62m 40s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
          +1 unit 106m 52s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_85.
          -1 asflicense 0m 34s Patch generated 19 ASF License warnings.
          457m 21s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
            Unused field:ReservationListRequestPBImpl.java
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.listReservations(ReservationListRequest) makes inefficient use of keySet iterator instead of entrySet iterator At ClientRMService.java:keySet iterator instead of entrySet iterator At ClientRMService.java:[line 1363]
            Unread field:ReservationDefinitionInfo.java:[line 36]
            Unread field:ReservationDefinitionInfo.java:[line 37]
            Unread field:ReservationDefinitionInfo.java:[line 38]
            Unread field:ReservationDefinitionInfo.java:[line 45]
            Unread field:ReservationInfo.java:[line 48]
            Unread field:ReservationInfo.java:[line 49]
            Unread public/protected field:At ReservationInfo.java:[line 45]
            new org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ReservationInfo(ReservationAllocation, boolean) makes inefficient use of keySet iterator instead of entrySet iterator At ReservationInfo.java:use of keySet iterator instead of entrySet iterator At ReservationInfo.java:[line 61]
            Call to equals(null) in new org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ReservationListInfo(Set, boolean) At ReservationListInfo.java:org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ReservationListInfo(Set, boolean) At ReservationListInfo.java:[line 43]
            Unread public/protected field:At ReservationRequestInfo.java:[line 35]
            Unread public/protected field:At ReservationRequestInfo.java:[line 36]
            Unread public/protected field:At ReservationRequestInfo.java:[line 37]
            Unread public/protected field:At ReservationRequestInfo.java:[line 38]
            Unread public/protected field:At ReservationRequestsInfo.java:[line 37]
            Unread public/protected field:At ReservationRequestsInfo.java:[line 38]
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.reservation.TestReservationInputValidator
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
          JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.reservation.TestReservationInputValidator
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-17
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772863/YARN-4340.v1.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 3b3dfd994f4a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / dfbde3f
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
          javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/whitespace-eol.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9715/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9715/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 8m 47s trunk passed +1 compile 10m 34s trunk passed with JDK v1.8.0_66 +1 compile 10m 17s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 7s trunk passed +1 mvnsite 3m 0s trunk passed +1 mvneclipse 1m 15s trunk passed -1 findbugs 1m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 2m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 48s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 38s the patch passed +1 compile 10m 8s the patch passed with JDK v1.8.0_66 +1 cc 10m 8s the patch passed -1 javac 20m 32s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 4 new issues (was 778, now 781). +1 javac 10m 8s the patch passed +1 compile 10m 6s the patch passed with JDK v1.7.0_85 +1 cc 10m 6s the patch passed -1 javac 30m 39s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 4 new issues (was 772, now 775). +1 javac 10m 6s the patch passed -1 checkstyle 1m 11s Patch generated 306 new checkstyle issues in root (total was 217, now 521). +1 mvnsite 2m 52s the patch passed +1 mvneclipse 1m 13s the patch passed -1 whitespace 0m 0s The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 findbugs 1m 49s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 1 new FindBugs issues. -1 findbugs 1m 49s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 16 new FindBugs issues. -1 javadoc 4m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66 with JDK v1.8.0_66 generated 14 new issues (was 100, now 100). +1 javadoc 3m 22s the patch passed with JDK v1.8.0_66 +1 javadoc 5m 9s the patch passed with JDK v1.7.0_85 +1 unit 0m 30s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 9m 15s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 62m 43s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 105m 31s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 36s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. +1 unit 2m 28s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. +1 unit 9m 33s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_85. -1 unit 62m 40s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. +1 unit 106m 52s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 34s Patch generated 19 ASF License warnings. 457m 21s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common   Unused field:ReservationListRequestPBImpl.java FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.listReservations(ReservationListRequest) makes inefficient use of keySet iterator instead of entrySet iterator At ClientRMService.java:keySet iterator instead of entrySet iterator At ClientRMService.java: [line 1363]   Unread field:ReservationDefinitionInfo.java: [line 36]   Unread field:ReservationDefinitionInfo.java: [line 37]   Unread field:ReservationDefinitionInfo.java: [line 38]   Unread field:ReservationDefinitionInfo.java: [line 45]   Unread field:ReservationInfo.java: [line 48]   Unread field:ReservationInfo.java: [line 49]   Unread public/protected field:At ReservationInfo.java: [line 45]   new org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ReservationInfo(ReservationAllocation, boolean) makes inefficient use of keySet iterator instead of entrySet iterator At ReservationInfo.java:use of keySet iterator instead of entrySet iterator At ReservationInfo.java: [line 61]   Call to equals(null) in new org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ReservationListInfo(Set, boolean) At ReservationListInfo.java:org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.ReservationListInfo(Set, boolean) At ReservationListInfo.java: [line 43]   Unread public/protected field:At ReservationRequestInfo.java: [line 35]   Unread public/protected field:At ReservationRequestInfo.java: [line 36]   Unread public/protected field:At ReservationRequestInfo.java: [line 37]   Unread public/protected field:At ReservationRequestInfo.java: [line 38]   Unread public/protected field:At ReservationRequestsInfo.java: [line 37]   Unread public/protected field:At ReservationRequestsInfo.java: [line 38] JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.reservation.TestReservationInputValidator   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.mapreduce.v2.TestMRJobsWithProfiler JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.reservation.TestReservationInputValidator   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-17 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772863/YARN-4340.v1.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 3b3dfd994f4a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / dfbde3f findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9715/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9715/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9715/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 5s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          +1 mvninstall 8m 12s trunk passed
          +1 compile 9m 3s trunk passed with JDK v1.8.0_66
          +1 compile 10m 28s trunk passed with JDK v1.7.0_85
          +1 checkstyle 1m 8s trunk passed
          +1 mvnsite 3m 2s trunk passed
          +1 mvneclipse 1m 18s trunk passed
          -1 findbugs 1m 31s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
          +1 javadoc 2m 28s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 47s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 48s the patch passed
          +1 compile 10m 8s the patch passed with JDK v1.8.0_66
          +1 cc 10m 8s the patch passed
          -1 javac 20m 46s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 779, now 779).
          +1 javac 10m 8s the patch passed
          +1 compile 10m 19s the patch passed with JDK v1.7.0_85
          +1 cc 10m 19s the patch passed
          -1 javac 31m 5s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 772, now 772).
          +1 javac 10m 19s the patch passed
          -1 checkstyle 1m 6s Patch generated 286 new checkstyle issues in root (total was 217, now 501).
          +1 mvnsite 2m 59s the patch passed
          +1 mvneclipse 1m 15s the patch passed
          +1 whitespace 0m 1s Patch has no whitespace issues.
          -1 findbugs 1m 45s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 1 new FindBugs issues.
          -1 findbugs 1m 35s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 13 new FindBugs issues.
          -1 javadoc 3m 19s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 100, now 100).
          +1 javadoc 2m 17s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 43s the patch passed with JDK v1.7.0_85
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 57s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 8m 56s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 60m 47s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 106m 9s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 35s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
          -1 unit 0m 30s hadoop-yarn-common in the patch failed with JDK v1.7.0_85.
          -1 unit 0m 36s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_85.
          -1 unit 0m 31s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
          -1 unit 0m 33s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 20s Patch generated 11 ASF License warnings.
          272m 34s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
            Unused field:ReservationListRequestPBImpl.java
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            Unread field:ReservationDefinitionInfo.java:[line 36]
            Unread field:ReservationDefinitionInfo.java:[line 37]
            Unread field:ReservationDefinitionInfo.java:[line 38]
            Unread field:ReservationDefinitionInfo.java:[line 45]
            Unread field:ReservationInfo.java:[line 48]
            Unread field:ReservationInfo.java:[line 49]
            Unread public/protected field:At ReservationInfo.java:[line 45]
            Unread public/protected field:At ReservationRequestInfo.java:[line 35]
            Unread public/protected field:At ReservationRequestInfo.java:[line 36]
            Unread public/protected field:At ReservationRequestInfo.java:[line 37]
            Unread public/protected field:At ReservationRequestInfo.java:[line 38]
            Unread public/protected field:At ReservationRequestsInfo.java:[line 37]
            Unread public/protected field:At ReservationRequestsInfo.java:[line 38]
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.mapreduce.v2.TestMRJobsWithProfiler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-18
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773062/YARN-4340.v2.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 85bdfff9302e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / bad2afe
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
          javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9724/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9724/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 5s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 8m 12s trunk passed +1 compile 9m 3s trunk passed with JDK v1.8.0_66 +1 compile 10m 28s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 8s trunk passed +1 mvnsite 3m 2s trunk passed +1 mvneclipse 1m 18s trunk passed -1 findbugs 1m 31s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 2m 28s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 47s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 48s the patch passed +1 compile 10m 8s the patch passed with JDK v1.8.0_66 +1 cc 10m 8s the patch passed -1 javac 20m 46s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 779, now 779). +1 javac 10m 8s the patch passed +1 compile 10m 19s the patch passed with JDK v1.7.0_85 +1 cc 10m 19s the patch passed -1 javac 31m 5s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 772, now 772). +1 javac 10m 19s the patch passed -1 checkstyle 1m 6s Patch generated 286 new checkstyle issues in root (total was 217, now 501). +1 mvnsite 2m 59s the patch passed +1 mvneclipse 1m 15s the patch passed +1 whitespace 0m 1s Patch has no whitespace issues. -1 findbugs 1m 45s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 1 new FindBugs issues. -1 findbugs 1m 35s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 13 new FindBugs issues. -1 javadoc 3m 19s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 100, now 100). +1 javadoc 2m 17s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 43s the patch passed with JDK v1.7.0_85 +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 57s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 56s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. -1 unit 60m 47s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 106m 9s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 35s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. -1 unit 0m 30s hadoop-yarn-common in the patch failed with JDK v1.7.0_85. -1 unit 0m 36s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_85. -1 unit 0m 31s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. -1 unit 0m 33s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 20s Patch generated 11 ASF License warnings. 272m 34s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common   Unused field:ReservationListRequestPBImpl.java FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   Unread field:ReservationDefinitionInfo.java: [line 36]   Unread field:ReservationDefinitionInfo.java: [line 37]   Unread field:ReservationDefinitionInfo.java: [line 38]   Unread field:ReservationDefinitionInfo.java: [line 45]   Unread field:ReservationInfo.java: [line 48]   Unread field:ReservationInfo.java: [line 49]   Unread public/protected field:At ReservationInfo.java: [line 45]   Unread public/protected field:At ReservationRequestInfo.java: [line 35]   Unread public/protected field:At ReservationRequestInfo.java: [line 36]   Unread public/protected field:At ReservationRequestInfo.java: [line 37]   Unread public/protected field:At ReservationRequestInfo.java: [line 38]   Unread public/protected field:At ReservationRequestsInfo.java: [line 37]   Unread public/protected field:At ReservationRequestsInfo.java: [line 38] JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.mapreduce.v2.TestMRJobsWithProfiler Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-18 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773062/YARN-4340.v2.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 85bdfff9302e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / bad2afe findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9724/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9724/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9724/console This message was automatically generated.
          Hide
          seanpo03 Sean Po added a comment -

          For the following, the fields are required JSON serialization:
          Unread field:ReservationDefinitionInfo.java:[line 36]
          Unread field:ReservationDefinitionInfo.java:[line 37]
          Unread field:ReservationDefinitionInfo.java:[line 38]
          Unread field:ReservationDefinitionInfo.java:[line 45]
          Unread field:ReservationInfo.java:[line 48]
          Unread field:ReservationInfo.java:[line 49]
          Unread public/protected field:At ReservationInfo.java:[line 45]
          Unread public/protected field:At ReservationRequestInfo.java:[line 35]
          Unread public/protected field:At ReservationRequestInfo.java:[line 36]
          Unread public/protected field:At ReservationRequestInfo.java:[line 37]
          Unread public/protected field:At ReservationRequestInfo.java:[line 38]
          Unread public/protected field:At ReservationRequestsInfo.java:[line 37]
          Unread public/protected field:At ReservationRequestsInfo.java:[line 38]

          The following test might be flaky - I am not able to reproduce this test failure:
          hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService

          I do not think the following are tests that are caused by my changes as they also occur in the latest version of trunk.
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.mapreduce.v2.TestMRJobsWithProfiler

          Show
          seanpo03 Sean Po added a comment - For the following, the fields are required JSON serialization: Unread field:ReservationDefinitionInfo.java: [line 36] Unread field:ReservationDefinitionInfo.java: [line 37] Unread field:ReservationDefinitionInfo.java: [line 38] Unread field:ReservationDefinitionInfo.java: [line 45] Unread field:ReservationInfo.java: [line 48] Unread field:ReservationInfo.java: [line 49] Unread public/protected field:At ReservationInfo.java: [line 45] Unread public/protected field:At ReservationRequestInfo.java: [line 35] Unread public/protected field:At ReservationRequestInfo.java: [line 36] Unread public/protected field:At ReservationRequestInfo.java: [line 37] Unread public/protected field:At ReservationRequestInfo.java: [line 38] Unread public/protected field:At ReservationRequestsInfo.java: [line 37] Unread public/protected field:At ReservationRequestsInfo.java: [line 38] The following test might be flaky - I am not able to reproduce this test failure: hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService I do not think the following are tests that are caused by my changes as they also occur in the latest version of trunk. hadoop.yarn.server.resourcemanager.TestAMAuthorization hadoop.yarn.server.resourcemanager.TestClientRMTokens hadoop.mapreduce.v2.TestMRJobsWithProfiler
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 5s YARN-4340 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774927/YARN-4340.v3.patch
          JIRA Issue YARN-4340
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9818/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 5s YARN-4340 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774927/YARN-4340.v3.patch JIRA Issue YARN-4340 Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9818/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          +1 mvninstall 17m 33s trunk passed
          -1 compile 1m 5s root in trunk failed with JDK v1.8.0_66.
          +1 compile 17m 8s trunk passed with JDK v1.7.0_85
          +1 checkstyle 1m 50s trunk passed
          +1 mvnsite 4m 58s trunk passed
          +1 mvneclipse 1m 59s trunk passed
          +1 findbugs 10m 13s trunk passed
          +1 javadoc 5m 12s trunk passed with JDK v1.8.0_66
          +1 javadoc 7m 19s trunk passed with JDK v1.7.0_85
          +1 mvninstall 4m 26s the patch passed
          +1 compile 22m 22s the patch passed with JDK v1.8.0_66
          -1 cc 40m 11s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 13 new issues (was 0, now 13).
          +1 cc 22m 22s the patch passed
          -1 javac 40m 14s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 751 new issues (was 0, now 751).
          +1 javac 22m 22s the patch passed
          +1 compile 16m 45s the patch passed with JDK v1.7.0_85
          +1 cc 16m 45s the patch passed
          -1 javac 57m 0s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 745, now 745).
          +1 javac 16m 45s the patch passed
          -1 checkstyle 1m 46s Patch generated 70 new checkstyle issues in root (total was 218, now 285).
          +1 mvnsite 5m 0s the patch passed
          +1 mvneclipse 1m 56s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 2m 52s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 1 new FindBugs issues.
          -1 findbugs 2m 43s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 13 new FindBugs issues.
          -1 javadoc 7m 5s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66 with JDK v1.8.0_66 generated 9 new issues (was 100, now 100).
          +1 javadoc 5m 18s the patch passed with JDK v1.8.0_66
          +1 javadoc 7m 33s the patch passed with JDK v1.7.0_85
          +1 unit 1m 8s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 4m 9s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 13m 52s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 82m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 148m 22s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 48s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
          +1 unit 3m 5s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
          +1 unit 11m 5s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_85.
          -1 unit 76m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
          -1 unit 152m 47s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 55s Patch generated 15 ASF License warnings.
          643m 13s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
            Unused field:ReservationListRequestPBImpl.java
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
            Unread public/protected field:At ReservationDefinitionInfo.java:[line 35]
            Unread public/protected field:At ReservationDefinitionInfo.java:[line 36]
            Unread public/protected field:At ReservationDefinitionInfo.java:[line 37]
            Unread public/protected field:At ReservationDefinitionInfo.java:[line 44]
            Unread public/protected field:At ReservationInfo.java:[line 42]
            Unread public/protected field:At ReservationInfo.java:[line 45]
            Unread public/protected field:At ReservationInfo.java:[line 46]
            Unread public/protected field:At ReservationRequestInfo.java:[line 35]
            Unread public/protected field:At ReservationRequestInfo.java:[line 36]
            Unread public/protected field:At ReservationRequestInfo.java:[line 37]
            Unread public/protected field:At ReservationRequestInfo.java:[line 38]
            Unread public/protected field:At ReservationRequestsInfo.java:[line 37]
            Unread public/protected field:At ReservationRequestsInfo.java:[line 38]
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.nodemanager.TestNodeManagerResync
            hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService
            hadoop.yarn.server.resourcemanager.scheduler.fair.policies.TestEmptyQueues
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestSchedulingPolicy
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapred.TestMRTimelineEventHandling
          JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestSchedulingPolicy
            hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapreduce.v2.TestRMNMInfo
            hadoop.mapred.TestMRTimelineEventHandling



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774941/YARN-4340.v4.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 9751600b7a44 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1c05393
          compile https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/branch-compile-root-jdk1.8.0_66.txt
          findbugs v3.0.0
          cc root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/diff-compile-cc-root-jdk1.8.0_66.txt
          javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
          javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9820/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9820/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 17m 33s trunk passed -1 compile 1m 5s root in trunk failed with JDK v1.8.0_66. +1 compile 17m 8s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 50s trunk passed +1 mvnsite 4m 58s trunk passed +1 mvneclipse 1m 59s trunk passed +1 findbugs 10m 13s trunk passed +1 javadoc 5m 12s trunk passed with JDK v1.8.0_66 +1 javadoc 7m 19s trunk passed with JDK v1.7.0_85 +1 mvninstall 4m 26s the patch passed +1 compile 22m 22s the patch passed with JDK v1.8.0_66 -1 cc 40m 11s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 13 new issues (was 0, now 13). +1 cc 22m 22s the patch passed -1 javac 40m 14s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 751 new issues (was 0, now 751). +1 javac 22m 22s the patch passed +1 compile 16m 45s the patch passed with JDK v1.7.0_85 +1 cc 16m 45s the patch passed -1 javac 57m 0s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 745, now 745). +1 javac 16m 45s the patch passed -1 checkstyle 1m 46s Patch generated 70 new checkstyle issues in root (total was 218, now 285). +1 mvnsite 5m 0s the patch passed +1 mvneclipse 1m 56s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 2m 52s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 1 new FindBugs issues. -1 findbugs 2m 43s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager introduced 13 new FindBugs issues. -1 javadoc 7m 5s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66 with JDK v1.8.0_66 generated 9 new issues (was 100, now 100). +1 javadoc 5m 18s the patch passed with JDK v1.8.0_66 +1 javadoc 7m 33s the patch passed with JDK v1.7.0_85 +1 unit 1m 8s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 4m 9s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 13m 52s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. -1 unit 82m 42s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 148m 22s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 48s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. +1 unit 3m 5s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. +1 unit 11m 5s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_85. -1 unit 76m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. -1 unit 152m 47s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 55s Patch generated 15 ASF License warnings. 643m 13s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common   Unused field:ReservationListRequestPBImpl.java FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   Unread public/protected field:At ReservationDefinitionInfo.java: [line 35]   Unread public/protected field:At ReservationDefinitionInfo.java: [line 36]   Unread public/protected field:At ReservationDefinitionInfo.java: [line 37]   Unread public/protected field:At ReservationDefinitionInfo.java: [line 44]   Unread public/protected field:At ReservationInfo.java: [line 42]   Unread public/protected field:At ReservationInfo.java: [line 45]   Unread public/protected field:At ReservationInfo.java: [line 46]   Unread public/protected field:At ReservationRequestInfo.java: [line 35]   Unread public/protected field:At ReservationRequestInfo.java: [line 36]   Unread public/protected field:At ReservationRequestInfo.java: [line 37]   Unread public/protected field:At ReservationRequestInfo.java: [line 38]   Unread public/protected field:At ReservationRequestsInfo.java: [line 37]   Unread public/protected field:At ReservationRequestsInfo.java: [line 38] JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.nodemanager.TestNodeManagerResync   hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService   hadoop.yarn.server.resourcemanager.scheduler.fair.policies.TestEmptyQueues   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.fair.TestSchedulingPolicy   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestMRTimelineEventHandling JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.fair.TestSchedulingPolicy   hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapreduce.v2.TestRMNMInfo   hadoop.mapred.TestMRTimelineEventHandling Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774941/YARN-4340.v4.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 9751600b7a44 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1c05393 compile https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/branch-compile-root-jdk1.8.0_66.txt findbugs v3.0.0 cc root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/diff-compile-cc-root-jdk1.8.0_66.txt javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9820/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9820/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9820/console This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Sean Po for working on this. Kindly fix the test-patch warnings.

          I went through the patch and please find my feedback below.

          First up, the patch is huge and will only get bigger so I suggest splitting it into 2 - the RPC API changes and REST API changes. I have reviewed only the RPC changes here.

          Secondly, there are very few test cases. You need to test cases at least for TestInMemoryPlan, TestYarnClient, TestReservationInputValidator, TestPBImplRecords, etc. Take a look at the other Reservation APIs for reference.

          Lastly, YarnClient needs to updated to add the new API so that it's consumable by clients.

          Now to the new listReservations API in ApplicationClientProtocol. We should be very diligent as we are adding an externally visible API:

          • We should use queue instead of planName as Plan is an internal data structure and we only expose queues to users
          • We should clearly explain in the Javadocs how the different params in ReservationListRequest influence the query. For e.g.: what are mandatory, what are optional, how does specifying multiple params affect the result, etc
          • We must explicitly call out the ResourceAllocation we are returing in ReservationListResponse is based on the current state of the Plan and we can change it for different reasons like replanning subject to the constraints of the user contract as described by ReservationDefinition

          Minor comments for rest of the code:

          • Typos in argument names for setPlanName and setUser in ReservationListRequest
          • Link the Plan/ReservationId and ResourceAllocation in the Javadocs of ReservationListRequest
          • The Javadoc of ReservationListResponse has copy paste typo, please update it
          • In ReservationInfo, all setters should be @Private
          • Link the ReservationDefinition/ReservationId and ResourceAllocation in the Javadocs of ReservationInfo
          • We should reconcile ResourceAllocation with ReservationAllocationStateProto which we use for recovery as both look to contain the same information
          • Rename ResourceAllocation --> ReservationResourceAllocation
          • Again call out explicitly in the Javadocs that the allocations are based on the current state of the Plan and we can change it for different reasons like replanning subject to the constraints of the user contract as described by ReservationDefinition
          • In ResourceAllocation, all setters should be @Private
          • Link Resource in the Javadocs of ResourceAllocation
          • In ReservationListRequestPBImpl, return NULL if string field is not set, not empty string
          • In ReservationListRequestPBImpl, check for negative long values before setting. Use ReservationDefinitionPBImpl as reference
          • Align ReservationListRequestPBImpl::getReservationInfo with ReservationRequestsPBImpl::getReservationResources
          • Add existence checks for getters and null/negative check for setters for fields in ReservationInfoPBImpl
          • Align ReservationInfoPBImpl::getResourceAllocations with ReservationRequestsPBImpl::getReservationResources
          • In ResourceAllocationPBImpl, check for negative long values before setting
          • Revert the unrelated formatting changes in ClientRMService
          • In ClientRMService::listReservations, ACL check has to be done before querying the Plan
          • In ClientRMService::listReservations, refactor the translation of Set<ReservationAllocation> into List<ReservationInfo> into a separate helper method. It may make sense to have in ReservationSystemUtil as can have other consumers in future
          • In InMemoryPlan::getReservations, there are 2 read locks - the outer one is redundant and can be removed
          • Add null check for user in InMemoryPlan::getReservations
          • In ReservationInputValidator::validateReservationListRequest, the validation seems to be common with other existing checks so would be better to extract a common helper private method and reuse it.
          • In ReservationInputValidator::validateReservationListRequest, we are only validating the plan queue name - what about other params?
          • In TestClientRMService, add more listReservations queries after submission, deletion. Also check for a narrower time window rather than 0 - Long.MAX_VALUE.
          • In TestClientRMService, rename lRequest and lResponse with request and response respectively.
          Show
          subru Subru Krishnan added a comment - Thanks Sean Po for working on this. Kindly fix the test-patch warnings. I went through the patch and please find my feedback below. First up, the patch is huge and will only get bigger so I suggest splitting it into 2 - the RPC API changes and REST API changes. I have reviewed only the RPC changes here. Secondly, there are very few test cases. You need to test cases at least for TestInMemoryPlan, TestYarnClient, TestReservationInputValidator, TestPBImplRecords , etc. Take a look at the other Reservation APIs for reference. Lastly, YarnClient needs to updated to add the new API so that it's consumable by clients. Now to the new listReservations API in ApplicationClientProtocol . We should be very diligent as we are adding an externally visible API: We should use queue instead of planName as Plan is an internal data structure and we only expose queues to users We should clearly explain in the Javadocs how the different params in ReservationListRequest influence the query. For e.g.: what are mandatory, what are optional, how does specifying multiple params affect the result, etc We must explicitly call out the ResourceAllocation we are returing in ReservationListResponse is based on the current state of the Plan and we can change it for different reasons like replanning subject to the constraints of the user contract as described by ReservationDefinition Minor comments for rest of the code: Typos in argument names for setPlanName and setUser in ReservationListRequest Link the Plan/ReservationId and ResourceAllocation in the Javadocs of ReservationListRequest The Javadoc of ReservationListResponse has copy paste typo, please update it In ReservationInfo , all setters should be @Private Link the ReservationDefinition/ReservationId and ResourceAllocation in the Javadocs of ReservationInfo We should reconcile ResourceAllocation with ReservationAllocationStateProto which we use for recovery as both look to contain the same information Rename ResourceAllocation --> ReservationResourceAllocation Again call out explicitly in the Javadocs that the allocations are based on the current state of the Plan and we can change it for different reasons like replanning subject to the constraints of the user contract as described by ReservationDefinition In ResourceAllocation , all setters should be @Private Link Resource in the Javadocs of ResourceAllocation In ReservationListRequestPBImpl , return NULL if string field is not set, not empty string In ReservationListRequestPBImpl , check for negative long values before setting. Use ReservationDefinitionPBImpl as reference Align ReservationListRequestPBImpl::getReservationInfo with ReservationRequestsPBImpl::getReservationResources Add existence checks for getters and null/negative check for setters for fields in ReservationInfoPBImpl Align ReservationInfoPBImpl::getResourceAllocations with ReservationRequestsPBImpl::getReservationResources In ResourceAllocationPBImpl , check for negative long values before setting Revert the unrelated formatting changes in ClientRMService In ClientRMService::listReservations , ACL check has to be done before querying the Plan In ClientRMService::listReservations , refactor the translation of Set<ReservationAllocation> into List<ReservationInfo> into a separate helper method. It may make sense to have in ReservationSystemUtil as can have other consumers in future In InMemoryPlan::getReservations , there are 2 read locks - the outer one is redundant and can be removed Add null check for user in InMemoryPlan::getReservations In ReservationInputValidator::validateReservationListRequest , the validation seems to be common with other existing checks so would be better to extract a common helper private method and reuse it. In ReservationInputValidator::validateReservationListRequest , we are only validating the plan queue name - what about other params? In TestClientRMService , add more listReservations queries after submission, deletion. Also check for a narrower time window rather than 0 - Long.MAX_VALUE. In TestClientRMService , rename lRequest and lResponse with request and response respectively.
          Hide
          subru Subru Krishnan added a comment -

          Thinking more about it, I am not sure we should have user in the interface. We should automatically pick up user from context. If we want to allow user, then it should be an Admin API and not a Client API IMHO.

          Show
          subru Subru Krishnan added a comment - Thinking more about it, I am not sure we should have user in the interface. We should automatically pick up user from context. If we want to allow user, then it should be an Admin API and not a Client API IMHO.
          Hide
          seanpo03 Sean Po added a comment -

          I took all your suggestions above, and with regards to your second comment, I also removed 'user' from the interface in v5 of the patch.
          The REST aspect of the code was also removed, and will be a part of a second ticket YARN-4420.

          Show
          seanpo03 Sean Po added a comment - I took all your suggestions above, and with regards to your second comment, I also removed 'user' from the interface in v5 of the patch. The REST aspect of the code was also removed, and will be a part of a second ticket YARN-4420 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          +1 mvninstall 8m 21s trunk passed
          +1 compile 8m 57s trunk passed with JDK v1.8.0_66
          +1 compile 9m 29s trunk passed with JDK v1.7.0_85
          +1 checkstyle 1m 5s trunk passed
          +1 mvnsite 3m 32s trunk passed
          +1 mvneclipse 1m 23s trunk passed
          +1 findbugs 6m 12s trunk passed
          +1 javadoc 2m 20s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 53s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 50s the patch passed
          +1 compile 8m 56s the patch passed with JDK v1.8.0_66
          +1 cc 8m 56s the patch passed
          -1 javac 19m 31s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 751, now 751).
          +1 javac 8m 56s the patch passed
          +1 compile 9m 25s the patch passed with JDK v1.7.0_85
          +1 cc 9m 25s the patch passed
          -1 javac 28m 56s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 745, now 745).
          +1 javac 9m 25s the patch passed
          -1 checkstyle 1m 15s Patch generated 32 new checkstyle issues in root (total was 352, now 382).
          +1 mvnsite 3m 10s the patch passed
          +1 mvneclipse 1m 24s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 1m 37s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 4 new FindBugs issues.
          -1 javadoc 3m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66 with JDK v1.8.0_66 generated 9 new issues (was 100, now 100).
          +1 javadoc 2m 23s the patch passed with JDK v1.8.0_66
          -1 javadoc 8m 49s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85 with JDK v1.7.0_85 generated 5 new issues (was 0, now 5).
          +1 javadoc 5m 8s the patch passed with JDK v1.7.0_85
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 8m 51s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66.
          -1 unit 59m 54s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 49m 29s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 103m 31s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
          +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
          +1 unit 9m 31s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_85.
          -1 unit 63m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
          -1 unit 49m 51s hadoop-yarn-client in the patch failed with JDK v1.7.0_85.
          -1 unit 67m 43s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          508m 0s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
            org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationListRequestPBImpl defines equals and uses Object.hashCode() At ReservationListRequestPBImpl.java:Object.hashCode() At ReservationListRequestPBImpl.java:[lines 150-156]
            org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationListResponsePBImpl defines equals and uses Object.hashCode() At ReservationListResponsePBImpl.java:Object.hashCode() At ReservationListResponsePBImpl.java:[lines 139-145]
            org.apache.hadoop.yarn.api.records.impl.pb.ReservationAllocationStatePBImpl defines equals and uses Object.hashCode() At ReservationAllocationStatePBImpl.java:Object.hashCode() At ReservationAllocationStatePBImpl.java:[lines 248-254]
            org.apache.hadoop.yarn.api.records.impl.pb.ResourceAllocationRequestPBImpl defines equals and uses Object.hashCode() At ResourceAllocationRequestPBImpl.java:Object.hashCode() At ResourceAllocationRequestPBImpl.java:[lines 156-162]
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.client.TestGetGroups
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775683/YARN-4340.v5.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 2be78ec70e13 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 924a33d
          findbugs v3.0.0
          javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
          javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9853/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 30MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9853/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. +1 mvninstall 8m 21s trunk passed +1 compile 8m 57s trunk passed with JDK v1.8.0_66 +1 compile 9m 29s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 5s trunk passed +1 mvnsite 3m 32s trunk passed +1 mvneclipse 1m 23s trunk passed +1 findbugs 6m 12s trunk passed +1 javadoc 2m 20s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 53s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 50s the patch passed +1 compile 8m 56s the patch passed with JDK v1.8.0_66 +1 cc 8m 56s the patch passed -1 javac 19m 31s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 751, now 751). +1 javac 8m 56s the patch passed +1 compile 9m 25s the patch passed with JDK v1.7.0_85 +1 cc 9m 25s the patch passed -1 javac 28m 56s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 745, now 745). +1 javac 9m 25s the patch passed -1 checkstyle 1m 15s Patch generated 32 new checkstyle issues in root (total was 352, now 382). +1 mvnsite 3m 10s the patch passed +1 mvneclipse 1m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 1m 37s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 4 new FindBugs issues. -1 javadoc 3m 20s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66 with JDK v1.8.0_66 generated 9 new issues (was 100, now 100). +1 javadoc 2m 23s the patch passed with JDK v1.8.0_66 -1 javadoc 8m 49s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85 with JDK v1.7.0_85 generated 5 new issues (was 0, now 5). +1 javadoc 5m 8s the patch passed with JDK v1.7.0_85 +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 51s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 59m 54s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 49m 29s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 103m 31s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. +1 unit 9m 31s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_85. -1 unit 63m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. -1 unit 49m 51s hadoop-yarn-client in the patch failed with JDK v1.7.0_85. -1 unit 67m 43s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 508m 0s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common   org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationListRequestPBImpl defines equals and uses Object.hashCode() At ReservationListRequestPBImpl.java:Object.hashCode() At ReservationListRequestPBImpl.java: [lines 150-156]   org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationListResponsePBImpl defines equals and uses Object.hashCode() At ReservationListResponsePBImpl.java:Object.hashCode() At ReservationListResponsePBImpl.java: [lines 139-145]   org.apache.hadoop.yarn.api.records.impl.pb.ReservationAllocationStatePBImpl defines equals and uses Object.hashCode() At ReservationAllocationStatePBImpl.java:Object.hashCode() At ReservationAllocationStatePBImpl.java: [lines 248-254]   org.apache.hadoop.yarn.api.records.impl.pb.ResourceAllocationRequestPBImpl defines equals and uses Object.hashCode() At ResourceAllocationRequestPBImpl.java:Object.hashCode() At ResourceAllocationRequestPBImpl.java: [lines 156-162] JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestMRJobsWithProfiler JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775683/YARN-4340.v5.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 2be78ec70e13 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 924a33d findbugs v3.0.0 javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9853/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9853/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 30MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9853/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          +1 mvninstall 9m 1s trunk passed
          +1 compile 11m 15s trunk passed with JDK v1.8.0_66
          +1 compile 10m 40s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 10s trunk passed
          +1 mvnsite 3m 28s trunk passed
          +1 mvneclipse 1m 32s trunk passed
          +1 findbugs 6m 51s trunk passed
          +1 javadoc 2m 57s trunk passed with JDK v1.8.0_66
          +1 javadoc 5m 24s trunk passed with JDK v1.7.0_91
          +1 mvninstall 3m 11s the patch passed
          +1 compile 11m 14s the patch passed with JDK v1.8.0_66
          +1 cc 11m 14s the patch passed
          -1 javac 23m 22s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 751, now 751).
          +1 javac 11m 14s the patch passed
          +1 compile 10m 39s the patch passed with JDK v1.7.0_91
          +1 cc 10m 39s the patch passed
          -1 javac 34m 1s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 745, now 745).
          +1 javac 10m 39s the patch passed
          -1 checkstyle 1m 11s Patch generated 32 new checkstyle issues in root (total was 351, now 381).
          +1 mvnsite 3m 29s the patch passed
          +1 mvneclipse 1m 31s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 1m 48s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 4 new FindBugs issues.
          -1 javadoc 4m 0s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66 with JDK v1.8.0_66 generated 14 new issues (was 100, now 100).
          +1 javadoc 2m 56s the patch passed with JDK v1.8.0_66
          -1 javadoc 10m 0s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_91 with JDK v1.7.0_91 generated 5 new issues (was 0, now 5).
          +1 javadoc 5m 37s the patch passed with JDK v1.7.0_91
          +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 23s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 9m 46s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66.
          -1 unit 66m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 50m 31s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 151m 25s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 59s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 3m 33s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 unit 11m 46s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91.
          -1 unit 74m 2s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 49m 55s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
          -1 unit 120m 49s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 33s Patch generated 19 ASF License warnings.
          645m 21s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
            org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationListRequestPBImpl defines equals and uses Object.hashCode() At ReservationListRequestPBImpl.java:Object.hashCode() At ReservationListRequestPBImpl.java:[lines 150-156]
            org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationListResponsePBImpl defines equals and uses Object.hashCode() At ReservationListResponsePBImpl.java:Object.hashCode() At ReservationListResponsePBImpl.java:[lines 139-145]
            org.apache.hadoop.yarn.api.records.impl.pb.ReservationAllocationStatePBImpl defines equals and uses Object.hashCode() At ReservationAllocationStatePBImpl.java:Object.hashCode() At ReservationAllocationStatePBImpl.java:[lines 248-254]
            org.apache.hadoop.yarn.api.records.impl.pb.ResourceAllocationRequestPBImpl defines equals and uses Object.hashCode() At ResourceAllocationRequestPBImpl.java:Object.hashCode() At ResourceAllocationRequestPBImpl.java:[lines 156-162]
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.client.TestGetGroups
            hadoop.mapreduce.v2.TestRMNMInfo
            hadoop.mapred.TestMRTimelineEventHandling
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapred.TestClusterMRNotification
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestSchedulingPolicy
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.client.TestGetGroups
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
            org.apache.hadoop.mapred.TestMRIntermediateDataEncryption



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775722/YARN-4340.v5.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux e75b3003a2da 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e84d6ca
          findbugs v3.0.0
          javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt
          javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/diff-checkstyle-root.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9856/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9856/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. +1 mvninstall 9m 1s trunk passed +1 compile 11m 15s trunk passed with JDK v1.8.0_66 +1 compile 10m 40s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 10s trunk passed +1 mvnsite 3m 28s trunk passed +1 mvneclipse 1m 32s trunk passed +1 findbugs 6m 51s trunk passed +1 javadoc 2m 57s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 24s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 11s the patch passed +1 compile 11m 14s the patch passed with JDK v1.8.0_66 +1 cc 11m 14s the patch passed -1 javac 23m 22s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 751, now 751). +1 javac 11m 14s the patch passed +1 compile 10m 39s the patch passed with JDK v1.7.0_91 +1 cc 10m 39s the patch passed -1 javac 34m 1s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 745, now 745). +1 javac 10m 39s the patch passed -1 checkstyle 1m 11s Patch generated 32 new checkstyle issues in root (total was 351, now 381). +1 mvnsite 3m 29s the patch passed +1 mvneclipse 1m 31s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 1m 48s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 4 new FindBugs issues. -1 javadoc 4m 0s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66 with JDK v1.8.0_66 generated 14 new issues (was 100, now 100). +1 javadoc 2m 56s the patch passed with JDK v1.8.0_66 -1 javadoc 10m 0s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_91 with JDK v1.7.0_91 generated 5 new issues (was 0, now 5). +1 javadoc 5m 37s the patch passed with JDK v1.7.0_91 +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 23s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 9m 46s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 66m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 50m 31s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 151m 25s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 59s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 3m 33s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 11m 46s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91. -1 unit 74m 2s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 49m 55s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. -1 unit 120m 49s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 33s Patch generated 19 ASF License warnings. 645m 21s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common   org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationListRequestPBImpl defines equals and uses Object.hashCode() At ReservationListRequestPBImpl.java:Object.hashCode() At ReservationListRequestPBImpl.java: [lines 150-156]   org.apache.hadoop.yarn.api.protocolrecords.impl.pb.ReservationListResponsePBImpl defines equals and uses Object.hashCode() At ReservationListResponsePBImpl.java:Object.hashCode() At ReservationListResponsePBImpl.java: [lines 139-145]   org.apache.hadoop.yarn.api.records.impl.pb.ReservationAllocationStatePBImpl defines equals and uses Object.hashCode() At ReservationAllocationStatePBImpl.java:Object.hashCode() At ReservationAllocationStatePBImpl.java: [lines 248-254]   org.apache.hadoop.yarn.api.records.impl.pb.ResourceAllocationRequestPBImpl defines equals and uses Object.hashCode() At ResourceAllocationRequestPBImpl.java:Object.hashCode() At ResourceAllocationRequestPBImpl.java: [lines 156-162] JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestRMNMInfo   hadoop.mapred.TestMRTimelineEventHandling   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestClusterMRNotification JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.scheduler.fair.TestSchedulingPolicy   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient   org.apache.hadoop.mapred.TestMRIntermediateDataEncryption Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775722/YARN-4340.v5.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux e75b3003a2da 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e84d6ca findbugs v3.0.0 javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/diff-checkstyle-root.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9856/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9856/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9856/console This message was automatically generated.
          Hide
          seanpo03 Sean Po added a comment -

          Fixed all relevant checkstyle, javac, findbugs, javadoc issues.

          Show
          seanpo03 Sean Po added a comment - Fixed all relevant checkstyle, javac, findbugs, javadoc issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          +1 mvninstall 8m 16s trunk passed
          +1 compile 9m 4s trunk passed with JDK v1.8.0_66
          +1 compile 9m 32s trunk passed with JDK v1.7.0_85
          +1 checkstyle 1m 3s trunk passed
          +1 mvnsite 3m 9s trunk passed
          +1 mvneclipse 1m 25s trunk passed
          +1 findbugs 6m 15s trunk passed
          -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66.
          +1 javadoc 4m 56s trunk passed with JDK v1.7.0_85
          +1 mvninstall 2m 53s the patch passed
          +1 compile 9m 6s the patch passed with JDK v1.8.0_66
          +1 cc 9m 6s the patch passed
          +1 javac 9m 6s the patch passed
          +1 compile 9m 36s the patch passed with JDK v1.7.0_85
          +1 cc 9m 36s the patch passed
          -1 javac 29m 33s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 746, now 746).
          +1 javac 9m 36s the patch passed
          -1 checkstyle 1m 5s Patch generated 4 new checkstyle issues in root (total was 353, now 355).
          +1 mvnsite 3m 13s the patch passed
          +1 mvneclipse 1m 30s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 7m 7s the patch passed
          -1 javadoc 3m 31s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66 with JDK v1.8.0_66 generated 3 new issues (was 100, now 100).
          -1 javadoc 0m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 javadoc 5m 6s the patch passed with JDK v1.7.0_85
          +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 3s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 9m 2s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66.
          -1 unit 69m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 49m 41s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 104m 22s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
          +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
          +1 unit 9m 34s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_85.
          -1 unit 66m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
          -1 unit 49m 43s hadoop-yarn-client in the patch failed with JDK v1.7.0_85.
          +1 unit 105m 34s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_85.
          -1 asflicense 0m 38s Patch generated 3 ASF License warnings.
          560m 2s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.client.TestGetGroups
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.client.TestGetGroups
          JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776222/YARN-4340.v6.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 4fd807063d70 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fc47084
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9892/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9892/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. +1 mvninstall 8m 16s trunk passed +1 compile 9m 4s trunk passed with JDK v1.8.0_66 +1 compile 9m 32s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 3s trunk passed +1 mvnsite 3m 9s trunk passed +1 mvneclipse 1m 25s trunk passed +1 findbugs 6m 15s trunk passed -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66. +1 javadoc 4m 56s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 53s the patch passed +1 compile 9m 6s the patch passed with JDK v1.8.0_66 +1 cc 9m 6s the patch passed +1 javac 9m 6s the patch passed +1 compile 9m 36s the patch passed with JDK v1.7.0_85 +1 cc 9m 36s the patch passed -1 javac 29m 33s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 746, now 746). +1 javac 9m 36s the patch passed -1 checkstyle 1m 5s Patch generated 4 new checkstyle issues in root (total was 353, now 355). +1 mvnsite 3m 13s the patch passed +1 mvneclipse 1m 30s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 7m 7s the patch passed -1 javadoc 3m 31s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66 with JDK v1.8.0_66 generated 3 new issues (was 100, now 100). -1 javadoc 0m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 javadoc 5m 6s the patch passed with JDK v1.7.0_85 +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 3s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 9m 2s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 69m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 49m 41s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 104m 22s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 31s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. +1 unit 9m 34s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_85. -1 unit 66m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. -1 unit 49m 43s hadoop-yarn-client in the patch failed with JDK v1.7.0_85. +1 unit 105m 34s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_85. -1 asflicense 0m 38s Patch generated 3 ASF License warnings. 560m 2s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestMRJobsWithProfiler JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776222/YARN-4340.v6.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 4fd807063d70 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fc47084 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/diff-checkstyle-root.txt javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9892/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9892/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9892/console This message was automatically generated.
          Hide
          seanpo03 Sean Po added a comment -

          This patch addresses the remaining findbugs, checkstyle errors.

          The following unit tests are failing and have associated Jira tickets:
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          YARN-4306
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          YARN-4318
          hadoop.yarn.client.TestGetGroups
          YARN-4351

          The following unit tests are passing locally and flakiness may be related to YARN-4352:
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          – testShouldNotRetryForeverForNonNetworkExceptions also fails locally on trunk
          – testAMMRToken passes locally on trunk
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient

          The following tests are passing locally:
          hadoop.mapreduce.v2.TestMRJobsWithProfiler

          Show
          seanpo03 Sean Po added a comment - This patch addresses the remaining findbugs, checkstyle errors. The following unit tests are failing and have associated Jira tickets: hadoop.yarn.server.resourcemanager.TestClientRMTokens – YARN-4306 hadoop.yarn.server.resourcemanager.TestAMAuthorization – YARN-4318 hadoop.yarn.client.TestGetGroups – YARN-4351 The following unit tests are passing locally and flakiness may be related to YARN-4352 : org.apache.hadoop.yarn.client.api.impl.TestYarnClient – testShouldNotRetryForeverForNonNetworkExceptions also fails locally on trunk – testAMMRToken passes locally on trunk org.apache.hadoop.yarn.client.api.impl.TestAMRMClient org.apache.hadoop.yarn.client.api.impl.TestNMClient The following tests are passing locally: hadoop.mapreduce.v2.TestMRJobsWithProfiler
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          +1 mvninstall 8m 48s trunk passed
          +1 compile 10m 20s trunk passed with JDK v1.8.0_66
          +1 compile 10m 11s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 5s trunk passed
          +1 mvnsite 3m 20s trunk passed
          +1 mvneclipse 1m 26s trunk passed
          +1 findbugs 6m 51s trunk passed
          -1 javadoc 0m 23s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66.
          +1 javadoc 4m 53s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 50s the patch passed
          +1 compile 9m 8s the patch passed with JDK v1.8.0_66
          +1 cc 9m 8s the patch passed
          +1 javac 9m 8s the patch passed
          +1 compile 9m 25s the patch passed with JDK v1.7.0_91
          +1 cc 9m 25s the patch passed
          -1 javac 29m 27s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 746, now 746).
          +1 javac 9m 25s the patch passed
          +1 checkstyle 1m 3s the patch passed
          +1 mvnsite 3m 3s the patch passed
          +1 mvneclipse 1m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 6m 55s the patch passed
          -1 javadoc 3m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 100, now 100).
          +1 javadoc 2m 25s the patch passed with JDK v1.8.0_66
          +1 javadoc 5m 6s the patch passed with JDK v1.7.0_91
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 8m 54s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66.
          -1 unit 60m 55s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 49m 27s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 112m 10s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 33s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 22s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 unit 9m 23s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91.
          -1 unit 62m 10s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 49m 49s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
          +1 unit 104m 39s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 33s Patch generated 15 ASF License warnings.
          556m 23s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.client.TestGetGroups
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
            org.apache.hadoop.mapred.TestMRIntermediateDataEncryption
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions
            hadoop.yarn.client.TestGetGroups
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776470/YARN-4340.v7.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux f252bb3bd795 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ada9c2c
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9909/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9909/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. +1 mvninstall 8m 48s trunk passed +1 compile 10m 20s trunk passed with JDK v1.8.0_66 +1 compile 10m 11s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 5s trunk passed +1 mvnsite 3m 20s trunk passed +1 mvneclipse 1m 26s trunk passed +1 findbugs 6m 51s trunk passed -1 javadoc 0m 23s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66. +1 javadoc 4m 53s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 50s the patch passed +1 compile 9m 8s the patch passed with JDK v1.8.0_66 +1 cc 9m 8s the patch passed +1 javac 9m 8s the patch passed +1 compile 9m 25s the patch passed with JDK v1.7.0_91 +1 cc 9m 25s the patch passed -1 javac 29m 27s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 746, now 746). +1 javac 9m 25s the patch passed +1 checkstyle 1m 3s the patch passed +1 mvnsite 3m 3s the patch passed +1 mvneclipse 1m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 55s the patch passed -1 javadoc 3m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 100, now 100). +1 javadoc 2m 25s the patch passed with JDK v1.8.0_66 +1 javadoc 5m 6s the patch passed with JDK v1.7.0_91 +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 54s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 60m 55s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 49m 27s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 112m 10s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 33s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 22s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 9m 23s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91. -1 unit 62m 10s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 49m 49s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. +1 unit 104m 39s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 33s Patch generated 15 ASF License warnings. 556m 23s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestMRJobsWithProfiler JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient   org.apache.hadoop.mapred.TestMRIntermediateDataEncryption JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions   hadoop.yarn.client.TestGetGroups JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776470/YARN-4340.v7.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux f252bb3bd795 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ada9c2c findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9909/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9909/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9909/console This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Sean Po for addressing my comments. This patch looks much better. Please find my feedback below.

          The Javadocs for listReservations API in ApplicationClientProtocol looks pretty good. A few nits (same holds for Javadoc of ReservationListRequest and YarnClient):

          • We are still not explicitly calling out that the ResourceAllocation we are returing in ReservationListResponse is based on the current state of the Plan and we can change it for different reasons like replanning subject to the constraints of the user contract as described by ReservationDefinition
          • Specify the queue refers to the reservable queue in the scheduler. Refer ReservationSubmissionRequest
          • Remove username as it's no longer used
          • Typo in starttime - start not end after the startTime will be selected
          • Typo in endTime - end not start after the endTime will be selected

          Minor Comments for rest of the patch:

          • Replace all occurance of plan with queue in ReservationListRequest
          • Typo in Javadoc of ReservationAllocationState::getReservationDefinition, replace set with get. Also you can link ReservationDefinition in the return param. This is cosmetic but I see it in a few places so if possible, kindly fix those too.
          • Can we order the arguments of ResourceAllocationRequest::newInstance as startTime, endTime and capability to improve readability
          • In ClientRMService::listReservations, includeResourceAllocations can be of primitive boolean type
          • Shouldn't we check for requestInfo.getEndTime() <= -1 in ClientRMService::listReservations?
          • Can we rename info to say reservationInfo or something more verbal to make it more readable in ClientRMService::listReservations
          • I am confused by the Javadocs of PlanView::getReservations, looks like start and end time are swapped
          • You can revert the change to PlanView::getReservationByUserAtTime as that's being addressed in YARN-4358
          • In ReservationInputValidator, the error strings can also be created in getPlanFromQueue as they can be made consistent and reduce redundant code
          • Can we rename info to say reservationInfo or something more verbal to make it more readable in ReservationSystemUtil::convertAllocationsToReservationInfo
          • In ReservationSystemUtil::convertAllocationsToReservationInfo, we need not create local variables for acceptanceTime, user, id, definition as we don't use them locally
          • The Map<ReservationInterval, Resource> can be defined outside of the for loops in ReservationSystemUtil::convertAllocationsToReservationInfo
          • In TestClientRMService, can you add a query for listReservations based on arrival and duration like you have done in TestYarnClient
          • The test case additions to TestInMemoryPlan are great. Can we cover a few more scenarios like more than reservations, invalid reservation id and boundary conditions of time interval
          • Looks like there are some whitespaces in TestInMemoryPlan
          Show
          subru Subru Krishnan added a comment - Thanks Sean Po for addressing my comments. This patch looks much better. Please find my feedback below. The Javadocs for listReservations API in ApplicationClientProtocol looks pretty good. A few nits (same holds for Javadoc of ReservationListRequest and YarnClient ): We are still not explicitly calling out that the ResourceAllocation we are returing in ReservationListResponse is based on the current state of the Plan and we can change it for different reasons like replanning subject to the constraints of the user contract as described by ReservationDefinition Specify the queue refers to the reservable queue in the scheduler. Refer ReservationSubmissionRequest Remove username as it's no longer used Typo in starttime - start not end after the startTime will be selected Typo in endTime - end not start after the endTime will be selected Minor Comments for rest of the patch: Replace all occurance of plan with queue in ReservationListRequest Typo in Javadoc of ReservationAllocationState::getReservationDefinition , replace set with get . Also you can link ReservationDefinition in the return param. This is cosmetic but I see it in a few places so if possible, kindly fix those too. Can we order the arguments of ResourceAllocationRequest::newInstance as startTime, endTime and capability to improve readability In ClientRMService::listReservations , includeResourceAllocations can be of primitive boolean type Shouldn't we check for requestInfo.getEndTime() <= -1 in ClientRMService::listReservations ? Can we rename info to say reservationInfo or something more verbal to make it more readable in ClientRMService::listReservations I am confused by the Javadocs of PlanView::getReservations , looks like start and end time are swapped You can revert the change to PlanView::getReservationByUserAtTime as that's being addressed in YARN-4358 In ReservationInputValidator , the error strings can also be created in getPlanFromQueue as they can be made consistent and reduce redundant code Can we rename info to say reservationInfo or something more verbal to make it more readable in ReservationSystemUtil::convertAllocationsToReservationInfo In ReservationSystemUtil::convertAllocationsToReservationInfo , we need not create local variables for acceptanceTime, user, id, definition as we don't use them locally The Map<ReservationInterval, Resource> can be defined outside of the for loops in ReservationSystemUtil::convertAllocationsToReservationInfo In TestClientRMService , can you add a query for listReservations based on arrival and duration like you have done in TestYarnClient The test case additions to TestInMemoryPlan are great. Can we cover a few more scenarios like more than reservations, invalid reservation id and boundary conditions of time interval Looks like there are some whitespaces in TestInMemoryPlan
          Hide
          seanpo03 Sean Po added a comment -

          Thanks Subru for the comments. I have taken all your recommendations, except for the following:

          The startTime and endTime wasn't a typo - I actually intended on selecting all active reservations within the time interval. that's why only reservations that ended after the selection startTime, and reservations that start before or on the selection endTime are included in the response.

          In ReservationInputValidator, I didn't want to create the error strings from getPlanFromQueue because it almost seems like we are bending over backwards to prevent repeated code. The reason is because validateReservation uses this method, and has a drastically different error message, and it doesn't seem easy to reword it to fit into the pattern of the other error messages. I have instead overloaded the method so that users can optionally pass in the error messages. Otherwise, the defaults will be used.

          Show
          seanpo03 Sean Po added a comment - Thanks Subru for the comments. I have taken all your recommendations, except for the following: The startTime and endTime wasn't a typo - I actually intended on selecting all active reservations within the time interval. that's why only reservations that ended after the selection startTime, and reservations that start before or on the selection endTime are included in the response. In ReservationInputValidator, I didn't want to create the error strings from getPlanFromQueue because it almost seems like we are bending over backwards to prevent repeated code. The reason is because validateReservation uses this method, and has a drastically different error message, and it doesn't seem easy to reword it to fit into the pattern of the other error messages. I have instead overloaded the method so that users can optionally pass in the error messages. Otherwise, the defaults will be used.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          +1 mvninstall 8m 7s trunk passed
          +1 compile 9m 2s trunk passed with JDK v1.8.0_66
          +1 compile 9m 30s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 2s trunk passed
          +1 mvnsite 3m 9s trunk passed
          +1 mvneclipse 1m 25s trunk passed
          +1 findbugs 6m 16s trunk passed
          -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66.
          +1 javadoc 4m 53s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 52s the patch passed
          +1 compile 8m 51s the patch passed with JDK v1.8.0_66
          -1 cc 19m 34s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 13, now 13).
          +1 cc 8m 51s the patch passed
          +1 javac 8m 51s the patch passed
          +1 compile 9m 24s the patch passed with JDK v1.7.0_91
          +1 cc 9m 24s the patch passed
          -1 javac 28m 59s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 729, now 729).
          +1 javac 9m 24s the patch passed
          -1 checkstyle 1m 0s Patch generated 1 new checkstyle issues in root (total was 353, now 352).
          +1 mvnsite 3m 8s the patch passed
          +1 mvneclipse 1m 24s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 7m 29s the patch passed
          -1 javadoc 0m 43s hadoop-yarn-api in the patch failed with JDK v1.8.0_66.
          -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 javadoc 0m 15s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 javadoc 8m 48s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_91 with JDK v1.7.0_91 generated 3 new issues (was 0, now 3).
          -1 javadoc 8m 48s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91 with JDK v1.7.0_91 generated 2 new issues (was 0, now 2).
          +1 javadoc 4m 59s the patch passed with JDK v1.7.0_91
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 59s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 9m 4s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66.
          -1 unit 71m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 49m 46s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 105m 59s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 35s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 25s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 unit 9m 38s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91.
          -1 unit 67m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 49m 42s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
          -1 unit 96m 41s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          554m 37s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.reservation.TestReservationInputValidator
            hadoop.yarn.client.TestGetGroups
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_91 Failed junit tests hadoop.mapreduce.lib.output.TestJobOutputCommitter



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776723/YARN-4340.v8.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 56167feaacba 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 132478e
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          cc root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/diff-compile-cc-root-jdk1.8.0_66.txt
          javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_91.txt
          javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9922/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 30MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9922/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. +1 mvninstall 8m 7s trunk passed +1 compile 9m 2s trunk passed with JDK v1.8.0_66 +1 compile 9m 30s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 2s trunk passed +1 mvnsite 3m 9s trunk passed +1 mvneclipse 1m 25s trunk passed +1 findbugs 6m 16s trunk passed -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66. +1 javadoc 4m 53s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 52s the patch passed +1 compile 8m 51s the patch passed with JDK v1.8.0_66 -1 cc 19m 34s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 13, now 13). +1 cc 8m 51s the patch passed +1 javac 8m 51s the patch passed +1 compile 9m 24s the patch passed with JDK v1.7.0_91 +1 cc 9m 24s the patch passed -1 javac 28m 59s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 729, now 729). +1 javac 9m 24s the patch passed -1 checkstyle 1m 0s Patch generated 1 new checkstyle issues in root (total was 353, now 352). +1 mvnsite 3m 8s the patch passed +1 mvneclipse 1m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 7m 29s the patch passed -1 javadoc 0m 43s hadoop-yarn-api in the patch failed with JDK v1.8.0_66. -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 javadoc 0m 15s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 javadoc 8m 48s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_91 with JDK v1.7.0_91 generated 3 new issues (was 0, now 3). -1 javadoc 8m 48s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91 with JDK v1.7.0_91 generated 2 new issues (was 0, now 2). +1 javadoc 4m 59s the patch passed with JDK v1.7.0_91 +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 59s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 9m 4s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 71m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 49m 46s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 105m 59s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 35s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 25s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 9m 38s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91. -1 unit 67m 8s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 49m 42s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. -1 unit 96m 41s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 554m 37s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.reservation.TestReservationInputValidator   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestMRJobsWithProfiler JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.mapreduce.lib.output.TestJobOutputCommitter Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776723/YARN-4340.v8.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 56167feaacba 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 132478e findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt cc root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/diff-compile-cc-root-jdk1.8.0_66.txt javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.8.0_66.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-jdk1.7.0_91.txt javadoc hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9922/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9922/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 30MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9922/console This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          Thanks for addressing my feedback Sean Po. The latest patch (v8) LGTM.

          Carlo Curino, can you take a look and commit.

          Show
          subru Subru Krishnan added a comment - Thanks for addressing my feedback Sean Po . The latest patch (v8) LGTM. Carlo Curino , can you take a look and commit.
          Hide
          subru Subru Krishnan added a comment -

          Sean Po, I noticed there are couple of minor checkstyle & Javadoc issues. Can you kindly fix those.

          Also the TestReservationInputValidator::testSubmitReservationDoesnotExist is failing, seems like a minor fix.

          It will be great if you can try running it e2e on at least a single node setup.

          Thanks for working on this.

          Show
          subru Subru Krishnan added a comment - Sean Po , I noticed there are couple of minor checkstyle & Javadoc issues. Can you kindly fix those. Also the TestReservationInputValidator::testSubmitReservationDoesnotExist is failing, seems like a minor fix. It will be great if you can try running it e2e on at least a single node setup. Thanks for working on this.
          Hide
          subru Subru Krishnan added a comment -

          Sean Po, I ran a few e2e tests on my single box and found the following small issues:

          • Can we have newInstance methods ReservationListRequest with just the queue and reservationid as that will make it easy for the most common cases
          • We need a null check for reservationid in ReservationListRequest
          • I see the reservation being listed even though I give the start time after the end of the reservation
          • Similarly I see the reservation being listed even though I give the end time before the start of the reservation
          • We need to add a check for endTime > startTime in ReservationInputValidator

          Can you also unit tests to cover these scenarios.

          Thanks!

          Show
          subru Subru Krishnan added a comment - Sean Po , I ran a few e2e tests on my single box and found the following small issues: Can we have newInstance methods ReservationListRequest with just the queue and reservationid as that will make it easy for the most common cases We need a null check for reservationid in ReservationListRequest I see the reservation being listed even though I give the start time after the end of the reservation Similarly I see the reservation being listed even though I give the end time before the start of the reservation We need to add a check for endTime > startTime in ReservationInputValidator Can you also unit tests to cover these scenarios. Thanks!
          Hide
          seanpo03 Sean Po added a comment -

          Thanks Subru for the comments. I took your comments, and added it to this latest patch. After doing that, I noticed that I am not able to replicate the incorrect behavior that you mentioned.

          Show
          seanpo03 Sean Po added a comment - Thanks Subru for the comments. I took your comments, and added it to this latest patch. After doing that, I noticed that I am not able to replicate the incorrect behavior that you mentioned.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          +1 mvninstall 8m 3s trunk passed
          +1 compile 9m 12s trunk passed with JDK v1.8.0_66
          +1 compile 9m 41s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 4s trunk passed
          +1 mvnsite 3m 9s trunk passed
          +1 mvneclipse 1m 24s trunk passed
          +1 findbugs 6m 18s trunk passed
          +1 javadoc 2m 23s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 53s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 52s the patch passed
          +1 compile 9m 10s the patch passed with JDK v1.8.0_66
          +1 cc 9m 10s the patch passed
          +1 javac 9m 10s the patch passed
          +1 compile 9m 32s the patch passed with JDK v1.7.0_91
          +1 cc 9m 32s the patch passed
          -1 javac 29m 22s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 723, now 723).
          +1 javac 9m 32s the patch passed
          -1 checkstyle 1m 2s Patch generated 4 new checkstyle issues in root (total was 353, now 355).
          +1 mvnsite 3m 8s the patch passed
          +1 mvneclipse 1m 24s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 6m 53s the patch passed
          +1 javadoc 2m 21s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 58s the patch passed with JDK v1.7.0_91
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          -1 unit 1m 59s hadoop-yarn-common in the patch failed with JDK v1.8.0_66.
          +1 unit 8m 56s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66.
          -1 unit 64m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 49m 32s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 103m 8s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 33s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 23s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 unit 9m 32s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91.
          -1 unit 66m 43s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 49m 45s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
          -1 unit 108m 26s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 31s Patch generated 15 ASF License warnings.
          556m 9s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.util.TestFSDownload
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler
            hadoop.yarn.client.TestGetGroups
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapred.TestNetworkedJob
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.client.TestGetGroups
            hadoop.mapred.TestNetworkedJob
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777654/YARN-4340.v9.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 6b175ba2e63f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d8a4542
          findbugs v3.0.0
          javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9975/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9975/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. +1 mvninstall 8m 3s trunk passed +1 compile 9m 12s trunk passed with JDK v1.8.0_66 +1 compile 9m 41s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 4s trunk passed +1 mvnsite 3m 9s trunk passed +1 mvneclipse 1m 24s trunk passed +1 findbugs 6m 18s trunk passed +1 javadoc 2m 23s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 53s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 52s the patch passed +1 compile 9m 10s the patch passed with JDK v1.8.0_66 +1 cc 9m 10s the patch passed +1 javac 9m 10s the patch passed +1 compile 9m 32s the patch passed with JDK v1.7.0_91 +1 cc 9m 32s the patch passed -1 javac 29m 22s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 723, now 723). +1 javac 9m 32s the patch passed -1 checkstyle 1m 2s Patch generated 4 new checkstyle issues in root (total was 353, now 355). +1 mvnsite 3m 8s the patch passed +1 mvneclipse 1m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 53s the patch passed +1 javadoc 2m 21s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 58s the patch passed with JDK v1.7.0_91 +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. -1 unit 1m 59s hadoop-yarn-common in the patch failed with JDK v1.8.0_66. +1 unit 8m 56s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 64m 41s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 49m 32s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 103m 8s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 33s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 23s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 9m 32s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91. -1 unit 66m 43s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 49m 45s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. -1 unit 108m 26s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 31s Patch generated 15 ASF License warnings. 556m 9s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.util.TestFSDownload   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups   hadoop.mapred.TestNetworkedJob JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777654/YARN-4340.v9.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 6b175ba2e63f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d8a4542 findbugs v3.0.0 javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9975/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9975/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9975/console This message was automatically generated.
          Hide
          seanpo03 Sean Po added a comment -

          Fixing Checkstyle Issues.

          Show
          seanpo03 Sean Po added a comment - Fixing Checkstyle Issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          +1 mvninstall 7m 30s trunk passed
          +1 compile 7m 56s trunk passed with JDK v1.8.0_66
          +1 compile 8m 49s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 59s trunk passed
          +1 mvnsite 2m 59s trunk passed
          +1 mvneclipse 1m 17s trunk passed
          +1 findbugs 5m 45s trunk passed
          +1 javadoc 2m 7s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 34s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 40s the patch passed
          +1 compile 8m 27s the patch passed with JDK v1.8.0_66
          +1 cc 8m 27s the patch passed
          +1 javac 8m 27s the patch passed
          +1 compile 8m 54s the patch passed with JDK v1.7.0_91
          +1 cc 8m 54s the patch passed
          -1 javac 27m 14s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 723, now 723).
          +1 javac 8m 54s the patch passed
          +1 checkstyle 0m 59s the patch passed
          +1 mvnsite 2m 55s the patch passed
          +1 mvneclipse 1m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 6m 30s the patch passed
          +1 javadoc 2m 9s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 49s the patch passed with JDK v1.7.0_91
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 51s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 8m 28s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66.
          -1 unit 59m 0s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 18s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 16s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          -1 unit 0m 20s hadoop-yarn-common in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 28s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 22s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 14s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 13s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          155m 21s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777841/YARN-4340.v10.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 5123d602cc41 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8602692
          findbugs v3.0.0
          javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9992/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 75MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9992/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. +1 mvninstall 7m 30s trunk passed +1 compile 7m 56s trunk passed with JDK v1.8.0_66 +1 compile 8m 49s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 59s trunk passed +1 mvnsite 2m 59s trunk passed +1 mvneclipse 1m 17s trunk passed +1 findbugs 5m 45s trunk passed +1 javadoc 2m 7s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 34s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 40s the patch passed +1 compile 8m 27s the patch passed with JDK v1.8.0_66 +1 cc 8m 27s the patch passed +1 javac 8m 27s the patch passed +1 compile 8m 54s the patch passed with JDK v1.7.0_91 +1 cc 8m 54s the patch passed -1 javac 27m 14s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 723, now 723). +1 javac 8m 54s the patch passed +1 checkstyle 0m 59s the patch passed +1 mvnsite 2m 55s the patch passed +1 mvneclipse 1m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 30s the patch passed +1 javadoc 2m 9s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 49s the patch passed with JDK v1.7.0_91 +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 51s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 28s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 59m 0s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 0m 18s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 0m 16s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. -1 unit 0m 20s hadoop-yarn-common in the patch failed with JDK v1.7.0_91. -1 unit 0m 28s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91. -1 unit 0m 22s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 0m 14s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. -1 unit 0m 13s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 155m 21s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777841/YARN-4340.v10.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 5123d602cc41 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8602692 findbugs v3.0.0 javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9992/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9992/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 75MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9992/console This message was automatically generated.
          Hide
          seanpo03 Sean Po added a comment -

          Added null check for reservationId in ClientRMService.

          Show
          seanpo03 Sean Po added a comment - Added null check for reservationId in ClientRMService.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          +1 mvninstall 8m 5s trunk passed
          +1 compile 8m 50s trunk passed with JDK v1.8.0_66
          +1 compile 9m 36s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 4s trunk passed
          +1 mvnsite 3m 12s trunk passed
          +1 mvneclipse 1m 24s trunk passed
          +1 findbugs 6m 13s trunk passed
          +1 javadoc 2m 23s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 53s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 52s the patch passed
          +1 compile 8m 52s the patch passed with JDK v1.8.0_66
          +1 cc 8m 52s the patch passed
          +1 javac 8m 52s the patch passed
          +1 compile 9m 22s the patch passed with JDK v1.7.0_91
          +1 cc 9m 22s the patch passed
          -1 javac 28m 54s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 723, now 723).
          +1 javac 9m 22s the patch passed
          +1 checkstyle 1m 1s the patch passed
          +1 mvnsite 3m 5s the patch passed
          +1 mvneclipse 1m 24s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 6m 50s the patch passed
          +1 javadoc 2m 22s the patch passed with JDK v1.8.0_66
          +1 javadoc 5m 4s the patch passed with JDK v1.7.0_91
          +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 6s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 8m 47s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66.
          -1 unit 60m 0s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 49m 25s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 103m 25s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 23s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 unit 9m 32s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91.
          -1 unit 63m 12s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 49m 54s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
          -1 unit 103m 32s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 30s Patch generated 17 ASF License warnings.
          542m 25s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.client.TestGetGroups
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapred.TestNetworkedJob
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.client.TestGetGroups
            hadoop.mapred.TestJobSysDirWithDFS
            hadoop.mapred.TestNetworkedJob
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777899/YARN-4340.v10.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux c7f4b0c7a911 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ae67c84
          findbugs v3.0.0
          javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10001/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 75MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10001/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. +1 mvninstall 8m 5s trunk passed +1 compile 8m 50s trunk passed with JDK v1.8.0_66 +1 compile 9m 36s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 4s trunk passed +1 mvnsite 3m 12s trunk passed +1 mvneclipse 1m 24s trunk passed +1 findbugs 6m 13s trunk passed +1 javadoc 2m 23s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 53s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 52s the patch passed +1 compile 8m 52s the patch passed with JDK v1.8.0_66 +1 cc 8m 52s the patch passed +1 javac 8m 52s the patch passed +1 compile 9m 22s the patch passed with JDK v1.7.0_91 +1 cc 9m 22s the patch passed -1 javac 28m 54s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 723, now 723). +1 javac 9m 22s the patch passed +1 checkstyle 1m 1s the patch passed +1 mvnsite 3m 5s the patch passed +1 mvneclipse 1m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 50s the patch passed +1 javadoc 2m 22s the patch passed with JDK v1.8.0_66 +1 javadoc 5m 4s the patch passed with JDK v1.7.0_91 +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 6s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 47s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 60m 0s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 49m 25s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 103m 25s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 23s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 9m 32s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91. -1 unit 63m 12s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 49m 54s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. -1 unit 103m 32s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 30s Patch generated 17 ASF License warnings. 542m 25s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.client.TestGetGroups   hadoop.mapred.TestJobSysDirWithDFS   hadoop.mapred.TestNetworkedJob JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777899/YARN-4340.v10.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux c7f4b0c7a911 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ae67c84 findbugs v3.0.0 javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10001/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10001/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 75MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10001/console This message was automatically generated.
          Hide
          seanpo03 Sean Po added a comment -

          I made a comment about the test failures before, but to make it easier to find, I'll paste it here again:

          This patch addresses the remaining findbugs, checkstyle errors.
          The following unit tests are failing and have associated Jira tickets:
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          YARN-4306
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          YARN-4318
          hadoop.yarn.client.TestGetGroups
          YARN-4351
          The following unit tests are passing locally and flakiness may be related to YARN-4352:
          org.apache.hadoop.yarn.client.api.impl.TestYarnClient
          – testShouldNotRetryForeverForNonNetworkExceptions actually fails, but it also fails locally on trunk
          – testAMMRToken
          org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          org.apache.hadoop.yarn.client.api.impl.TestNMClient
          The following tests are passing locally:
          hadoop.mapreduce.v2.TestMRJobsWithProfiler

          There are three new test failures above, but when I ran the tests locally, they all passed:
          hadoop.mapred.TestJobSysDirWithDFS
          hadoop.mapred.TestNetworkedJob
          hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler

          If you also look at the Hadoop QA comment from two days ago, where the code only changed with regards to style, there were very few test failures, which indicates that some of the above tests are flaky:

          JDK v1.8.0_66 Failed junit tests
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
          hadoop.yarn.server.resourcemanager.TestClientRMTokens

          Show
          seanpo03 Sean Po added a comment - I made a comment about the test failures before, but to make it easier to find, I'll paste it here again: This patch addresses the remaining findbugs, checkstyle errors. The following unit tests are failing and have associated Jira tickets: hadoop.yarn.server.resourcemanager.TestClientRMTokens – YARN-4306 hadoop.yarn.server.resourcemanager.TestAMAuthorization – YARN-4318 hadoop.yarn.client.TestGetGroups – YARN-4351 The following unit tests are passing locally and flakiness may be related to YARN-4352 : org.apache.hadoop.yarn.client.api.impl.TestYarnClient – testShouldNotRetryForeverForNonNetworkExceptions actually fails, but it also fails locally on trunk – testAMMRToken org.apache.hadoop.yarn.client.api.impl.TestAMRMClient org.apache.hadoop.yarn.client.api.impl.TestNMClient The following tests are passing locally: hadoop.mapreduce.v2.TestMRJobsWithProfiler There are three new test failures above, but when I ran the tests locally, they all passed: hadoop.mapred.TestJobSysDirWithDFS hadoop.mapred.TestNetworkedJob hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler If you also look at the Hadoop QA comment from two days ago, where the code only changed with regards to style, there were very few test failures, which indicates that some of the above tests are flaky: JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler hadoop.yarn.server.resourcemanager.TestClientRMTokens
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks Sean Po,
          Patch looks generally good to me, few minor comments:

          1) Duplicated suppress warnings:

            @SuppressWarnings("unchecked")
            @Override
            @SuppressWarnings("unchecked")
            public SignalContainerResponse signalContainer(
          

          2) Indent issue:

            @Override
              public Set<ReservationAllocation> getReservation
          

          And patch needs rebase to latest trunk.

          I hope to get +1 from someone who is more familiar with reservation system before commit it.

          Show
          leftnoteasy Wangda Tan added a comment - Thanks Sean Po , Patch looks generally good to me, few minor comments: 1) Duplicated suppress warnings: @SuppressWarnings( "unchecked" ) @Override @SuppressWarnings( "unchecked" ) public SignalContainerResponse signalContainer( 2) Indent issue: @Override public Set<ReservationAllocation> getReservation And patch needs rebase to latest trunk. I hope to get +1 from someone who is more familiar with reservation system before commit it.
          Hide
          seanpo03 Sean Po added a comment -

          Wangda, thanks for the code review - I wasn't able to find the duplicate suppress warnings after searching through the diff I posted, and my local branch. I did see the indent issue however, and I have fixed it in YARN-4340.v12.patch.

          Show
          seanpo03 Sean Po added a comment - Wangda, thanks for the code review - I wasn't able to find the duplicate suppress warnings after searching through the diff I posted, and my local branch. I did see the indent issue however, and I have fixed it in YARN-4340 .v12.patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          0 mvndep 1m 11s Maven dependency ordering for branch
          +1 mvninstall 8m 27s trunk passed
          +1 compile 7m 10s trunk passed with JDK v1.8.0_66
          +1 compile 7m 38s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 10s trunk passed
          +1 mvnsite 3m 11s trunk passed
          +1 mvneclipse 1m 24s trunk passed
          +1 findbugs 6m 20s trunk passed
          +1 javadoc 2m 23s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 56s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 54s Maven dependency ordering for patch
          +1 mvninstall 2m 37s the patch passed
          +1 compile 7m 5s the patch passed with JDK v1.8.0_66
          +1 cc 7m 5s the patch passed
          +1 javac 7m 5s the patch passed
          +1 compile 7m 34s the patch passed with JDK v1.7.0_91
          +1 cc 7m 34s the patch passed
          +1 javac 7m 34s the patch passed
          +1 checkstyle 1m 13s root: patch generated 0 new + 346 unchanged - 2 fixed = 346 total (was 348)
          +1 mvnsite 3m 11s the patch passed
          +1 mvneclipse 1m 25s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 7m 32s the patch passed
          +1 javadoc 2m 27s the patch passed with JDK v1.8.0_66
          +1 javadoc 5m 6s the patch passed with JDK v1.7.0_91
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 8m 51s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 63m 47s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 64m 45s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 107m 1s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 24s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 9m 22s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 64m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 65m 0s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
          -1 unit 111m 47s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 36s Patch generated 17 ASF License warnings.
          586m 31s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.client.TestGetGroups
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapred.TestNetworkedJob
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.client.TestGetGroups
            hadoop.mapred.TestNetworkedJob
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784531/YARN-4340.v11.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 87658ce7327c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d323639
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10390/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10390/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. 0 mvndep 1m 11s Maven dependency ordering for branch +1 mvninstall 8m 27s trunk passed +1 compile 7m 10s trunk passed with JDK v1.8.0_66 +1 compile 7m 38s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 10s trunk passed +1 mvnsite 3m 11s trunk passed +1 mvneclipse 1m 24s trunk passed +1 findbugs 6m 20s trunk passed +1 javadoc 2m 23s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 56s trunk passed with JDK v1.7.0_91 0 mvndep 0m 54s Maven dependency ordering for patch +1 mvninstall 2m 37s the patch passed +1 compile 7m 5s the patch passed with JDK v1.8.0_66 +1 cc 7m 5s the patch passed +1 javac 7m 5s the patch passed +1 compile 7m 34s the patch passed with JDK v1.7.0_91 +1 cc 7m 34s the patch passed +1 javac 7m 34s the patch passed +1 checkstyle 1m 13s root: patch generated 0 new + 346 unchanged - 2 fixed = 346 total (was 348) +1 mvnsite 3m 11s the patch passed +1 mvneclipse 1m 25s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 7m 32s the patch passed +1 javadoc 2m 27s the patch passed with JDK v1.8.0_66 +1 javadoc 5m 6s the patch passed with JDK v1.7.0_91 +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 51s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. -1 unit 63m 47s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 64m 45s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 107m 1s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 24s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 9m 22s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91. -1 unit 64m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 65m 0s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. -1 unit 111m 47s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 36s Patch generated 17 ASF License warnings. 586m 31s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.metrics.TestSystemMetricsPublisher   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.client.TestGetGroups   hadoop.mapred.TestNetworkedJob JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784531/YARN-4340.v11.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 87658ce7327c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d323639 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10390/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10390/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10390/console This message was automatically generated.
          Hide
          seanpo03 Sean Po added a comment -

          The test failures above have all been addressed in a previous comment, except for TestYarnCLI. This test passes on my local machine.

          Show
          seanpo03 Sean Po added a comment - The test failures above have all been addressed in a previous comment, except for TestYarnCLI. This test passes on my local machine.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Manually kicked Jenkins.

          Show
          leftnoteasy Wangda Tan added a comment - Manually kicked Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          0 mvndep 1m 23s Maven dependency ordering for branch
          +1 mvninstall 6m 53s trunk passed
          +1 compile 6m 16s trunk passed with JDK v1.8.0_66
          +1 compile 6m 47s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 7s trunk passed
          +1 mvnsite 2m 59s trunk passed
          +1 mvneclipse 1m 20s trunk passed
          +1 findbugs 5m 45s trunk passed
          +1 javadoc 2m 10s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 41s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 53s Maven dependency ordering for patch
          +1 mvninstall 2m 23s the patch passed
          +1 compile 5m 50s the patch passed with JDK v1.8.0_66
          +1 cc 5m 50s the patch passed
          +1 javac 5m 50s the patch passed
          +1 compile 6m 51s the patch passed with JDK v1.7.0_91
          +1 cc 6m 51s the patch passed
          +1 javac 6m 51s the patch passed
          +1 checkstyle 1m 8s root: patch generated 0 new + 347 unchanged - 2 fixed = 347 total (was 349)
          +1 mvnsite 2m 57s the patch passed
          +1 mvneclipse 1m 21s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 7m 3s the patch passed
          +1 javadoc 2m 11s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 58s the patch passed with JDK v1.7.0_91
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 56s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 8m 30s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 61m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 64m 31s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 97m 3s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 30s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 9m 5s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 62m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 64m 49s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
          -1 unit 104m 52s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 39s Patch generated 19 ASF License warnings.
          556m 12s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.client.TestGetGroups
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapred.TestNetworkedJob
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.client.TestGetGroups
            hadoop.mapred.TestNetworkedJob
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784531/YARN-4340.v11.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux fac81bcd0c15 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 662e17b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10418/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10418/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. 0 mvndep 1m 23s Maven dependency ordering for branch +1 mvninstall 6m 53s trunk passed +1 compile 6m 16s trunk passed with JDK v1.8.0_66 +1 compile 6m 47s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 7s trunk passed +1 mvnsite 2m 59s trunk passed +1 mvneclipse 1m 20s trunk passed +1 findbugs 5m 45s trunk passed +1 javadoc 2m 10s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 41s trunk passed with JDK v1.7.0_91 0 mvndep 0m 53s Maven dependency ordering for patch +1 mvninstall 2m 23s the patch passed +1 compile 5m 50s the patch passed with JDK v1.8.0_66 +1 cc 5m 50s the patch passed +1 javac 5m 50s the patch passed +1 compile 6m 51s the patch passed with JDK v1.7.0_91 +1 cc 6m 51s the patch passed +1 javac 6m 51s the patch passed +1 checkstyle 1m 8s root: patch generated 0 new + 347 unchanged - 2 fixed = 347 total (was 349) +1 mvnsite 2m 57s the patch passed +1 mvneclipse 1m 21s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 7m 3s the patch passed +1 javadoc 2m 11s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 58s the patch passed with JDK v1.7.0_91 +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 56s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 30s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. -1 unit 61m 35s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 64m 31s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 97m 3s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 30s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 9m 5s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91. -1 unit 62m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 64m 49s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. -1 unit 104m 52s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 39s Patch generated 19 ASF License warnings. 556m 12s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.client.TestGetGroups   hadoop.mapred.TestNetworkedJob JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784531/YARN-4340.v11.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux fac81bcd0c15 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 662e17b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10418/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10418/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10418/console This message was automatically generated.
          Hide
          seanpo03 Sean Po added a comment -

          I double checked the ASFLicense failures by running test-patch on my local machine and there were no failures found. I also ran this patch end to end with a single node cluster on my local machine, with no failures. With this patch applied, a reservation was made, and an application was submitted against the reservation, and again - there were no failures.

          Show
          seanpo03 Sean Po added a comment - I double checked the ASFLicense failures by running test-patch on my local machine and there were no failures found. I also ran this patch end to end with a single node cluster on my local machine, with no failures. With this patch applied, a reservation was made, and an application was submitted against the reservation, and again - there were no failures.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          0 mvndep 1m 6s Maven dependency ordering for branch
          +1 mvninstall 6m 57s trunk passed
          +1 compile 6m 15s trunk passed with JDK v1.8.0_66
          +1 compile 7m 10s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 10s trunk passed
          +1 mvnsite 3m 25s trunk passed
          +1 mvneclipse 1m 39s trunk passed
          +1 findbugs 6m 30s trunk passed
          +1 javadoc 2m 24s trunk passed with JDK v1.8.0_66
          +1 javadoc 5m 0s trunk passed with JDK v1.7.0_91
          0 mvndep 1m 5s Maven dependency ordering for patch
          +1 mvninstall 2m 45s the patch passed
          +1 compile 6m 5s the patch passed with JDK v1.8.0_66
          +1 cc 6m 5s the patch passed
          +1 javac 6m 5s the patch passed
          +1 compile 6m 59s the patch passed with JDK v1.7.0_91
          +1 cc 6m 59s the patch passed
          +1 javac 6m 59s the patch passed
          -1 checkstyle 1m 7s root: patch generated 2 new + 347 unchanged - 2 fixed = 349 total (was 349)
          +1 mvnsite 3m 23s the patch passed
          +1 mvneclipse 1m 36s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 7m 47s the patch passed
          +1 javadoc 2m 25s the patch passed with JDK v1.8.0_66
          +1 javadoc 5m 8s the patch passed with JDK v1.7.0_91
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 57s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 8m 42s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 66m 4s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 64m 28s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 99m 6s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 58s hadoop-sls in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 30s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 9m 12s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 66m 57s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 64m 48s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
          -1 unit 32m 59s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 55s hadoop-sls in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 23s Patch generated 1 ASF License warnings.
          501m 59s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA
            hadoop.yarn.client.TestGetGroups
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapred.TestNetworkedJob
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestClusterMRNotification
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.sls.appmaster.TestAMSimulator



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785141/YARN-4340.v12.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 8b4dd92b5abf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a277bdc
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10433/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-sls U: .
          Max memory used 29MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10433/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. 0 mvndep 1m 6s Maven dependency ordering for branch +1 mvninstall 6m 57s trunk passed +1 compile 6m 15s trunk passed with JDK v1.8.0_66 +1 compile 7m 10s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 10s trunk passed +1 mvnsite 3m 25s trunk passed +1 mvneclipse 1m 39s trunk passed +1 findbugs 6m 30s trunk passed +1 javadoc 2m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 0s trunk passed with JDK v1.7.0_91 0 mvndep 1m 5s Maven dependency ordering for patch +1 mvninstall 2m 45s the patch passed +1 compile 6m 5s the patch passed with JDK v1.8.0_66 +1 cc 6m 5s the patch passed +1 javac 6m 5s the patch passed +1 compile 6m 59s the patch passed with JDK v1.7.0_91 +1 cc 6m 59s the patch passed +1 javac 6m 59s the patch passed -1 checkstyle 1m 7s root: patch generated 2 new + 347 unchanged - 2 fixed = 349 total (was 349) +1 mvnsite 3m 23s the patch passed +1 mvneclipse 1m 36s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 7m 47s the patch passed +1 javadoc 2m 25s the patch passed with JDK v1.8.0_66 +1 javadoc 5m 8s the patch passed with JDK v1.7.0_91 +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 57s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 42s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. -1 unit 66m 4s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 64m 28s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 99m 6s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 58s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 30s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 14s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 9m 12s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91. -1 unit 66m 57s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 64m 48s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. -1 unit 32m 59s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 unit 0m 55s hadoop-sls in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 23s Patch generated 1 ASF License warnings. 501m 59s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestClusterMRNotification JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.sls.appmaster.TestAMSimulator Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785141/YARN-4340.v12.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 8b4dd92b5abf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a277bdc Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10433/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10433/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-sls U: . Max memory used 29MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10433/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          0 mvndep 0m 59s Maven dependency ordering for branch
          +1 mvninstall 6m 53s trunk passed
          +1 compile 7m 48s trunk passed with JDK v1.8.0_66
          +1 compile 7m 58s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 17s trunk passed
          +1 mvnsite 3m 3s trunk passed
          +1 mvneclipse 1m 21s trunk passed
          +1 findbugs 5m 44s trunk passed
          +1 javadoc 2m 21s trunk passed with JDK v1.8.0_66
          +1 javadoc 4m 27s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 53s Maven dependency ordering for patch
          +1 mvninstall 2m 22s the patch passed
          +1 compile 6m 28s the patch passed with JDK v1.8.0_66
          +1 cc 6m 28s the patch passed
          +1 javac 6m 28s the patch passed
          +1 compile 7m 16s the patch passed with JDK v1.7.0_91
          +1 cc 7m 16s the patch passed
          +1 javac 7m 16s the patch passed
          +1 checkstyle 1m 8s root: patch generated 0 new + 347 unchanged - 2 fixed = 347 total (was 349)
          +1 mvnsite 3m 2s the patch passed
          +1 mvneclipse 1m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 7m 2s the patch passed
          +1 javadoc 2m 13s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 50s the patch passed with JDK v1.7.0_91
          +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 8m 38s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 66m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 64m 33s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 97m 43s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 33s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 9m 15s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 67m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 64m 51s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
          -1 unit 43m 20s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          507m 58s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.client.TestGetGroups
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
            hadoop.mapred.TestNetworkedJob
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestMRIntermediateDataEncryption



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785226/YARN-4340.v12.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 476f8e0de276 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c9a09d6
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10438/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
          Max memory used 30MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10438/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. 0 mvndep 0m 59s Maven dependency ordering for branch +1 mvninstall 6m 53s trunk passed +1 compile 7m 48s trunk passed with JDK v1.8.0_66 +1 compile 7m 58s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 17s trunk passed +1 mvnsite 3m 3s trunk passed +1 mvneclipse 1m 21s trunk passed +1 findbugs 5m 44s trunk passed +1 javadoc 2m 21s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 27s trunk passed with JDK v1.7.0_91 0 mvndep 0m 53s Maven dependency ordering for patch +1 mvninstall 2m 22s the patch passed +1 compile 6m 28s the patch passed with JDK v1.8.0_66 +1 cc 6m 28s the patch passed +1 javac 6m 28s the patch passed +1 compile 7m 16s the patch passed with JDK v1.7.0_91 +1 cc 7m 16s the patch passed +1 javac 7m 16s the patch passed +1 checkstyle 1m 8s root: patch generated 0 new + 347 unchanged - 2 fixed = 347 total (was 349) +1 mvnsite 3m 2s the patch passed +1 mvneclipse 1m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 7m 2s the patch passed +1 javadoc 2m 13s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 50s the patch passed with JDK v1.7.0_91 +1 unit 0m 22s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 54s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 38s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. -1 unit 66m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 64m 33s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 97m 43s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 33s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 9m 15s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91. -1 unit 67m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 64m 51s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. -1 unit 43m 20s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 507m 58s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.mapred.TestMRIntermediateDataEncryption Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785226/YARN-4340.v12.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 476f8e0de276 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c9a09d6 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10438/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10438/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . Max memory used 30MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10438/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          0 mvndep 1m 33s Maven dependency ordering for branch
          +1 mvninstall 11m 6s trunk passed
          +1 compile 14m 36s trunk passed with JDK v1.8.0_66
          +1 compile 11m 33s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 51s trunk passed
          +1 mvnsite 4m 34s trunk passed
          +1 mvneclipse 1m 55s trunk passed
          +1 findbugs 8m 48s trunk passed
          +1 javadoc 4m 24s trunk passed with JDK v1.8.0_66
          +1 javadoc 6m 32s trunk passed with JDK v1.7.0_91
          0 mvndep 1m 15s Maven dependency ordering for patch
          +1 mvninstall 3m 45s the patch passed
          +1 compile 14m 20s the patch passed with JDK v1.8.0_66
          +1 cc 14m 20s the patch passed
          +1 javac 14m 20s the patch passed
          +1 compile 11m 27s the patch passed with JDK v1.7.0_91
          +1 cc 11m 27s the patch passed
          +1 javac 11m 27s the patch passed
          +1 checkstyle 1m 39s root: patch generated 0 new + 347 unchanged - 2 fixed = 347 total (was 349)
          +1 mvnsite 4m 28s the patch passed
          +1 mvneclipse 1m 56s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 10m 28s the patch passed
          +1 javadoc 4m 24s the patch passed with JDK v1.8.0_66
          +1 javadoc 6m 51s the patch passed with JDK v1.7.0_91
          +1 unit 0m 49s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 3m 14s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 11m 28s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 73m 47s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 65m 57s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 130m 55s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 48s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          +1 unit 3m 7s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 10m 56s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 74m 4s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 65m 46s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
          -1 unit 130m 36s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 44s Patch generated 15 ASF License warnings.
          703m 4s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore
            hadoop.yarn.client.TestGetGroups
            hadoop.mapred.TestMRTimelineEventHandling
            hadoop.mapred.TestNetworkedJob
            hadoop.mapreduce.v2.TestMRJobsWithProfiler
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation
            hadoop.yarn.server.resourcemanager.scheduler.fair.TestSchedulingPolicy
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing
            hadoop.yarn.client.TestGetGroups
            hadoop.mapred.TestNetworkedJob
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785226/YARN-4340.v12.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux 4eca202a5bf1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 772ea7b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10446/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10446/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. 0 mvndep 1m 33s Maven dependency ordering for branch +1 mvninstall 11m 6s trunk passed +1 compile 14m 36s trunk passed with JDK v1.8.0_66 +1 compile 11m 33s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 51s trunk passed +1 mvnsite 4m 34s trunk passed +1 mvneclipse 1m 55s trunk passed +1 findbugs 8m 48s trunk passed +1 javadoc 4m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 6m 32s trunk passed with JDK v1.7.0_91 0 mvndep 1m 15s Maven dependency ordering for patch +1 mvninstall 3m 45s the patch passed +1 compile 14m 20s the patch passed with JDK v1.8.0_66 +1 cc 14m 20s the patch passed +1 javac 14m 20s the patch passed +1 compile 11m 27s the patch passed with JDK v1.7.0_91 +1 cc 11m 27s the patch passed +1 javac 11m 27s the patch passed +1 checkstyle 1m 39s root: patch generated 0 new + 347 unchanged - 2 fixed = 347 total (was 349) +1 mvnsite 4m 28s the patch passed +1 mvneclipse 1m 56s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 10m 28s the patch passed +1 javadoc 4m 24s the patch passed with JDK v1.8.0_66 +1 javadoc 6m 51s the patch passed with JDK v1.7.0_91 +1 unit 0m 49s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 3m 14s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 11m 28s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. -1 unit 73m 47s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 65m 57s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 130m 55s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 48s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 3m 7s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 10m 56s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91. -1 unit 74m 4s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 65m 46s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. -1 unit 130m 36s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 44s Patch generated 15 ASF License warnings. 703m 4s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore   hadoop.yarn.client.TestGetGroups   hadoop.mapred.TestMRTimelineEventHandling   hadoop.mapred.TestNetworkedJob   hadoop.mapreduce.v2.TestMRJobsWithProfiler JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation   hadoop.yarn.server.resourcemanager.scheduler.fair.TestSchedulingPolicy   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing   hadoop.yarn.client.TestGetGroups   hadoop.mapred.TestNetworkedJob JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785226/YARN-4340.v12.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 4eca202a5bf1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 772ea7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10446/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10446/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10446/console This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          +1, will commit once Sean Po/Subru Krishnan confirm there's no issue with the Jenkins run.

          Show
          leftnoteasy Wangda Tan added a comment - +1, will commit once Sean Po / Subru Krishnan confirm there's no issue with the Jenkins run.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 10 new or modified test files.
          0 mvndep 1m 7s Maven dependency ordering for branch
          +1 mvninstall 10m 33s trunk passed
          +1 compile 13m 23s trunk passed with JDK v1.8.0_66
          +1 compile 11m 11s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 26s trunk passed
          +1 mvnsite 4m 11s trunk passed
          +1 mvneclipse 1m 44s trunk passed
          +1 findbugs 8m 19s trunk passed
          +1 javadoc 4m 3s trunk passed with JDK v1.8.0_66
          +1 javadoc 5m 47s trunk passed with JDK v1.7.0_91
          0 mvndep 1m 7s Maven dependency ordering for patch
          +1 mvninstall 3m 31s the patch passed
          +1 compile 13m 36s the patch passed with JDK v1.8.0_66
          +1 cc 13m 36s the patch passed
          +1 javac 13m 36s the patch passed
          +1 compile 10m 54s the patch passed with JDK v1.7.0_91
          +1 cc 10m 54s the patch passed
          +1 javac 10m 54s the patch passed
          +1 checkstyle 1m 36s root: patch generated 0 new + 346 unchanged - 2 fixed = 346 total (was 348)
          +1 mvnsite 4m 16s the patch passed
          +1 mvneclipse 1m 44s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 10m 18s the patch passed
          +1 javadoc 3m 54s the patch passed with JDK v1.8.0_66
          +1 javadoc 6m 8s the patch passed with JDK v1.7.0_91
          +1 unit 0m 46s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          +1 unit 3m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 11m 3s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 76m 30s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 28s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 24s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 36s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          -1 unit 0m 31s hadoop-yarn-common in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 36s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 30s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 19s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 19s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 34s Patch does not generate ASF License warnings.
          217m 29s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785226/YARN-4340.v12.patch
          JIRA Issue YARN-4340
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux c38d3519647b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e30ce01
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10462/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10462/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 10 new or modified test files. 0 mvndep 1m 7s Maven dependency ordering for branch +1 mvninstall 10m 33s trunk passed +1 compile 13m 23s trunk passed with JDK v1.8.0_66 +1 compile 11m 11s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 26s trunk passed +1 mvnsite 4m 11s trunk passed +1 mvneclipse 1m 44s trunk passed +1 findbugs 8m 19s trunk passed +1 javadoc 4m 3s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 47s trunk passed with JDK v1.7.0_91 0 mvndep 1m 7s Maven dependency ordering for patch +1 mvninstall 3m 31s the patch passed +1 compile 13m 36s the patch passed with JDK v1.8.0_66 +1 cc 13m 36s the patch passed +1 javac 13m 36s the patch passed +1 compile 10m 54s the patch passed with JDK v1.7.0_91 +1 cc 10m 54s the patch passed +1 javac 10m 54s the patch passed +1 checkstyle 1m 36s root: patch generated 0 new + 346 unchanged - 2 fixed = 346 total (was 348) +1 mvnsite 4m 16s the patch passed +1 mvneclipse 1m 44s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 10m 18s the patch passed +1 javadoc 3m 54s the patch passed with JDK v1.8.0_66 +1 javadoc 6m 8s the patch passed with JDK v1.7.0_91 +1 unit 0m 46s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 3m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 11m 3s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_66. -1 unit 76m 30s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 0m 28s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. -1 unit 0m 24s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_66. +1 unit 0m 36s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. -1 unit 0m 31s hadoop-yarn-common in the patch failed with JDK v1.7.0_91. -1 unit 0m 36s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91. -1 unit 0m 30s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 0m 19s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. -1 unit 0m 19s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 34s Patch does not generate ASF License warnings. 217m 29s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785226/YARN-4340.v12.patch JIRA Issue YARN-4340 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux c38d3519647b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e30ce01 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10462/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10462/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10462/console This message was automatically generated.
          Hide
          subru Subru Krishnan added a comment -

          The test failures seem unrelated and are tracked by YARN-4478 and HADOOP-12687. Sean Po also double checked them locally. So I am +1 on the latest patch.

          Show
          subru Subru Krishnan added a comment - The test failures seem unrelated and are tracked by YARN-4478 and HADOOP-12687 . Sean Po also double checked them locally. So I am +1 on the latest patch.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9220 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9220/)
          YARN-4340. Add list API to reservation system. (Sean Po via wangda) (wangda: rev 9875325d5c63f343809907d06bf48a298035a611)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStoreStoreReservationEvent.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystemUtil.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/ReservationListResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/ReservationListResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ReservationAllocationStatePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/PlanView.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/MockResourceManagerFacade.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/ReservationListRequestPBImpl.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestInMemoryPlan.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationInputValidator.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceAllocationRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceAllocationRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationSystemUtil.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/AbstractReservationSystem.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/ReservationListRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/NullRMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/InMemoryPlan.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/FileSystemRMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/MemoryRMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStoreTestBase.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestReservationSystemWithRMHA.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/proto/yarn_server_resourcemanager_recovery.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ReservationAllocationState.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/LeveldbRMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationInputValidator.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9220 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9220/ ) YARN-4340 . Add list API to reservation system. (Sean Po via wangda) (wangda: rev 9875325d5c63f343809907d06bf48a298035a611) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStoreStoreReservationEvent.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationSystemUtil.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/ReservationListResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/ReservationListResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ReservationAllocationStatePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/PlanView.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/MockResourceManagerFacade.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/ReservationListRequestPBImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/ZKRMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestInMemoryPlan.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationInputValidator.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceAllocationRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceAllocationRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestReservationSystemUtil.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/AbstractReservationSystem.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/ReservationListRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/NullRMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/InMemoryPlan.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/FileSystemRMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/MemoryRMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStoreTestBase.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestReservationSystemWithRMHA.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/proto/yarn_server_resourcemanager_recovery.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ReservationAllocationState.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/LeveldbRMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/ReservationInputValidator.java
          Hide
          leftnoteasy Wangda Tan added a comment -

          Committed to trunk/branch-2/2.8, thanks Sean Po and thanks reviews from Subru Krishnan!

          Show
          leftnoteasy Wangda Tan added a comment - Committed to trunk/branch-2/2.8, thanks Sean Po and thanks reviews from Subru Krishnan !
          Hide
          subru Subru Krishnan added a comment -

          Thanks Sean Po for your contribution and Tan, Wangda for reviewing/committing!

          Show
          subru Subru Krishnan added a comment - Thanks Sean Po for your contribution and Tan, Wangda for reviewing/committing!
          Hide
          seanpo03 Sean Po added a comment -

          Thank you Tan, Wangda, and Subru Krishnan both for reviewing and committing!

          Show
          seanpo03 Sean Po added a comment - Thank you Tan, Wangda , and Subru Krishnan both for reviewing and committing!

            People

            • Assignee:
              seanpo03 Sean Po
              Reporter:
              curino Carlo Curino
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development