Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4307

Display blacklisted nodes for AM container in the RM web UI

    Details

      Description

      In pseudo cluster had 2 NM's and had launched app with incorrect configuration ./hadoop org.apache.hadoop.mapreduce.SleepJob -Dmapreduce.job.node-label-expression=labelX -Dyarn.app.mapreduce.am.env=JAVA_HOME=/no/jvm/here -m 5 -mt 1200.
      First attempt failed and 2nd attempt was launched, but the application was hung. In the scheduler logs found that localhost was blacklisted but in the UI (app& apps listing page) count was shown as zero and as well no hosts listed in the app page.

      1. yarn-capacity-scheduler-debug.log
        729 kB
        Naganarasimha G R
      2. YARN-4307-branch-2.8.txt
        20 kB
        Vinod Kumar Vavilapalli
      3. YARN-4307.v1.005.patch
        19 kB
        Naganarasimha G R
      4. YARN-4307.v1.004.patch
        19 kB
        Naganarasimha G R
      5. YARN-4307.v1.003.patch
        18 kB
        Naganarasimha G R
      6. YARN-4307.v1.002.patch
        17 kB
        Naganarasimha G R
      7. YARN-4307.v1.001.patch
        11 kB
        Naganarasimha G R
      8. webpage.png
        278 kB
        Naganarasimha G R
      9. RMappAttempt.png
        233 kB
        Naganarasimha G R
      10. AppInfoPage.png
        216 kB
        Naganarasimha G R

        Issue Links

          Activity

          Hide
          Naganarasimha Naganarasimha G R added a comment -

          From the preliminary check, i presume its because SchedulerApplicationAttempt.getBlacklistedNodes() => appSchedulingInfo.getBlackListCopy() => return new HashSet<>(this.userBlacklist) but not amBlacklist.
          Not sure whether when appSchedulingInfo.amBlacklist gets updated we need to update userBlacklist also. thoughts ?
          cc/ Varun Vasudev,

          Show
          Naganarasimha Naganarasimha G R added a comment - From the preliminary check, i presume its because SchedulerApplicationAttempt.getBlacklistedNodes() => appSchedulingInfo.getBlackListCopy() => return new HashSet<>(this.userBlacklist) but not amBlacklist . Not sure whether when appSchedulingInfo.amBlacklist gets updated we need to update userBlacklist also. thoughts ? cc/ Varun Vasudev ,
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Additionally i feel Dump scheduler logs in the scheduler page should show more informative alert like where the logs will be found and also for the first time users it would be clear to inform like logs will be completely available after what period of time. thoughts ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Additionally i feel Dump scheduler logs in the scheduler page should show more informative alert like where the logs will be found and also for the first time users it would be clear to inform like logs will be completely available after what period of time. thoughts ?
          Hide
          vvasudev Varun Vasudev added a comment -

          So the blacklisted nodes in the UI refers to nodes blacklisted by the AM. My understanding is you also want to display nodes blacklisted by the RM for the AM. Correct? If so, we should display them as two separate columns. We should rename the existing column to "App blacklisted nodes" or something that indicates that it shows the nodes blacklisted by the app and add a new column to display the information you want.

          Show
          vvasudev Varun Vasudev added a comment - So the blacklisted nodes in the UI refers to nodes blacklisted by the AM. My understanding is you also want to display nodes blacklisted by the RM for the AM. Correct? If so, we should display them as two separate columns. We should rename the existing column to "App blacklisted nodes" or something that indicates that it shows the nodes blacklisted by the app and add a new column to display the information you want.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the comments [~varun vasudev],
          Yes my intention is to show the black listed nodes irrespective of who has identified it. Also variable names its misleading : amBlacklist is actually the nodes blacklisted by RM for AM and userBlacklist is the nodes black listed by AM(user).
          Currently apps list , app and appattempt pages we are showing count of black listed nodes, in my opinion we need to sum up from both the list and show right ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the comments [~varun vasudev] , Yes my intention is to show the black listed nodes irrespective of who has identified it. Also variable names its misleading : amBlacklist is actually the nodes blacklisted by RM for AM and userBlacklist is the nodes black listed by AM(user). Currently apps list , app and appattempt pages we are showing count of black listed nodes, in my opinion we need to sum up from both the list and show right ?
          Hide
          vvasudev Varun Vasudev added a comment - - edited

          No - they should be separate. One refers to nodes blacklisted by the app and the other to nodes blacklisted by the AM. Show both the numbers but as separate columns.

          Show
          vvasudev Varun Vasudev added a comment - - edited No - they should be separate. One refers to nodes blacklisted by the app and the other to nodes blacklisted by the AM. Show both the numbers but as separate columns.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Varun Vasudev,
          Please find the attached patch i have created as per your suggestion. I have updated AppInfo & AppAttempt page, but have touched app listing page.
          please review

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Varun Vasudev , Please find the attached patch i have created as per your suggestion. I have updated AppInfo & AppAttempt page, but have touched app listing page. please review
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 6s trunk passed
          +1 compile 0m 30s trunk passed with JDK v1.8.0_66
          +1 compile 0m 32s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 40s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 19s trunk passed
          +1 javadoc 0m 24s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 28s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 35s the patch passed
          +1 compile 0m 30s the patch passed with JDK v1.8.0_66
          +1 javac 0m 30s the patch passed
          +1 compile 0m 33s the patch passed with JDK v1.7.0_91
          +1 javac 0m 33s the patch passed
          -1 checkstyle 0m 14s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager (total was 28, now 29).
          +1 mvnsite 0m 38s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 24s the patch passed
          +1 javadoc 0m 24s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 29s the patch passed with JDK v1.7.0_91
          -1 unit 64m 26s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 65m 43s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          149m 11s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.security.TestRMDelegationTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777343/YARN-4307.v1.001.patch
          JIRA Issue YARN-4307
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b78d3ac23a38 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7fb212e
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9961/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/9961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9961/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Max memory used 76MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9961/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 6s trunk passed +1 compile 0m 30s trunk passed with JDK v1.8.0_66 +1 compile 0m 32s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 40s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 19s trunk passed +1 javadoc 0m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 28s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 35s the patch passed +1 compile 0m 30s the patch passed with JDK v1.8.0_66 +1 javac 0m 30s the patch passed +1 compile 0m 33s the patch passed with JDK v1.7.0_91 +1 javac 0m 33s the patch passed -1 checkstyle 0m 14s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager (total was 28, now 29). +1 mvnsite 0m 38s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 24s the patch passed +1 javadoc 0m 24s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 29s the patch passed with JDK v1.7.0_91 -1 unit 64m 26s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 65m 43s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 149m 11s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.security.TestRMDelegationTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777343/YARN-4307.v1.001.patch JIRA Issue YARN-4307 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b78d3ac23a38 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7fb212e findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9961/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9961/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9961/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 76MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9961/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Test cases are passing locally check style can take care in the next patch.

          Show
          Naganarasimha Naganarasimha G R added a comment - Test cases are passing locally check style can take care in the next patch.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Varun Vasudev, how abt the patch ?if you have cycles can you take a look?

          Show
          Naganarasimha Naganarasimha G R added a comment - Varun Vasudev , how abt the patch ?if you have cycles can you take a look?
          Hide
          vvasudev Varun Vasudev added a comment -

          Thanks for the patch NGarla_Unused. Some comments -
          1)

          -import org.apache.commons.logging.Log;
          -import org.apache.commons.logging.LogFactory;
          -
           import java.util.ArrayList;
           import java.util.HashSet;
           import java.util.List;
           import java.util.Set;
           
          +import org.apache.commons.logging.Log;
          +import org.apache.commons.logging.LogFactory;
          +
          

          and

          +import java.util.Collection;
          +import java.util.List;
          +import java.util.Set;
          +
           import org.apache.commons.lang.StringUtils;
           import org.apache.hadoop.conf.Configuration;
           import org.apache.hadoop.yarn.api.records.ApplicationAttemptId;
          @@ -48,11 +52,8 @@
           import org.apache.hadoop.yarn.webapp.hamlet.Hamlet.TABLE;
           import org.apache.hadoop.yarn.webapp.util.WebAppUtils;
           import org.apache.hadoop.yarn.webapp.view.InfoBlock;
          -import com.google.inject.Inject;
          -import java.util.List;
           
          -import java.util.Collection;
          -import java.util.Set;
          +import com.google.inject.Inject;
          

          Can you undo these un-neccessary changes?

          2)

          +    RMAppAttempt rmAppAttempt = getRMAppAttempt();
          +    String appBlacklistedNodes =
          +        getNodeString(getBlacklistedNodes(rm, rmAppAttempt.getAppAttemptId()));
          +    String rmBlackListedNodes = getNodeString(
          +        rmAppAttempt.getAMBlacklist().getBlacklistUpdates().getAdditions());
           

          Can we add the AM blacklisted nodes and the nodes blacklisted by the RM in to the app attempt info and expose both of these via webservices? Both fields should be a part of the rmAppAttempt.

          3)

          -            .th(".blacklistednodes", "Blacklisted Nodes")._()._().tbody();
          +            .th(".appBlacklistednodes", "App Blacklisted Nodes")
          +            .th(".rmBlacklistednodes", "RM Blacklisted Nodes")._()._().tbody();
          

          Can we add a tool tip to explain the difference between the two fields?

          Show
          vvasudev Varun Vasudev added a comment - Thanks for the patch NGarla_Unused . Some comments - 1) - import org.apache.commons.logging.Log; - import org.apache.commons.logging.LogFactory; - import java.util.ArrayList; import java.util.HashSet; import java.util.List; import java.util.Set; + import org.apache.commons.logging.Log; + import org.apache.commons.logging.LogFactory; + and + import java.util.Collection; + import java.util.List; + import java.util.Set; + import org.apache.commons.lang.StringUtils; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.yarn.api.records.ApplicationAttemptId; @@ -48,11 +52,8 @@ import org.apache.hadoop.yarn.webapp.hamlet.Hamlet.TABLE; import org.apache.hadoop.yarn.webapp.util.WebAppUtils; import org.apache.hadoop.yarn.webapp.view.InfoBlock; - import com.google.inject.Inject; - import java.util.List; - import java.util.Collection; - import java.util.Set; + import com.google.inject.Inject; Can you undo these un-neccessary changes? 2) + RMAppAttempt rmAppAttempt = getRMAppAttempt(); + String appBlacklistedNodes = + getNodeString(getBlacklistedNodes(rm, rmAppAttempt.getAppAttemptId())); + String rmBlackListedNodes = getNodeString( + rmAppAttempt.getAMBlacklist().getBlacklistUpdates().getAdditions()); Can we add the AM blacklisted nodes and the nodes blacklisted by the RM in to the app attempt info and expose both of these via webservices? Both fields should be a part of the rmAppAttempt. 3) - .th( ".blacklistednodes" , "Blacklisted Nodes" )._()._().tbody(); + .th( ".appBlacklistednodes" , "App Blacklisted Nodes" ) + .th( ".rmBlacklistednodes" , "RM Blacklisted Nodes" )._()._().tbody(); Can we add a tool tip to explain the difference between the two fields?
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Varun Vasudev,
          I have uploaded a new patch with modifications for your comments

          Can we add the AM blacklisted nodes and the nodes blacklisted by the RM in to the app attempt info and expose both of these via webservices? Both fields should be a part of the rmAppAttempt.

          earlier patch was also exposing these info in app attempt info. In the latest patch have taken case for RMAppAttempt

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Varun Vasudev , I have uploaded a new patch with modifications for your comments Can we add the AM blacklisted nodes and the nodes blacklisted by the RM in to the app attempt info and expose both of these via webservices? Both fields should be a part of the rmAppAttempt. earlier patch was also exposing these info in app attempt info. In the latest patch have taken case for RMAppAttempt
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 23s trunk passed
          +1 compile 1m 46s trunk passed with JDK v1.8.0_66
          +1 compile 2m 5s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 33s trunk passed
          +1 mvnsite 1m 7s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 2m 26s trunk passed
          +1 javadoc 0m 50s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 59s trunk passed with JDK v1.7.0_91
          -1 mvninstall 0m 18s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 compile 1m 11s hadoop-yarn in the patch failed with JDK v1.8.0_66.
          -1 javac 1m 11s hadoop-yarn in the patch failed with JDK v1.8.0_66.
          -1 compile 1m 24s hadoop-yarn in the patch failed with JDK v1.7.0_91.
          -1 javac 1m 24s hadoop-yarn in the patch failed with JDK v1.7.0_91.
          -1 checkstyle 0m 32s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 437, now 440).
          -1 mvnsite 0m 21s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 0m 19s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 javadoc 0m 43s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 56s the patch passed with JDK v1.7.0_91
          +1 unit 1m 52s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 0m 15s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 0m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          32m 9s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781904/YARN-4307.v1.002.patch
          JIRA Issue YARN-4307
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0eb6cd67479c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 126705f
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10250/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10250/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 23s trunk passed +1 compile 1m 46s trunk passed with JDK v1.8.0_66 +1 compile 2m 5s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 2m 26s trunk passed +1 javadoc 0m 50s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 59s trunk passed with JDK v1.7.0_91 -1 mvninstall 0m 18s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 1m 11s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 javac 1m 11s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 compile 1m 24s hadoop-yarn in the patch failed with JDK v1.7.0_91. -1 javac 1m 24s hadoop-yarn in the patch failed with JDK v1.7.0_91. -1 checkstyle 0m 32s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 437, now 440). -1 mvnsite 0m 21s hadoop-yarn-server-resourcemanager in the patch failed. +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 19s hadoop-yarn-server-resourcemanager in the patch failed. +1 javadoc 0m 43s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 56s the patch passed with JDK v1.7.0_91 +1 unit 1m 52s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 0m 15s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 0m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 32m 9s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781904/YARN-4307.v1.002.patch JIRA Issue YARN-4307 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0eb6cd67479c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 126705f Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10250/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10250/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10250/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          uploaded with new patch fixing compilation issues

          Show
          Naganarasimha Naganarasimha G R added a comment - uploaded with new patch fixing compilation issues
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 3s trunk passed
          +1 compile 2m 23s trunk passed with JDK v1.8.0_66
          +1 compile 2m 31s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 39s trunk passed
          +1 mvnsite 1m 26s trunk passed
          +1 mvneclipse 0m 31s trunk passed
          +1 findbugs 2m 55s trunk passed
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 16s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 15s the patch passed
          +1 compile 2m 29s the patch passed with JDK v1.8.0_66
          +1 javac 2m 29s the patch passed
          +1 compile 2m 18s the patch passed with JDK v1.7.0_91
          +1 javac 2m 18s the patch passed
          -1 checkstyle 0m 36s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 440, now 443).
          +1 mvnsite 1m 8s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 58s the patch passed
          +1 javadoc 0m 52s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 58s the patch passed with JDK v1.7.0_91
          +1 unit 2m 0s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 61m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 62m 9s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          163m 45s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782033/YARN-4307.v1.003.patch
          JIRA Issue YARN-4307
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a7cf1bcefc34 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c0537bc
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10263/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10263/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10263/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10263/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10263/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10263/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10263/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 3s trunk passed +1 compile 2m 23s trunk passed with JDK v1.8.0_66 +1 compile 2m 31s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 39s trunk passed +1 mvnsite 1m 26s trunk passed +1 mvneclipse 0m 31s trunk passed +1 findbugs 2m 55s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 16s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 15s the patch passed +1 compile 2m 29s the patch passed with JDK v1.8.0_66 +1 javac 2m 29s the patch passed +1 compile 2m 18s the patch passed with JDK v1.7.0_91 +1 javac 2m 18s the patch passed -1 checkstyle 0m 36s Patch generated 5 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 440, now 443). +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 58s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 58s the patch passed with JDK v1.7.0_91 +1 unit 2m 0s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 61m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 2m 17s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 62m 9s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 163m 45s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782033/YARN-4307.v1.003.patch JIRA Issue YARN-4307 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a7cf1bcefc34 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c0537bc Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10263/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10263/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10263/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10263/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10263/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10263/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10263/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Varun Vasudev,
          Can you take a look at the latest patch, check style nothing much can be done and test case failures are not related to the patch

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Varun Vasudev , Can you take a look at the latest patch, check style nothing much can be done and test case failures are not related to the patch
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Varun Vasudev, if you some cycles can you take a look at this patch ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Varun Vasudev , if you some cycles can you take a look at this patch ?
          Hide
          vvasudev Varun Vasudev added a comment -

          My apologies for the delay Naga. Patch looks mostly good to me. Some more minor nits -

          1) rename getApplicationBlackListNodes to getBlackListedNodes

          2) In RMAppAttemptBlock.java

          +    String appBlacklistedNodes =
          +        getNodeString(rmAppAttempt.getApplicationBlackListNodes());
          +    String rmBlackListedNodes = getNodeString(
          +        rmAppAttempt.getAMBlacklist().getBlacklistUpdates().getAdditions());
          

          Add a comment explaining difference between the two.

          3) In RMAppAttemptBlock.java

          ._("RM Blacklisted Nodes:", rmBlackListedNodes);
          

          Change "RM Blacklisted Nodes" to "RM Blacklisted Nodes(for AM launches)"

          4) In RMAppBlock.java

          String appBlacklistedNodesCount = String.valueOf(nodes.size());
          String rmBlacklistedNodesCount = String.valueOf(rmAppAttempt
              .getAMBlacklist().getBlacklistUpdates().getAdditions().size());
          

          Similar to (2) - add a comment explaining difference

          5) In AppAttemptInfo
          rename blacklistedNodesForAMByRM to rmBlacklistedNodesForAMLaunches

          Show
          vvasudev Varun Vasudev added a comment - My apologies for the delay Naga. Patch looks mostly good to me. Some more minor nits - 1) rename getApplicationBlackListNodes to getBlackListedNodes 2) In RMAppAttemptBlock.java + String appBlacklistedNodes = + getNodeString(rmAppAttempt.getApplicationBlackListNodes()); + String rmBlackListedNodes = getNodeString( + rmAppAttempt.getAMBlacklist().getBlacklistUpdates().getAdditions()); Add a comment explaining difference between the two. 3) In RMAppAttemptBlock.java ._( "RM Blacklisted Nodes:" , rmBlackListedNodes); Change "RM Blacklisted Nodes" to "RM Blacklisted Nodes(for AM launches)" 4) In RMAppBlock.java String appBlacklistedNodesCount = String .valueOf(nodes.size()); String rmBlacklistedNodesCount = String .valueOf(rmAppAttempt .getAMBlacklist().getBlacklistUpdates().getAdditions().size()); Similar to (2) - add a comment explaining difference 5) In AppAttemptInfo rename blacklistedNodesForAMByRM to rmBlacklistedNodesForAMLaunches
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Varun Vasudev for the review comments, and sorry for the delay in responding. Please find the attached patch with fixes for the review comment !

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Varun Vasudev for the review comments, and sorry for the delay in responding. Please find the attached patch with fixes for the review comment !
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 20s Maven dependency ordering for branch
          +1 mvninstall 6m 37s trunk passed
          +1 compile 1m 56s trunk passed with JDK v1.8.0_66
          +1 compile 2m 10s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 36s trunk passed
          +1 mvnsite 1m 9s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 2m 21s trunk passed
          +1 javadoc 0m 47s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 2s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 0m 59s the patch passed
          +1 compile 2m 2s the patch passed with JDK v1.8.0_66
          +1 javac 2m 2s the patch passed
          +1 compile 2m 26s the patch passed with JDK v1.7.0_91
          +1 javac 2m 26s the patch passed
          -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: patch generated 3 new + 433 unchanged - 0 fixed = 436 total (was 433)
          +1 mvnsite 1m 10s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 1s the patch passed
          +1 javadoc 0m 48s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 56s the patch passed with JDK v1.7.0_91
          +1 unit 1m 58s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 66m 53s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 66m 59s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          169m 42s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785509/YARN-4307.v1.004.patch
          JIRA Issue YARN-4307
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 73e8ea6986df 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8f2622b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10455/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10455/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10455/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10455/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10455/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10455/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10455/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 20s Maven dependency ordering for branch +1 mvninstall 6m 37s trunk passed +1 compile 1m 56s trunk passed with JDK v1.8.0_66 +1 compile 2m 10s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 36s trunk passed +1 mvnsite 1m 9s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 2m 21s trunk passed +1 javadoc 0m 47s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_91 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 0m 59s the patch passed +1 compile 2m 2s the patch passed with JDK v1.8.0_66 +1 javac 2m 2s the patch passed +1 compile 2m 26s the patch passed with JDK v1.7.0_91 +1 javac 2m 26s the patch passed -1 checkstyle 0m 39s hadoop-yarn-project/hadoop-yarn: patch generated 3 new + 433 unchanged - 0 fixed = 436 total (was 433) +1 mvnsite 1m 10s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 1s the patch passed +1 javadoc 0m 48s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 56s the patch passed with JDK v1.7.0_91 +1 unit 1m 58s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 66m 53s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 66m 59s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 169m 42s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785509/YARN-4307.v1.004.patch JIRA Issue YARN-4307 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 73e8ea6986df 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8f2622b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10455/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10455/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10455/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10455/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10455/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10455/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10455/console This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          Thanks for the update Naga. Patch is almost there - couple of minor fixes -

          1) Rename getBlackListedNodes to getBlacklistedNodes - my apologies for this - the 'L' should have been lowercase in my earlier comment

          2) Fix the checkstyle warnings for RMAppBlock.java - lines 116 and 117 are greater than 80 characters.

          Show
          vvasudev Varun Vasudev added a comment - Thanks for the update Naga. Patch is almost there - couple of minor fixes - 1) Rename getBlackListedNodes to getBlacklistedNodes - my apologies for this - the 'L' should have been lowercase in my earlier comment 2) Fix the checkstyle warnings for RMAppBlock.java - lines 116 and 117 are greater than 80 characters.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Varun Vasudev for the review comments, have attached the patch with corrections you mentioned.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Varun Vasudev for the review comments, have attached the patch with corrections you mentioned.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 19s Maven dependency ordering for branch
          +1 mvninstall 7m 50s trunk passed
          +1 compile 2m 21s trunk passed with JDK v1.8.0_66
          +1 compile 2m 31s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 43s trunk passed
          +1 mvnsite 1m 17s trunk passed
          +1 mvneclipse 0m 32s trunk passed
          +1 findbugs 2m 37s trunk passed
          +1 javadoc 0m 53s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 2s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 0m 59s the patch passed
          +1 compile 1m 57s the patch passed with JDK v1.8.0_66
          +1 javac 1m 57s the patch passed
          +1 compile 2m 16s the patch passed with JDK v1.7.0_91
          +1 javac 2m 16s the patch passed
          -1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: patch generated 1 new + 433 unchanged - 0 fixed = 434 total (was 433)
          +1 mvnsite 1m 6s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 59s the patch passed
          +1 javadoc 0m 49s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 1s the patch passed with JDK v1.7.0_91
          +1 unit 2m 3s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 62m 47s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          -1 unit 65m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          166m 34s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785781/YARN-4307.v1.005.patch
          JIRA Issue YARN-4307
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6b062a15b58e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 700a176
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10469/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10469/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10469/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 19s Maven dependency ordering for branch +1 mvninstall 7m 50s trunk passed +1 compile 2m 21s trunk passed with JDK v1.8.0_66 +1 compile 2m 31s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 43s trunk passed +1 mvnsite 1m 17s trunk passed +1 mvneclipse 0m 32s trunk passed +1 findbugs 2m 37s trunk passed +1 javadoc 0m 53s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_91 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 0m 59s the patch passed +1 compile 1m 57s the patch passed with JDK v1.8.0_66 +1 javac 1m 57s the patch passed +1 compile 2m 16s the patch passed with JDK v1.7.0_91 +1 javac 2m 16s the patch passed -1 checkstyle 0m 38s hadoop-yarn-project/hadoop-yarn: patch generated 1 new + 433 unchanged - 0 fixed = 434 total (was 433) +1 mvnsite 1m 6s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 59s the patch passed +1 javadoc 0m 49s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 1s the patch passed with JDK v1.7.0_91 +1 unit 2m 3s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 62m 47s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 65m 11s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 166m 34s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785781/YARN-4307.v1.005.patch JIRA Issue YARN-4307 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6b062a15b58e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 700a176 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10469/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10469/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10469/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10469/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Varun Vasudev, Jenkins reports seems to be fine now as test cases are not related and the check style issue seems to be ok to be left out.

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Varun Vasudev , Jenkins reports seems to be fine now as test cases are not related and the check style issue seems to be ok to be left out.
          Hide
          vvasudev Varun Vasudev added a comment -

          +1 for the latest patch. I'll commit this tomorrow if no one objects.

          Show
          vvasudev Varun Vasudev added a comment - +1 for the latest patch. I'll commit this tomorrow if no one objects.
          Hide
          vvasudev Varun Vasudev added a comment -

          Committed to trunk and branch-2. Thanks NGarla_Unused!

          Show
          vvasudev Varun Vasudev added a comment - Committed to trunk and branch-2. Thanks NGarla_Unused !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9244 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9244/)
          YARN-4307. Display blacklisted nodes for AM container in the RM web UI. (vvasudev: rev 308d63f382e1992ea2b8ccf3130edaaa751c644d)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppsBlock.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/hamlet/Hamlet.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppAttemptInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/blacklist/SimpleBlacklistManager.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppAttemptBlock.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9244 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9244/ ) YARN-4307 . Display blacklisted nodes for AM container in the RM web UI. (vvasudev: rev 308d63f382e1992ea2b8ccf3130edaaa751c644d) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppsBlock.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/hamlet/Hamlet.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/AppAttemptInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttempt.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/blacklist/SimpleBlacklistManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppAttemptBlock.java
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Varun Vasudev, for reviewing and committing the patch !

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Varun Vasudev , for reviewing and committing the patch !
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Uploading a patch that I just pushed in for branch-2.8. This patch is needed by YARN-4837 on branch-2.8.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Uploading a patch that I just pushed in for branch-2.8. This patch is needed by YARN-4837 on branch-2.8.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Reopening the issue to apply patch for 2.8...

          Show
          Naganarasimha Naganarasimha G R added a comment - Reopening the issue to apply patch for 2.8...
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          0 patch 0m 5s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          -1 patch 0m 10s YARN-4307 does not apply to branch-2.8. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824437/YARN-4307-branch-2.8.txt
          JIRA Issue YARN-4307
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12829/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. 0 patch 0m 5s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. -1 patch 0m 10s YARN-4307 does not apply to branch-2.8. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824437/YARN-4307-branch-2.8.txt JIRA Issue YARN-4307 Console output https://builds.apache.org/job/PreCommit-YARN-Build/12829/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Reopening the issue to apply patch for 2.8...

          Naganarasimha G R, no need to reopen, the conflicts were straight-forward to fix, I already committed the patch. Just uploaded the 2.8 branch for posterity.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Reopening the issue to apply patch for 2.8... Naganarasimha G R , no need to reopen, the conflicts were straight-forward to fix, I already committed the patch. Just uploaded the 2.8 branch for posterity.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Vinod Kumar Vavilapalli, Oops did not see your comment properly just read the uploaded patch ... thanks for closing anyway!

          Show
          Naganarasimha Naganarasimha G R added a comment - Vinod Kumar Vavilapalli , Oops did not see your comment properly just read the uploaded patch ... thanks for closing anyway!

            People

            • Assignee:
              Naganarasimha Naganarasimha G R
              Reporter:
              Naganarasimha Naganarasimha G R
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development