Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4296

DistributedShell Log.info is not friendly

    Details

      Description

      In java/org/apache/hadoop/yarn/applications/distributedshell/Client.java, line 453´╝îLog.info is not friendly ,I think,nodeAddress and its content should be separated with "="

      The origin Log.info is

      15/10/24 10:20:26 INFO distributedshell.Client: Got node report from ASM for, nodeId=cloud101414328.wd.nm.ss.nop:45454, nodeAddresscloud101414328.wd.nm.ss.nop:23999, nodeRackName/default-rack, nodeNumContainers19
      15/10/24 10:20:26 INFO distributedshell.Client: Got node report from ASM for, nodeId=rsync.cloud10141032027.wd.nm.nop:45454, nodeAddressrsync.cloud10141032027.wd.nm.nop:23999, nodeRackName/default-rack, nodeNumContainers19
      

      A better way is

      15/10/24 10:20:26 INFO distributedshell.Client: Got node report from ASM for, nodeId=cloud101414328.wd.nm.ss.nop:45454, nodeAddress=cloud101414328.wd.nm.ss.nop:23999, nodeRackName=/default-rack, nodeNumContainers=19
      15/10/24 10:20:26 INFO distributedshell.Client: Got node report from ASM for, nodeId=rsync.cloud10141032027.wd.nm.nop:45454, nodeAddress=rsync.cloud10141032027.wd.nm.nop:23999, nodeRackName=/default-rack, nodeNumContainers=19
      

        Activity

        Hide
        wisgood Xiaowei Wang added a comment -
        Show
        wisgood Xiaowei Wang added a comment - I need a review .Thanks Steve Loughran Tsuyoshi Ozawa Akira Ajisaka
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 20m 21s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 9m 25s There were no new javac warning messages.
        +1 javadoc 11m 49s There were no new javadoc warning messages.
        +1 release audit 0m 29s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 27s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 44s mvn install still works.
        +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
        +1 findbugs 0m 57s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 7m 6s Tests passed in hadoop-yarn-applications-distributedshell.
            52m 59s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12768480/YARN-4296.0.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7781fe1
        hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/9559/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9559/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9559/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 21s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 9m 25s There were no new javac warning messages. +1 javadoc 11m 49s There were no new javadoc warning messages. +1 release audit 0m 29s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 27s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 44s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. +1 findbugs 0m 57s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 7m 6s Tests passed in hadoop-yarn-applications-distributedshell.     52m 59s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768480/YARN-4296.0.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7781fe1 hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/9559/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9559/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9559/console This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        +1, committed

        Show
        stevel@apache.org Steve Loughran added a comment - +1, committed
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8702 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8702/)
        YARN-4296. DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8702 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8702/ ) YARN-4296 . DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1315 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1315/)
        YARN-4296. DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1315 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1315/ ) YARN-4296 . DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #580 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/580/)
        YARN-4296. DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #580 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/580/ ) YARN-4296 . DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2524 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2524/)
        YARN-4296. DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2524 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2524/ ) YARN-4296 . DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #592 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/592/)
        YARN-4296. DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #592 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/592/ ) YARN-4296 . DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2471 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2471/)
        YARN-4296. DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2471 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2471/ ) YARN-4296 . DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #534 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/534/)
        YARN-4296. DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #534 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/534/ ) YARN-4296 . DistributedShell Log.info is not friendly. (Xiaowei Wang via (stevel: rev 446212a39ecf295cdd0e0b06ab870b48c5e6b500) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/Client.java

          People

          • Assignee:
            wisgood Xiaowei Wang
            Reporter:
            wisgood Xiaowei Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development