Sunil G added a comment - 25/Nov/15 19:08 Attaching an initial version. This became little trickier as ResourceUtilization was written in org.apache.hadoop.yarn.server.api.records where as we needed it in org.apache.hadoop.yarn.api.records . Since we need to pull this info to client as node report. So i moved these classes to yarn.api , hence all source files which used ResourceUtilization needed a change in import. This information is added to "node -status" command only. Wangda Tan could you please help to check this and let me know whether the approach is fine or not. Thank You.

Sunil G added a comment - 02/Dec/15 16:18 Submitting the patch to kick jenkins. Wangda Tan Kindly help to check the same.

Wangda Tan added a comment - 02/Dec/15 21:08 Thanks Sunil G . Karthik Kambatla , I found the biggest change of this patch is moving ResourceUtilization class from server.api to api. Do you think if ResourceUtilization should be a part of user-facing API?

Hadoop QA added a comment - 02/Dec/15 22:29 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 13s trunk passed +1 compile 9m 4s trunk passed with JDK v1.8.0_66 +1 compile 9m 26s trunk passed with JDK v1.7.0_85 +1 checkstyle 1m 7s trunk passed +1 mvnsite 3m 47s trunk passed +1 mvneclipse 1m 50s trunk passed +1 findbugs 7m 39s trunk passed +1 javadoc 2m 57s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 33s trunk passed with JDK v1.7.0_85 +1 mvninstall 3m 29s the patch passed +1 compile 9m 6s the patch passed with JDK v1.8.0_66 +1 cc 9m 6s the patch passed -1 javac 21m 42s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 751, now 751). +1 javac 9m 6s the patch passed +1 compile 9m 27s the patch passed with JDK v1.7.0_85 +1 cc 9m 27s the patch passed -1 javac 31m 9s root-jdk1.7.0_85 with JDK v1.7.0_85 generated 1 new issues (was 745, now 745). +1 javac 9m 27s the patch passed -1 checkstyle 1m 5s Patch generated 8 new checkstyle issues in root (total was 254, now 261). +1 mvnsite 3m 46s the patch passed +1 mvneclipse 1m 49s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 8m 47s the patch passed +1 javadoc 2m 59s the patch passed with JDK v1.8.0_66 +1 javadoc 5m 37s the patch passed with JDK v1.7.0_85 +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. -1 unit 2m 1s hadoop-yarn-common in the patch failed with JDK v1.8.0_66. +1 unit 0m 25s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 53s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 61m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 6m 25s hadoop-yarn-server-tests in the patch failed with JDK v1.8.0_66. -1 unit 49m 29s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. +1 unit 0m 55s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. -1 unit 2m 18s hadoop-yarn-common in the patch failed with JDK v1.7.0_85. +1 unit 0m 29s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_85. +1 unit 9m 18s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_85. -1 unit 61m 4s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. -1 unit 6m 46s hadoop-yarn-server-tests in the patch failed with JDK v1.7.0_85. -1 unit 49m 39s hadoop-yarn-client in the patch failed with JDK v1.7.0_85. +1 unit 0m 58s hadoop-sls in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 359m 45s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.api.TestPBImplRecords   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.client.TestGetGroups JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_85 Failed junit tests hadoop.yarn.api.TestPBImplRecords   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.client.TestGetGroups JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774397/0001-YARN-4293.patch JIRA Issue YARN-4293 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 13b8151df06b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 53e3bf7 findbugs v3.0.0 javac root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/diff-compile-javac-root-jdk1.8.0_66.txt javac root-jdk1.7.0_85: https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_85.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9839/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9839/testReport/ modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: . Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9839/console This message was automatically generated.

Sunil G added a comment - 03/Dec/15 16:52 Couple of test cases are related along with few warnings. I will handle those once Karthik Kambatla Wangda Tan confirms the approach. Thank You!

Naganarasimha G R added a comment - 06/Dec/15 15:14 hi Sunil G , Seems like you have handled scope of YARN-4291 in this jira itself, so shall i close YARN-4291 jira?

Sunil G added a comment - 06/Dec/15 15:27 Hi NGarla_Unused Extremely sorry for the mixed up. I was trying to have the CLI up here, and automatically did NodeReport since we needed that resource info. I feel it can be marked up as dup here if its fine.

Wangda Tan added a comment - 09/Dec/15 22:13 Karthik Kambatla , Could you take a look at my comment if you have chance? https://issues.apache.org/jira/browse/YARN-4293?focusedCommentId=15036630&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15036630 . I was asking this since I want to understand if it is discussed before.

Wangda Tan added a comment - 11/Dec/15 22:19 Hi Sunil G , Look at look at the patch, one comment, NodeCLI, we should print ResourceUtilization/ContainerUtilization when corresponding field != null, Otherwise it could cause misunderstanding about PMem:0, etc. Thoughts? And could you take a look at test failures, etc.

Sunil G added a comment - 12/Dec/15 15:24 Thank you Wangda Tan for sharing the comments. Adding empty resource utilization cases in CLI, also added a test case to verify same. Apart from this, fixed valid test failures reported in jenkins. Uploading a new patch. Kindly help to review the same.

Hadoop QA added a comment - 12/Dec/15 21:41 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 7m 56s trunk passed +1 compile 8m 51s trunk passed with JDK v1.8.0_66 +1 compile 9m 56s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 10s trunk passed +1 mvnsite 3m 53s trunk passed +1 mvneclipse 1m 52s trunk passed +1 findbugs 7m 22s trunk passed -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66. +1 javadoc 5m 31s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 28s the patch passed +1 compile 8m 52s the patch passed with JDK v1.8.0_66 +1 cc 8m 52s the patch passed +1 javac 8m 52s the patch passed +1 compile 10m 7s the patch passed with JDK v1.7.0_91 +1 cc 10m 7s the patch passed -1 javac 31m 32s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 728, now 728). +1 javac 10m 7s the patch passed -1 checkstyle 1m 5s Patch generated 4 new checkstyle issues in root (total was 259, now 262). +1 mvnsite 4m 0s the patch passed +1 mvneclipse 1m 56s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 9m 14s the patch passed -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 javadoc 5m 44s the patch passed with JDK v1.7.0_91 +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 2s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 25s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 55s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 65m 28s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 7m 2s hadoop-yarn-server-tests in the patch failed with JDK v1.8.0_66. -1 unit 49m 39s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. +1 unit 0m 54s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 19s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 0m 30s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_91. -1 unit 9m 28s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_91. -1 unit 66m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 7m 55s hadoop-yarn-server-tests in the patch failed with JDK v1.7.0_91. -1 unit 49m 37s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. +1 unit 0m 57s hadoop-sls in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 372m 36s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.client.TestGetGroups JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.client.TestGetGroups JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777289/0002-YARN-4293.patch JIRA Issue YARN-4293 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux e62956a0877c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bf5295b findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9951/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9951/testReport/ modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: . Max memory used 75MB Powered by Apache Yetus 0.1.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9951/console This message was automatically generated.

Sunil G added a comment - 14/Dec/15 15:39 Test failures are not related. I have verified locally ,and seen that few are failing w/o this patch also. I have raised ticket for same . I think change is impacting more test suits and hence getting these time outs.

Wangda Tan added a comment - 14/Dec/15 19:02 Thanks Sunil G , One other comments: InterfaceAudience for ResourceUtilization seems not correct, if getResourceUtilization is public in NodeReport, ResourceUtilization should be public as well. Is it better to mark all ResourceUtilization related apis to public and unstable?

Karthik Kambatla added a comment - 15/Dec/15 10:02 Just saw the ping here (was out on vacation and slowly catching up on things). When adding resource utilization, all the uses were on the server side and hence we left it in the server API. I am open to moving it to the client API.

Sunil G added a comment - 15/Dec/15 16:23 Thank you Wangda Tan . Yes, we need to make the changes in annotations. Uploading a new patch addressing the same. Thank you Karthik Kambatla for the clarification.

Wangda Tan added a comment - 15/Dec/15 19:18 Thanks Karthik Kambatla for clarification and updates from Sunil G . Patch LGTM, +1, will commit in a few days if no opposite opinions.

Hadoop QA added a comment - 15/Dec/15 22:42 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. +1 mvninstall 8m 31s trunk passed +1 compile 9m 20s trunk passed with JDK v1.8.0_66 +1 compile 10m 6s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 10s trunk passed +1 mvnsite 3m 50s trunk passed +1 mvneclipse 1m 51s trunk passed +1 findbugs 7m 24s trunk passed +1 javadoc 2m 57s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 47s trunk passed with JDK v1.7.0_91 +1 mvninstall 3m 26s the patch passed +1 compile 8m 44s the patch passed with JDK v1.8.0_66 -1 cc 21m 31s root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 16, now 16). +1 cc 8m 44s the patch passed +1 javac 8m 44s the patch passed +1 compile 9m 25s the patch passed with JDK v1.7.0_91 +1 cc 9m 25s the patch passed -1 javac 30m 56s root-jdk1.7.0_91 with JDK v1.7.0_91 generated 1 new issues (was 723, now 723). +1 javac 9m 25s the patch passed -1 checkstyle 1m 3s Patch generated 4 new checkstyle issues in root (total was 259, now 262). +1 mvnsite 4m 6s the patch passed +1 mvneclipse 2m 9s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 9m 3s the patch passed +1 javadoc 2m 58s the patch passed with JDK v1.8.0_66 +1 javadoc 5m 37s the patch passed with JDK v1.7.0_91 +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 1m 59s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 24s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_66. +1 unit 8m 52s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_66. -1 unit 66m 50s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 7m 5s hadoop-yarn-server-tests in the patch failed with JDK v1.8.0_66. -1 unit 49m 35s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. +1 unit 0m 55s hadoop-sls in the patch passed with JDK v1.8.0_66. +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 18s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 0m 29s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_91. +1 unit 9m 25s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_91. -1 unit 67m 27s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 7m 13s hadoop-yarn-server-tests in the patch failed with JDK v1.7.0_91. -1 unit 49m 39s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. +1 unit 0m 57s hadoop-sls in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 374m 20s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestRM   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.client.TestGetGroups JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestApplicationPriority   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.yarn.server.TestMiniYarnClusterNodeUtilization   hadoop.yarn.client.TestGetGroups JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777769/0003-YARN-4293.patch JIRA Issue YARN-4293 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux de6ca4aa4c77 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0c3a53e findbugs v3.0.0 cc root-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/diff-compile-cc-root-jdk1.8.0_66.txt javac root-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-tests-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9986/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9986/testReport/ modules C: hadoop-tools/hadoop-sls hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests U: . Max memory used 76MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9986/console This message was automatically generated.

Hudson added a comment - 16/Dec/15 21:44 FAILURE: Integrated in Hadoop-trunk-Commit #8978 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8978/ ) YARN-4293 . ResourceUtilization should be a part of yarn node CLI. (Sunil (wangda: rev 79c41b1d83e981ae74cb8b58ffcf7907b7612ad4) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitor.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerNode.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/impl/pb/ResourceUtilizationPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/NodeStatus.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/proto/yarn_server_common_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeStatusUpdaterImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/scheduler/RMNodeWrapper.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeStatusEvent.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/ResourceUtilization.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockNodes.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeResourceMonitorImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/ResourceUtilization.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNode.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/ResourceUtilizationInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/api/records/impl/pb/NodeStatusPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesNodes.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/ResourceUtilizationPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/nodemanager/NodeInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/TestMiniYarnClusterNodeUtilization.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/utils/BuilderUtils.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/NodeResourceMonitor.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/NodeReport.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/NodeReportPBImpl.java

Wangda Tan added a comment - 17/Dec/15 19:23 Committed to trunk/branch-2, thanks Sunil G !

Sunil G added a comment - 18/Dec/15 01:52 Thank you Wangda Tan for the review and commit and thank you Karthik Kambatla for the review.

Wangda Tan added a comment - 19/Dec/15 00:38 Committed to branch-2.8.