Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4250

NPE in AppSchedulingInfo#isRequestLabelChanged

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Trace

      java.lang.NullPointerException
      	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo.isRequestLabelChanged(AppSchedulingInfo.java:420)
      	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo.updateResourceRequests(AppSchedulingInfo.java:342)
      	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt.updateResourceRequests(SchedulerApplicationAttempt.java:300)
      	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.fifo.FifoScheduler.allocate(FifoScheduler.java:350)
      	at org.apache.hadoop.yarn.client.api.impl.TestAMRMClientOnRMRestart$MyFifoScheduler.allocate(TestAMRMClientOnRMRestart.java:544)
      	at org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.allocate(ApplicationMasterService.java:507)
      	at org.apache.hadoop.yarn.client.api.impl.AMRMClientImpl.allocate(AMRMClientImpl.java:277)
      	at org.apache.hadoop.yarn.client.api.impl.TestAMRMClientOnRMRestart.testAMRMClientResendsRequestsOnRMRestart(TestAMRMClientOnRMRestart.java:187)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
      	at java.lang.reflect.Method.invoke(Unknown Source)
      	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
      	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
      	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
      	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
      	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
      
      1. YARN-4250.patch
        1 kB
        Brahma Reddy Battula
      2. YARN-4250-002.patch
        1 kB
        Brahma Reddy Battula
      3. YARN-4250-003.patch
        1 kB
        Brahma Reddy Battula
      4. YARN-4250-004.patch
        2 kB
        Bibin A Chundatt

        Issue Links

          Activity

          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          it's induced by YARN-4140.

          Reproduce : Execute TestAMRMClientOnRMRestart#testAMRMClientResendsRequestsOnRMRestart

          Null check is missed while checking the requestlabelchanged..

          private boolean isRequestLabelChanged(ResourceRequest requestOne,
                ResourceRequest requestTwo) {
              String requestOneLabelExp = requestOne.getNodeLabelExpression();
              String requestTwoLabelExp = requestTwo.getNodeLabelExpression();
              return (!(requestOneLabelExp.equals(requestTwoLabelExp)));
            }
          
          Show
          brahmareddy Brahma Reddy Battula added a comment - it's induced by YARN-4140 . Reproduce : Execute TestAMRMClientOnRMRestart#testAMRMClientResendsRequestsOnRMRestart Null check is missed while checking the requestlabelchanged.. private boolean isRequestLabelChanged(ResourceRequest requestOne, ResourceRequest requestTwo) { String requestOneLabelExp = requestOne.getNodeLabelExpression(); String requestTwoLabelExp = requestTwo.getNodeLabelExpression(); return (!(requestOneLabelExp.equals(requestTwoLabelExp))); }
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 4s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 59s There were no new javac warning messages.
          +1 javadoc 10m 17s There were no new javadoc warning messages.
          -1 release audit 0m 19s The applied patch generated 1 release audit warnings.
          -1 checkstyle 0m 49s The applied patch generated 1 new checkstyle issues (total was 39, now 40).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 1m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 yarn tests 48m 35s Tests failed in hadoop-yarn-server-resourcemanager.
              88m 39s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.TestRMRestart
          Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12765992/YARN-4250.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 7e2c971
          Release Audit https://builds.apache.org/job/PreCommit-YARN-Build/9398/artifact/patchprocess/patchReleaseAuditProblems.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9398/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9398/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9398/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9398/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 4s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 59s There were no new javac warning messages. +1 javadoc 10m 17s There were no new javadoc warning messages. -1 release audit 0m 19s The applied patch generated 1 release audit warnings. -1 checkstyle 0m 49s The applied patch generated 1 new checkstyle issues (total was 39, now 40). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 48m 35s Tests failed in hadoop-yarn-server-resourcemanager.     88m 39s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.TestRMRestart Timed out tests org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765992/YARN-4250.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7e2c971 Release Audit https://builds.apache.org/job/PreCommit-YARN-Build/9398/artifact/patchprocess/patchReleaseAuditProblems.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9398/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9398/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9398/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9398/console This message was automatically generated.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Brahma Reddy Battula

          Thanks for reporting this.

          In ApplicationMasterService#allocate null labels are getting changed to NO_LABEL so label should be null in requests after the below.

                  RMServerUtils.normalizeAndValidateRequests(ask,
                      maximumCapacity, app.getQueue(),
                      rScheduler, rmContext);
          

          But to my understanding fix should be in TestAMRMClientOnRMRestart#allocate

                List<ResourceRequest> askCopy = new ArrayList<ResourceRequest>();
                for (ResourceRequest req : ask) {
                  ResourceRequest reqCopy =
                      ResourceRequest.newInstance(req.getPriority(),
                          req.getResourceName(), req.getCapability(),
                          req.getNumContainers(), req.getRelaxLocality());
                  askCopy.add(reqCopy);
                }
          

          When reqCopy is created the label expression is not copied

                  ResourceRequest reqCopy =
                      ResourceRequest.newInstance(req.getPriority(),
                          req.getResourceName(), req.getCapability(),
                          req.getNumContainers(), req.getRelaxLocality(),req.getNodeLabelExpression());
          

          Could you please check again with above.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Brahma Reddy Battula Thanks for reporting this. In ApplicationMasterService#allocate null labels are getting changed to NO_LABEL so label should be null in requests after the below. RMServerUtils.normalizeAndValidateRequests(ask, maximumCapacity, app.getQueue(), rScheduler, rmContext); But to my understanding fix should be in TestAMRMClientOnRMRestart#allocate List<ResourceRequest> askCopy = new ArrayList<ResourceRequest>(); for (ResourceRequest req : ask) { ResourceRequest reqCopy = ResourceRequest.newInstance(req.getPriority(), req.getResourceName(), req.getCapability(), req.getNumContainers(), req.getRelaxLocality()); askCopy.add(reqCopy); } When reqCopy is created the label expression is not copied ResourceRequest reqCopy = ResourceRequest.newInstance(req.getPriority(), req.getResourceName(), req.getCapability(), req.getNumContainers(), req.getRelaxLocality(),req.getNodeLabelExpression()); Could you please check again with above.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Small correction in comment.
          In ApplicationMasterService#allocate null labels are getting changed to NO_LABEL so label should not be null in requests after the below.

          Also if you agree please change defect description too.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Small correction in comment. In ApplicationMasterService#allocate null labels are getting changed to NO_LABEL so label should not be null in requests after the below. Also if you agree please change defect description too.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Bibin A Chundatt Thanks for taking a look into this..When reqCopy is created the label expression is not copied, that's correct.After YARN-4140, we need add req.getNodeLabelExpression() for resourcerequest.

          Actually TestAMRMClientOnRMRestart and TestRMContainerAllocator both are failing,hence I fixed like that..May be I will raise seperate issue for TestRMContainerAllocator and add req.getNodeLabelExpression().

          cc to Wangda Tan

          Show
          brahmareddy Brahma Reddy Battula added a comment - Bibin A Chundatt Thanks for taking a look into this..When reqCopy is created the label expression is not copied, that's correct.After YARN-4140 , we need add req.getNodeLabelExpression() for resourcerequest . Actually TestAMRMClientOnRMRestart and TestRMContainerAllocator both are failing,hence I fixed like that..May be I will raise seperate issue for TestRMContainerAllocator and add req.getNodeLabelExpression() . cc to Wangda Tan
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 6m 13s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 40s There were no new javac warning messages.
          -1 release audit 0m 17s The applied patch generated 1 release audit warnings.
          +1 checkstyle 0m 29s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 26s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 7m 0s Tests passed in hadoop-yarn-client.
              24m 30s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766015/YARN-4250-002.patch
          Optional Tests javac unit findbugs checkstyle
          git revision trunk / db93047
          Release Audit https://builds.apache.org/job/PreCommit-YARN-Build/9402/artifact/patchprocess/patchReleaseAuditProblems.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9402/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9402/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9402/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 6m 13s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 40s There were no new javac warning messages. -1 release audit 0m 17s The applied patch generated 1 release audit warnings. +1 checkstyle 0m 29s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 7m 0s Tests passed in hadoop-yarn-client.     24m 30s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766015/YARN-4250-002.patch Optional Tests javac unit findbugs checkstyle git revision trunk / db93047 Release Audit https://builds.apache.org/job/PreCommit-YARN-Build/9402/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9402/artifact/patchprocess/testrun_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9402/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9402/console This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks for looking at this Bibin A Chundatt/Brahma Reddy Battula.

          I think we need to fix AppSchedulingInfo side, consider null node-label-expression at isRequestLabelChanged. I thought ApplicationMasterService normalizes expression, but it cannot avoid a customized scheduler copy and modify resource request before inserting to AppSchedulingInfo. Bibin A Chundatt you are right .

          Comment on the patch is:

          • Update {{isRequestLabelChanged}
          • Revert changes of TestAMRMClientOnRMRestart

          Thoughts?

          Show
          leftnoteasy Wangda Tan added a comment - Thanks for looking at this Bibin A Chundatt / Brahma Reddy Battula . I think we need to fix AppSchedulingInfo side, consider null node-label-expression at isRequestLabelChanged . I thought ApplicationMasterService normalizes expression, but it cannot avoid a customized scheduler copy and modify resource request before inserting to AppSchedulingInfo. Bibin A Chundatt you are right . Comment on the patch is: Update {{isRequestLabelChanged} Revert changes of TestAMRMClientOnRMRestart Thoughts?
          Hide
          sunilg Sunil G added a comment -

          Yes Wangda Tan. I also looked this part, and +1 for the approach suggested by Wangda. We need the change in AppSchedulingInfo.

          Show
          sunilg Sunil G added a comment - Yes Wangda Tan . I also looked this part, and +1 for the approach suggested by Wangda. We need the change in AppSchedulingInfo.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Wangda Tan and Sunil G thanks for your comments...I too agree change in AppSchedulingInfo#isRequestLabelChanged.can you please look at first patch ( i.e YARN-4250.patch).

          Show
          brahmareddy Brahma Reddy Battula added a comment - Wangda Tan and Sunil G thanks for your comments...I too agree change in AppSchedulingInfo#isRequestLabelChanged .can you please look at first patch ( i.e YARN-4250 .patch).
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Brahma Reddy Battula

          The check done is incomplete in YARN-4250.patch

          +    return ((null != requestOneLabelExp) && !(requestOneLabelExp
          +        .equals(requestTwoLabelExp)))
          +        || ((null == requestOneLabelExp) && (null != requestTwoLabelExp));
          

          The check should be like above.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Brahma Reddy Battula The check done is incomplete in YARN-4250 .patch + return (( null != requestOneLabelExp) && !(requestOneLabelExp + .equals(requestTwoLabelExp))) + || (( null == requestOneLabelExp) && ( null != requestTwoLabelExp)); The check should be like above.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Brahma Reddy Battula can you update the patch?

          Show
          rohithsharma Rohith Sharma K S added a comment - Brahma Reddy Battula can you update the patch?
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          hmm.. Uploaded the patch..thanks Bibin A Chundatt and others.

          Show
          brahmareddy Brahma Reddy Battula added a comment - hmm.. Uploaded the patch..thanks Bibin A Chundatt and others.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 23m 13s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 10m 36s There were no new javac warning messages.
          +1 javadoc 13m 21s There were no new javadoc warning messages.
          +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 17s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
          +1 findbugs 1m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 yarn tests 58m 49s Tests failed in hadoop-yarn-server-resourcemanager.
              111m 25s  



          Reason Tests
          Timed out tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766311/YARN-4250-003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 5b6bae0
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9427/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9427/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9427/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 23m 13s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 10m 36s There were no new javac warning messages. +1 javadoc 13m 21s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 17s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 1m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 58m 49s Tests failed in hadoop-yarn-server-resourcemanager.     111m 25s   Reason Tests Timed out tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766311/YARN-4250-003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 5b6bae0 hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9427/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9427/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9427/console This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Marking it as blocker since pre-commit builds are keep on failing..can somebody look into this..?

          Show
          brahmareddy Brahma Reddy Battula added a comment - Marking it as blocker since pre-commit builds are keep on failing..can somebody look into this..?
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          The conditions are bit complex at least to me. Can it be more simpler and readable?

          Show
          rohithsharma Rohith Sharma K S added a comment - The conditions are bit complex at least to me. Can it be more simpler and readable?
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Rohith i feel its fine.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Rohith i feel its fine.
          Hide
          sunilg Sunil G added a comment -

          Hi Bibin,
          At first look, I also feel it's slightly confusing what we try to achieve here. On a closer analysis, this does handle all cases. So you could try give a detailed comment about the cases which is handled by this truth expression.

          Show
          sunilg Sunil G added a comment - Hi Bibin, At first look, I also feel it's slightly confusing what we try to achieve here. On a closer analysis, this does handle all cases. So you could try give a detailed comment about the cases which is handled by this truth expression.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Updating patch for the same since precommit build is failing.

          Rohith Sharma K S/Sunil G On second thoughts yea its confusing. So have attached patch with comments and splitting check too.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Updating patch for the same since precommit build is failing. Rohith Sharma K S / Sunil G On second thoughts yea its confusing. So have attached patch with comments and splitting check too.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 58s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 8m 6s There were no new javac warning messages.
          +1 javadoc 10m 46s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 57s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
          +1 findbugs 1m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 68m 48s Tests passed in hadoop-yarn-server-resourcemanager.
              113m 44s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766472/YARN-4250-004.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 40cac59
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9435/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9435/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9435/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 58s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 6s There were no new javac warning messages. +1 javadoc 10m 46s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 57s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. +1 findbugs 1m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 68m 48s Tests passed in hadoop-yarn-server-resourcemanager.     113m 44s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766472/YARN-4250-004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 40cac59 hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9435/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9435/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9435/console This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          committed to branch-2/trunk. thanks Brahma for contributions!! And thanks Bibin, Wangda and Sunil G for the review...

          Show
          rohithsharma Rohith Sharma K S added a comment - committed to branch-2/trunk. thanks Brahma for contributions!! And thanks Bibin, Wangda and Sunil G for the review...
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8631 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8631/)
          YARN-4250. NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8631 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8631/ ) YARN-4250 . NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #540 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/540/)
          YARN-4250. NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #540 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/540/ ) YARN-4250 . NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1264 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1264/)
          YARN-4250. NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1264 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1264/ ) YARN-4250 . NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #528 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/528/)
          YARN-4250. NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #528 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/528/ ) YARN-4250 . NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2476 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2476/)
          YARN-4250. NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2476 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2476/ ) YARN-4250 . NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2432 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2432/)
          YARN-4250. NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2432 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2432/ ) YARN-4250 . NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #495 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/495/)
          YARN-4250. NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #495 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/495/ ) YARN-4250 . NPE in AppSchedulingInfo#isRequestLabelChanged. (Brahma Reddy (rohithsharmaks: rev d6c8bad86964dbad3cc810914f786c7c4722227a) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AppSchedulingInfo.java

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              brahmareddy Brahma Reddy Battula
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development