Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4225

Add preemption status to yarn queue -status for capacity scheduler

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    1. YARN-4225.001.patch
      11 kB
      Eric Payne
    2. YARN-4225.002.patch
      11 kB
      Eric Payne
    3. YARN-4225.003.patch
      11 kB
      Eric Payne
    4. YARN-4225.004.patch
      16 kB
      Eric Payne
    5. YARN-4225.005.patch
      16 kB
      Eric Payne

      Activity

      Hide
      vinodkv Vinod Kumar Vavilapalli added a comment -

      Moving out all non-critical / non-blocker issues that didn't make it out of 2.7.2 into 2.7.3.

      Show
      vinodkv Vinod Kumar Vavilapalli added a comment - Moving out all non-critical / non-blocker issues that didn't make it out of 2.7.2 into 2.7.3.
      Hide
      eepayne Eric Payne added a comment -

      Attching YARN-4225.001.patch for both trunk and branch-2.8

      Show
      eepayne Eric Payne added a comment - Attching YARN-4225 .001.patch for both trunk and branch-2.8
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 12s docker + precommit patch detected.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
      +1 mvninstall 4m 11s trunk passed
      +1 compile 1m 31s trunk passed with JDK v1.8.0_66
      +1 compile 1m 13s trunk passed with JDK v1.7.0_79
      +1 checkstyle 0m 36s trunk passed
      +1 mvnsite 2m 29s trunk passed
      +1 mvneclipse 1m 17s trunk passed
      -1 findbugs 1m 46s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
      +1 javadoc 2m 56s trunk passed with JDK v1.8.0_66
      +1 javadoc 5m 27s trunk passed with JDK v1.7.0_79
      +1 mvninstall 2m 20s the patch passed
      +1 compile 1m 13s the patch passed with JDK v1.8.0_66
      +1 cc 1m 13s the patch passed
      +1 javac 1m 13s the patch passed
      +1 compile 1m 2s the patch passed with JDK v1.7.0_79
      +1 cc 1m 2s the patch passed
      +1 javac 1m 2s the patch passed
      -1 checkstyle 0m 39s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 50, now 50).
      +1 mvnsite 2m 27s the patch passed
      +1 mvneclipse 1m 9s the patch passed
      -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
      -1 findbugs 1m 58s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 1 new FindBugs issues.
      +1 javadoc 2m 30s the patch passed with JDK v1.8.0_66
      +1 javadoc 5m 9s the patch passed with JDK v1.7.0_79
      +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
      -1 unit 49m 56s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
      +1 unit 2m 41s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
      -1 unit 67m 51s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
      +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_79.
      -1 unit 49m 44s hadoop-yarn-client in the patch failed with JDK v1.7.0_79.
      +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.7.0_79.
      -1 unit 67m 53s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_79.
      +1 asflicense 0m 27s Patch does not generate ASF License warnings.
      293m 0s



      Reason Tests
      FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        Possible null pointer dereference of null in org.apache.hadoop.yarn.api.records.impl.pb.QueueInfoPBImpl.getPreemptionDisabled() Dereferenced at QueueInfoPBImpl.java:null in org.apache.hadoop.yarn.api.records.impl.pb.QueueInfoPBImpl.getPreemptionDisabled() Dereferenced at QueueInfoPBImpl.java:[line 402]
      JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups
        hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions
        hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization
      JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
        org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
        org.apache.hadoop.yarn.client.api.impl.TestNMClient
      JDK v1.7.0_79 Failed junit tests hadoop.yarn.client.TestGetGroups
        hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization
      JDK v1.7.0_79 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
        org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
        org.apache.hadoop.yarn.client.api.impl.TestNMClient



      Subsystem Report/Notes
      Docker Client=1.7.0 Server=1.7.0 Image:test-patch-base-hadoop-date2015-11-16
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772552/YARN-4225.001.patch
      JIRA Issue YARN-4225
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
      uname Linux 2c58c10e3c75 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh
      git revision trunk / 02653ad
      findbugs v3.0.0
      findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/whitespace-eol.txt
      findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_79.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_79.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_79.txt https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_79.txt
      JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9696/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Max memory used 228MB
      Powered by Apache Yetus http://yetus.apache.org
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/9696/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 4m 11s trunk passed +1 compile 1m 31s trunk passed with JDK v1.8.0_66 +1 compile 1m 13s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 36s trunk passed +1 mvnsite 2m 29s trunk passed +1 mvneclipse 1m 17s trunk passed -1 findbugs 1m 46s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 2m 56s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 27s trunk passed with JDK v1.7.0_79 +1 mvninstall 2m 20s the patch passed +1 compile 1m 13s the patch passed with JDK v1.8.0_66 +1 cc 1m 13s the patch passed +1 javac 1m 13s the patch passed +1 compile 1m 2s the patch passed with JDK v1.7.0_79 +1 cc 1m 2s the patch passed +1 javac 1m 2s the patch passed -1 checkstyle 0m 39s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 50, now 50). +1 mvnsite 2m 27s the patch passed +1 mvneclipse 1m 9s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 findbugs 1m 58s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 1 new FindBugs issues. +1 javadoc 2m 30s the patch passed with JDK v1.8.0_66 +1 javadoc 5m 9s the patch passed with JDK v1.7.0_79 +1 unit 0m 32s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. -1 unit 49m 56s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. +1 unit 2m 41s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 67m 51s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_79. -1 unit 49m 44s hadoop-yarn-client in the patch failed with JDK v1.7.0_79. +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.7.0_79. -1 unit 67m 53s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 27s Patch does not generate ASF License warnings. 293m 0s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common   Possible null pointer dereference of null in org.apache.hadoop.yarn.api.records.impl.pb.QueueInfoPBImpl.getPreemptionDisabled() Dereferenced at QueueInfoPBImpl.java:null in org.apache.hadoop.yarn.api.records.impl.pb.QueueInfoPBImpl.getPreemptionDisabled() Dereferenced at QueueInfoPBImpl.java: [line 402] JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups   hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_79 Failed junit tests hadoop.yarn.client.TestGetGroups   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_79 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Client=1.7.0 Server=1.7.0 Image:test-patch-base-hadoop-date2015-11-16 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772552/YARN-4225.001.patch JIRA Issue YARN-4225 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 2c58c10e3c75 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh git revision trunk / 02653ad findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html unit https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_79.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_79.txt https://builds.apache.org/job/PreCommit-YARN-Build/9696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9696/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 228MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9696/console This message was automatically generated.
      Hide
      eepayne Eric Payne added a comment -

      Attaching YARN-4225.002.patch

      I fixed QueueInfoPBImpl#getPreemptionDisabled to return {{true by default instead of {{null}.

      Show
      eepayne Eric Payne added a comment - Attaching YARN-4225 .002.patch I fixed QueueInfoPBImpl#getPreemptionDisabled to return {{true by default instead of {{null}.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 6s docker + precommit patch detected.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
      +1 mvninstall 7m 57s trunk passed
      +1 compile 2m 8s trunk passed with JDK v1.8.0_66
      +1 compile 2m 16s trunk passed with JDK v1.7.0_85
      +1 checkstyle 0m 28s trunk passed
      +1 mvnsite 2m 3s trunk passed
      +1 mvneclipse 0m 53s trunk passed
      -1 findbugs 1m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
      +1 javadoc 1m 52s trunk passed with JDK v1.8.0_66
      +1 javadoc 4m 13s trunk passed with JDK v1.7.0_85
      +1 mvninstall 2m 1s the patch passed
      +1 compile 2m 15s the patch passed with JDK v1.8.0_66
      +1 cc 2m 15s the patch passed
      +1 javac 2m 15s the patch passed
      +1 compile 2m 25s the patch passed with JDK v1.7.0_85
      +1 cc 2m 25s the patch passed
      +1 javac 2m 25s the patch passed
      -1 checkstyle 0m 31s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 50, now 50).
      +1 mvnsite 2m 10s the patch passed
      +1 mvneclipse 0m 58s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      +1 findbugs 5m 35s the patch passed
      +1 javadoc 2m 1s the patch passed with JDK v1.8.0_66
      +1 javadoc 4m 15s the patch passed with JDK v1.7.0_85
      +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
      -1 unit 49m 28s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
      +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
      -1 unit 59m 36s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
      +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
      -1 unit 49m 36s hadoop-yarn-client in the patch failed with JDK v1.7.0_85.
      +1 unit 2m 21s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
      -1 unit 62m 33s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
      +1 asflicense 0m 26s Patch does not generate ASF License warnings.
      277m 16s



      Reason Tests
      JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups
        hadoop.yarn.server.resourcemanager.TestAMAuthorization
        hadoop.yarn.server.resourcemanager.TestClientRMTokens
      JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
        org.apache.hadoop.yarn.client.api.impl.TestYarnClient
        org.apache.hadoop.yarn.client.api.impl.TestNMClient
      JDK v1.7.0_85 Failed junit tests hadoop.yarn.client.TestGetGroups
        hadoop.yarn.server.resourcemanager.TestAMAuthorization
        hadoop.yarn.server.resourcemanager.TestClientRMTokens
      JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
        org.apache.hadoop.yarn.client.api.impl.TestYarnClient
        org.apache.hadoop.yarn.client.api.impl.TestNMClient



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:date2015-11-19
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773125/YARN-4225.002.patch
      JIRA Issue YARN-4225
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
      uname Linux 6bde9731f268 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
      git revision trunk / 23a130a
      findbugs v3.0.0
      findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
      JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9728/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Max memory used 77MB
      Powered by Apache Yetus http://yetus.apache.org
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/9728/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 7m 57s trunk passed +1 compile 2m 8s trunk passed with JDK v1.8.0_66 +1 compile 2m 16s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 28s trunk passed +1 mvnsite 2m 3s trunk passed +1 mvneclipse 0m 53s trunk passed -1 findbugs 1m 23s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 1m 52s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 13s trunk passed with JDK v1.7.0_85 +1 mvninstall 2m 1s the patch passed +1 compile 2m 15s the patch passed with JDK v1.8.0_66 +1 cc 2m 15s the patch passed +1 javac 2m 15s the patch passed +1 compile 2m 25s the patch passed with JDK v1.7.0_85 +1 cc 2m 25s the patch passed +1 javac 2m 25s the patch passed -1 checkstyle 0m 31s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 50, now 50). +1 mvnsite 2m 10s the patch passed +1 mvneclipse 0m 58s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 35s the patch passed +1 javadoc 2m 1s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 15s the patch passed with JDK v1.7.0_85 +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. -1 unit 49m 28s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. +1 unit 2m 1s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 59m 36s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. -1 unit 49m 36s hadoop-yarn-client in the patch failed with JDK v1.7.0_85. +1 unit 2m 21s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. -1 unit 62m 33s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 277m 16s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.client.TestGetGroups   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_85 Failed junit tests hadoop.yarn.client.TestGetGroups   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-19 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773125/YARN-4225.002.patch JIRA Issue YARN-4225 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 6bde9731f268 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 23a130a findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9728/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9728/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 77MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9728/console This message was automatically generated.
      Hide
      eepayne Eric Payne added a comment -

      All of the tests listed in the failure section above work for me in my local build environment.

      Jason Lowe, would you have time to review this patch?

      Show
      eepayne Eric Payne added a comment - All of the tests listed in the failure section above work for me in my local build environment. Jason Lowe , would you have time to review this patch?
      Hide
      jlowe Jason Lowe added a comment -

      Patch looks good overall, with just one minor issue regarding forward compatibility. If a newer client talks to an older ResourceManager then it will report a preemption status when none was provided. This could lead to some confusion when the preemption actually is disabled but the client defaults the missing field to false and reports preemption is enabled. Not sure that is must-fix for this scenario. If it is we'd have to expose something like the hasPreemptionDisabled protobuf method so the client could avoid reporting the value if the server didn't provide it.

      Show
      jlowe Jason Lowe added a comment - Patch looks good overall, with just one minor issue regarding forward compatibility. If a newer client talks to an older ResourceManager then it will report a preemption status when none was provided. This could lead to some confusion when the preemption actually is disabled but the client defaults the missing field to false and reports preemption is enabled. Not sure that is must-fix for this scenario. If it is we'd have to expose something like the hasPreemptionDisabled protobuf method so the client could avoid reporting the value if the server didn't provide it.
      Hide
      eepayne Eric Payne added a comment -

      Jason Lowe, Thanks for reviewing this patch and for your thoughtful comments.

      If I can restate your comment, I think you are suggesting exposing QueueInfoPBImpl#hasPreemptionDisabled and calling it in QueueCLI#printQueueInfo, placing it around the preemption status, similar to the following:

          if (queueInfo.hasPreemptionDisabled()) {
            writer.print("\tPreemption : ");
            writer.println(queueInfo.getPreemptionDisabled() ? "disabled" : "enabled");
          }
      
      Show
      eepayne Eric Payne added a comment - Jason Lowe , Thanks for reviewing this patch and for your thoughtful comments. If I can restate your comment, I think you are suggesting exposing QueueInfoPBImpl#hasPreemptionDisabled and calling it in QueueCLI#printQueueInfo , placing it around the preemption status, similar to the following: if (queueInfo.hasPreemptionDisabled()) { writer.print( "\tPreemption : " ); writer.println(queueInfo.getPreemptionDisabled() ? "disabled" : "enabled" ); }
      Hide
      jlowe Jason Lowe added a comment -

      Yes, I was thinking the client would refrain from reporting on a field it knew wasn't provided. However I think having a getPreemptionDisabled and hasPreemptionDisabled methods exposed outside the protobuf is very confusing – someone might call has when they should be calling get. Maybe a name like "isPreemptionDisabledValid" or something would be more clear.

      Show
      jlowe Jason Lowe added a comment - Yes, I was thinking the client would refrain from reporting on a field it knew wasn't provided. However I think having a getPreemptionDisabled and hasPreemptionDisabled methods exposed outside the protobuf is very confusing – someone might call has when they should be calling get. Maybe a name like "isPreemptionDisabledValid" or something would be more clear.
      Hide
      eepayne Eric Payne added a comment -

      someone might call has when they should be calling get. Maybe a name like "isPreemptionDisabledValid" or something would be more clear

      In order to remove the need for two methods, another alternative would be to have QueueInfoPBImpl#getPreemptionDisabled return a Boolean rather than a native type, and then have it return null if it internally determines that the field is not there.

      So, in QueueCLI#printQueueInfo, the code would look something like this:

          Boolean preemptStatus = queueInfo.getPreemptionDisabled();
          if (preemptStatus != null) {
            writer.print("\tPreemption : ");
            writer.println(preemptStatus ? "disabled" : "enabled");
          }
      

      In General, what is the Hadoop policy when a newer client talks to an older server and the protobuf output is different than expected. Should we expose some form of the has method, or should we overload the get method as I described here?

      I would appreciate any additional feedback from the community in general (Vinod Kumar Vavilapalli, do you have any thoughts?)

      Show
      eepayne Eric Payne added a comment - someone might call has when they should be calling get. Maybe a name like "isPreemptionDisabledValid" or something would be more clear In order to remove the need for two methods, another alternative would be to have QueueInfoPBImpl#getPreemptionDisabled return a Boolean rather than a native type, and then have it return null if it internally determines that the field is not there. So, in QueueCLI#printQueueInfo , the code would look something like this: Boolean preemptStatus = queueInfo.getPreemptionDisabled(); if (preemptStatus != null ) { writer.print( "\tPreemption : " ); writer.println(preemptStatus ? "disabled" : "enabled" ); } In General, what is the Hadoop policy when a newer client talks to an older server and the protobuf output is different than expected. Should we expose some form of the has method, or should we overload the get method as I described here? I would appreciate any additional feedback from the community in general ( Vinod Kumar Vavilapalli , do you have any thoughts?)
      Hide
      eepayne Eric Payne added a comment -

      Attaching YARN-4225.002.patch, which implements getPreemptionDisabled() to return a Boolean, and QueueCLI#printQueueInfo will check for non-null before printing out queue status. Patch applies cleanly to trunk, branch-2, and branch-2.8.

      In General, what is the Hadoop policy when a newer client talks to an older server and the protobuf output is different than expected. Should we expose some form of the has method, or should we overload the get method as I described here?

      I would appreciate any additional feedback from the community in general (Vinod Kumar Vavilapalli, do you have any thoughts?)

      Vinod Kumar Vavilapalli, did you have a chance to think about this? Jason Lowe, do you have any additional thoughts?

      Show
      eepayne Eric Payne added a comment - Attaching YARN-4225 .002.patch , which implements getPreemptionDisabled() to return a Boolean , and QueueCLI#printQueueInfo will check for non-null before printing out queue status. Patch applies cleanly to trunk, branch-2, and branch-2.8. In General, what is the Hadoop policy when a newer client talks to an older server and the protobuf output is different than expected. Should we expose some form of the has method, or should we overload the get method as I described here? I would appreciate any additional feedback from the community in general (Vinod Kumar Vavilapalli, do you have any thoughts?) Vinod Kumar Vavilapalli , did you have a chance to think about this? Jason Lowe , do you have any additional thoughts?
      Hide
      eepayne Eric Payne added a comment -

      Sorry, I mis-named the patch. Should have been YARN-4225.003.patch

      Show
      eepayne Eric Payne added a comment - Sorry, I mis-named the patch. Should have been YARN-4225 .003.patch
      Hide
      leftnoteasy Wangda Tan added a comment -

      Eric Payne,

      Thanks for working on the patch, few comments:

      1)

      public abstract Boolean getPreemptionDisabled();

      Do you think is it better to return boolean? I'd prefer to return a default value (false) instead of return null

      2)
      For QueueCLI, is it better to print "preemption is disabled/enabled" instead of "preemption status: disabled/enabled"?

      3)
      Is it possible to add a simple test to verify end-to-end behavior?

      Show
      leftnoteasy Wangda Tan added a comment - Eric Payne , Thanks for working on the patch, few comments: 1) public abstract Boolean getPreemptionDisabled(); Do you think is it better to return boolean? I'd prefer to return a default value (false) instead of return null 2) For QueueCLI, is it better to print "preemption is disabled/enabled" instead of "preemption status: disabled/enabled"? 3) Is it possible to add a simple test to verify end-to-end behavior?
      Hide
      eepayne Eric Payne added a comment -

      Thanks Wangda Tan, for your helpful comments.

      Do you think is it better to return boolean? I'd prefer to return a default value (false) instead of return null

      This is the nature of the question that I have about the more general Hadoop policy, and which Jason Lowe and I were discussing in the comments above.
      Basically, the use case is a newer client is querying an older server, and so some of the newer protobuf entries that the client expects may not exist. In that case, we have 2 options that I can see:

      1. The client exposes both the get protobuf method and the has protobuf method for the structure in question
      2. We overload the get protobuf method to do the has checking internally and return NULL if the field doesn't exist.
        I actually prefer the second option because it exposes only one method. But, I would like to know the opinion of others and if there is already a precedence for this use case.
      Show
      eepayne Eric Payne added a comment - Thanks Wangda Tan , for your helpful comments. Do you think is it better to return boolean? I'd prefer to return a default value (false) instead of return null This is the nature of the question that I have about the more general Hadoop policy, and which Jason Lowe and I were discussing in the comments above. Basically, the use case is a newer client is querying an older server, and so some of the newer protobuf entries that the client expects may not exist. In that case, we have 2 options that I can see: The client exposes both the get protobuf method and the has protobuf method for the structure in question We overload the get protobuf method to do the has checking internally and return NULL if the field doesn't exist. I actually prefer the second option because it exposes only one method. But, I would like to know the opinion of others and if there is already a precedence for this use case.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 0s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
      +1 mvninstall 7m 58s trunk passed
      +1 compile 2m 0s trunk passed with JDK v1.8.0_66
      +1 compile 2m 22s trunk passed with JDK v1.7.0_85
      +1 checkstyle 0m 29s trunk passed
      +1 mvnsite 2m 4s trunk passed
      +1 mvneclipse 0m 57s trunk passed
      +1 findbugs 4m 45s trunk passed
      +1 javadoc 1m 49s trunk passed with JDK v1.8.0_66
      +1 javadoc 4m 8s trunk passed with JDK v1.7.0_85
      +1 mvninstall 1m 57s the patch passed
      +1 compile 2m 5s the patch passed with JDK v1.8.0_66
      +1 cc 2m 5s the patch passed
      +1 javac 2m 5s the patch passed
      +1 compile 2m 18s the patch passed with JDK v1.7.0_85
      +1 cc 2m 18s the patch passed
      +1 javac 2m 18s the patch passed
      -1 checkstyle 0m 29s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 50, now 50).
      +1 mvnsite 2m 6s the patch passed
      +1 mvneclipse 0m 54s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      -1 findbugs 1m 34s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 1 new FindBugs issues.
      +1 javadoc 1m 51s the patch passed with JDK v1.8.0_66
      +1 javadoc 4m 9s the patch passed with JDK v1.7.0_85
      +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
      +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
      -1 unit 64m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
      -1 unit 49m 30s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
      +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_85.
      +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
      -1 unit 65m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85.
      -1 unit 49m 46s hadoop-yarn-client in the patch failed with JDK v1.7.0_85.
      +1 asflicense 0m 25s Patch does not generate ASF License warnings.
      284m 35s



      Reason Tests
      FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        org.apache.hadoop.yarn.api.records.impl.pb.QueueInfoPBImpl.getPreemptionDisabled() has Boolean return type and returns explicit null At QueueInfoPBImpl.java:and returns explicit null At QueueInfoPBImpl.java:[line 402]
      JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization
        hadoop.yarn.client.TestGetGroups
      JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
        org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
        org.apache.hadoop.yarn.client.api.impl.TestNMClient
      JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization
        hadoop.yarn.client.TestGetGroups
      JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient
        org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
        org.apache.hadoop.yarn.client.api.impl.TestNMClient



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:0ca8df7
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775348/YARN-4225.003.patch
      JIRA Issue YARN-4225
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
      uname Linux 751a85dd6bcf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 53e3bf7
      findbugs v3.0.0
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt
      JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9842/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Max memory used 76MB
      Powered by Apache Yetus http://yetus.apache.org
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/9842/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 7m 58s trunk passed +1 compile 2m 0s trunk passed with JDK v1.8.0_66 +1 compile 2m 22s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 29s trunk passed +1 mvnsite 2m 4s trunk passed +1 mvneclipse 0m 57s trunk passed +1 findbugs 4m 45s trunk passed +1 javadoc 1m 49s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 8s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 57s the patch passed +1 compile 2m 5s the patch passed with JDK v1.8.0_66 +1 cc 2m 5s the patch passed +1 javac 2m 5s the patch passed +1 compile 2m 18s the patch passed with JDK v1.7.0_85 +1 cc 2m 18s the patch passed +1 javac 2m 18s the patch passed -1 checkstyle 0m 29s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 50, now 50). +1 mvnsite 2m 6s the patch passed +1 mvneclipse 0m 54s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 1m 34s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 1 new FindBugs issues. +1 javadoc 1m 51s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 9s the patch passed with JDK v1.7.0_85 +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 64m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 49m 30s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.7.0_85. +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. -1 unit 65m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_85. -1 unit 49m 46s hadoop-yarn-client in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 284m 35s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common   org.apache.hadoop.yarn.api.records.impl.pb.QueueInfoPBImpl.getPreemptionDisabled() has Boolean return type and returns explicit null At QueueInfoPBImpl.java:and returns explicit null At QueueInfoPBImpl.java: [line 402] JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_85 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775348/YARN-4225.003.patch JIRA Issue YARN-4225 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 751a85dd6bcf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 53e3bf7 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html unit https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_85.txt https://builds.apache.org/job/PreCommit-YARN-Build/9842/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9842/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9842/console This message was automatically generated.
      Hide
      leftnoteasy Wangda Tan added a comment -

      Thanks Eric Payne,

      The use case is a newer client is querying an older server...

      I'm wondering if this is a valid use case: IMHO, rolling upgrade should be always server-first. If we plan support newer client talks to older server, we may experience many issues AND we need to add this to Hadoop's code compatibility policy.

      Show
      leftnoteasy Wangda Tan added a comment - Thanks Eric Payne , The use case is a newer client is querying an older server... I'm wondering if this is a valid use case: IMHO, rolling upgrade should be always server-first. If we plan support newer client talks to older server, we may experience many issues AND we need to add this to Hadoop's code compatibility policy.
      Hide
      jlowe Jason Lowe added a comment -

      With deployments of multiple clusters it's easy to get into situations where newer clients end up talking to older clusters. Clusters are rarely upgraded at the same time, and remote access of one cluster for a job's input is not rare at least in our setups. That's a perfect example of a newer client talking to an older server. It may not be officially supported, but it's not going to be a rare occurrence (for HDFS, at least).

      For this specific case I think the need for the feature would be rare, hence my hedging about whether we really need it. It's not that the new client completely breaks talking to the older server, it just would be capable of returning misleading information about the preemption status. I'm OK if we decide this scenario isn't worth supporting. (It's not hard to do so, just tedious and a bit messy with the API.) But in general there will be cases where breaking compatibility between a newer client and an older server is going to be problematic even if it isn't officially supported because of the multiple cluster scenarios.

      Show
      jlowe Jason Lowe added a comment - With deployments of multiple clusters it's easy to get into situations where newer clients end up talking to older clusters. Clusters are rarely upgraded at the same time, and remote access of one cluster for a job's input is not rare at least in our setups. That's a perfect example of a newer client talking to an older server. It may not be officially supported, but it's not going to be a rare occurrence (for HDFS, at least). For this specific case I think the need for the feature would be rare, hence my hedging about whether we really need it. It's not that the new client completely breaks talking to the older server, it just would be capable of returning misleading information about the preemption status. I'm OK if we decide this scenario isn't worth supporting. (It's not hard to do so, just tedious and a bit messy with the API.) But in general there will be cases where breaking compatibility between a newer client and an older server is going to be problematic even if it isn't officially supported because of the multiple cluster scenarios.
      Hide
      leftnoteasy Wangda Tan added a comment -

      Thanks Jason Lowe, I can understand the issue now.

      I'm OK with both approach - existing one in latest patch or simply return false if there's no such field in proto.

      Show
      leftnoteasy Wangda Tan added a comment - Thanks Jason Lowe , I can understand the issue now. I'm OK with both approach - existing one in latest patch or simply return false if there's no such field in proto.
      Hide
      eepayne Eric Payne added a comment -

      Thanks very much Wangda Tan, for your review and helpful comments.

      I'm OK with both approach - existing one in latest patch or simply return false if there's no such field in proto.

      So, if I understand correctly, you are okay with QueueInfo#getPreemptionDisabled returning Boolean with the possibility of returning null if the field doesn't exist. With that understanding, I'm leaving that in the latest patch.

      2) For QueueCLI, is it better to print "preemption is disabled/enabled" instead of "preemption status: disabled/enabled"?

      Actually, I think that leaving it as "Preemption : disabled/enabled" is more consistent with the way the other properties are displayed. What do you think?

      3) Is it possible to add a simple test to verify end-to-end behavior?

      I added a couple of tests to TestYarnCLI. Good suggestion.

      Show
      eepayne Eric Payne added a comment - Thanks very much Wangda Tan , for your review and helpful comments. I'm OK with both approach - existing one in latest patch or simply return false if there's no such field in proto. So, if I understand correctly, you are okay with QueueInfo#getPreemptionDisabled returning Boolean with the possibility of returning null if the field doesn't exist. With that understanding, I'm leaving that in the latest patch. 2) For QueueCLI, is it better to print "preemption is disabled/enabled" instead of "preemption status: disabled/enabled"? Actually, I think that leaving it as "Preemption : disabled/enabled" is more consistent with the way the other properties are displayed. What do you think? 3) Is it possible to add a simple test to verify end-to-end behavior? I added a couple of tests to TestYarnCLI . Good suggestion.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 0s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
      +1 mvninstall 7m 40s trunk passed
      +1 compile 1m 52s trunk passed with JDK v1.8.0_66
      +1 compile 2m 6s trunk passed with JDK v1.7.0_91
      +1 checkstyle 0m 26s trunk passed
      +1 mvnsite 2m 0s trunk passed
      +1 mvneclipse 0m 52s trunk passed
      +1 findbugs 4m 26s trunk passed
      -1 javadoc 0m 25s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66.
      +1 javadoc 4m 0s trunk passed with JDK v1.7.0_91
      +1 mvninstall 1m 51s the patch passed
      +1 compile 1m 53s the patch passed with JDK v1.8.0_66
      +1 cc 1m 53s the patch passed
      +1 javac 1m 53s the patch passed
      +1 compile 2m 10s the patch passed with JDK v1.7.0_91
      +1 cc 2m 10s the patch passed
      +1 javac 2m 10s the patch passed
      -1 checkstyle 0m 28s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 50, now 50).
      +1 mvnsite 1m 59s the patch passed
      +1 mvneclipse 0m 52s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      -1 findbugs 1m 40s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 1 new FindBugs issues.
      -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
      +1 javadoc 4m 2s the patch passed with JDK v1.7.0_91
      +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
      +1 unit 2m 3s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
      -1 unit 60m 3s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
      -1 unit 64m 22s hadoop-yarn-client in the patch failed with JDK v1.8.0_66.
      +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
      +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
      -1 unit 60m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
      -1 unit 64m 30s hadoop-yarn-client in the patch failed with JDK v1.7.0_91.
      +1 asflicense 0m 28s Patch does not generate ASF License warnings.
      313m 17s



      Reason Tests
      FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
        org.apache.hadoop.yarn.api.records.impl.pb.QueueInfoPBImpl.getPreemptionDisabled() has Boolean return type and returns explicit null At QueueInfoPBImpl.java:and returns explicit null At QueueInfoPBImpl.java:[line 402]
      JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization
        hadoop.yarn.client.TestGetGroups
      JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
        org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
        org.apache.hadoop.yarn.client.api.impl.TestYarnClient
        org.apache.hadoop.yarn.client.api.impl.TestNMClient
      JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
        hadoop.yarn.server.resourcemanager.TestAMAuthorization
        hadoop.yarn.client.TestGetGroups
      JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
        org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
        org.apache.hadoop.yarn.client.api.impl.TestYarnClient
        org.apache.hadoop.yarn.client.api.impl.TestNMClient



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:0ca8df7
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776436/YARN-4225.004.patch
      JIRA Issue YARN-4225
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
      uname Linux 48cbb2d33ebc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 7e47151
      findbugs v3.0.0
      javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html
      javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt
      JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9906/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Max memory used 75MB
      Powered by Apache Yetus http://yetus.apache.org
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/9906/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 7m 40s trunk passed +1 compile 1m 52s trunk passed with JDK v1.8.0_66 +1 compile 2m 6s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 26s trunk passed +1 mvnsite 2m 0s trunk passed +1 mvneclipse 0m 52s trunk passed +1 findbugs 4m 26s trunk passed -1 javadoc 0m 25s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66. +1 javadoc 4m 0s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 51s the patch passed +1 compile 1m 53s the patch passed with JDK v1.8.0_66 +1 cc 1m 53s the patch passed +1 javac 1m 53s the patch passed +1 compile 2m 10s the patch passed with JDK v1.7.0_91 +1 cc 2m 10s the patch passed +1 javac 2m 10s the patch passed -1 checkstyle 0m 28s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 50, now 50). +1 mvnsite 1m 59s the patch passed +1 mvneclipse 0m 52s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 1m 40s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common introduced 1 new FindBugs issues. -1 javadoc 0m 24s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 javadoc 4m 2s the patch passed with JDK v1.7.0_91 +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. +1 unit 2m 3s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 60m 3s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 64m 22s hadoop-yarn-client in the patch failed with JDK v1.8.0_66. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. -1 unit 60m 20s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 64m 30s hadoop-yarn-client in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 313m 17s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common   org.apache.hadoop.yarn.api.records.impl.pb.QueueInfoPBImpl.getPreemptionDisabled() has Boolean return type and returns explicit null At QueueInfoPBImpl.java:and returns explicit null At QueueInfoPBImpl.java: [line 402] JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.TestGetGroups JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776436/YARN-4225.004.patch JIRA Issue YARN-4225 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 48cbb2d33ebc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7e47151 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/9906/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9906/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9906/console This message was automatically generated.
      Hide
      eepayne Eric Payne added a comment -

      I'd like to address the issues raised by the above pre-commit build:

      • Unit Tests: The following unit tests failed during the above pre-commit build, but they all pass for me in my local build environment:
      Test Name Modified by this patch Pre-commit failure
      hadoop.yarn.client.api.impl.TestAMRMClient No Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
      hadoop.yarn.client.api.impl.TestNMClient No Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
      hadoop.yarn.client.api.impl.TestYarnClient No TEST TIMED OUT
      hadoop.yarn.client.cli.TestYarnCLI Yes Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
      hadoop.yarn.client.TestGetGroups No java.net.UnknownHostException: Invalid host name: local host is: (unknown); destination host is: "48cbb2d33ebc":8033; java.net.UnknownHostException
      hadoop.yarn.server.resourcemanager.TestAMAuthorization No java.net.UnknownHostException: Invalid host name: local host is: (unknown); destination host is: "48cbb2d33ebc":8030; java.net.UnknownHostException
      hadoop.yarn.server.resourcemanager.TestClientRMTokens No java.lang.NullPointerException:
      • Findbugs warnings:
        org.apache.hadoop.yarn.api.records.impl.pb.QueueInfoPBImpl.getPreemptionDisabled() has Boolean return type and returns explicit null At QueueInfoPBImpl.java:and returns explicit null At QueueInfoPBImpl.java:[line 402]
        This is a result of QueueInfo#getPreemptionDisabled returning a Boolean. Again, we could expose the hasPreemptionDisabled method and use that instead.
      • JavaDocs warnings/failures: I don't think these are caused by this patch:
        [WARNING] The requested profile "docs" could not be activated because it does not exist.
        [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8.1:javadoc (default-cli) on project hadoop-yarn-server-resourcemanager: An error has occurred in JavaDocs report generation:
        ...
      Show
      eepayne Eric Payne added a comment - I'd like to address the issues raised by the above pre-commit build: Unit Tests: The following unit tests failed during the above pre-commit build, but they all pass for me in my local build environment: Test Name Modified by this patch Pre-commit failure hadoop.yarn.client.api.impl.TestAMRMClient No Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 hadoop.yarn.client.api.impl.TestNMClient No Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 hadoop.yarn.client.api.impl.TestYarnClient No TEST TIMED OUT hadoop.yarn.client.cli.TestYarnCLI Yes Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 hadoop.yarn.client.TestGetGroups No java.net.UnknownHostException: Invalid host name: local host is: (unknown); destination host is: "48cbb2d33ebc":8033; java.net.UnknownHostException hadoop.yarn.server.resourcemanager.TestAMAuthorization No java.net.UnknownHostException: Invalid host name: local host is: (unknown); destination host is: "48cbb2d33ebc":8030; java.net.UnknownHostException hadoop.yarn.server.resourcemanager.TestClientRMTokens No java.lang.NullPointerException: Findbugs warnings: org.apache.hadoop.yarn.api.records.impl.pb.QueueInfoPBImpl.getPreemptionDisabled() has Boolean return type and returns explicit null At QueueInfoPBImpl.java:and returns explicit null At QueueInfoPBImpl.java: [line 402] This is a result of QueueInfo#getPreemptionDisabled returning a Boolean. Again, we could expose the hasPreemptionDisabled method and use that instead. JavaDocs warnings/failures: I don't think these are caused by this patch: [WARNING] The requested profile "docs" could not be activated because it does not exist. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8.1:javadoc (default-cli) on project hadoop-yarn-server-resourcemanager: An error has occurred in JavaDocs report generation: ...
      Hide
      leftnoteasy Wangda Tan added a comment -

      Hi Eric Payne,
      Patch looks good, could you mark the findbugs warning needs to be skipped?

      Show
      leftnoteasy Wangda Tan added a comment - Hi Eric Payne , Patch looks good, could you mark the findbugs warning needs to be skipped?
      Hide
      eepayne Eric Payne added a comment -

      Patch looks good, could you mark the findbugs warning needs to be skipped?

      Thanks a lot, Wangda Tan. Attaching YARN-4225.005.patch with findbugs suppressed for org.apache.hadoop.yarn.api.records.impl.pb: NP_BOOLEAN_RETURN_NULL

      Show
      eepayne Eric Payne added a comment - Patch looks good, could you mark the findbugs warning needs to be skipped? Thanks a lot, Wangda Tan . Attaching YARN-4225 .005.patch with findbugs suppressed for org.apache.hadoop.yarn.api.records.impl.pb: NP_BOOLEAN_RETURN_NULL
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 0s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
      +1 mvninstall 8m 29s trunk passed
      +1 compile 2m 17s trunk passed with JDK v1.8.0_66
      +1 compile 2m 25s trunk passed with JDK v1.7.0_91
      +1 checkstyle 0m 31s trunk passed
      +1 mvnsite 2m 58s trunk passed
      +1 mvneclipse 0m 21s trunk passed
      -1 findbugs 7m 3s branch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml)
      +1 javadoc 1m 58s trunk passed with JDK v1.8.0_66
      +1 javadoc 4m 28s trunk passed with JDK v1.7.0_91
      +1 mvninstall 2m 18s the patch passed
      +1 compile 2m 8s the patch passed with JDK v1.8.0_66
      +1 cc 2m 8s the patch passed
      +1 javac 2m 8s the patch passed
      +1 compile 2m 20s the patch passed with JDK v1.7.0_91
      +1 cc 2m 20s the patch passed
      +1 javac 2m 20s the patch passed
      -1 checkstyle 0m 28s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 50, now 50).
      +1 mvnsite 2m 57s the patch passed
      +1 mvneclipse 0m 22s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      +1 xml 0m 1s The patch has no ill-formed XML file.
      -1 findbugs 7m 19s patch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml)
      +1 javadoc 2m 11s the patch passed with JDK v1.8.0_66
      +1 javadoc 4m 48s the patch passed with JDK v1.7.0_91
      -1 unit 39m 0s hadoop-yarn in the patch failed with JDK v1.8.0_66.
      -1 unit 2m 36s hadoop-yarn in the patch failed with JDK v1.7.0_91.
      +1 asflicense 0m 22s Patch does not generate ASF License warnings.
      98m 35s



      Reason Tests
      JDK v1.7.0_91 Failed junit tests hadoop.yarn.event.TestAsyncDispatcher



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:0ca8df7
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777511/YARN-4225.005.patch
      JIRA Issue YARN-4225
      Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle cc
      uname Linux 7a34bd3f7175 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 7fb212e
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9968/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9968/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/9968/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
      unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9968/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
      JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9968/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Max memory used 29MB
      Powered by Apache Yetus 0.1.0 http://yetus.apache.org
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/9968/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 8m 29s trunk passed +1 compile 2m 17s trunk passed with JDK v1.8.0_66 +1 compile 2m 25s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 31s trunk passed +1 mvnsite 2m 58s trunk passed +1 mvneclipse 0m 21s trunk passed -1 findbugs 7m 3s branch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml) +1 javadoc 1m 58s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 28s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 18s the patch passed +1 compile 2m 8s the patch passed with JDK v1.8.0_66 +1 cc 2m 8s the patch passed +1 javac 2m 8s the patch passed +1 compile 2m 20s the patch passed with JDK v1.7.0_91 +1 cc 2m 20s the patch passed +1 javac 2m 20s the patch passed -1 checkstyle 0m 28s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 50, now 50). +1 mvnsite 2m 57s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 findbugs 7m 19s patch/hadoop-yarn-project/hadoop-yarn no findbugs output file (hadoop-yarn-project/hadoop-yarn/target/findbugsXml.xml) +1 javadoc 2m 11s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 48s the patch passed with JDK v1.7.0_91 -1 unit 39m 0s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 2m 36s hadoop-yarn in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 98m 35s Reason Tests JDK v1.7.0_91 Failed junit tests hadoop.yarn.event.TestAsyncDispatcher Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777511/YARN-4225.005.patch JIRA Issue YARN-4225 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle cc uname Linux 7a34bd3f7175 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7fb212e checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9968/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9968/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/9968/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9968/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9968/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 29MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9968/console This message was automatically generated.
      Hide
      leftnoteasy Wangda Tan added a comment -

      Thanks Eric Payne for update.

      Could you check findbugs warning in latest Jenkins run is related or not? There's no link to findbugs result in latest Jenkins report, so I guess it's not related.

      Show
      leftnoteasy Wangda Tan added a comment - Thanks Eric Payne for update. Could you check findbugs warning in latest Jenkins run is related or not? There's no link to findbugs result in latest Jenkins report, so I guess it's not related.
      Hide
      eepayne Eric Payne added a comment -

      Could you check findbugs warning in latest Jenkins run is related or not? There's no link to findbugs result in latest Jenkins report, so I guess it's not related.

      Wangda Tan, is there something wrong with this build? I can get to https://builds.apache.org/job/PreCommit-YARN-Build/9968, but many of the other links work in the comment above. For example, https://builds.apache.org/job/PreCommit-YARN-Build/9968/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt gets 404. I tried to get to the artifacts page, but that comes up 404 also.

      I didn't find any findbugs report.

      Show
      eepayne Eric Payne added a comment - Could you check findbugs warning in latest Jenkins run is related or not? There's no link to findbugs result in latest Jenkins report, so I guess it's not related. Wangda Tan , is there something wrong with this build? I can get to https://builds.apache.org/job/PreCommit-YARN-Build/9968 , but many of the other links work in the comment above. For example, https://builds.apache.org/job/PreCommit-YARN-Build/9968/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt gets 404. I tried to get to the artifacts page, but that comes up 404 also. I didn't find any findbugs report.
      Hide
      leftnoteasy Wangda Tan added a comment -

      Thanks Eric Payne for clarification. Latest patch LGTM, +1.

      Show
      leftnoteasy Wangda Tan added a comment - Thanks Eric Payne for clarification. Latest patch LGTM, +1.
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-trunk-Commit #8978 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8978/)
      YARN-4225. Add preemption status to yarn queue -status for capacity (wangda: rev 7faa406f27f687844c941346f59a27a375af3233)

      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto
      • hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestSchedulerApplicationAttempt.java
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/QueueInfo.java
      • hadoop-yarn-project/CHANGES.txt
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/QueueCLI.java
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/QueueInfoPBImpl.java
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java
      • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/ProtocolHATestBase.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8978 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8978/ ) YARN-4225 . Add preemption status to yarn queue -status for capacity (wangda: rev 7faa406f27f687844c941346f59a27a375af3233) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_protos.proto hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestSchedulerApplicationAttempt.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/QueueInfo.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/QueueCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/QueueInfoPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/TestPBImplRecords.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/ProtocolHATestBase.java
      Hide
      eepayne Eric Payne added a comment -

      Thanks a lot, Wangda Tan

      Show
      eepayne Eric Payne added a comment - Thanks a lot, Wangda Tan
      Hide
      eepayne Eric Payne added a comment -

      Oh, one more thing, Wangda Tan. I ran testpatch in my own build environment and it gave a +1 for the findbugs, so the above must be a glitch in the Apache pre-commit build .

      Show
      eepayne Eric Payne added a comment - Oh, one more thing, Wangda Tan . I ran testpatch in my own build environment and it gave a +1 for the findbugs, so the above must be a glitch in the Apache pre-commit build .
      Hide
      leftnoteasy Wangda Tan added a comment -

      Committed to trunk/branch-2, thanks Eric Payne and thanks Jason Lowe for reviews!

      Show
      leftnoteasy Wangda Tan added a comment - Committed to trunk/branch-2, thanks Eric Payne and thanks Jason Lowe for reviews!
      Hide
      leftnoteasy Wangda Tan added a comment -

      Committed to branch-2.8.

      Show
      leftnoteasy Wangda Tan added a comment - Committed to branch-2.8.

        People

        • Assignee:
          eepayne Eric Payne
          Reporter:
          eepayne Eric Payne
        • Votes:
          0 Vote for this issue
          Watchers:
          11 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development