Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4188

MoveApplicationAcrossQueuesResponse should be an abstract class

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: resourcemanager
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MoveApplicationAcrossQueuesResponse should be an abstract class. Additionally the new instance should have a static modifier. Currently we are not facing any issues because the response is empty object on success.

      1. YARN-4188.v0.patch
        1 kB
        Giovanni Matteo Fumarola

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2339 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2339/)
        YARN-4188. Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2339 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2339/ ) YARN-4188 . Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #401 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/401/)
        YARN-4188. Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #401 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/401/ ) YARN-4188 . Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2366 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2366/)
        YARN-4188. Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2366 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2366/ ) YARN-4188 . Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1160 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1160/)
        YARN-4188. Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1160 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1160/ ) YARN-4188 . Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #428 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/428/)
        YARN-4188. Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #428 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/428/ ) YARN-4188 . Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #420 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/420/)
        YARN-4188. Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #420 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/420/ ) YARN-4188 . Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8496 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8496/)
        YARN-4188. Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8496 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8496/ ) YARN-4188 . Make MoveApplicationAcrossQueues abstract, newInstance static (cdouglas: rev 8e01b0d97ac3d74b049a801dfa1cc6e77d8f680a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/MoveApplicationAcrossQueuesResponse.java hadoop-yarn-project/CHANGES.txt
        Hide
        chris.douglas Chris Douglas added a comment -

        +1 I committed this

        Thanks Gio

        Show
        chris.douglas Chris Douglas added a comment - +1 I committed this Thanks Gio
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 19m 13s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 54s There were no new javac warning messages.
        +1 javadoc 11m 2s There were no new javadoc warning messages.
        +1 release audit 0m 31s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 13s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 49s mvn install still works.
        +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse.
        +1 findbugs 1m 46s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 0m 26s Tests passed in hadoop-yarn-api.
            44m 37s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12761462/YARN-4188.v0.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / c9cb6a5
        hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9231/artifact/patchprocess/testrun_hadoop-yarn-api.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9231/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9231/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 13s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 54s There were no new javac warning messages. +1 javadoc 11m 2s There were no new javadoc warning messages. +1 release audit 0m 31s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 13s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 49s mvn install still works. +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse. +1 findbugs 1m 46s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 26s Tests passed in hadoop-yarn-api.     44m 37s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761462/YARN-4188.v0.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c9cb6a5 hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/9231/artifact/patchprocess/testrun_hadoop-yarn-api.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9231/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9231/console This message was automatically generated.
        Hide
        giovanni.fumarola Giovanni Matteo Fumarola added a comment -

        No test needed

        Show
        giovanni.fumarola Giovanni Matteo Fumarola added a comment - No test needed

          People

          • Assignee:
            giovanni.fumarola Giovanni Matteo Fumarola
            Reporter:
            giovanni.fumarola Giovanni Matteo Fumarola
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development