[YARN-4158] Remove duplicate close for LogWriter in AppLogAggregatorImpl#uploadLogsForContainers

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: 2.8.0, 2.7.2, 3.0.0-alpha1
• Component/s: nodemanager
• Labels: cleanup
• Hadoop Flags: Reviewed
• Assignee: Zhihai Xu
• Reporter: Zhihai Xu
• Created: 15/Sep/15 07:05
• Updated: 06/Jan/17 01:54
• Resolved: 15/Sep/15 20:24

Description

Remove duplicate close for LogWriter in AppLogAggregatorImpl#uploadLogsForContainers
writer.close() was called twice in uploadLogsForContainers. One is called at the middle of the function and the other one is called at finally block. It will be better to just close writer once. Also LogWriter didn't implement java.io.Closeable interface. So we can't suppose LogWriter.close is idempotent.