Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4158

Remove duplicate close for LogWriter in AppLogAggregatorImpl#uploadLogsForContainers

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Remove duplicate close for LogWriter in AppLogAggregatorImpl#uploadLogsForContainers
      writer.close() was called twice in uploadLogsForContainers. One is called at the middle of the function and the other one is called at finally block. It will be better to just close writer once. Also LogWriter didn't implement java.io.Closeable interface. So we can't suppose LogWriter.close is idempotent.

        Attachments

          Activity

            People

            • Assignee:
              zxu zhihai xu
              Reporter:
              zxu zhihai xu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: