Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-1963 Support priorities across applications within the same queue
  3. YARN-4141

Runtime Application Priority change should not throw exception for applications at finishing states

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: resourcemanager
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As suggested by Jason Lowe in MAPREDUCE-5870-comment , its good that if YARN can suppress exceptions during change application priority calls for applications at its finishing stages.
      Currently it will be difficult for clients to handle this. This will be similar to kill application behavior.

      1. 0001-YARN-4141.patch
        6 kB
        Sunil G
      2. 0002-YARN-4141.patch
        7 kB
        Sunil G
      3. 0003-YARN-4141.patch
        7 kB
        Sunil G
      4. 0004-YARN-4141.patch
        7 kB
        Sunil G
      5. 0005-YARN-4141.patch
        7 kB
        Sunil G
      6. 0006-YARN-4141.patch
        7 kB
        Sunil G
      7. 0007-YARN-4141.patch
        7 kB
        Sunil G

        Activity

        Hide
        sunilg Sunil G added a comment -

        Uploading an initial version of patch.

        Show
        sunilg Sunil G added a comment - Uploading an initial version of patch.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 19m 36s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 10m 40s There were no new javac warning messages.
        +1 javadoc 12m 1s There were no new javadoc warning messages.
        +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 9s The applied patch generated 1 new checkstyle issues (total was 33, now 34).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 47s mvn install still works.
        +1 eclipse:eclipse 0m 39s The patch built with eclipse:eclipse.
        +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 55m 30s Tests failed in hadoop-yarn-server-resourcemanager.
            103m 44s  



        Reason Tests
        Timed out tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebApp



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12754972/0001-YARN-4141.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 4014ce5
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9067/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9067/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9067/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9067/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 36s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 10m 40s There were no new javac warning messages. +1 javadoc 12m 1s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 9s The applied patch generated 1 new checkstyle issues (total was 33, now 34). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 47s mvn install still works. +1 eclipse:eclipse 0m 39s The patch built with eclipse:eclipse. +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 55m 30s Tests failed in hadoop-yarn-server-resourcemanager.     103m 44s   Reason Tests Timed out tests org.apache.hadoop.yarn.server.resourcemanager.webapp.TestRMWebApp Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754972/0001-YARN-4141.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4014ce5 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9067/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9067/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9067/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9067/console This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Thanks Sunil G for the patch..
        nit :

        1. UpdateApplicationPriorityResponse can be created once and used. Now, 2 times repsonse object is created separately.
          +        UpdateApplicationPriorityResponse response = recordFactory
          +            .newRecordInstance(UpdateApplicationPriorityResponse.class);
          +        return response;
          
        2. Audit logger is logged as failure. I feel log level would be Success instead of failure. Any thoughts?
          RMAuditLogger.logFailure(
          +            callerUGI.getShortUserName(),
          +            AuditConstants.UPDATE_APP_PRIORITY,
          +            "UNKNOWN",
          +            "ClientRMService",
          +            "Skip update application priority, as app is in "
          +                + application.getState());
          
        Show
        rohithsharma Rohith Sharma K S added a comment - Thanks Sunil G for the patch.. nit : UpdateApplicationPriorityResponse can be created once and used. Now, 2 times repsonse object is created separately. + UpdateApplicationPriorityResponse response = recordFactory + .newRecordInstance(UpdateApplicationPriorityResponse.class); + return response; Audit logger is logged as failure. I feel log level would be Success instead of failure. Any thoughts? RMAuditLogger.logFailure( + callerUGI.getShortUserName(), + AuditConstants.UPDATE_APP_PRIORITY, + "UNKNOWN", + "ClientRMService", + "Skip update application priority, as app is in " + + application.getState());
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Marked as subtask of YARN-1963

        Show
        rohithsharma Rohith Sharma K S added a comment - Marked as subtask of YARN-1963
        Hide
        sunilg Sunil G added a comment -

        HI Rohith Sharma K S
        Thank you for the comments. I have one input for second comment.
        As we are not updating priority here, its not success, correct?. Hence I put as failure.

        How do u feel?

        Show
        sunilg Sunil G added a comment - HI Rohith Sharma K S Thank you for the comments. I have one input for second comment. As we are not updating priority here, its not success, correct?. Hence I put as failure. How do u feel?
        Hide
        sunilg Sunil G added a comment -

        Meantime, attaching a new patch by addressing point 1. We will wait for input for point 2.

        Show
        sunilg Sunil G added a comment - Meantime, attaching a new patch by addressing point 1. We will wait for input for point 2.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 3s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 53s There were no new javac warning messages.
        +1 javadoc 10m 7s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 50s The applied patch generated 1 new checkstyle issues (total was 33, now 34).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 30s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 54m 37s Tests passed in hadoop-yarn-server-resourcemanager.
            94m 31s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12755171/0002-YARN-4141.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7766610
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9078/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9078/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9078/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9078/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 3s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 53s There were no new javac warning messages. +1 javadoc 10m 7s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 50s The applied patch generated 1 new checkstyle issues (total was 33, now 34). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 54m 37s Tests passed in hadoop-yarn-server-resourcemanager.     94m 31s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755171/0002-YARN-4141.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7766610 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9078/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9078/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9078/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9078/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        HI Rohith Sharma K S

        As we are not updating priority if app is in final states, I feel action is not success from user point of view. Because if user tries to verify the priority from server side, it will be still old value. Also in RMAuditLogger.logSuccess, we cannot supply any useful messages such as "priority change is skipped since app is in final states". Hence I thought we can print logFailure for now. How do you feel? cc/Jian He

        Show
        sunilg Sunil G added a comment - HI Rohith Sharma K S As we are not updating priority if app is in final states, I feel action is not success from user point of view. Because if user tries to verify the priority from server side, it will be still old value. Also in RMAuditLogger.logSuccess , we cannot supply any useful messages such as "priority change is skipped since app is in final states". Hence I thought we can print logFailure for now. How do you feel? cc/ Jian He
        Hide
        jlowe Jason Lowe added a comment -

        When the user tries to verify the priority they will get an app report showing the job is in a terminal state which will explain why the priority isn't updated. This is akin to killing an application that already completed. We don't retroactively mark it as killed, and we also don't report an error to the user when they tried to kill the terminated application.

        Show
        jlowe Jason Lowe added a comment - When the user tries to verify the priority they will get an app report showing the job is in a terminal state which will explain why the priority isn't updated. This is akin to killing an application that already completed. We don't retroactively mark it as killed, and we also don't report an error to the user when they tried to kill the terminated application.
        Hide
        sunilg Sunil G added a comment -

        Thank you Jason Lowe for sharing the comments.
        Yes. I understood the case as in comparison with kill operation. The app will be finished when user checks reports again. so its fine there.

        Attaching patch by addressing this point.

        Show
        sunilg Sunil G added a comment - Thank you Jason Lowe for sharing the comments. Yes. I understood the case as in comparison with kill operation. The app will be finished when user checks reports again. so its fine there. Attaching patch by addressing this point.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 55s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 53s There were no new javac warning messages.
        +1 javadoc 9m 58s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 30s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 29s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 53m 42s Tests failed in hadoop-yarn-server-resourcemanager.
            91m 57s  



        Reason Tests
        Failed unit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps
          hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService
          hadoop.yarn.server.resourcemanager.monitor.TestSchedulingMonitor



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12755752/0003-YARN-4141.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 6955771
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9126/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9126/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9126/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 55s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 53s There were no new javac warning messages. +1 javadoc 9m 58s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 30s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 53m 42s Tests failed in hadoop-yarn-server-resourcemanager.     91m 57s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesApps   hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService   hadoop.yarn.server.resourcemanager.monitor.TestSchedulingMonitor Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12755752/0003-YARN-4141.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6955771 hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9126/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9126/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9126/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        These failed tests are passing locally.

        Show
        sunilg Sunil G added a comment - These failed tests are passing locally.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        +1 for the latest patch.. Will commit it tomorrow if no more comments..

        Show
        rohithsharma Rohith Sharma K S added a comment - +1 for the latest patch.. Will commit it tomorrow if no more comments..
        Hide
        jlowe Jason Lowe added a comment -

        It looks like the latest patch will still throw an exception if the app is in the FINAL_SAVING state. So if an app just unregistered and is trying to store the final state I think the patch will still throw an exception when trying to change the priority. Rather than checking if the app final state is stored, would it make more sense to explicitly check for the app state in the enum set of FINAL_SAVING, FINISHING, FINISHED, FAILED, KILLING, or KILLED states and silently skip priority setting for those states?

        Nit: "state cannot be update priority" should be "state cannot update priority"

        Show
        jlowe Jason Lowe added a comment - It looks like the latest patch will still throw an exception if the app is in the FINAL_SAVING state. So if an app just unregistered and is trying to store the final state I think the patch will still throw an exception when trying to change the priority. Rather than checking if the app final state is stored, would it make more sense to explicitly check for the app state in the enum set of FINAL_SAVING, FINISHING, FINISHED, FAILED, KILLING, or KILLED states and silently skip priority setting for those states? Nit: "state cannot be update priority" should be "state cannot update priority"
        Hide
        sunilg Sunil G added a comment -

        Yes Jason Lowe. Thank you. FINAL_SAVING and KILLING also to be handled here. Updating the patch as per comments.

        Show
        sunilg Sunil G added a comment - Yes Jason Lowe . Thank you. FINAL_SAVING and KILLING also to be handled here. Updating the patch as per comments.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Make sense to me

        Show
        rohithsharma Rohith Sharma K S added a comment - Make sense to me
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 45s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 54s There were no new javac warning messages.
        +1 javadoc 9m 58s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 50s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 30s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 1m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 54m 39s Tests passed in hadoop-yarn-server-resourcemanager.
            94m 10s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12756154/0004-YARN-4141.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 2ffe2db
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9155/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9155/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9155/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 45s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 54s There were no new javac warning messages. +1 javadoc 9m 58s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 50s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 1m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 54m 39s Tests passed in hadoop-yarn-server-resourcemanager.     94m 10s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12756154/0004-YARN-4141.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2ffe2db hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9155/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9155/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9155/console This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks for updating the patch. One last nit: the EnumSets were using are all effectively constants, and we should precompute these as static variable constants rather than create them every time. Otherwise latest patch looks good to me.

        Show
        jlowe Jason Lowe added a comment - Thanks for updating the patch. One last nit: the EnumSets were using are all effectively constants, and we should precompute these as static variable constants rather than create them every time. Otherwise latest patch looks good to me.
        Hide
        sunilg Sunil G added a comment -

        Thank you Jason Lowe. Yes, its a good optimization. Updating a patch based on same.

        Show
        sunilg Sunil G added a comment - Thank you Jason Lowe . Yes, its a good optimization. Updating a patch based on same.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 35s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 54s There were no new javac warning messages.
        +1 javadoc 10m 16s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 51s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 27s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 51m 18s Tests failed in hadoop-yarn-server-resourcemanager.
            90m 48s  



        Reason Tests
        Failed unit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12757094/0005-YARN-4141.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 58d1a02
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9190/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9190/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9190/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 54s There were no new javac warning messages. +1 javadoc 10m 16s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 51s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 51m 18s Tests failed in hadoop-yarn-server-resourcemanager.     90m 48s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12757094/0005-YARN-4141.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 58d1a02 hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9190/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9190/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9190/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Test case failures are not related. TestRMRestart failed due to "java.util.zip.ZipException: invalid code lengths set".

        Show
        sunilg Sunil G added a comment - Test case failures are not related. TestRMRestart failed due to "java.util.zip.ZipException: invalid code lengths set".
        Hide
        sunilg Sunil G added a comment -

        Hi Jason Lowe and Rohith Sharma K S
        Could you please help to check the updated patch.

        Show
        sunilg Sunil G added a comment - Hi Jason Lowe and Rohith Sharma K S Could you please help to check the updated patch.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks for updating the patch. The new constants should be marked final. Also using "active" instead of "accepted" may be a bit more clear since accepted directly maps to an existing app state.

        Show
        jlowe Jason Lowe added a comment - Thanks for updating the patch. The new constants should be marked final. Also using "active" instead of "accepted" may be a bit more clear since accepted directly maps to an existing app state.
        Hide
        sunilg Sunil G added a comment -

        Thankyou Jason Lowe for sharing the comments. Updated patch addressing the same.

        Show
        sunilg Sunil G added a comment - Thankyou Jason Lowe for sharing the comments. Updated patch addressing the same.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 6s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 4s There were no new javac warning messages.
        +1 javadoc 10m 20s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 50s The applied patch generated 2 new checkstyle issues (total was 33, now 35).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 55m 14s Tests passed in hadoop-yarn-server-resourcemanager.
            95m 34s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12761940/0006-YARN-4141.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 692d51c
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9246/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9246/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9246/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9246/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 6s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 4s There were no new javac warning messages. +1 javadoc 10m 20s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 50s The applied patch generated 2 new checkstyle issues (total was 33, now 35). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 55m 14s Tests passed in hadoop-yarn-server-resourcemanager.     95m 34s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761940/0006-YARN-4141.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 692d51c checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9246/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9246/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9246/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9246/console This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        Since these are constants, checkstyle wants them to be named with capitals and underscores, like COMPLETED_APP_STATES.

        Show
        jlowe Jason Lowe added a comment - Since these are constants, checkstyle wants them to be named with capitals and underscores, like COMPLETED_APP_STATES.
        Hide
        sunilg Sunil G added a comment -

        Thank you Jason Lowe. Yes, the naming convention to be changed here. Uploading a new patch.

        Show
        sunilg Sunil G added a comment - Thank you Jason Lowe . Yes, the naming convention to be changed here. Uploading a new patch.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 10s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 57s There were no new javac warning messages.
        +1 javadoc 10m 14s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 47s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 55m 43s Tests failed in hadoop-yarn-server-resourcemanager.
            95m 51s  



        Reason Tests
        Failed unit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12762169/0007-YARN-4141.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 71a81b6
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9254/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9254/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9254/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 10s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 57s There were no new javac warning messages. +1 javadoc 10m 14s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 47s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 55m 43s Tests failed in hadoop-yarn-server-resourcemanager.     95m 51s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12762169/0007-YARN-4141.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 71a81b6 hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9254/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9254/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9254/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Test case failures are unrelated.

        Show
        sunilg Sunil G added a comment - Test case failures are unrelated.
        Hide
        jlowe Jason Lowe added a comment -

        +1 lgtm. Committing this.

        Show
        jlowe Jason Lowe added a comment - +1 lgtm. Committing this.
        Hide
        jlowe Jason Lowe added a comment -

        Thanks to Sunil for the contribution and to Rohith for additional review! I committed this to trunk and branch-2.

        Show
        jlowe Jason Lowe added a comment - Thanks to Sunil for the contribution and to Rohith for additional review! I committed this to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8535 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8535/)
        YARN-4141. Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8535 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8535/ ) YARN-4141 . Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #455 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/455/)
        YARN-4141. Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #455 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/455/ ) YARN-4141 . Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #430 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/430/)
        YARN-4141. Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #430 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/430/ ) YARN-4141 . Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #461 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/461/)
        YARN-4141. Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #461 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/461/ ) YARN-4141 . Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1193 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1193/)
        YARN-4141. Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1193 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1193/ ) YARN-4141 . Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2371 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2371/)
        YARN-4141. Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2371 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2371/ ) YARN-4141 . Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2399 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2399/)
        YARN-4141. Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2399 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2399/ ) YARN-4141 . Runtime Application Priority change should not throw exception for applications at finishing states. Contributed by Sunil G (jlowe: rev 9f53a95ff624f66a774fe3defeea4a3454f4c4af) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/CHANGES.txt
        Hide
        sunilg Sunil G added a comment -

        Thank you Jason Lowe for the review and commit and thank you Rohith Sharma K S for the review.

        Show
        sunilg Sunil G added a comment - Thank you Jason Lowe for the review and commit and thank you Rohith Sharma K S for the review.

          People

          • Assignee:
            sunilg Sunil G
            Reporter:
            sunilg Sunil G
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development