Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: nodemanager
    • Labels:
      None

      Description

      The Linux container executor launchContainer method throws ResourceHandlerException when there are problems setting up the container -but these aren't propagated in the raised IOE. They should be nested with the string value included in the message text.

      1. 0001-YARN-4136.patch
        1 kB
        Bibin A Chundatt

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #357 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/357/)
        YARN-4136. LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #357 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/357/ ) YARN-4136 . LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2296 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2296/)
        YARN-4136. LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2296 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2296/ ) YARN-4136 . LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #371 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/371/)
        YARN-4136. LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #371 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/371/ ) YARN-4136 . LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1109 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1109/)
        YARN-4136. LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1109 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1109/ ) YARN-4136 . LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2319 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2319/)
        YARN-4136. LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2319 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2319/ ) YARN-4136 . LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #377 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/377/)
        YARN-4136. LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #377 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/377/ ) YARN-4136 . LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8433 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8433/)
        YARN-4136. LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8433 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8433/ ) YARN-4136 . LinuxContainerExecutor loses info when forwarding ResourceHandlerException. Contributed by Bibin A Chundatt. (vvasudev: rev 486d5cb803efec7b4db445ee65a3df83392940a3) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java hadoop-yarn-project/CHANGES.txt
        Hide
        vvasudev Varun Vasudev added a comment -

        Committed to trunk and branch-2. Thanks Bibin A Chundatt!

        Show
        vvasudev Varun Vasudev added a comment - Committed to trunk and branch-2. Thanks Bibin A Chundatt !
        Hide
        vvasudev Varun Vasudev added a comment -

        +1 for the patch. I'll commit this tomorrow if no one objects.

        Show
        vvasudev Varun Vasudev added a comment - +1 for the patch. I'll commit this tomorrow if no one objects.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        I feel testcases are not required for this patch

        Show
        bibinchundatt Bibin A Chundatt added a comment - I feel testcases are not required for this patch
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 25s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 51s There were no new javac warning messages.
        +1 javadoc 10m 2s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 36s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 7m 50s Tests passed in hadoop-yarn-server-nodemanager.
            46m 32s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12754923/0001-YARN-4136.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 0f0e897
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9065/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9065/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9065/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 25s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 51s There were no new javac warning messages. +1 javadoc 10m 2s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 36s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 7m 50s Tests passed in hadoop-yarn-server-nodemanager.     46m 32s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754923/0001-YARN-4136.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0f0e897 hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9065/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9065/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9065/console This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Code at fault:

            } catch (ResourceHandlerException e) {
              LOG.error("ResourceHandlerChain.preStart() failed!", e);
              throw new IOException("ResourceHandlerChain.preStart() failed!");
            }
        

        All I want is that IOE to include the error string and text. We shouldn't be losing stack traces

        Show
        stevel@apache.org Steve Loughran added a comment - Code at fault: } catch (ResourceHandlerException e) { LOG.error( "ResourceHandlerChain.preStart() failed!" , e); throw new IOException( "ResourceHandlerChain.preStart() failed!" ); } All I want is that IOE to include the error string and text. We shouldn't be losing stack traces

          People

          • Assignee:
            bibinchundatt Bibin A Chundatt
            Reporter:
            stevel@apache.org Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development