Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4135

Improve the assertion message in MockRM while failing after waiting for the state.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      In MockRM when the test is failed after waiting for the given state, the application id or the attempt id can be printed for easy debug

      As of now if it hard to track the test fail in log since there is no relation with test case and the application id.

      Any thoughts ?

      1. YARN-4135_1.patch
        2 kB
        nijel
      2. YARN-4135_2.patch
        2 kB
        nijel

        Activity

        Hide
        nijel nijel added a comment -

        attached the patch
        please review

        Show
        nijel nijel added a comment - attached the patch please review
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 6m 39s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 50s There were no new javac warning messages.
        +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 52s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 26s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 54m 12s Tests passed in hadoop-yarn-server-resourcemanager.
            73m 21s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12754904/YARN-4135_1.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 0113e45
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9057/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9057/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9057/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 6m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 50s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 52s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 54m 12s Tests passed in hadoop-yarn-server-resourcemanager.     73m 21s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754904/YARN-4135_1.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 0113e45 hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9057/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9057/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9057/console This message was automatically generated.
        Hide
        adhoot Anubhav Dhoot added a comment -

        The patch looks fine except for missing spaces at before and after the + at "+appId

        Show
        adhoot Anubhav Dhoot added a comment - The patch looks fine except for missing spaces at before and after the + at "+appId
        Hide
        nijel nijel added a comment -

        thanks Anubhav Dhoot for the comment
        Updated the patch. Please review

        Show
        nijel nijel added a comment - thanks Anubhav Dhoot for the comment Updated the patch. Please review
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 6m 57s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 52s There were no new javac warning messages.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 50s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 26s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 54m 15s Tests failed in hadoop-yarn-server-resourcemanager.
            73m 44s  



        Reason Tests
        Timed out tests org.apache.hadoop.yarn.server.resourcemanager.security.TestAMRMTokens



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12756164/YARN-4135_2.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 2ffe2db
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9156/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9156/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9156/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 6m 57s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 52s There were no new javac warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 50s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 54m 15s Tests failed in hadoop-yarn-server-resourcemanager.     73m 44s   Reason Tests Timed out tests org.apache.hadoop.yarn.server.resourcemanager.security.TestAMRMTokens Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12756164/YARN-4135_2.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 2ffe2db hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/9156/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9156/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9156/console This message was automatically generated.
        Hide
        nijel nijel added a comment -

        -1 yarn tests 54m 15s Tests failed in hadoop-yarn-server-resourcemanager.

        Test skip is not related to this change

        Thanks

        Show
        nijel nijel added a comment - -1 yarn tests 54m 15s Tests failed in hadoop-yarn-server-resourcemanager. Test skip is not related to this change Thanks
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        +1 lgtm

        Show
        rohithsharma Rohith Sharma K S added a comment - +1 lgtm
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Committed to branch-2/trunk.. Thanks Anubhav Dhoot for review and nijel for contributions..

        Show
        rohithsharma Rohith Sharma K S added a comment - Committed to branch-2/trunk.. Thanks Anubhav Dhoot for review and nijel for contributions..
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #8475 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8475/)
        YARN-4135. Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8475 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8475/ ) YARN-4135 . Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #405 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/405/)
        YARN-4135. Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #405 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/405/ ) YARN-4135 . Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #412 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/412/)
        YARN-4135. Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #412 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/412/ ) YARN-4135 . Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1146 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1146/)
        YARN-4135. Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1146 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1146/ ) YARN-4135 . Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2352 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2352/)
        YARN-4135. Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2352 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2352/ ) YARN-4135 . Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #388 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/388/)
        YARN-4135. Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #388 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/388/ ) YARN-4135 . Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2327 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2327/)
        YARN-4135. Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2327 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2327/ ) YARN-4135 . Improve the assertion message in MockRM while failing after waiting for the state.(Nijel S F via rohithsharmaks) (rohithsharmaks: rev 723c31d45bc0f64b1d1a67350b108059d2a220a3) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockRM.java hadoop-yarn-project/CHANGES.txt
        Hide
        nijel nijel added a comment -
        Show
        nijel nijel added a comment - thanks Rohith Sharma K S and Anubhav Dhoot

          People

          • Assignee:
            nijel nijel
            Reporter:
            nijel nijel
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development