[YARN-4113] RM should respect retry-interval when uses RetryPolicies.RETRY_FOREVER

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Hadoop Flags: Reviewed
• Assignee: Sunil G
• Reporter: Wangda Tan
• Created: 03/Sep/15 21:21
• Updated: 24/Feb/17 21:44
• Resolved: 21/Sep/15 18:39

Description

Found one issue in RMProxy how to initialize RetryPolicy: In RMProxy#createRetryPolicy. When rmConnectWaitMS is set to -1 (wait forever), it uses RetryPolicies.RETRY_FOREVER which doesn't respect yarn.resourcemanager.connect.retry-interval.ms setting.

RetryPolicies.RETRY_FOREVER uses 0 as the interval, when I run the test without properly setup localhost name: TestYarnClient#testShouldNotRetryForeverForNonNetworkExceptions, it wrote 14G DEBUG exception message to system before it dies. This will be very bad if we do the same thing in a production cluster.

We should fix two places:

• Make RETRY_FOREVER can take retry-interval as constructor parameter.
• Respect retry-interval when we uses RETRY_FOREVER policy.

Issue Links

• depends upon: HADOOP-12386 RetryPolicies.RETRY_FOREVER should be able to specify a retry interval