Details

    • Hadoop Flags:
      Reviewed

      Description

      Add Documentation for Distributed Node Labels feature

      1. YARN-4100.v1.005.patch
        17 kB
        Naganarasimha G R
      2. YARN-4100.v1.004.patch
        13 kB
        Naganarasimha G R
      3. YARN-4100.v1.003.patch
        13 kB
        Naganarasimha G R
      4. YARN-4100.v1.002.patch
        12 kB
        Naganarasimha G R
      5. YARN-4100.v1.001.patch
        10 kB
        Naganarasimha G R
      6. NodeLabel.html
        38 kB
        Naganarasimha G R

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9222 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9222/)
          YARN-4100. Add Documentation for Distributed and Delegated-Centralized (devaraj: rev db144eb1c51c1f37bdd1e0c18e9a5b0969c82e33)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeLabel.md
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9222 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9222/ ) YARN-4100 . Add Documentation for Distributed and Delegated-Centralized (devaraj: rev db144eb1c51c1f37bdd1e0c18e9a5b0969c82e33) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/NodeLabel.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the review and commit Devaraj K , Dian Fu & Wangda Tan

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the review and commit Devaraj K , Dian Fu & Wangda Tan
          Hide
          devaraj.k Devaraj K added a comment -

          Committed to trunk, branch-2 and branch-2.8.

          Thanks Naganarasimha G R for the contribution. Thanks Dian Fu and Wangda Tan for reviews.

          Show
          devaraj.k Devaraj K added a comment - Committed to trunk, branch-2 and branch-2.8. Thanks Naganarasimha G R for the contribution. Thanks Dian Fu and Wangda Tan for reviews.
          Hide
          devaraj.k Devaraj K added a comment -

          +1, lgtm, will commit it shortly.

          Show
          devaraj.k Devaraj K added a comment - +1, lgtm, will commit it shortly.
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks Naganarasimha G R for the updated patch with comments fix.

          The latest patch looks good to me, I will commit it tomorrow unless there are no comments from others.

          Show
          devaraj.k Devaraj K added a comment - Thanks Naganarasimha G R for the updated patch with comments fix. The latest patch looks good to me, I will commit it tomorrow unless there are no comments from others.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Devaraj K for triggering the build ! Now it seems be better,

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Devaraj K for triggering the build ! Now it seems be better,
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 21s Maven dependency ordering for branch
          +1 mvninstall 7m 14s trunk passed
          +1 compile 1m 58s trunk passed with JDK v1.8.0_66
          +1 compile 2m 10s trunk passed with JDK v1.7.0_91
          +1 mvnsite 0m 49s trunk passed
          +1 mvneclipse 0m 21s trunk passed
          +1 javadoc 0m 38s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 44s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 0m 34s the patch passed
          +1 compile 1m 50s the patch passed with JDK v1.8.0_66
          +1 javac 1m 50s the patch passed
          +1 compile 2m 7s the patch passed with JDK v1.7.0_91
          +1 javac 2m 7s the patch passed
          +1 mvnsite 0m 42s the patch passed
          +1 mvneclipse 0m 19s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 javadoc 0m 32s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 40s the patch passed with JDK v1.7.0_91
          +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 6s hadoop-yarn-site in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 unit 0m 7s hadoop-yarn-site in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          27m 3s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785212/YARN-4100.v1.005.patch
          JIRA Issue YARN-4100
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 0bafef47e271 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2673cba
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10453/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10453/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 21s Maven dependency ordering for branch +1 mvninstall 7m 14s trunk passed +1 compile 1m 58s trunk passed with JDK v1.8.0_66 +1 compile 2m 10s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 49s trunk passed +1 mvneclipse 0m 21s trunk passed +1 javadoc 0m 38s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 44s trunk passed with JDK v1.7.0_91 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 0m 34s the patch passed +1 compile 1m 50s the patch passed with JDK v1.8.0_66 +1 javac 1m 50s the patch passed +1 compile 2m 7s the patch passed with JDK v1.7.0_91 +1 javac 2m 7s the patch passed +1 mvnsite 0m 42s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 0m 32s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 40s the patch passed with JDK v1.7.0_91 +1 unit 2m 4s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 6s hadoop-yarn-site in the patch passed with JDK v1.8.0_66. +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 0m 7s hadoop-yarn-site in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 27m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785212/YARN-4100.v1.005.patch JIRA Issue YARN-4100 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 0bafef47e271 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2673cba Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10453/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10453/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Devaraj K,
          White space issues, tabs and ASF license issue are all related to testptch/hadoop/hadoop-tools/hadoop-sls/hs_err_pid6818.log hence not related to the modifications in the attached patch. Verified Locally by applying using git apply --whitespace=fix and there were no fixes found !

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Devaraj K , White space issues, tabs and ASF license issue are all related to testptch/hadoop/hadoop-tools/hadoop-sls/hs_err_pid6818.log hence not related to the modifications in the attached patch. Verified Locally by applying using git apply --whitespace=fix and there were no fixes found !
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 7m 4s trunk passed
          +1 compile 2m 6s trunk passed with JDK v1.8.0_66
          +1 compile 2m 10s trunk passed with JDK v1.7.0_91
          +1 mvnsite 0m 47s trunk passed
          +1 mvneclipse 0m 20s trunk passed
          +1 javadoc 0m 36s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 43s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 0m 35s the patch passed
          +1 compile 2m 5s the patch passed with JDK v1.8.0_66
          +1 javac 2m 5s the patch passed
          +1 compile 2m 21s the patch passed with JDK v1.7.0_91
          +1 javac 2m 21s the patch passed
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 19s the patch passed
          -1 whitespace 0m 0s The patch has 255 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 0m 5s The patch has 384 line(s) with tabs.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 36s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 40s the patch passed with JDK v1.7.0_91
          +1 unit 1m 57s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 7s hadoop-yarn-site in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 unit 0m 6s hadoop-yarn-site in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 19s Patch generated 1 ASF License warnings.
          27m 38s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785212/YARN-4100.v1.005.patch
          JIRA Issue YARN-4100
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 11d6d42cd288 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c9a09d6
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10437/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10437/artifact/patchprocess/whitespace-tabs.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10437/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10437/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10437/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 7m 4s trunk passed +1 compile 2m 6s trunk passed with JDK v1.8.0_66 +1 compile 2m 10s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 47s trunk passed +1 mvneclipse 0m 20s trunk passed +1 javadoc 0m 36s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 43s trunk passed with JDK v1.7.0_91 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 0m 35s the patch passed +1 compile 2m 5s the patch passed with JDK v1.8.0_66 +1 javac 2m 5s the patch passed +1 compile 2m 21s the patch passed with JDK v1.7.0_91 +1 javac 2m 21s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 19s the patch passed -1 whitespace 0m 0s The patch has 255 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 5s The patch has 384 line(s) with tabs. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 36s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 40s the patch passed with JDK v1.7.0_91 +1 unit 1m 57s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 7s hadoop-yarn-site in the patch passed with JDK v1.8.0_66. +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 0m 6s hadoop-yarn-site in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 19s Patch generated 1 ASF License warnings. 27m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785212/YARN-4100.v1.005.patch JIRA Issue YARN-4100 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 11d6d42cd288 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c9a09d6 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10437/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10437/artifact/patchprocess/whitespace-tabs.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10437/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10437/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10437/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks Devaraj K for the review and sorry for the delay in responding.
          Have uploaded a patch with the review comments and also have added Contents section in the beginning and thus reorganising the headers. Please review the same.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks Devaraj K for the review and sorry for the delay in responding. Have uploaded a patch with the review comments and also have added Contents section in the beginning and thus reorganising the headers. Please review the same.
          Hide
          devaraj.k Devaraj K added a comment -

          Thanks Naganarasimha G R for the patch, Sorry for late here. The latest patch looks fine to me except these below points.

          • Can you check to re-frame the above sentence something like "Administrators can configure the provider for the node labels by configuring this parameter in NM"?
            +    in RM, Administrators can configure in NM the provider for the
                 node labels by configuring this parameter.
            
          • This would be helpfull, can you correct to helpful here?
          • If user don’t specify “(exclusive=…)”, execlusive, please change execlusive to exclusive?
          • Can you remove the spaces between package name and class name org.apache.hadoop.yarn.server.resourcemanager.nodelabels. RMNodeLabelsMappingProvider?
          Show
          devaraj.k Devaraj K added a comment - Thanks Naganarasimha G R for the patch, Sorry for late here. The latest patch looks fine to me except these below points. Can you check to re-frame the above sentence something like "Administrators can configure the provider for the node labels by configuring this parameter in NM"? + in RM, Administrators can configure in NM the provider for the node labels by configuring this parameter. This would be helpfull , can you correct to helpful here? If user don’t specify “(exclusive=…)”, execlusive , please change execlusive to exclusive? Can you remove the spaces between package name and class name org.apache.hadoop.yarn.server.resourcemanager.nodelabels. RMNodeLabelsMappingProvider ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 54s trunk passed
          +1 compile 1m 47s trunk passed with JDK v1.8.0_66
          +1 compile 2m 9s trunk passed with JDK v1.7.0_91
          +1 mvnsite 0m 50s trunk passed
          +1 mvneclipse 0m 24s trunk passed
          +1 javadoc 0m 39s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 46s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 41s the patch passed
          +1 compile 1m 49s the patch passed with JDK v1.8.0_66
          +1 javac 1m 49s the patch passed
          +1 compile 2m 11s the patch passed with JDK v1.7.0_91
          +1 javac 2m 11s the patch passed
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 37s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 44s the patch passed with JDK v1.7.0_91
          +1 unit 1m 53s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          27m 26s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778981/YARN-4100.v1.004.patch
          JIRA Issue YARN-4100
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 5267cac0d62f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 114b590
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10069/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10069/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 54s trunk passed +1 compile 1m 47s trunk passed with JDK v1.8.0_66 +1 compile 2m 9s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 24s trunk passed +1 javadoc 0m 39s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 46s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 41s the patch passed +1 compile 1m 49s the patch passed with JDK v1.8.0_66 +1 javac 1m 49s the patch passed +1 compile 2m 11s the patch passed with JDK v1.7.0_91 +1 javac 2m 11s the patch passed +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 37s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 44s the patch passed with JDK v1.7.0_91 +1 unit 1m 53s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.8.0_66. +1 unit 2m 11s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 27m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778981/YARN-4100.v1.004.patch JIRA Issue YARN-4100 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 5267cac0d62f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 114b590 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10069/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10069/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the feedback Wangda Tan,
          I have updated a patch covering most of your comments ,

          for the first 2 points ...

          IMO indexing order should be as follows <will add the indexing in the next patch if appropriate>:

          Overview
          Features
          Configurations
              Setting up ResourceManager to enable Node Labels:
                  Basic configurations to enable Node Labels
                  Add/modify node labels list to YARN
                  Add/modify node-to-labels mapping to YARN
              Configuration of Schedulers for node labels
                  Capacity Scheduler Configuration
                  <Fair Scheduler Configuration ... in future>
          Specifying node label for application
          Monitoring
              Monitoring through web UI
              Monitoring through commandline
          Useful links
          

          Considering this i felt it was still under Setting up ResourceManager to enable Node Labels, Thoughts?
          and have added the minimal configuration in the first part(Basic configurations) in this patch

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the feedback Wangda Tan , I have updated a patch covering most of your comments , for the first 2 points ... IMO indexing order should be as follows <will add the indexing in the next patch if appropriate>: Overview Features Configurations Setting up ResourceManager to enable Node Labels: Basic configurations to enable Node Labels Add/modify node labels list to YARN Add/modify node-to-labels mapping to YARN Configuration of Schedulers for node labels Capacity Scheduler Configuration <Fair Scheduler Configuration ... in future > Specifying node label for application Monitoring Monitoring through web UI Monitoring through commandline Useful links Considering this i felt it was still under Setting up ResourceManager to enable Node Labels , Thoughts? and have added the minimal configuration in the first part(Basic configurations) in this patch
          Hide
          leftnoteasy Wangda Tan added a comment - - edited

          Thanks Naganarasimha G R and reviews from Dian Fu,

          Some suggestions:

          • configuring labels to nodes in Distributed/(Delegated-Centralized) NodeLabel setup should be a part of Setting up ResourceManager to enable Node Labels.
          • If you agree with Add/modify node-to-labels mapping to YARN should not include all the options. You can include an example like configuring ConfigurationNodeLabelsProvider to show how to get node-to-labels mapping to YARN.
          • configuring labels to .. -> Configuring...
          • yarn.node-labels.configuration-type | Set configuration type for node labels. Administrators can specify "centralized", "delegated-centralized" or "distributed". Default value is "centralized" and "delegated-centralized" needs to be set to fetch the labels from a interface in RM..
            "Default value is "centralized" and "delegated-centralized" needs to be set to fetch.." This is a little confusing to me: default value should be "centralized" only, and explanation of "delegated-centralized" should in the Setting up ResourceManager to enable Node Labels.
          • *Distributed :* Mapping can be done through NM exposed interface "NodeLabelsProvider"...: This is too implementation-detailed to me, do you think is it better to say "Mapping will be set by configured NodeLabelsProvider" in NM, and then describe two different kinds of Providers
          • *Delegated-Centralized :* Mapping can be done through RM exposed interface "RMNodeLabelsMappingProvider"... like above, could we say: "Mapping will be set by configured NodeLabelsProvider" in RM.
          • For above two, Mapping -> Node-to-labels mapping
          • By default 2 implementations are supported: -> "We have two different providers in YARN: ..."

          Thoughts?

          Show
          leftnoteasy Wangda Tan added a comment - - edited Thanks Naganarasimha G R and reviews from Dian Fu , Some suggestions: configuring labels to nodes in Distributed/(Delegated-Centralized) NodeLabel setup should be a part of Setting up ResourceManager to enable Node Labels . If you agree with Add/modify node-to-labels mapping to YARN should not include all the options. You can include an example like configuring ConfigurationNodeLabelsProvider to show how to get node-to-labels mapping to YARN. configuring labels to .. -> Configuring... yarn.node-labels.configuration-type | Set configuration type for node labels. Administrators can specify "centralized" , "delegated-centralized" or "distributed" . Default value is "centralized" and "delegated-centralized" needs to be set to fetch the labels from a interface in RM. . "Default value is "centralized" and "delegated-centralized" needs to be set to fetch.." This is a little confusing to me: default value should be "centralized" only, and explanation of "delegated-centralized" should in the Setting up ResourceManager to enable Node Labels . * Distributed : * Mapping can be done through NM exposed interface "NodeLabelsProvider" ... : This is too implementation-detailed to me, do you think is it better to say "Mapping will be set by configured NodeLabelsProvider" in NM, and then describe two different kinds of Providers * Delegated-Centralized : * Mapping can be done through RM exposed interface "RMNodeLabelsMappingProvider" ... like above, could we say: "Mapping will be set by configured NodeLabelsProvider" in RM. For above two, Mapping -> Node-to-labels mapping By default 2 implementations are supported: -> "We have two different providers in YARN: ..." Thoughts?
          Hide
          dian.fu Dian Fu added a comment -

          Hi Naganarasimha G R,
          Thanks a lot for the quick update. LGTM. +1.

          Show
          dian.fu Dian Fu added a comment - Hi Naganarasimha G R , Thanks a lot for the quick update. LGTM. +1.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 43s trunk passed
          +1 compile 2m 24s trunk passed with JDK v1.8.0_66
          +1 compile 2m 37s trunk passed with JDK v1.7.0_91
          +1 mvnsite 0m 57s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 javadoc 0m 46s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 50s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 41s the patch passed
          +1 compile 2m 17s the patch passed with JDK v1.8.0_66
          +1 javac 2m 17s the patch passed
          +1 compile 2m 27s the patch passed with JDK v1.7.0_91
          +1 javac 2m 27s the patch passed
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 24s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 javadoc 0m 42s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 45s the patch passed with JDK v1.7.0_91
          +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 8s hadoop-yarn-site in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 18s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 25s Patch generated 1 ASF License warnings.
          30m 55s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778738/YARN-4100.v1.003.patch
          JIRA Issue YARN-4100
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 337f90a1d604 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0f82b5d
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10051/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10051/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10051/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 43s trunk passed +1 compile 2m 24s trunk passed with JDK v1.8.0_66 +1 compile 2m 37s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 26s trunk passed +1 javadoc 0m 46s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 50s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 41s the patch passed +1 compile 2m 17s the patch passed with JDK v1.8.0_66 +1 javac 2m 17s the patch passed +1 compile 2m 27s the patch passed with JDK v1.7.0_91 +1 javac 2m 27s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 42s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 45s the patch passed with JDK v1.7.0_91 +1 unit 2m 8s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 8s hadoop-yarn-site in the patch passed with JDK v1.8.0_66. +1 unit 2m 18s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 25s Patch generated 1 ASF License warnings. 30m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778738/YARN-4100.v1.003.patch JIRA Issue YARN-4100 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 337f90a1d604 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0f82b5d JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10051/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10051/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10051/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the comments Dian Fu, i have fixed your review comments in the latest patch.
          Hope to get review comments from Bibin A Chundatt, Rohith Sharma K S & Tan, Wangda can review and get it committed before the cut for 2.8

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the comments Dian Fu , i have fixed your review comments in the latest patch. Hope to get review comments from Bibin A Chundatt , Rohith Sharma K S & Tan, Wangda can review and get it committed before the cut for 2.8
          Hide
          dian.fu Dian Fu added a comment -

          Hi Naganarasimha G R,
          Very sorry for late response. It LGTM overall. Just a few small comments as follows:

          When "yarn.nodemanager.node-labels.provider" is configured with "config", "Script"

          S should be lower case for Script.

          When "yarn.nodemanager.node-labels.provider" is configured with "config" then

          A comma can be added before then

          which queries the Node labels.

          Node can be node. Actually node label, Node Label, Node label, node Label appears a lot of times in the doc, I think they should be consistent.

          In case of multiple lines have this pattern, then last one will be considered

          A period should be added at the end.

          Configured class needs to extend

          Two white space between Configured and class

          Show
          dian.fu Dian Fu added a comment - Hi Naganarasimha G R , Very sorry for late response. It LGTM overall. Just a few small comments as follows: When "yarn.nodemanager.node-labels.provider" is configured with "config", "Script" S should be lower case for Script . When "yarn.nodemanager.node-labels.provider" is configured with "config" then A comma can be added before then which queries the Node labels. Node can be node . Actually node label , Node Label , Node label , node Label appears a lot of times in the doc, I think they should be consistent. In case of multiple lines have this pattern, then last one will be considered A period should be added at the end. Configured class needs to extend Two white space between Configured and class
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Dian Fu, Tan, Wangda & Devaraj K,
          Can you guys review the latest patch ?

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Dian Fu , Tan, Wangda & Devaraj K , Can you guys review the latest patch ?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 26s trunk passed
          +1 compile 1m 50s trunk passed with JDK v1.8.0_66
          +1 compile 2m 8s trunk passed with JDK v1.7.0_91
          +1 mvnsite 0m 47s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          +1 javadoc 0m 37s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 43s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 40s the patch passed
          +1 compile 1m 51s the patch passed with JDK v1.8.0_66
          +1 javac 1m 51s the patch passed
          +1 compile 2m 7s the patch passed with JDK v1.7.0_91
          +1 javac 2m 7s the patch passed
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 javadoc 0m 36s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 43s the patch passed with JDK v1.7.0_91
          +1 unit 1m 52s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 8s hadoop-yarn-site in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          26m 34s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777255/YARN-4100.v1.002.patch
          JIRA Issue YARN-4100
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 7425f4d4ad03 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bf5295b
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9942/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9942/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Max memory used 75MB
          Powered by Apache Yetus 0.1.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9942/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 26s trunk passed +1 compile 1m 50s trunk passed with JDK v1.8.0_66 +1 compile 2m 8s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 47s trunk passed +1 mvneclipse 0m 23s trunk passed +1 javadoc 0m 37s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 43s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 40s the patch passed +1 compile 1m 51s the patch passed with JDK v1.8.0_66 +1 javac 1m 51s the patch passed +1 compile 2m 7s the patch passed with JDK v1.7.0_91 +1 javac 2m 7s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 23s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 0m 36s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 43s the patch passed with JDK v1.7.0_91 +1 unit 1m 52s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 8s hadoop-yarn-site in the patch passed with JDK v1.8.0_66. +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 26m 34s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12777255/YARN-4100.v1.002.patch JIRA Issue YARN-4100 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 7425f4d4ad03 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bf5295b whitespace https://builds.apache.org/job/PreCommit-YARN-Build/9942/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9942/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Max memory used 75MB Powered by Apache Yetus 0.1.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9942/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Thanks for the detailed review Dian Fu, I have attached a patch fixing all your comments with slight modifications for some.

          Show
          Naganarasimha Naganarasimha G R added a comment - Thanks for the detailed review Dian Fu , I have attached a patch fixing all your comments with slight modifications for some.
          Hide
          dian.fu Dian Fu added a comment -

          Hi Naganarasimha G R,
          Thanks a lot for patch. LGTM. Just a few minor comments:

          • Script should be script.
          • NM will send its loaded labels every x intervals configured along with heartbeat from NM to RM. can be changed to NM will send its loaded labels every x intervals configured along with heartbeat to RM..
          • By default 2 implementations are supported, Script and Configuration based

            What about By default 2 implementations are supported: Script based and Configuration based?

          • In case of Script,......In case of config,

            The capital of script and config should be consistent.

          • This would helpfull can be changed to This would be helpfull
          • "delegated-centralized" needs to be set, to fetch the labels from a interface in RM.}}

            The comma can be removed.

          • When "yarn.node-labels.configuration-type" parameter in RM is configured as "distributed",

            What about changed to When "yarn.node-labels.configuration-type" is configured with "distributed"

          • If "config" is specified then "ConfigurationNodeLabelsProvider" and "script" then "ScriptNodeLabelsProvider" will be used.

            What about changed to If "config" is configured, then "ConfigurationNodeLabelsProvider" will be used and if "script" is configured, then "ScriptNodeLabelsProvider" will be used.

          • admin might have removed the cluster label which was provided NM

            Missed one word by between provided and NM.

          • This configuration is to define the interval period.If -1 is configured

            Missed one white space before If.

          • When....then, If...then
            I think there should be one comma before then.
          • will be considered for Node Labels.
            Seems that it should be will be considered as Node Labels.
          • {{ In case of multiple lines having the pattern, last one will be considered.}}
            What about In case that multiple lines have this pattern, the last line will be considered.
          Show
          dian.fu Dian Fu added a comment - Hi Naganarasimha G R , Thanks a lot for patch. LGTM. Just a few minor comments: Script should be script . NM will send its loaded labels every x intervals configured along with heartbeat from NM to RM. can be changed to NM will send its loaded labels every x intervals configured along with heartbeat to RM. . By default 2 implementations are supported, Script and Configuration based What about By default 2 implementations are supported: Script based and Configuration based ? In case of Script,......In case of config, The capital of script and config should be consistent. This would helpfull can be changed to This would be helpfull "delegated-centralized" needs to be set, to fetch the labels from a interface in RM.}} The comma can be removed. When "yarn.node-labels.configuration-type" parameter in RM is configured as "distributed", What about changed to When "yarn.node-labels.configuration-type" is configured with "distributed" If "config" is specified then "ConfigurationNodeLabelsProvider" and "script" then "ScriptNodeLabelsProvider" will be used. What about changed to If "config" is configured, then "ConfigurationNodeLabelsProvider" will be used and if "script" is configured, then "ScriptNodeLabelsProvider" will be used. admin might have removed the cluster label which was provided NM Missed one word by between provided and NM . This configuration is to define the interval period.If -1 is configured Missed one white space before If . When....then , If...then I think there should be one comma before then. will be considered for Node Labels. Seems that it should be will be considered as Node Labels. {{ In case of multiple lines having the pattern, last one will be considered.}} What about In case that multiple lines have this pattern, the last line will be considered.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Dian Fu, Devaraj K, Tan, Wangda, & Rohith Sharma K S,
          Can one/all of you guys take a look at the documentation update in this jira, it would be better to go as part of 2.8.0 as the features are already checked in.

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Dian Fu , Devaraj K , Tan, Wangda , & Rohith Sharma K S , Can one/all of you guys take a look at the documentation update in this jira, it would be better to go as part of 2.8.0 as the features are already checked in.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 15s trunk passed
          +1 compile 2m 13s trunk passed with JDK v1.8.0_66
          +1 compile 2m 23s trunk passed with JDK v1.7.0_91
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 javadoc 0m 39s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 46s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 43s the patch passed
          +1 compile 2m 10s the patch passed with JDK v1.8.0_66
          +1 javac 2m 10s the patch passed
          +1 compile 2m 21s the patch passed with JDK v1.7.0_91
          +1 javac 2m 21s the patch passed
          +1 mvnsite 0m 52s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 javadoc 0m 40s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 47s the patch passed with JDK v1.7.0_91
          +1 unit 2m 3s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.8.0_66.
          +1 unit 2m 19s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.7.0_91.
          -1 asflicense 0m 20s Patch generated 3 ASF License warnings.
          46m 16s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776358/YARN-4100.v1.001.patch
          JIRA Issue YARN-4100
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux f60b5fcdd61e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9676774
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9903/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9903/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9903/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 15s trunk passed +1 compile 2m 13s trunk passed with JDK v1.8.0_66 +1 compile 2m 23s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 25s trunk passed +1 javadoc 0m 39s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 46s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 43s the patch passed +1 compile 2m 10s the patch passed with JDK v1.8.0_66 +1 javac 2m 10s the patch passed +1 compile 2m 21s the patch passed with JDK v1.7.0_91 +1 javac 2m 21s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 0m 40s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 47s the patch passed with JDK v1.7.0_91 +1 unit 2m 3s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.8.0_66. +1 unit 2m 19s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 0m 9s hadoop-yarn-site in the patch passed with JDK v1.7.0_91. -1 asflicense 0m 20s Patch generated 3 ASF License warnings. 46m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776358/YARN-4100.v1.001.patch JIRA Issue YARN-4100 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux f60b5fcdd61e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9676774 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9903/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/9903/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9903/console This message was automatically generated.
          Hide
          Naganarasimha Naganarasimha G R added a comment -

          Hi Tan, Wangda,Dian Fu, Devaraj K & Rohith Sharma K S,
          Please review the the attached patch for the documentation update for different configuration types of the Node Labels. This covers the scope of the YARN-4240

          Show
          Naganarasimha Naganarasimha G R added a comment - Hi Tan, Wangda , Dian Fu , Devaraj K & Rohith Sharma K S , Please review the the attached patch for the documentation update for different configuration types of the Node Labels. This covers the scope of the YARN-4240

            People

            • Assignee:
              Naganarasimha Naganarasimha G R
              Reporter:
              Naganarasimha Naganarasimha G R
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development