Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: resourcemanager
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This JIRA is to track documentation of application priority and its user, admin and REST interfaces.

      1. 0004-YARN-4098.patch
        4 kB
        Rohith Sharma K S
      2. 0003-YARN-4098.patch
        4 kB
        Rohith Sharma K S
      3. 0002-YARN-4098.patch
        4 kB
        Rohith Sharma K S
      4. 0001-YARN-4098.patch
        4 kB
        Rohith Sharma K S
      5. YARN-4098.rar
        212 kB
        Rohith Sharma K S
      6. 0001-YARN-4098.patch
        3 kB
        Rohith Sharma K S

        Activity

        Hide
        rohithsharma Rohith Sharma K S added a comment -

        updating initial patch.. This is mainly server side changes patch. There are still more doc need to update wrt client interfaces

        Show
        rohithsharma Rohith Sharma K S added a comment - updating initial patch.. This is mainly server side changes patch. There are still more doc need to update wrt client interfaces
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updated the documentation patch adding client interfaces. Attached the "mvn site" to see the content in html page.
        Sunil G/Jian He kindly review documentation patch

        Show
        rohithsharma Rohith Sharma K S added a comment - Updated the documentation patch adding client interfaces. Attached the "mvn site" to see the content in html page. Sunil G / Jian He kindly review documentation patch
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvnsite 0m 15s trunk passed
        +1 mvnsite 0m 15s the patch passed
        -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        0m 57s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778978/0001-YARN-4098.patch
        JIRA Issue YARN-4098
        Optional Tests asflicense mvnsite
        uname Linux 47188a197ee4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 114b590
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10068/artifact/patchprocess/whitespace-eol.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
        Max memory used 30MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10068/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvnsite 0m 15s trunk passed +1 mvnsite 0m 15s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 0m 57s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778978/0001-YARN-4098.patch JIRA Issue YARN-4098 Optional Tests asflicense mvnsite uname Linux 47188a197ee4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 114b590 whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10068/artifact/patchprocess/whitespace-eol.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site Max memory used 30MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10068/console This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Hi Rohith Sharma K S
        Thank you for sharing the patch.

        Some minor nits.
        CS Page:
        1.

        Higher the integer higher the priority of an applications. Note : Application priority is supported only for FIFO ordering policy.
        

        Could we rephrase this as Higher integer value indicates higher priority for the application. Currently Application priority is supported only for FIFO ordering policy.

        2. Application priority works along with FIFO ordering policy only can be Application priority works only along with FIFO ordering policy
        3. Default priority for an applications can be at cluster level and queue level. its better to mention as an application.
        4. Missing / in etc/hadoop/capacity-scheduler.xml
        5. typo in yarn.scheduler.capacity.root.<leaf-queue-patch>.default-application-priority. it can be <leaf-queue-path>

        Show
        sunilg Sunil G added a comment - Hi Rohith Sharma K S Thank you for sharing the patch. Some minor nits. CS Page: 1. Higher the integer higher the priority of an applications. Note : Application priority is supported only for FIFO ordering policy. Could we rephrase this as Higher integer value indicates higher priority for the application. Currently Application priority is supported only for FIFO ordering policy. 2. Application priority works along with FIFO ordering policy only can be Application priority works only along with FIFO ordering policy 3. Default priority for an applications can be at cluster level and queue level. its better to mention as an application . 4. Missing / in etc/hadoop/capacity-scheduler.xml 5. typo in yarn.scheduler.capacity.root.<leaf-queue-patch>.default-application-priority . it can be <leaf-queue-path>
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updated the patch fixing review comments.

        Show
        rohithsharma Rohith Sharma K S added a comment - Updated the patch fixing review comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvnsite 0m 15s trunk passed
        +1 mvnsite 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        -1 asflicense 0m 21s Patch generated 1 ASF License warnings.
        1m 1s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779248/0002-YARN-4098.patch
        JIRA Issue YARN-4098
        Optional Tests asflicense mvnsite
        uname Linux 08368cfedd76 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 882f2f0
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10081/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
        Max memory used 30MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10081/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvnsite 0m 15s trunk passed +1 mvnsite 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 asflicense 0m 21s Patch generated 1 ASF License warnings. 1m 1s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779248/0002-YARN-4098.patch JIRA Issue YARN-4098 Optional Tests asflicense mvnsite uname Linux 08368cfedd76 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 882f2f0 asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10081/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site Max memory used 30MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10081/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvnsite 0m 14s trunk passed
        +1 mvnsite 0m 15s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        -1 asflicense 0m 18s Patch generated 1 ASF License warnings.
        0m 58s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779251/0003-YARN-4098.patch
        JIRA Issue YARN-4098
        Optional Tests asflicense mvnsite
        uname Linux 88545b721bd1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 882f2f0
        asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10082/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
        Max memory used 29MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10082/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvnsite 0m 14s trunk passed +1 mvnsite 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 asflicense 0m 18s Patch generated 1 ASF License warnings. 0m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779251/0003-YARN-4098.patch JIRA Issue YARN-4098 Optional Tests asflicense mvnsite uname Linux 88545b721bd1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 882f2f0 asflicense https://builds.apache.org/job/PreCommit-YARN-Build/10082/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site Max memory used 29MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10082/console This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        -1 asflicense

        No new files are added, and for the existing modified file has asf header.

        Show
        rohithsharma Rohith Sharma K S added a comment - -1 asflicense No new files are added, and for the existing modified file has asf header.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Sunil G/Jian He kindly review the patch

        Show
        rohithsharma Rohith Sharma K S added a comment - Sunil G / Jian He kindly review the patch
        Hide
        sunilg Sunil G added a comment -

        Looks good for me. Will wait for Jian He comments also.

        Show
        sunilg Sunil G added a comment - Looks good for me. Will wait for Jian He comments also.
        Hide
        jianhe Jian He added a comment -

        looks good overall

        • this feature allows applications to be submitted and scheduled with different priorities.
          may be this feature allows applications to be submitted and scheduled with different priorities.
        • which is greater then - should be greater than
        Show
        jianhe Jian He added a comment - looks good overall this feature allows applications to be submitted and scheduled with different priorities. may be this feature allows applications to be submitted and scheduled with different priorities. which is greater then - should be greater than
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        may be this feature allows applications to be submitted and scheduled with different priorities.

        I did not get what is the change to be done, I see both are sentences are same. I think something missed.

        Show
        rohithsharma Rohith Sharma K S added a comment - may be this feature allows applications to be submitted and scheduled with different priorities. I did not get what is the change to be done, I see both are sentences are same. I think something missed.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 mvnsite 0m 25s trunk passed
        +1 mvnsite 0m 20s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 asflicense 0m 30s Patch does not generate ASF License warnings.
        1m 49s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779633/0004-YARN-4098.patch
        JIRA Issue YARN-4098
        Optional Tests asflicense mvnsite
        uname Linux 7dd964f9f901 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a0249da
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site
        Max memory used 29MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10104/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvnsite 0m 25s trunk passed +1 mvnsite 0m 20s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 asflicense 0m 30s Patch does not generate ASF License warnings. 1m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779633/0004-YARN-4098.patch JIRA Issue YARN-4098 Optional Tests asflicense mvnsite uname Linux 7dd964f9f901 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a0249da modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site Max memory used 29MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10104/console This message was automatically generated.
        Hide
        jianhe Jian He added a comment -

        sorry, pasted wrong, earlier it was saying "submitted with different priorities." only, could be "submitted and scheduled"

        Show
        jianhe Jian He added a comment - sorry, pasted wrong, earlier it was saying "submitted with different priorities." only, could be "submitted and scheduled"
        Hide
        jianhe Jian He added a comment -

        Committed to trunk, branch-2, branch-2.8 thanks Rohith Sharma K S !
        thanks Sunil G for reviewing the patch !

        Show
        jianhe Jian He added a comment - Committed to trunk, branch-2, branch-2.8 thanks Rohith Sharma K S ! thanks Sunil G for reviewing the patch !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9037 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9037/)
        YARN-4098. Document ApplicationPriority feature. Contributed by Rohith (jianhe: rev ad997fab67c65071a745a30afaa4e7d63fe40ec2)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnCommands.md
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/CapacityScheduler.md
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9037 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9037/ ) YARN-4098 . Document ApplicationPriority feature. Contributed by Rohith (jianhe: rev ad997fab67c65071a745a30afaa4e7d63fe40ec2) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnCommands.md hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/CapacityScheduler.md hadoop-yarn-project/CHANGES.txt

          People

          • Assignee:
            rohithsharma Rohith Sharma K S
            Reporter:
            rohithsharma Rohith Sharma K S
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development