Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4057

If ContainersMonitor is not enabled, only print related log info one time

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: nodemanager
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ContainersMonitorImpl will check whether it is enabled when handling every event, and it will print following messages again and again if not enabled:

      2015-08-17 13:20:13,792 INFO org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainersMonitorImpl: Neither virutal-memory nor physical-memory is needed. Not running the monitor-thread

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #289 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/289/)
        YARN-4057. If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #289 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/289/ ) YARN-4057 . If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2238 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2238/)
        YARN-4057. If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2238 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2238/ ) YARN-4057 . If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #281 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/281/)
        YARN-4057. If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #281 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/281/ ) YARN-4057 . If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2219 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2219/)
        YARN-4057. If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2219 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2219/ ) YARN-4057 . If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #292 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/292/)
        YARN-4057. If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #292 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/292/ ) YARN-4057 . If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1022 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1022/)
        YARN-4057. If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1022 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1022/ ) YARN-4057 . If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
        Hide
        hex108 Jun Gong added a comment -

        Thanks zhihai xu for the review and commit!

        Show
        hex108 Jun Gong added a comment - Thanks zhihai xu for the review and commit!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8318 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8318/)
        YARN-4057. If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8318 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8318/ ) YARN-4057 . If ContainersMonitor is not enabled, only print related log info one time. Contributed by Jun Gong. (zxu: rev 14215c8ef83d58b8443c52a3cb93e6d44fc87065) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainersMonitorImpl.java
        Hide
        zxu zhihai xu added a comment -

        thanks Jun Gong for the contribution! I committed this to trunk and branch-2.

        Show
        zxu zhihai xu added a comment - thanks Jun Gong for the contribution! I committed this to trunk and branch-2.
        Hide
        zxu zhihai xu added a comment -

        Thanks for reporting and working on the issue. It is a good catch.
        This is also an optimization even if ContainersMonitor is enabled, because we don't need call isEnabled every time ContainersMonitorEvent handler is called.
        The patch is a minor optimization and also a very safe change.
        +1 for the patch, If no objection will commit it tomorrow.

        Show
        zxu zhihai xu added a comment - Thanks for reporting and working on the issue. It is a good catch. This is also an optimization even if ContainersMonitor is enabled, because we don't need call isEnabled every time ContainersMonitorEvent handler is called. The patch is a minor optimization and also a very safe change. +1 for the patch, If no objection will commit it tomorrow.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 2s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 49s There were no new javac warning messages.
        +1 javadoc 9m 46s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 36s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 22s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 6m 17s Tests passed in hadoop-yarn-server-nodemanager.
            44m 7s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12750783/YARN-4057.01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 13604bd
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8860/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8860/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8860/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 49s There were no new javac warning messages. +1 javadoc 9m 46s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 36s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 6m 17s Tests passed in hadoop-yarn-server-nodemanager.     44m 7s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750783/YARN-4057.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 13604bd hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8860/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8860/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8860/console This message was automatically generated.

          People

          • Assignee:
            hex108 Jun Gong
            Reporter:
            hex108 Jun Gong
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development