Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Track the changes for user-RM client protocol i.e ApplicationClientProtocol changes and discussions in this jira.

      1. 0004-YARN-4014.patch
        55 kB
        Rohith Sharma K S
      2. 0004-YARN-4014.patch
        55 kB
        Rohith Sharma K S
      3. 0003-YARN-4014.patch
        55 kB
        Rohith Sharma K S
      4. 0002-YARN-4014.patch
        55 kB
        Rohith Sharma K S
      5. 0001-YARN-4014-V1.patch
        47 kB
        Rohith Sharma K S
      6. 0001-YARN-4014.patch
        53 kB
        Rohith Sharma K S

        Issue Links

          Activity

          Hide
          imstefanlee stefanlee added a comment -

          it's done , i forgot to add |optional PriorityProto applicationPriority = 1;| in yarn_service_protos.proto

          Show
          imstefanlee stefanlee added a comment - it's done , i forgot to add |optional PriorityProto applicationPriority = 1;| in yarn_service_protos.proto
          Hide
          imstefanlee stefanlee added a comment -

          Rohith Sharma K S Jian He thanks for sharing this jira ,i have added those code to hadoop2.4.0 ,but when i mvn package this project,some errors happened as follows:

          [ERROR] /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java:[76,10] error: cannot find symbol
          [ERROR] symbol: method setApplicationPriority(PriorityProto)
          [ERROR] location: variable builder of type Builder
          [ERROR] /hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java:[88,10] error: cannot find symbol
          [ERROR] symbol: method hasApplicationPriority()
          [ERROR] location: variable p of type UpdateApplicationPriorityResponseProtoOrBuilder
          [ERROR] /hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java:[92,32] error: cannot find symbol
          [ERROR] symbol: method getApplicationPriority()
          [ERROR] location: variable p of type UpdateApplicationPriorityResponseProtoOrBuilder
          [ERROR]/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java:[100,13] error: cannot find symbol

          but i have modified ApplicationClientProtocol.java ,applicationclient_protocol.proto,etc. and importted related class at the beginning.

          import org.apache.hadoop.yarn.proto.YarnServiceProtos.UpdateApplicationPriorityResponseProto;
          import org.apache.hadoop.yarn.proto.YarnServiceProtos.UpdateApplicationPriorityResponseProtoOrBuilder;

          how can i solve this problem.

          Show
          imstefanlee stefanlee added a comment - Rohith Sharma K S Jian He thanks for sharing this jira ,i have added those code to hadoop2.4.0 ,but when i mvn package this project,some errors happened as follows: [ERROR] /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java: [76,10] error: cannot find symbol [ERROR] symbol: method setApplicationPriority(PriorityProto) [ERROR] location: variable builder of type Builder [ERROR] /hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java: [88,10] error: cannot find symbol [ERROR] symbol: method hasApplicationPriority() [ERROR] location: variable p of type UpdateApplicationPriorityResponseProtoOrBuilder [ERROR] /hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java: [92,32] error: cannot find symbol [ERROR] symbol: method getApplicationPriority() [ERROR] location: variable p of type UpdateApplicationPriorityResponseProtoOrBuilder [ERROR] /hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java: [100,13] error: cannot find symbol but i have modified ApplicationClientProtocol.java ,applicationclient_protocol.proto,etc. and importted related class at the beginning. import org.apache.hadoop.yarn.proto.YarnServiceProtos.UpdateApplicationPriorityResponseProto; import org.apache.hadoop.yarn.proto.YarnServiceProtos.UpdateApplicationPriorityResponseProtoOrBuilder; how can i solve this problem.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #294 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/294/)
          YARN-4014. Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #294 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/294/ ) YARN-4014 . Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2251 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2251/)
          YARN-4014. Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2251 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2251/ ) YARN-4014 . Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2232 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2232/)
          YARN-4014. Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2232 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2232/ ) YARN-4014 . Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #307 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/307/)
          YARN-4014. Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #307 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/307/ ) YARN-4014 . Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1035 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1035/)
          YARN-4014. Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1035 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1035/ ) YARN-4014 . Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #302 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/302/)
          YARN-4014. Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #302 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/302/ ) YARN-4014 . Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Thanks Jian He and Sunil G for detailed review and commit.

          Show
          rohithsharma Rohith Sharma K S added a comment - Thanks Jian He and Sunil G for detailed review and commit.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8346 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8346/)
          YARN-4014. Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8346 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8346/ ) YARN-4014 . Support user cli interface in for Application Priority. Contributed by Rohith Sharma K S (jianhe: rev 57c7ae1affb2e1821fbdc3f47738d7e6fd83c7c1) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestClientRedirect.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacityScheduler.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityRequest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/YarnClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateStore.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityResponsePBImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/ResourceMgrDelegate.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/service/ApplicationClientProtocolPBServiceImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/ApplicationClientProtocol.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/RMStateUpdateAppEvent.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMAuditLogger.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/impl/pb/UpdateApplicationPriorityRequestPBImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/impl/pb/client/ApplicationClientProtocolPBClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/UpdateApplicationPriorityResponse.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/applicationclient_protocol.proto
          Hide
          jianhe Jian He added a comment -

          Thanks Sunil for reviewing the patch !

          Show
          jianhe Jian He added a comment - Thanks Sunil for reviewing the patch !
          Hide
          jianhe Jian He added a comment -

          Committed to trunk and branch-2, thanks Rohith !

          Show
          jianhe Jian He added a comment - Committed to trunk and branch-2, thanks Rohith !
          Hide
          sunilg Sunil G added a comment -

          Yes. Thanks for clarifying Rohith and Jian. +1.

          Show
          sunilg Sunil G added a comment - Yes. Thanks for clarifying Rohith and Jian. +1.
          Hide
          jianhe Jian He added a comment -

          I think there would NOT ocur any possibility where currentAttempt has old priority.

          I think this is true.

          Show
          jianhe Jian He added a comment - I think there would NOT ocur any possibility where currentAttempt has old priority. I think this is true.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          When 2nd or subsequent AM attempt is spawned, we are never setting the old attempt as null in SchedulerApplication, correct? Hence there is a chance that we set priority to old attempt while new attempt is getting created..

          Right.. Since latest priority has been reset to attempt after attempt got updated in the SchedulerApplication#setCurrentAttempt, I think there would NOT ocur any possibility where currentAttempt has old priority. So I believe currentAttempt NEED NOT to be volatile.
          Jian He Could you give your opinion on this?

          Show
          rohithsharma Rohith Sharma K S added a comment - When 2nd or subsequent AM attempt is spawned, we are never setting the old attempt as null in SchedulerApplication, correct? Hence there is a chance that we set priority to old attempt while new attempt is getting created.. Right.. Since latest priority has been reset to attempt after attempt got updated in the SchedulerApplication#setCurrentAttempt, I think there would NOT ocur any possibility where currentAttempt has old priority. So I believe currentAttempt NEED NOT to be volatile. Jian He Could you give your opinion on this?
          Hide
          sunilg Sunil G added a comment -

          Thanks Rohith Sharma K S and Jian He for handling the race condition in CS#updateApplicationPriority.

          I feel there is another race condition other than the null case of currentAttempt in SchedulerApplication.
          When 2nd or subsequent AM attempt is spawned, we are never setting the old attempt as null in SchedulerApplication, correct?
          Hence there is a chance that we set priority to old attempt while new attempt is getting created. As per your new change in updateApplicationPriority, I feel this case is also handled.
          However, I think we may need to make currentAttempt also volatile in SchedulerApplication. pls suggest your thoughts.

          private T currentAttempt;
          
          Show
          sunilg Sunil G added a comment - Thanks Rohith Sharma K S and Jian He for handling the race condition in CS#updateApplicationPriority . I feel there is another race condition other than the null case of currentAttempt in SchedulerApplication. When 2nd or subsequent AM attempt is spawned, we are never setting the old attempt as null in SchedulerApplication , correct? Hence there is a chance that we set priority to old attempt while new attempt is getting created. As per your new change in updateApplicationPriority , I feel this case is also handled. However, I think we may need to make currentAttempt also volatile in SchedulerApplication . pls suggest your thoughts. private T currentAttempt;
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          test failures are unrelated to this patch.

          Show
          rohithsharma Rohith Sharma K S added a comment - test failures are unrelated to this patch.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 45s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 7m 57s There were no new javac warning messages.
          +1 javadoc 9m 57s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 37s The applied patch generated 5 new checkstyle issues (total was 31, now 36).
          +1 whitespace 0m 12s The patch has no lines that end in whitespace.
          +1 install 1m 23s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 6m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 mapreduce tests 101m 22s Tests failed in hadoop-mapreduce-client-jobclient.
          +1 yarn tests 0m 39s Tests passed in hadoop-yarn-api.
          +1 yarn tests 7m 29s Tests passed in hadoop-yarn-client.
          -1 yarn tests 2m 12s Tests failed in hadoop-yarn-common.
          -1 yarn tests 56m 1s Tests failed in hadoop-yarn-server-resourcemanager.
              218m 20s  



          Reason Tests
          Failed unit tests hadoop.yarn.util.TestRackResolver
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
          Timed out tests org.apache.hadoop.mapred.TestMRIntermediateDataEncryption



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12751035/0004-YARN-4014.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / fc509f6
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8876/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/8876/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8876/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8876/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8876/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8876/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8876/testReport/
          Java 1.7.0_55
          uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8876/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 45s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 7m 57s There were no new javac warning messages. +1 javadoc 9m 57s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 37s The applied patch generated 5 new checkstyle issues (total was 31, now 36). +1 whitespace 0m 12s The patch has no lines that end in whitespace. +1 install 1m 23s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 6m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 101m 22s Tests failed in hadoop-mapreduce-client-jobclient. +1 yarn tests 0m 39s Tests passed in hadoop-yarn-api. +1 yarn tests 7m 29s Tests passed in hadoop-yarn-client. -1 yarn tests 2m 12s Tests failed in hadoop-yarn-common. -1 yarn tests 56m 1s Tests failed in hadoop-yarn-server-resourcemanager.     218m 20s   Reason Tests Failed unit tests hadoop.yarn.util.TestRackResolver   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Timed out tests org.apache.hadoop.mapred.TestMRIntermediateDataEncryption Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751035/0004-YARN-4014.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fc509f6 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8876/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/8876/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8876/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8876/artifact/patchprocess/testrun_hadoop-yarn-client.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8876/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8876/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8876/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8876/console This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Updating the same with fixing java doc issues.. Kick off jenkins

          Show
          rohithsharma Rohith Sharma K S added a comment - Updating the same with fixing java doc issues.. Kick off jenkins
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 19s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 7m 49s There were no new javac warning messages.
          -1 javadoc 9m 47s The applied patch generated 3 additional warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 30s The applied patch generated 3 new checkstyle issues (total was 31, now 34).
          +1 whitespace 0m 12s The patch has no lines that end in whitespace.
          +1 install 1m 25s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 6m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 mapreduce tests 104m 56s Tests failed in hadoop-mapreduce-client-jobclient.
          +1 yarn tests 0m 27s Tests passed in hadoop-yarn-api.
          -1 yarn tests 5m 9s Tests failed in hadoop-yarn-client.
          -1 yarn tests 0m 23s Tests failed in hadoop-yarn-common.
          -1 yarn tests 0m 22s Tests failed in hadoop-yarn-server-resourcemanager.
              161m 9s  



          Reason Tests
          Failed unit tests hadoop.mapreduce.lib.output.TestJobOutputCommitter
            hadoop.yarn.client.api.impl.TestNMClient
            hadoop.yarn.client.api.impl.TestYarnClient
          Timed out tests org.apache.hadoop.mapreduce.TestLargeSort
            org.apache.hadoop.yarn.client.api.impl.TestAHSClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
          Failed build hadoop-yarn-common
            hadoop-yarn-server-resourcemanager



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12750963/0004-YARN-4014.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 71566e2
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/diffJavadocWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8873/testReport/
          Java 1.7.0_55
          uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8873/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 19s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 7m 49s There were no new javac warning messages. -1 javadoc 9m 47s The applied patch generated 3 additional warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 30s The applied patch generated 3 new checkstyle issues (total was 31, now 34). +1 whitespace 0m 12s The patch has no lines that end in whitespace. +1 install 1m 25s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 6m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 104m 56s Tests failed in hadoop-mapreduce-client-jobclient. +1 yarn tests 0m 27s Tests passed in hadoop-yarn-api. -1 yarn tests 5m 9s Tests failed in hadoop-yarn-client. -1 yarn tests 0m 23s Tests failed in hadoop-yarn-common. -1 yarn tests 0m 22s Tests failed in hadoop-yarn-server-resourcemanager.     161m 9s   Reason Tests Failed unit tests hadoop.mapreduce.lib.output.TestJobOutputCommitter   hadoop.yarn.client.api.impl.TestNMClient   hadoop.yarn.client.api.impl.TestYarnClient Timed out tests org.apache.hadoop.mapreduce.TestLargeSort   org.apache.hadoop.yarn.client.api.impl.TestAHSClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient Failed build hadoop-yarn-common   hadoop-yarn-server-resourcemanager Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750963/0004-YARN-4014.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 71566e2 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/diffJavadocWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/testrun_hadoop-yarn-client.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8873/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8873/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8873/console This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Updated the patch fixing race condition in updating the priority vs SchedulerApplicationAttemp creation which would take up old priority rather than updated priority.

          Show
          rohithsharma Rohith Sharma K S added a comment - Updated the patch fixing race condition in updating the priority vs SchedulerApplicationAttemp creation which would take up old priority rather than updated priority.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          That means the updated priority is lost

          Discussed offline with Jian He, updated priority wont be lost if application is in ACCEPTED state.

          Show
          rohithsharma Rohith Sharma K S added a comment - That means the updated priority is lost Discussed offline with Jian He, updated priority wont be lost if application is in ACCEPTED state.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 24m 36s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 8m 0s There were no new javac warning messages.
          -1 javadoc 10m 3s The applied patch generated 2 additional warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 40s The applied patch generated 6 new checkstyle issues (total was 31, now 37).
          +1 whitespace 0m 11s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 6m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 103m 8s Tests passed in hadoop-mapreduce-client-jobclient.
          +1 yarn tests 0m 31s Tests passed in hadoop-yarn-api.
          +1 yarn tests 7m 8s Tests passed in hadoop-yarn-client.
          -1 yarn tests 2m 8s Tests failed in hadoop-yarn-common.
          -1 yarn tests 56m 16s Tests failed in hadoop-yarn-server-resourcemanager.
              224m 3s  



          Reason Tests
          Failed unit tests hadoop.yarn.util.TestRackResolver
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12750880/0003-YARN-4014.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / c77bd6a
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/diffJavadocWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8869/testReport/
          Java 1.7.0_55
          uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8869/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 24m 36s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 8m 0s There were no new javac warning messages. -1 javadoc 10m 3s The applied patch generated 2 additional warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 40s The applied patch generated 6 new checkstyle issues (total was 31, now 37). +1 whitespace 0m 11s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 6m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 103m 8s Tests passed in hadoop-mapreduce-client-jobclient. +1 yarn tests 0m 31s Tests passed in hadoop-yarn-api. +1 yarn tests 7m 8s Tests passed in hadoop-yarn-client. -1 yarn tests 2m 8s Tests failed in hadoop-yarn-common. -1 yarn tests 56m 16s Tests failed in hadoop-yarn-server-resourcemanager.     224m 3s   Reason Tests Failed unit tests hadoop.yarn.util.TestRackResolver   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750880/0003-YARN-4014.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c77bd6a javadoc https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/diffJavadocWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/testrun_hadoop-yarn-client.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8869/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8869/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8869/console This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          handled null entry adding to SchedulableEntity.

          I think simply ignoring the null entry is not enough. That means the updated priority is lost. We need to handle this too. We may inherit the priority from the SchedulerApplication when schedulerApplicationAttempt is created.

          Show
          jianhe Jian He added a comment - handled null entry adding to SchedulableEntity. I think simply ignoring the null entry is not enough. That means the updated priority is lost. We need to handle this too. We may inherit the priority from the SchedulerApplication when schedulerApplicationAttempt is created.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 39s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 7m 54s There were no new javac warning messages.
          -1 javadoc 9m 55s The applied patch generated 2 additional warning messages.
          +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 35s The applied patch generated 6 new checkstyle issues (total was 31, now 37).
          +1 whitespace 0m 11s The patch has no lines that end in whitespace.
          +1 install 1m 25s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 6m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 107m 10s Tests passed in hadoop-mapreduce-client-jobclient.
          +1 yarn tests 0m 27s Tests passed in hadoop-yarn-api.
          +1 yarn tests 6m 56s Tests passed in hadoop-yarn-client.
          -1 yarn tests 2m 0s Tests failed in hadoop-yarn-common.
          -1 yarn tests 53m 11s Tests failed in hadoop-yarn-server-resourcemanager.
              220m 12s  



          Reason Tests
          Failed unit tests hadoop.yarn.util.TestRackResolver
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12750823/0002-YARN-4014.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 13604bd
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/diffJavadocWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8862/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8862/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 7m 54s There were no new javac warning messages. -1 javadoc 9m 55s The applied patch generated 2 additional warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 35s The applied patch generated 6 new checkstyle issues (total was 31, now 37). +1 whitespace 0m 11s The patch has no lines that end in whitespace. +1 install 1m 25s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 6m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 107m 10s Tests passed in hadoop-mapreduce-client-jobclient. +1 yarn tests 0m 27s Tests passed in hadoop-yarn-api. +1 yarn tests 6m 56s Tests passed in hadoop-yarn-client. -1 yarn tests 2m 0s Tests failed in hadoop-yarn-common. -1 yarn tests 53m 11s Tests failed in hadoop-yarn-server-resourcemanager.     220m 12s   Reason Tests Failed unit tests hadoop.yarn.util.TestRackResolver   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750823/0002-YARN-4014.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 13604bd javadoc https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/diffJavadocWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/testrun_hadoop-yarn-client.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8862/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8862/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8862/console This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          updating the patch that check only for ACCEPTED and RUNNING application state before updating priority of an application.

          Show
          rohithsharma Rohith Sharma K S added a comment - updating the patch that check only for ACCEPTED and RUNNING application state before updating priority of an application.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          If the application is in SUBMITTED state, update priority should not be called because application would not be added to scheduler. In ACCEPTED state, update priority can be called.
          One of the doubt Jian He hasis if application is in ACCEPTED state, then application attempt would not be created. I rechecked the code flow, where we can do update in ACCEPTED state even though application is not created. IIRR, While doing YARN-3887, this specific scenario we discussed and handled null entry adding to SchedulableEntity.

          Show
          rohithsharma Rohith Sharma K S added a comment - If the application is in SUBMITTED state, update priority should not be called because application would not be added to scheduler. In ACCEPTED state, update priority can be called. One of the doubt Jian He hasis if application is in ACCEPTED state, then application attempt would not be created. I rechecked the code flow, where we can do update in ACCEPTED state even though application is not created. IIRR, While doing YARN-3887 , this specific scenario we discussed and handled null entry adding to SchedulableEntity.
          Hide
          sunilg Sunil G added a comment -

          IMHO, I feel we can change priority of an app at ACCEPTED state also. Bcz its yet to be activated, and we increase priority for same. Thoughts?

          Show
          sunilg Sunil G added a comment - IMHO, I feel we can change priority of an app at ACCEPTED state also. Bcz its yet to be activated, and we increase priority for same. Thoughts?
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          I did the above check leaving SUBMITTED, ACCEPTED, RUNNING state because thinking that application priority should be able to update in these states. Should we update only for RUNNING? I feel these states should be allowed to change priority. What do you think?

          Show
          rohithsharma Rohith Sharma K S added a comment - I did the above check leaving SUBMITTED, ACCEPTED, RUNNING state because thinking that application priority should be able to update in these states. Should we update only for RUNNING? I feel these states should be allowed to change priority. What do you think?
          Hide
          jianhe Jian He added a comment -

          I think we can throw YarnException with message "Application in <app-state> state cannot be update priority." Any thoughts?

          sounds good to me. We may just check if app is at RUNNING state for below if condition ?

             if (EnumSet.of(RMAppState.NEW, RMAppState.NEW_SAVING, RMAppState.FAILED,
                  RMAppState.FINAL_SAVING, RMAppState.FINISHING, RMAppState.FINISHED,
                  RMAppState.KILLED, RMAppState.KILLING, RMAppState.FAILED).contains(
                  application.getState())) {
          
          Show
          jianhe Jian He added a comment - I think we can throw YarnException with message "Application in <app-state> state cannot be update priority." Any thoughts? sounds good to me. We may just check if app is at RUNNING state for below if condition ? if (EnumSet.of(RMAppState.NEW, RMAppState.NEW_SAVING, RMAppState.FAILED, RMAppState.FINAL_SAVING, RMAppState.FINISHING, RMAppState.FINISHED, RMAppState.KILLED, RMAppState.KILLING, RMAppState.FAILED).contains( application.getState())) {
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Updating the modified patch, kindly review the patch.

          Show
          rohithsharma Rohith Sharma K S added a comment - Updating the modified patch, kindly review the patch.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          we can make updateApplicationPriority throw an ApplicationNotRunningException and let client catch the exception and prints “Application not running “ msg

          In ClientRMService#updateApplicationPriority, update priority to scheduler will not be called if application is in NEW , NEW_SAVING also. So I feel having new exception ApplicationNotRunningException would lead to confusion. I think we can throw YarnException with message "Application in <app-state> state cannot be update priority." Any thoughts?

          Show
          rohithsharma Rohith Sharma K S added a comment - we can make updateApplicationPriority throw an ApplicationNotRunningException and let client catch the exception and prints “Application not running “ msg In ClientRMService#updateApplicationPriority , update priority to scheduler will not be called if application is in NEW , NEW_SAVING also. So I feel having new exception ApplicationNotRunningException would lead to confusion. I think we can throw YarnException with message "Application in <app-state> state cannot be update priority." Any thoughts?
          Hide
          jianhe Jian He added a comment -

          some comments on my side:

          • updateApplicationPriority has two RPC calls, one to get the appReport the other to update priority. Can we make it one call ? we can make updateApplicationPriority throw an ApplicationNotRunningException and let client catch the exception and prints “Application not running “ msg.
          • I missed two things in YARN-3887, would you mind fixing those here ?
            • the updateApplicationStateSynchronously should not send the APP_UPDATE_SAVED events and so RMAppImpl should not need handle this event as changed this patch.
            • CapacityScheduler#updateApplicationPriority should not be synchronized. it’ll cause problem if hold capacity scheduler lock while accessing state-store.
          Show
          jianhe Jian He added a comment - some comments on my side: updateApplicationPriority has two RPC calls, one to get the appReport the other to update priority. Can we make it one call ? we can make updateApplicationPriority throw an ApplicationNotRunningException and let client catch the exception and prints “Application not running “ msg. I missed two things in YARN-3887 , would you mind fixing those here ? the updateApplicationStateSynchronously should not send the APP_UPDATE_SAVED events and so RMAppImpl should not need handle this event as changed this patch. CapacityScheduler#updateApplicationPriority should not be synchronized. it’ll cause problem if hold capacity scheduler lock while accessing state-store.
          Hide
          eepayne Eric Payne added a comment -
          +    pw.println(" -appId <Application ID>         ApplicationId can be used with any other");
          +    pw.println("                                 sub commands in future. Currently it is");
          +    pw.println("                                 used along only with -set-priority");
          ...
          +          "ApplicationId can be used with any other sub commands in future."
          +          + " Currently it is used along only with -set-priority");
          

          This is a minor point, but in these 2 places, I would simply state something like the following:
          "ID of the affected application."

          That way, when it is used in the future by other switches, the developer doesn't have to remember to change these statements.

          Show
          eepayne Eric Payne added a comment - + pw.println( " -appId <Application ID> ApplicationId can be used with any other" ); + pw.println( " sub commands in future . Currently it is" ); + pw.println( " used along only with -set-priority" ); ... + "ApplicationId can be used with any other sub commands in future ." + + " Currently it is used along only with -set-priority" ); This is a minor point, but in these 2 places, I would simply state something like the following: "ID of the affected application." That way, when it is used in the future by other switches, the developer doesn't have to remember to change these statements.
          Hide
          sunilg Sunil G added a comment -

          Hi Rohith Sharma K S
          Thank you. Overall the patch looks good. Some minor nits

          • In ApplicationClientProtocolPBServiceImpl, you may try like below
            catch (YarnException | IOException e) {
                  throw new ServiceException(e);
            }
            
          • In ClientRMService
            +    if (EnumSet.of(RMAppState.NEW, RMAppState.NEW_SAVING, RMAppState.FAILED,
            +        RMAppState.FINAL_SAVING, RMAppState.FINISHING, RMAppState.FINISHED,
            +        RMAppState.KILLED, RMAppState.KILLING, RMAppState.FAILED).contains(
            +        application.getState()))
            

            Could we have a lookup method for this rather checking it directly. May be other apis can use this.

          • In testUpdateApplicationPriorityRequest, Could we pass an invalid AppID and check that error condition also.
          • While printing message
            +    pw.println(" -appId <Application ID>         ApplicationId can be used with any other");
            +    pw.println("                                 sub commands in future. Currently it is");
            +    pw.println("                                 used along only with -set-priority");
            

            -set-priority can be changed to -updatePriority

          Show
          sunilg Sunil G added a comment - Hi Rohith Sharma K S Thank you. Overall the patch looks good. Some minor nits In ApplicationClientProtocolPBServiceImpl, you may try like below catch (YarnException | IOException e) { throw new ServiceException(e); } In ClientRMService + if (EnumSet.of(RMAppState.NEW, RMAppState.NEW_SAVING, RMAppState.FAILED, + RMAppState.FINAL_SAVING, RMAppState.FINISHING, RMAppState.FINISHED, + RMAppState.KILLED, RMAppState.KILLING, RMAppState.FAILED).contains( + application.getState())) Could we have a lookup method for this rather checking it directly. May be other apis can use this. In testUpdateApplicationPriorityRequest, Could we pass an invalid AppID and check that error condition also. While printing message + pw.println( " -appId <Application ID> ApplicationId can be used with any other" ); + pw.println( " sub commands in future . Currently it is" ); + pw.println( " used along only with -set-priority" ); -set-priority can be changed to -updatePriority
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 29s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
          +1 javac 7m 44s There were no new javac warning messages.
          -1 javadoc 9m 47s The applied patch generated 4 additional warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 31s The applied patch generated 6 new checkstyle issues (total was 31, now 37).
          -1 whitespace 0m 13s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 26s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 6m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 mapreduce tests 119m 56s Tests failed in hadoop-mapreduce-client-jobclient.
          +1 yarn tests 0m 29s Tests passed in hadoop-yarn-api.
          +1 yarn tests 7m 5s Tests passed in hadoop-yarn-client.
          -1 yarn tests 2m 2s Tests failed in hadoop-yarn-common.
          -1 yarn tests 53m 23s Tests failed in hadoop-yarn-server-resourcemanager.
              232m 56s  



          Reason Tests
          Failed unit tests hadoop.yarn.util.TestRackResolver
            hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
          Timed out tests org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12750273/0001-YARN-4014.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 53bef9c
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/diffJavadocWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/whitespace.txt
          hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/testrun_hadoop-yarn-client.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8841/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8841/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 29s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 7m 44s There were no new javac warning messages. -1 javadoc 9m 47s The applied patch generated 4 additional warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 31s The applied patch generated 6 new checkstyle issues (total was 31, now 37). -1 whitespace 0m 13s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 6m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 119m 56s Tests failed in hadoop-mapreduce-client-jobclient. +1 yarn tests 0m 29s Tests passed in hadoop-yarn-api. +1 yarn tests 7m 5s Tests passed in hadoop-yarn-client. -1 yarn tests 2m 2s Tests failed in hadoop-yarn-common. -1 yarn tests 53m 23s Tests failed in hadoop-yarn-server-resourcemanager.     232m 56s   Reason Tests Failed unit tests hadoop.yarn.util.TestRackResolver   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Timed out tests org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750273/0001-YARN-4014.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 53bef9c javadoc https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/diffJavadocWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/whitespace.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/testrun_hadoop-yarn-client.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8841/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8841/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8841/console This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment - - edited

          Try it without the dash. "-appid". The reason many commands use camel case is because Hadoop was written in Java and most Hadoop devs have clearly never used the command line on a regular basis.

          Show
          aw Allen Wittenauer added a comment - - edited Try it without the dash. "-appid". The reason many commands use camel case is because Hadoop was written in Java and most Hadoop devs have clearly never used the command line on a regular basis.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Updated the working patch with test cases, kindly review it.

          Show
          rohithsharma Rohith Sharma K S added a comment - Updated the working patch with test cases, kindly review it.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          thanks Sunil G for the review..

          In ApplicationCLI, public static final String SET_PRIORITY = "setPriority";

          Done, changed to updatePriority

          In future --appId can be used with other parameters also, correct?

          Yes, Done

          updateApplicationPriority can throw NumberFormatException

          Since exception is directly thrown back to client cli, I think this should be fine.

          ClientRMService.java has few commented code.

          Yes , Since YARN-3887 was not committed, I was used that patch to compile but while uploading patch I commented for HadoopQA compilation. Now I have uncommented those lines.

          Show
          rohithsharma Rohith Sharma K S added a comment - thanks Sunil G for the review.. In ApplicationCLI, public static final String SET_PRIORITY = "setPriority"; Done, changed to updatePriority In future --appId can be used with other parameters also, correct? Yes, Done updateApplicationPriority can throw NumberFormatException Since exception is directly thrown back to client cli, I think this should be fine. ClientRMService.java has few commented code. Yes , Since YARN-3887 was not committed, I was used that patch to compile but while uploading patch I commented for HadoopQA compilation. Now I have uncommented those lines.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Tried the syntax app-id,but options does not take app-id as valid input. May this is the reason other commands has camel case.

          Show
          rohithsharma Rohith Sharma K S added a comment - Tried the syntax app-id,but options does not take app-id as valid input. May this is the reason other commands has camel case.
          Hide
          aw Allen Wittenauer added a comment -

          Could we please stop adding camel case arguments to shell commands?

          Show
          aw Allen Wittenauer added a comment - Could we please stop adding camel case arguments to shell commands?
          Hide
          sunilg Sunil G added a comment -

          Hi Rohith Sharma K S
          Thank you for sharing the patch. As discussed in YARN-3250, I also feel yarn application --appId <Applicationid> --setPriority <value> is fine.

          Few small nits:
          1. In ApplicationCLI, public static final String SET_PRIORITY = "setPriority";
          Cud we use "UPDATE_PRIORITY" instead of "SET_PRIORITY"?
          2. In future --appId can be used with other parameters also, correct? So below option may not be suitable.

          opts.addOption(APP_ID, true, "Updates the priority of an application");
          

          3. updateApplicationPriority can throw NumberFormatException.
          4. ClientRMService.java has few commented code.

          Show
          sunilg Sunil G added a comment - Hi Rohith Sharma K S Thank you for sharing the patch. As discussed in YARN-3250 , I also feel yarn application --appId <Applicationid> --setPriority <value> is fine. Few small nits: 1. In ApplicationCLI, public static final String SET_PRIORITY = "setPriority"; Cud we use "UPDATE_PRIORITY" instead of "SET_PRIORITY"? 2. In future --appId can be used with other parameters also, correct? So below option may not be suitable. opts.addOption(APP_ID, true , "Updates the priority of an application" ); 3. updateApplicationPriority can throw NumberFormatException. 4. ClientRMService.java has few commented code.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Thinking that should users i.e ApplicationClientProtocol should getClusterMaxPriority API exposed even though RM take care of resetting to clusterMax priority?? any thoughts?

          Show
          rohithsharma Rohith Sharma K S added a comment - Thinking that should users i.e ApplicationClientProtocol should getClusterMaxPriority API exposed even though RM take care of resetting to clusterMax priority?? any thoughts?
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Attached the version-1 patch for early comments without tests. The ApplicationCLI api is ./yarn application -appId <ApplicationId> -setPriority <value>.

          Show
          rohithsharma Rohith Sharma K S added a comment - Attached the version-1 patch for early comments without tests. The ApplicationCLI api is ./yarn application -appId <ApplicationId> -setPriority <value> .
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Basic API's discussions were done in YARN-3250, comment1. Just reiterating the discussion summary here

          1. User API :
            1. For changing priority of an application, the API ApplicationClientProtocol#setApplicationPriority(SetApplicationProrityRequest) wil be added. SetApplicationProrityRequest comprises of ApplicationId and Priority. The clientRMService invokes API introduced by YARN-3887 i.e. updateApplicationPriority();
            2. For getting prioryt of any applicaiton, there will be NO api's will be added. Retriving an priority of any application can be done using ApplicationReport after YARN-3948 committed.
          Show
          rohithsharma Rohith Sharma K S added a comment - Basic API's discussions were done in YARN-3250 , comment1 . Just reiterating the discussion summary here User API : For changing priority of an application, the API ApplicationClientProtocol#setApplicationPriority(SetApplicationProrityRequest) wil be added. SetApplicationProrityRequest comprises of ApplicationId and Priority . The clientRMService invokes API introduced by YARN-3887 i.e. updateApplicationPriority(); For getting prioryt of any applicaiton, there will be NO api's will be added. Retriving an priority of any application can be done using ApplicationReport after YARN-3948 committed.

            People

            • Assignee:
              rohithsharma Rohith Sharma K S
              Reporter:
              rohithsharma Rohith Sharma K S
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development