Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3958

TestYarnConfigurationFields should be moved to hadoop-yarn-api module

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The test is for checking whether all the configurations declared in YarnConfiguration exist in yarn-default.xml or not.
      But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this file, it is not necessary that this test will be run. So if the developer misses to update yarn-default.xml and patch is committed, it will lead to unnecessary test failures after commit.

      1. YARN-3958.03.patch
        14 kB
        Varun Saxena
      2. YARN-3958.02.patch
        14 kB
        Varun Saxena
      3. YARN-3958.01.patch
        14 kB
        Varun Saxena

        Issue Links

          Activity

          Hide
          varun_saxena Varun Saxena added a comment -

          Thanks Akira Ajisaka for the review and commit

          Show
          varun_saxena Varun Saxena added a comment - Thanks Akira Ajisaka for the review and commit
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2215/)
          YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2215/ ) YARN-3958 . TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #266 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/266/)
          YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #266 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/266/ ) YARN-3958 . TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #258 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/258/)
          YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #258 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/258/ ) YARN-3958 . TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2196 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2196/)
          YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2196 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2196/ ) YARN-3958 . TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #999 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/999/)
          YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #999 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/999/ ) YARN-3958 . TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #269 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/269/)
          YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #269 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/269/ ) YARN-3958 . TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8223 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8223/)
          YARN-3958. TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8223 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8223/ ) YARN-3958 . TestYarnConfigurationFields should be moved to hadoop-yarn-api module. Contributed by Varun Saxena. (aajisaka: rev 42d4e0ae99d162fde52902cb86e29f2c82a084c8) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/conf/TestYarnConfigurationFields.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Varun Saxena for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Varun Saxena for the contribution!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Varun Saxena for the comment.

          Pls note hadoop-yarn-api does not have dependency on hadoop-yarn-common in its pom.xml Change can be made but this should go in branch-2 then ?

          I understand. We cannot move YarnConfiguration class in branch-2.

          Moreover, realistically will somebody add a YARN related config in yarn-default.xml but not add it in YarnConfiguration class ? I think unlikely. The reverse happens far more frequently.

          Make sense to me.

          So in branch-2 we can just move this test to hadoop-yarn-api and in trunk, move YarnConfiguration to hadoop-yarn-common.

          I'll commit your latest patch in trunk and branch-2. Now I'm thinking moving YarnConfiguration to yarn-common in trunk makes little sense because it is unlikely that someone adds a config in yarn-default.xml but not add it in YarnConfiguration.java, as you said.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Varun Saxena for the comment. Pls note hadoop-yarn-api does not have dependency on hadoop-yarn-common in its pom.xml Change can be made but this should go in branch-2 then ? I understand. We cannot move YarnConfiguration class in branch-2. Moreover, realistically will somebody add a YARN related config in yarn-default.xml but not add it in YarnConfiguration class ? I think unlikely. The reverse happens far more frequently. Make sense to me. So in branch-2 we can just move this test to hadoop-yarn-api and in trunk, move YarnConfiguration to hadoop-yarn-common. I'll commit your latest patch in trunk and branch-2. Now I'm thinking moving YarnConfiguration to yarn-common in trunk makes little sense because it is unlikely that someone adds a config in yarn-default.xml but not add it in YarnConfiguration.java, as you said.
          Hide
          varun_saxena Varun Saxena added a comment -

          Akira Ajisaka,
          Checked the test. You are correct.
          But I think this would be a major change.
          I have a concern that there might be some projects which might have induced dependency in their pom on hadoop-yarn-api because they want to use YarnConfiguration class. Pls note hadoop-yarn-api does not have dependency on hadoop-yarn-common in its pom.xml
          Change can be made but this should go in branch-2 then ?

          Moreover, realistically will somebody add a YARN related config in yarn-default.xml but not add it in YarnConfiguration class ?
          I think unlikely. The reverse happens far more frequently.

          So in branch-2 we can just move this test to hadoop-yarn-api and in trunk, move YarnConfiguration to hadoop-yarn-common. Thoughts ?

          Show
          varun_saxena Varun Saxena added a comment - Akira Ajisaka , Checked the test. You are correct. But I think this would be a major change. I have a concern that there might be some projects which might have induced dependency in their pom on hadoop-yarn-api because they want to use YarnConfiguration class. Pls note hadoop-yarn-api does not have dependency on hadoop-yarn-common in its pom.xml Change can be made but this should go in branch-2 then ? Moreover, realistically will somebody add a YARN related config in yarn-default.xml but not add it in YarnConfiguration class ? I think unlikely. The reverse happens far more frequently. So in branch-2 we can just move this test to hadoop-yarn-api and in trunk, move YarnConfiguration to hadoop-yarn-common. Thoughts ?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Rethinking this issue, can we move YarnConfiguration.java to hadoop-yarn-common to fix the problem? If the patch is committed, Jenkins cannot run the test when yarn-default.xml is changed.

          Show
          ajisakaa Akira Ajisaka added a comment - Rethinking this issue, can we move YarnConfiguration.java to hadoop-yarn-common to fix the problem? If the patch is committed, Jenkins cannot run the test when yarn-default.xml is changed.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 28s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 40s There were no new javac warning messages.
          +1 javadoc 9m 37s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 55s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 20s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api.
          +1 yarn tests 1m 56s Tests passed in hadoop-yarn-common.
              44m 24s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12747066/YARN-3958.03.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / fbd6063
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8652/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8652/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8652/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8652/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 28s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 40s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 55s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api. +1 yarn tests 1m 56s Tests passed in hadoop-yarn-common.     44m 24s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12747066/YARN-3958.03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fbd6063 hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8652/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8652/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8652/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8652/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1 pending Jenkins. Thanks.

          Show
          ajisakaa Akira Ajisaka added a comment - +1 pending Jenkins. Thanks.
          Hide
          varun_saxena Varun Saxena added a comment -

          Akira Ajisaka, updated a new patch.

          Show
          varun_saxena Varun Saxena added a comment - Akira Ajisaka , updated a new patch.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Varun Saxena for updating the patch. Would you replace tabs with whitespaces in TestYarnConfigurationFields.java?

          +    configurationPropsToSkipCompare
          +        .add(YarnConfiguration
          +	    .YARN_SECURITY_SERVICE_AUTHORIZATION_APPLICATIONCLIENT_PROTOCOL);
          +    configurationPropsToSkipCompare
          +        .add(YarnConfiguration
          +	    .YARN_SECURITY_SERVICE_AUTHORIZATION_APPLICATIONMASTER_PROTOCOL);
          

          The code has tabs before .YARN_SECURITY_.... I'm +1 if that is addressed.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Varun Saxena for updating the patch. Would you replace tabs with whitespaces in TestYarnConfigurationFields.java? + configurationPropsToSkipCompare + .add(YarnConfiguration + .YARN_SECURITY_SERVICE_AUTHORIZATION_APPLICATIONCLIENT_PROTOCOL); + configurationPropsToSkipCompare + .add(YarnConfiguration + .YARN_SECURITY_SERVICE_AUTHORIZATION_APPLICATIONMASTER_PROTOCOL); The code has tabs before .YARN_SECURITY_... . I'm +1 if that is addressed.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 19m 22s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 8m 30s There were no new javac warning messages.
          +1 javadoc 10m 21s There were no new javadoc warning messages.
          +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 15s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 3m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api.
          +1 yarn tests 2m 2s Tests passed in hadoop-yarn-common.
              48m 46s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746801/YARN-3958.02.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ee98d63
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8635/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8635/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8635/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8635/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 22s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 30s There were no new javac warning messages. +1 javadoc 10m 21s There were no new javadoc warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 15s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 3m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 23s Tests passed in hadoop-yarn-api. +1 yarn tests 2m 2s Tests passed in hadoop-yarn-common.     48m 46s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746801/YARN-3958.02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ee98d63 hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8635/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8635/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8635/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8635/console This message was automatically generated.
          Hide
          varun_saxena Varun Saxena added a comment -

          Fixed whitespace issue

          Show
          varun_saxena Varun Saxena added a comment - Fixed whitespace issue
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Cancelling my +1. Hi Varun Saxena, could you remove tabs in TestYarnConfigurationFields.java in this jira?

          Show
          ajisakaa Akira Ajisaka added a comment - Cancelling my +1. Hi Varun Saxena , could you remove tabs in TestYarnConfigurationFields.java in this jira?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 10s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 54s There were no new javac warning messages.
          +1 javadoc 9m 50s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 53s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 25s mvn install still works.
          +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
          +1 findbugs 3m 9s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 24s Tests passed in hadoop-yarn-api.
          +1 yarn tests 1m 57s Tests passed in hadoop-yarn-common.
              45m 48s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746657/YARN-3958.01.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 06e5dd2
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/8626/artifact/patchprocess/whitespace.txt
          hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8626/artifact/patchprocess/testrun_hadoop-yarn-api.txt
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8626/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8626/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8626/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 10s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 54s There were no new javac warning messages. +1 javadoc 9m 50s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 53s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 25s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. +1 findbugs 3m 9s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 24s Tests passed in hadoop-yarn-api. +1 yarn tests 1m 57s Tests passed in hadoop-yarn-common.     45m 48s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746657/YARN-3958.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 06e5dd2 whitespace https://builds.apache.org/job/PreCommit-YARN-Build/8626/artifact/patchprocess/whitespace.txt hadoop-yarn-api test log https://builds.apache.org/job/PreCommit-YARN-Build/8626/artifact/patchprocess/testrun_hadoop-yarn-api.txt hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8626/artifact/patchprocess/testrun_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8626/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8626/console This message was automatically generated.

            People

            • Assignee:
              varun_saxena Varun Saxena
              Reporter:
              varun_saxena Varun Saxena
            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development