Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3950

Add unique YARN_SHELL_ID environment variable to DistributedShell

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      As discussed in this comment, it would be useful to have a monotonically increasing and independent ID of some kind that is unique per shell in the distributed shell program.

      We can do that by adding a SHELL_ID env var.

      1. YARN-3950.001.patch
        7 kB
        Robert Kanter
      2. YARN-3950.002.patch
        7 kB
        Robert Kanter

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 39s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 46s There were no new javac warning messages.
          +1 javadoc 9m 41s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 22s The applied patch generated 2 new checkstyle issues (total was 46, now 48).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 21s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 42s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 6m 57s Tests passed in hadoop-yarn-applications-distributedshell.
              43m 27s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746452/YARN-3950.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 31f1171
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8602/artifact/patchprocess/diffcheckstylehadoop-yarn-applications-distributedshell.txt
          hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/8602/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8602/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8602/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 46s There were no new javac warning messages. +1 javadoc 9m 41s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 22s The applied patch generated 2 new checkstyle issues (total was 46, now 48). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 42s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 6m 57s Tests passed in hadoop-yarn-applications-distributedshell.     43m 27s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746452/YARN-3950.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 31f1171 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8602/artifact/patchprocess/diffcheckstylehadoop-yarn-applications-distributedshell.txt hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/8602/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8602/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8602/console This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          This needs to be either YARN_SHELL_ID or HADOOP_SHELL_ID. Having a 'naked' SHELL_ID pollutes the shell environment space.

          Show
          aw Allen Wittenauer added a comment - This needs to be either YARN_SHELL_ID or HADOOP_SHELL_ID. Having a 'naked' SHELL_ID pollutes the shell environment space.
          Hide
          rkanter Robert Kanter added a comment -

          Good point.

          The 002 patch renames it to YARN_SHELL_ID and fixes the checkstyle warnings.

          Show
          rkanter Robert Kanter added a comment - Good point. The 002 patch renames it to YARN_SHELL_ID and fixes the checkstyle warnings.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 30s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 6s There were no new javac warning messages.
          +1 javadoc 10m 27s There were no new javadoc warning messages.
          +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 20s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 22s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 42s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 7m 0s Tests passed in hadoop-yarn-applications-distributedshell.
              45m 25s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746659/YARN-3950.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 06e5dd2
          hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/8625/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8625/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8625/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 30s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 6s There were no new javac warning messages. +1 javadoc 10m 27s There were no new javadoc warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 20s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 42s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 7m 0s Tests passed in hadoop-yarn-applications-distributedshell.     45m 25s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746659/YARN-3950.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 06e5dd2 hadoop-yarn-applications-distributedshell test log https://builds.apache.org/job/PreCommit-YARN-Build/8625/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8625/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8625/console This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          +1 lgtm. Will commit tomorrow if there are no objections.

          Show
          jlowe Jason Lowe added a comment - +1 lgtm. Will commit tomorrow if there are no objections.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks to Robert for the contribution and to Allen for additional review! I committed this to trunk and branch-2.

          Show
          jlowe Jason Lowe added a comment - Thanks to Robert for the contribution and to Allen for additional review! I committed this to trunk and branch-2.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8239 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8239/)
          YARN-3950. Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8239 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8239/ ) YARN-3950 . Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java
          Hide
          rkanter Robert Kanter added a comment -

          Thanks!

          Show
          rkanter Robert Kanter added a comment - Thanks!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1002 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1002/)
          YARN-3950. Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1002 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1002/ ) YARN-3950 . Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #272 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/272/)
          YARN-3950. Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #272 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/272/ ) YARN-3950 . Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #261 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/261/)
          YARN-3950. Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #261 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/261/ ) YARN-3950 . Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2199 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2199/)
          YARN-3950. Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2199 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2199/ ) YARN-3950 . Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #269 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/269/)
          YARN-3950. Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #269 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/269/ ) YARN-3950 . Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2218 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2218/)
          YARN-3950. Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2218 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2218/ ) YARN-3950 . Add unique SHELL_ID environment variable to DistributedShell. Contributed by Robert Kanter (jlowe: rev 2b2bd9214604bc2e14e41e08d30bf86f512151bd) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSAppMaster.java hadoop-yarn-project/CHANGES.txt

            People

            • Assignee:
              rkanter Robert Kanter
              Reporter:
              rkanter Robert Kanter
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development