[YARN-3916] DrainDispatcher#await should wait till event has been completely handled

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Duplicate
• Affects Version/s: 2.7.0
• Target Version/s: 2.7.2
• Assignee: Varun Saxena
• Reporter: Varun Saxena
• Created: 11/Jul/15 11:18
• Updated: 30/Oct/15 06:03
• Resolved: 13/Jul/15 21:28

Description

DrainDispatcher#await should wait till event has been completely handled.
Currently it only checks for whether event queue has become empty.

And in many tests we directly check for a state to be changed after calling await.
Sometimes, the states do not change by the time we check them as event has not been completely handled.

This is causing test failures such as YARN-3909 and YARN-3910 and may cause other test failures as well.

Issue Links

• is duplicated by: YARN-3909 TestAMRMRPCNodeUpdates#testAMRMUnusableNodes fails on trunk
• is duplicated by: YARN-3910 TestRMAppTransitions#testAppAcceptedAttemptKilled fails on trunk
• is duplicated by: YARN-3913 TestResourceTrackerService#testReconnectNode fails on trunk
• is duplicated by: YARN-3918 TestApplicationCleanup#testContainerCleanup occasionally fails on trunk
• is duplicated by: YARN-3878 AsyncDispatcher can hang while stopping if it is configured for draining events on stop
• relates to: YARN-3909 TestAMRMRPCNodeUpdates#testAMRMUnusableNodes fails on trunk
• relates to: YARN-3910 TestRMAppTransitions#testAppAcceptedAttemptKilled fails on trunk
• relates to: YARN-3878 AsyncDispatcher can hang while stopping if it is configured for draining events on stop