Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3900

Protobuf layout of yarn_security_token causes errors in other protos that include it

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Because of the subdirectory server used in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto there are errors in other protos that include them.
      As per the docs http://sergei-ivanov.github.io/maven-protoc-plugin/usage.html

       Any subdirectories under src/main/proto/ are treated as package structure for protobuf definition imports.
      1. YARN-3900.001.patch
        10 kB
        Anubhav Dhoot
      2. YARN-3900.001.patch
        10 kB
        Anubhav Dhoot
      3. YARN-3900.002.patch
        10 kB
        Anubhav Dhoot

        Issue Links

          Activity

          Hide
          adhoot Anubhav Dhoot added a comment -

          Simply printing EpochProto.toString causes the following error which on debugging shows the culprit.
          The exception is thrown in Descriptors

           for (int i = 0; i < proto.getDependencyCount(); i++) {
                  if (!dependencies[i].getName().equals(proto.getDependency(i))) {
                    throw new DescriptorValidationException(result,
                      "Dependencies passed to FileDescriptor.buildFrom() don't match " +
                      "those listed in the FileDescriptorProto.");
          

          And looking at the variables the mismatch is for

          dependencies[i].getName() = {java.lang.String@856} "server/yarn_security_token.proto"
          proto.getDependency(i) = {java.lang.String@857} "yarn_security_token.proto"
          

          Here is the error

          java.lang.ExceptionInInitializerError
                  at org.apache.hadoop.yarn.proto.YarnServerResourceManagerRecoveryProtos$EpochProto.internalGetFieldAccessorTable(YarnServerResourceManagerRecoveryProtos.java:3522)
                  at com.google.protobuf.GeneratedMessage.getAllFieldsMutable(GeneratedMessage.java:105)
                  at com.google.protobuf.GeneratedMessage.getAllFields(GeneratedMessage.java:153)
                  at com.google.protobuf.TextFormat$Printer.print(TextFormat.java:272)
                  at com.google.protobuf.TextFormat$Printer.access$400(TextFormat.java:248)
                  at com.google.protobuf.TextFormat.print(TextFormat.java:71)
                  at com.google.protobuf.TextFormat.printToString(TextFormat.java:118)
                  at com.google.protobuf.AbstractMessage.toString(AbstractMessage.java:106)
                  at org.apache.hadoop.yarn.server.resourcemanager.recovery.TestProtos.testResourceProto(TestProtos.java:32)
                  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
                  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
                  at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
                  at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
                  at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
                  at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
                  at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
                  at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
                  at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
                  at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
                  at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
                  at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
                  at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
                  at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
                  at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
                  at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
                  at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:78)
                  at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:212)
                  at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:68)
                  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
                  at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)
          Caused by: java.lang.IllegalArgumentException: Invalid embedded descriptor for "yarn_server_resourcemanager_recovery.proto".
                  at com.google.protobuf.Descriptors$FileDescriptor.internalBuildGeneratedFileFrom(Descriptors.java:301)
                  at org.apache.hadoop.yarn.proto.YarnServerResourceManagerRecoveryProtos.<clinit>(YarnServerResourceManagerRecoveryProtos.java:5370)
                  ... 35 more
          Caused by: com.google.protobuf.Descriptors$DescriptorValidationException: yarn_server_resourcemanager_recovery.proto: Dependencies passed to FileDescriptor.buildFrom() don't match those listed in the FileDescriptorProto.
                  at com.google.protobuf.Descriptors$FileDescriptor.buildFrom(Descriptors.java:246)
                  at com.google.protobuf.Descriptors$FileDescriptor.internalBuildGeneratedFileFrom(Descriptors.java:299)
                  ... 36 more
          
          Show
          adhoot Anubhav Dhoot added a comment - Simply printing EpochProto.toString causes the following error which on debugging shows the culprit. The exception is thrown in Descriptors for (int i = 0; i < proto.getDependencyCount(); i++) { if (!dependencies[i].getName().equals(proto.getDependency(i))) { throw new DescriptorValidationException(result, "Dependencies passed to FileDescriptor.buildFrom() don't match " + "those listed in the FileDescriptorProto."); And looking at the variables the mismatch is for dependencies[i].getName() = {java.lang.String@856} "server/yarn_security_token.proto" proto.getDependency(i) = {java.lang.String@857} "yarn_security_token.proto" Here is the error java.lang.ExceptionInInitializerError at org.apache.hadoop.yarn.proto.YarnServerResourceManagerRecoveryProtos$EpochProto.internalGetFieldAccessorTable(YarnServerResourceManagerRecoveryProtos.java:3522) at com.google.protobuf.GeneratedMessage.getAllFieldsMutable(GeneratedMessage.java:105) at com.google.protobuf.GeneratedMessage.getAllFields(GeneratedMessage.java:153) at com.google.protobuf.TextFormat$Printer.print(TextFormat.java:272) at com.google.protobuf.TextFormat$Printer.access$400(TextFormat.java:248) at com.google.protobuf.TextFormat.print(TextFormat.java:71) at com.google.protobuf.TextFormat.printToString(TextFormat.java:118) at com.google.protobuf.AbstractMessage.toString(AbstractMessage.java:106) at org.apache.hadoop.yarn.server.resourcemanager.recovery.TestProtos.testResourceProto(TestProtos.java:32) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229) at org.junit.runners.ParentRunner.run(ParentRunner.java:309) at org.junit.runner.JUnitCore.run(JUnitCore.java:160) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:78) at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:212) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:68) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140) Caused by: java.lang.IllegalArgumentException: Invalid embedded descriptor for "yarn_server_resourcemanager_recovery.proto". at com.google.protobuf.Descriptors$FileDescriptor.internalBuildGeneratedFileFrom(Descriptors.java:301) at org.apache.hadoop.yarn.proto.YarnServerResourceManagerRecoveryProtos.<clinit>(YarnServerResourceManagerRecoveryProtos.java:5370) ... 35 more Caused by: com.google.protobuf.Descriptors$DescriptorValidationException: yarn_server_resourcemanager_recovery.proto: Dependencies passed to FileDescriptor.buildFrom() don't match those listed in the FileDescriptorProto. at com.google.protobuf.Descriptors$FileDescriptor.buildFrom(Descriptors.java:246) at com.google.protobuf.Descriptors$FileDescriptor.internalBuildGeneratedFileFrom(Descriptors.java:299) ... 36 more
          Hide
          adhoot Anubhav Dhoot added a comment -

          Attaching a simple fix that moves out the proto from the subdirectory and corresponding fix

          Show
          adhoot Anubhav Dhoot added a comment - Attaching a simple fix that moves out the proto from the subdirectory and corresponding fix
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 44s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 47s There were no new javac warning messages.
          +1 javadoc 9m 51s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 46s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 23s mvn install still works.
          +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
          +1 findbugs 3m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 1m 58s Tests passed in hadoop-yarn-common.
          +1 yarn tests 3m 10s Tests passed in hadoop-yarn-server-applicationhistoryservice.
          -1 yarn tests 50m 56s Tests failed in hadoop-yarn-server-resourcemanager.
              100m 29s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService
            hadoop.yarn.server.resourcemanager.reservation.TestFairReservationSystem
            hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12744322/YARN-3900.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 2e3d83f
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8458/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/8458/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8458/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8458/testReport/
          Java 1.7.0_55
          uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8458/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 44s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 47s There were no new javac warning messages. +1 javadoc 9m 51s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 46s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 23s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 3m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 1m 58s Tests passed in hadoop-yarn-common. +1 yarn tests 3m 10s Tests passed in hadoop-yarn-server-applicationhistoryservice. -1 yarn tests 50m 56s Tests failed in hadoop-yarn-server-resourcemanager.     100m 29s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService   hadoop.yarn.server.resourcemanager.reservation.TestFairReservationSystem   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokens Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744322/YARN-3900.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2e3d83f hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8458/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/8458/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8458/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8458/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8458/console This message was automatically generated.
          Hide
          adhoot Anubhav Dhoot added a comment -

          Retriggering jenkins as failures did not repro locally for me

          Show
          adhoot Anubhav Dhoot added a comment - Retriggering jenkins as failures did not repro locally for me
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 15s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 39s There were no new javac warning messages.
          +1 javadoc 9m 36s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 8s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 20s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 3m 56s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 1m 56s Tests passed in hadoop-yarn-common.
          +1 yarn tests 3m 12s Tests passed in hadoop-yarn-server-applicationhistoryservice.
          -1 yarn tests 51m 4s Tests failed in hadoop-yarn-server-resourcemanager.
              100m 6s  



          Reason Tests
          Failed unit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRMRPCNodeUpdates
            hadoop.yarn.server.resourcemanager.TestResourceTrackerService
            hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12744815/YARN-3900.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 47f4c54
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8499/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/8499/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8499/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8499/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8499/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 15s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 39s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 8s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 56s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 1m 56s Tests passed in hadoop-yarn-common. +1 yarn tests 3m 12s Tests passed in hadoop-yarn-server-applicationhistoryservice. -1 yarn tests 51m 4s Tests failed in hadoop-yarn-server-resourcemanager.     100m 6s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRMRPCNodeUpdates   hadoop.yarn.server.resourcemanager.TestResourceTrackerService   hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744815/YARN-3900.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 47f4c54 hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8499/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/8499/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8499/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8499/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8499/console This message was automatically generated.
          Hide
          adhoot Anubhav Dhoot added a comment -

          All failures were due to flaky tests with jiras open (TestAMRMRPCNodeUpdates YARN-3909, TestResourceTrackerService YARN-3913, TestRMAppTransitions YARN-3910)

          Show
          adhoot Anubhav Dhoot added a comment - All failures were due to flaky tests with jiras open (TestAMRMRPCNodeUpdates YARN-3909 , TestResourceTrackerService YARN-3913 , TestRMAppTransitions YARN-3910 )
          Hide
          adhoot Anubhav Dhoot added a comment -

          This is needed for YARN-3736. Without this the leveldb state store implementation of YARN-3736 actually causes a dump

          Show
          adhoot Anubhav Dhoot added a comment - This is needed for YARN-3736 . Without this the leveldb state store implementation of YARN-3736 actually causes a dump
          Hide
          adhoot Anubhav Dhoot added a comment -

          Updated patch for recent changes in ContainerTokenIdentifierProto

          Show
          adhoot Anubhav Dhoot added a comment - Updated patch for recent changes in ContainerTokenIdentifierProto
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 15m 51s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 43s There were no new javac warning messages.
          +1 javadoc 9m 44s There were no new javadoc warning messages.
          +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 36s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 20s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 59s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 1m 55s Tests passed in hadoop-yarn-common.
          +1 yarn tests 3m 11s Tests passed in hadoop-yarn-server-applicationhistoryservice.
          +1 yarn tests 51m 8s Tests passed in hadoop-yarn-server-resourcemanager.
              97m 24s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12745719/YARN-3900.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 3540d5f
          hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8564/artifact/patchprocess/testrun_hadoop-yarn-common.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/8564/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8564/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8564/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8564/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 51s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 43s There were no new javac warning messages. +1 javadoc 9m 44s There were no new javadoc warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 36s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 59s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 1m 55s Tests passed in hadoop-yarn-common. +1 yarn tests 3m 11s Tests passed in hadoop-yarn-server-applicationhistoryservice. +1 yarn tests 51m 8s Tests passed in hadoop-yarn-server-resourcemanager.     97m 24s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12745719/YARN-3900.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3540d5f hadoop-yarn-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8564/artifact/patchprocess/testrun_hadoop-yarn-common.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/8564/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8564/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8564/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8564/console This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          lgtm

          Show
          jianhe Jian He added a comment - lgtm
          Hide
          rkanter Robert Kanter added a comment -

          +1

          Show
          rkanter Robert Kanter added a comment - +1
          Hide
          rkanter Robert Kanter added a comment -

          Thanks for the fix Anubhav. Committed to trunk and branch-2!

          Show
          rkanter Robert Kanter added a comment - Thanks for the fix Anubhav. Committed to trunk and branch-2!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8208 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8208/)
          YARN-3900. Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8208 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8208/ ) YARN-3900 . Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java
          Hide
          adhoot Anubhav Dhoot added a comment -

          Thanks Jian He for the review and Robert Kanter for the review and commit !

          Show
          adhoot Anubhav Dhoot added a comment - Thanks Jian He for the review and Robert Kanter for the review and commit !
          Hide
          jianhe Jian He added a comment -

          sorry, I +1'ed but forgot to commit. thanks for committing, Robert

          Show
          jianhe Jian He added a comment - sorry, I +1'ed but forgot to commit. thanks for committing, Robert
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #996 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/996/)
          YARN-3900. Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #996 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/996/ ) YARN-3900 . Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #266 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/266/)
          YARN-3900. Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #266 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/266/ ) YARN-3900 . Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2193/)
          YARN-3900. Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2193/ ) YARN-3900 . Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #255 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/255/)
          YARN-3900. Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #255 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/255/ ) YARN-3900 . Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2212 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2212/)
          YARN-3900. Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2212 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2212/ ) YARN-3900 . Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #263 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/263/)
          YARN-3900. Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #263 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/263/ ) YARN-3900 . Protobuf layout of yarn_security_token causes errors in other protos that include it (adhoot via rkanter) (rkanter: rev 1d3026e7b3cf2f3a8a544b66ff14783cc590bdac) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestProtos.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/yarn_security_token.proto hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/proto/server/yarn_security_token.proto hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml

            People

            • Assignee:
              adhoot Anubhav Dhoot
              Reporter:
              adhoot Anubhav Dhoot
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development