Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3877

YarnClientImpl.submitApplication swallows exceptions

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When YarnClientImpl.submitApplication spins waiting for the application to be accepted, any interruption during its Sleep() calls are logged and swallowed.

      this makes it hard to interrupt the thread during shutdown. Really it should throw some form of exception and let the caller deal with it.

      1. YARN-3877.01.patch
        4 kB
        Varun Saxena
      2. YARN-3877.02.patch
        4 kB
        Varun Saxena
      3. YARN-3877.03.patch
        4 kB
        Varun Saxena
      4. YARN-3877.04.patch
        5 kB
        Varun Saxena

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 52s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 45s There were no new javac warning messages.
        +1 javadoc 9m 47s There were no new javadoc warning messages.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 30s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 0m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 6m 57s Tests passed in hadoop-yarn-client.
            44m 16s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12743320/YARN-3877.01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 2eae130
        hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8423/artifact/patchprocess/testrun_hadoop-yarn-client.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8423/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8423/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 52s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 9m 47s There were no new javadoc warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 30s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 6m 57s Tests passed in hadoop-yarn-client.     44m 16s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12743320/YARN-3877.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2eae130 hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8423/artifact/patchprocess/testrun_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8423/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8423/console This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        Steve Loughran / Chris Douglas kindly review

        Show
        varun_saxena Varun Saxena added a comment - Steve Loughran / Chris Douglas kindly review
        Hide
        chris.douglas Chris Douglas added a comment -
        • Not sure I understand this change:
          +    conf.setLong(YarnConfiguration.
          +        YARN_CLIENT_APPLICATION_CLIENT_PROTOCOL_POLL_TIMEOUT_MS, 2000);
          

          It seems like it would introduce timing bugs rather than prevent them. The @Test timeout should prevent the test from hanging; if the poll timeout fires before the interrupt is triggered, then the unit test will fail. Does config enforce a property that would be unverified without it?

        • If necessary, then it should probably also be relative to pollIntervalMs
        • This should probably be a separate test, instead of a subsection of testSubmitApplication
        Show
        chris.douglas Chris Douglas added a comment - Not sure I understand this change: + conf.setLong(YarnConfiguration. + YARN_CLIENT_APPLICATION_CLIENT_PROTOCOL_POLL_TIMEOUT_MS, 2000); It seems like it would introduce timing bugs rather than prevent them. The @Test timeout should prevent the test from hanging; if the poll timeout fires before the interrupt is triggered, then the unit test will fail. Does config enforce a property that would be unverified without it? If necessary, then it should probably also be relative to pollIntervalMs This should probably be a separate test, instead of a subsection of testSubmitApplication
        Hide
        varun_saxena Varun Saxena added a comment -

        Chris Douglas, thanks for the review.

        Yes, you are correct that this config is not required for test. Will remove it.
        Will move the relevant test code to a separate test.

        Show
        varun_saxena Varun Saxena added a comment - Chris Douglas , thanks for the review. Yes, you are correct that this config is not required for test. Will remove it. Will move the relevant test code to a separate test.
        Hide
        varun_saxena Varun Saxena added a comment -

        Chris Douglas, updated a new patch.
        Kindly review.

        To avoid timing issues in test, added code to wait for thread to enter sleep(enter TIMED_WAITING state) before call to interrupt.

        Show
        varun_saxena Varun Saxena added a comment - Chris Douglas , updated a new patch. Kindly review. To avoid timing issues in test, added code to wait for thread to enter sleep(enter TIMED_WAITING state) before call to interrupt.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 34s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 41s There were no new javac warning messages.
        +1 javadoc 9m 42s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 28s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 20s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 0m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 6m 55s Tests passed in hadoop-yarn-client.
            43m 31s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12745625/YARN-3877.02.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 1ba2986
        hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8558/artifact/patchprocess/testrun_hadoop-yarn-client.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8558/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8558/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 28s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 6m 55s Tests passed in hadoop-yarn-client.     43m 31s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12745625/YARN-3877.02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1ba2986 hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8558/artifact/patchprocess/testrun_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8558/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8558/console This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        LGTM. Do you think the final client.close() should go in a finally clause? Or better in a java 7 try-with-resources clause

        try{YarnClient client = new MockYarnClient()} {
        ...
        }
        
        Show
        stevel@apache.org Steve Loughran added a comment - LGTM. Do you think the final client.close() should go in a finally clause? Or better in a java 7 try-with-resources clause try {YarnClient client = new MockYarnClient()} { ... }
        Hide
        varun_saxena Varun Saxena added a comment -

        Ok...Will change.

        Show
        varun_saxena Varun Saxena added a comment - Ok...Will change.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 13s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 27s There were no new javac warning messages.
        +1 javadoc 10m 22s There were no new javadoc warning messages.
        +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 35s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 25s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 0m 57s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 6m 55s Tests failed in hadoop-yarn-client.
            46m 52s  



        Reason Tests
        Failed unit tests hadoop.yarn.client.api.impl.TestYarnClient



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12746536/YARN-3877.03.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 4025326
        hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8610/artifact/patchprocess/testrun_hadoop-yarn-client.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8610/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8610/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 13s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 27s There were no new javac warning messages. +1 javadoc 10m 22s There were no new javadoc warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 35s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 25s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 0m 57s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 6m 55s Tests failed in hadoop-yarn-client.     46m 52s   Reason Tests Failed unit tests hadoop.yarn.client.api.impl.TestYarnClient Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746536/YARN-3877.03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4025326 hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/8610/artifact/patchprocess/testrun_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8610/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8610/console This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        Test failure unrelated

        Show
        varun_saxena Varun Saxena added a comment - Test failure unrelated
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 52s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 11s There were no new javac warning messages.
        +1 javadoc 10m 37s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 27s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 0m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 yarn tests 7m 9s Tests passed in hadoop-yarn-client.
            46m 46s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12746536/YARN-3877.03.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 56e4f62
        hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9584/artifact/patchprocess/testrun_hadoop-yarn-client.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9584/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9584/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 52s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 11s There were no new javac warning messages. +1 javadoc 10m 37s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 27s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 7m 9s Tests passed in hadoop-yarn-client.     46m 46s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746536/YARN-3877.03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 56e4f62 hadoop-yarn-client test log https://builds.apache.org/job/PreCommit-YARN-Build/9584/artifact/patchprocess/testrun_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9584/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9584/console This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        LGTM

        +1

        Show
        stevel@apache.org Steve Loughran added a comment - LGTM +1
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Moving this improvement out of 2.7.2 and from future maintenance lines.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Moving this improvement out of 2.7.2 and from future maintenance lines.
        Hide
        Ying Zhang Ying Zhang added a comment -

        Hi Varun Saxena and Steve Loughran, thanks for making the patch. We have encountered the same issue. Beside YarnClientImpl.submitApplication, YarnClientImpl.killApplication is having the same issue. Do we still intend to get this in?

        Show
        Ying Zhang Ying Zhang added a comment - Hi Varun Saxena and Steve Loughran , thanks for making the patch. We have encountered the same issue. Beside YarnClientImpl.submitApplication, YarnClientImpl.killApplication is having the same issue. Do we still intend to get this in?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 3s trunk passed
        +1 compile 0m 24s trunk passed
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 0m 29s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 27s trunk passed
        +1 javadoc 0m 14s trunk passed
        +1 mvninstall 0m 18s the patch passed
        +1 compile 0m 17s the patch passed
        +1 javac 0m 17s the patch passed
        -1 checkstyle 0m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 3 new + 93 unchanged - 0 fixed = 96 total (was 93)
        +1 mvnsite 0m 24s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 34s the patch passed
        +1 javadoc 0m 12s the patch passed
        -1 unit 16m 41s hadoop-yarn-client in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        30m 5s



        Reason Tests
        Failed junit tests hadoop.yarn.client.api.impl.TestAMRMProxy



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12746536/YARN-3877.03.patch
        JIRA Issue YARN-3877
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b6fdebcfd8e6 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 537095d
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13184/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13184/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13184/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13184/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13184/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 3s trunk passed +1 compile 0m 24s trunk passed +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 18s the patch passed +1 compile 0m 17s the patch passed +1 javac 0m 17s the patch passed -1 checkstyle 0m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client: The patch generated 3 new + 93 unchanged - 0 fixed = 96 total (was 93) +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 34s the patch passed +1 javadoc 0m 12s the patch passed -1 unit 16m 41s hadoop-yarn-client in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 30m 5s Reason Tests Failed junit tests hadoop.yarn.client.api.impl.TestAMRMProxy Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12746536/YARN-3877.03.patch JIRA Issue YARN-3877 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b6fdebcfd8e6 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 537095d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13184/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13184/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13184/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13184/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Console output https://builds.apache.org/job/PreCommit-YARN-Build/13184/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for the comments Ying Zhang, We need to fix in YarnClientImpl.killApplication as well need to handle the checkstyle issues.

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for the comments Ying Zhang , We need to fix in YarnClientImpl.killApplication as well need to handle the checkstyle issues.
        Hide
        varun_saxena Varun Saxena added a comment -

        Yes. Somebody needs to commit it. Will look at killApplication too

        Show
        varun_saxena Varun Saxena added a comment - Yes. Somebody needs to commit it. Will look at killApplication too
        Hide
        stevel@apache.org Steve Loughran added a comment -

        was this ever committed? I guess not

        Show
        stevel@apache.org Steve Loughran added a comment - was this ever committed? I guess not
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 9m 32s trunk passed
        +1 compile 0m 23s trunk passed
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 0m 29s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 0m 43s trunk passed
        +1 javadoc 0m 17s trunk passed
        +1 mvninstall 0m 29s the patch passed
        +1 compile 0m 26s the patch passed
        +1 javac 0m 26s the patch passed
        +1 checkstyle 0m 18s the patch passed
        +1 mvnsite 0m 29s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 42s the patch passed
        +1 javadoc 0m 14s the patch passed
        +1 unit 16m 26s hadoop-yarn-client in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        32m 34s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829805/YARN-3877.04.patch
        JIRA Issue YARN-3877
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 08d29eebd6b5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 537095d
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13186/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13186/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 32s trunk passed +1 compile 0m 23s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 0m 43s trunk passed +1 javadoc 0m 17s trunk passed +1 mvninstall 0m 29s the patch passed +1 compile 0m 26s the patch passed +1 javac 0m 26s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 29s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 42s the patch passed +1 javadoc 0m 14s the patch passed +1 unit 16m 26s hadoop-yarn-client in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 32m 34s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829805/YARN-3877.04.patch JIRA Issue YARN-3877 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 08d29eebd6b5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 537095d Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13186/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client Console output https://builds.apache.org/job/PreCommit-YARN-Build/13186/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for the patch Varun Saxena, will get this patch committed if no further comments !

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for the patch Varun Saxena , will get this patch committed if no further comments !
        Hide
        xabriel Xabriel J Collazo Mojica added a comment -

        Folks, I see that the InterruptedException is being wrapped by a YarnException. This makes it cumbersome for the caller to interpret whether the Thread was interrupted. Can't we just rethrow the original InterruptedException?

        Show
        xabriel Xabriel J Collazo Mojica added a comment - Folks, I see that the InterruptedException is being wrapped by a YarnException . This makes it cumbersome for the caller to interpret whether the Thread was interrupted. Can't we just rethrow the original InterruptedException ?
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Xabriel J Collazo Mojica,
        InterruptedException is checked exception and hence if we require method to throw it then, we need to modify the YarnClient interface which would break the compatibility for existing clients hence cannot be included.
        Going ahead with committing the jira

        Show
        Naganarasimha Naganarasimha G R added a comment - Xabriel J Collazo Mojica , InterruptedException is checked exception and hence if we require method to throw it then, we need to modify the YarnClient interface which would break the compatibility for existing clients hence cannot be included. Going ahead with committing the jira
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for the contribution Varun Saxena, and review from Chris Douglas,Steve Loughran, Ying Zhang & Xabriel J Collazo Mojica

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for the contribution Varun Saxena , and review from Chris Douglas , Steve Loughran , Ying Zhang & Xabriel J Collazo Mojica
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10484 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10484/)
        YARN-3877. YarnClientImpl.submitApplication swallows exceptions. (naganarasimha_gr: rev e4e72db5f9f305b493138ab36f073fe5d1750ad8)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClient.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10484 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10484/ ) YARN-3877 . YarnClientImpl.submitApplication swallows exceptions. (naganarasimha_gr: rev e4e72db5f9f305b493138ab36f073fe5d1750ad8) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClient.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/YarnClientImpl.java
        Hide
        zhz Zhe Zhang added a comment -

        Hi Vinod, I'm considering this patch for branch-2.7. Any reason it was moved out of 2.7.2? Compatibility concern? Thanks.

        Show
        zhz Zhe Zhang added a comment - Hi Vinod, I'm considering this patch for branch-2.7. Any reason it was moved out of 2.7.2? Compatibility concern? Thanks.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks for the work Varun Saxena. I just backported to branch-2.7.

        Show
        zhz Zhe Zhang added a comment - Thanks for the work Varun Saxena . I just backported to branch-2.7.

          People

          • Assignee:
            varun_saxena Varun Saxena
            Reporter:
            stevel@apache.org Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            14 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development