[YARN-382] SchedulerUtils improve way normalizeRequest sets the resource capabilities

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.3-alpha
• Fix Version/s: 2.1.0-beta
• Component/s: scheduler
• Assignee: Zhijie Shen
• Reporter: Thomas Graves
• Created: 06/Feb/13 14:19
• Updated: 27/Aug/13 22:15
• Resolved: 02/Apr/13 18:10

Description

In YARN-370, we changed it from setting the capability to directly setting memory and cores:

• ask.setCapability(normalized);
  + ask.getCapability().setMemory(normalized.getMemory());
  + ask.getCapability().setVirtualCores(normalized.getVirtualCores());

We did this because it is directly setting the values in the original resource object passed in when the AM gets allocated and without it the AM doesn't get the resource normalized correctly in the submission context. See YARN-370 for more details.

I think we should find a better way of doing this long term, one so we don't have to keep adding things there when new resources are added, two because its a bit confusing as to what its doing and prone to someone accidentally breaking it in the future again. Something closer to what Arun suggested in YARN-370 would be better but we need to make sure all the places work and get some more testing on it before putting it in.

Issue Links

• relates to: YARN-486 Change startContainer NM API to accept Container as a parameter and make ContainerLaunchContext user land
• relates to: YARN-370 CapacityScheduler app submission fails when min alloc size not multiple of AM size
• relates to: YARN-193 Scheduler.normalizeRequest does not account for allocation requests that exceed maximumAllocation limits