Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3794

TestRMEmbeddedElector fails because of ambiguous LOG reference

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      After YARN-2921, MockRM has also a LOG field. Therefore LOG in the following code snippet is ambiguous.

          protected AdminService createAdminService() {
            return new AdminService(MockRMWithElector.this, getRMContext()) {
              @Override
              protected EmbeddedElectorService createEmbeddedElectorService() {
                return new EmbeddedElectorService(getRMContext()) {
                  @Override
                  public void becomeActive() throws
                      ServiceFailedException {
                    try {
                      callbackCalled.set(true);
                      LOG.info("Callback called. Sleeping now");
                      Thread.sleep(delayMs);
                      LOG.info("Sleep done");
                    } catch (InterruptedException e) {
                      e.printStackTrace();
                    }
                    super.becomeActive();
                  }
                };
              }
            };
          }
      

      Eclipse gives the following error:

      The field LOG is defined in an inherited type and an enclosing scope

      IMO, we should fix this as TestRMEmbeddedElector.LOG

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 6m 30s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 35s There were no new javac warning messages.
        +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 46s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 24s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 50m 49s Tests failed in hadoop-yarn-server-resourcemanager.
            69m 33s  



        Reason Tests
        Failed unit tests hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12738994/YARN-3794.01.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 95c73d4
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8236/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8236/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8236/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 6m 30s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 35s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 46s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 24s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 50m 49s Tests failed in hadoop-yarn-server-resourcemanager.     69m 33s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738994/YARN-3794.01.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 95c73d4 hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8236/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8236/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8236/console This message was automatically generated.
        Hide
        chengbing.liu Chengbing Liu added a comment -

        The failed test is unrelated.

        Show
        chengbing.liu Chengbing Liu added a comment - The failed test is unrelated.
        Hide
        devaraj.k Devaraj K added a comment -

        +1, Looks good to me, will commit it shortly.

        YARN-3790 exists to track the TestWorkPreservingRMRestart failure.

        Show
        devaraj.k Devaraj K added a comment - +1, Looks good to me, will commit it shortly. YARN-3790 exists to track the TestWorkPreservingRMRestart failure.
        Hide
        devaraj.k Devaraj K added a comment -

        Thanks Chengbing Liu for your contribution.

        Committed to trunk and branch-2.

        Show
        devaraj.k Devaraj K added a comment - Thanks Chengbing Liu for your contribution. Committed to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8009 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8009/)
        YARN-3794. TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8009 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8009/ ) YARN-3794 . TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
        Hide
        chengbing.liu Chengbing Liu added a comment -

        Thanks Devaraj K for committing!

        Show
        chengbing.liu Chengbing Liu added a comment - Thanks Devaraj K for committing!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #226 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/226/)
        YARN-3794. TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #226 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/226/ ) YARN-3794 . TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #956 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/956/)
        YARN-3794. TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #956 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/956/ ) YARN-3794 . TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2172 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2172/)
        YARN-3794. TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2172 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2172/ ) YARN-3794 . TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2154 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2154/)
        YARN-3794. TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2154 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2154/ ) YARN-3794 . TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #215 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/215/)
        YARN-3794. TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #215 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/215/ ) YARN-3794 . TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #224 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/224/)
        YARN-3794. TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #224 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/224/ ) YARN-3794 . TestRMEmbeddedElector fails because of ambiguous LOG reference. (devaraj: rev d8dcfa98e3ca6a6fea414fd503589bb83b7a9c51) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMEmbeddedElector.java hadoop-yarn-project/CHANGES.txt

          People

          • Assignee:
            chengbing.liu Chengbing Liu
            Reporter:
            chengbing.liu Chengbing Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development