Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3789

Improve logs for LeafQueue#activateApplications()

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: resourcemanager
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Duplicate logging from resource manager
      during am limit check for each application

      015-06-09 17:32:40,019 INFO org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue: not starting application as amIfStarted exceeds amLimit
      
      2015-06-09 17:32:40,019 INFO org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue: not starting application as amIfStarted exceeds amLimit
      
      2015-06-09 17:32:40,019 INFO org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue: not starting application as amIfStarted exceeds amLimit
      
      2015-06-09 17:32:40,019 INFO org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue: not starting application as amIfStarted exceeds amLimit
      
      2015-06-09 17:32:40,019 INFO org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue: not starting application as amIfStarted exceeds amLimit
      
      2015-06-09 17:32:40,019 INFO org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue: not starting application as amIfStarted exceeds amLimit
      
      1. 0001-YARN-3789.patch
        3 kB
        Bibin A Chundatt
      2. 0002-YARN-3789.patch
        3 kB
        Bibin A Chundatt
      3. 0003-YARN-3789.patch
        3 kB
        Bibin A Chundatt
      4. 0004-YARN-3789.patch
        3 kB
        Bibin A Chundatt
      5. 0005-YARN-3789.patch
        3 kB
        Bibin A Chundatt

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2176 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2176/)
        YARN-3789. Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2176 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2176/ ) YARN-3789 . Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #228 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/228/)
        YARN-3789. Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #228 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/228/ ) YARN-3789 . Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #219 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/219/)
        YARN-3789. Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #219 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/219/ ) YARN-3789 . Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2158 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2158/)
        YARN-3789. Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2158 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2158/ ) YARN-3789 . Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #230 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/230/)
        YARN-3789. Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #230 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/230/ ) YARN-3789 . Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #960 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/960/)
        YARN-3789. Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #960 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/960/ ) YARN-3789 . Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8025 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8025/)
        YARN-3789. Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8025 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8025/ ) YARN-3789 . Improve logs for LeafQueue#activateApplications(). Contributed (devaraj: rev b039e69bb03accef485361af301fa59f03d08d6a) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        Hide
        devaraj.k Devaraj K added a comment -

        Thanks Bibin A Chundatt for the patch and Rohith Sharma K S for review.

        Committed to trunk and branch-2.

        Show
        devaraj.k Devaraj K added a comment - Thanks Bibin A Chundatt for the patch and Rohith Sharma K S for review. Committed to trunk and branch-2.
        Hide
        devaraj.k Devaraj K added a comment -

        +1, will commit it shortly.

        Show
        devaraj.k Devaraj K added a comment - +1, will commit it shortly.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Looks good to me too..

        Show
        rohithsharma Rohith Sharma K S added a comment - Looks good to me too..
        Hide
        devaraj.k Devaraj K added a comment -

        Thanks Bibin A Chundatt for the updated patch. It looks good to me.

        Rohith Sharma K S, do you have any comments on the latest patch?

        Show
        devaraj.k Devaraj K added a comment - Thanks Bibin A Chundatt for the updated patch. It looks good to me. Rohith Sharma K S , do you have any comments on the latest patch?
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Looked at the precommit build results. Checkstyle already existing , Test failure due to YARN-3790.

        Show
        bibinchundatt Bibin A Chundatt added a comment - Looked at the precommit build results. Checkstyle already existing , Test failure due to YARN-3790 .
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 59s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 33s There were no new javac warning messages.
        +1 javadoc 9m 32s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 46s The applied patch generated 1 new checkstyle issues (total was 153, now 151).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 25s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 50m 52s Tests failed in hadoop-yarn-server-resourcemanager.
            88m 41s  



        Reason Tests
        Failed unit tests hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12739612/0005-YARN-3789.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 4c5da9b
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8251/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8251/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8251/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8251/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 59s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 32s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 46s The applied patch generated 1 new checkstyle issues (total was 153, now 151). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 25s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 50m 52s Tests failed in hadoop-yarn-server-resourcemanager.     88m 41s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739612/0005-YARN-3789.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4c5da9b checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8251/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8251/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8251/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8251/console This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Devaraj K i have removed unused
        import org.apache.hadoop.yarn.server.resourcemanager.RMContext;
        Also updated the log as per your comments .

        Show
        bibinchundatt Bibin A Chundatt added a comment - Devaraj K i have removed unused import org.apache.hadoop.yarn.server.resourcemanager.RMContext; Also updated the log as per your comments .
        Hide
        devaraj.k Devaraj K added a comment -

        I had a look into the 0003-YARN-3789.patch previously, sorry for that. I think the latest patch also has the same issue with the message which I mentioned.

        Show
        devaraj.k Devaraj K added a comment - I had a look into the 0003- YARN-3789 .patch previously, sorry for that. I think the latest patch also has the same issue with the message which I mentioned.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Devaraj K Thnks for review . Seems you have reviewed based on 003-YARN-3789 . In activateApplications() its checks for new AM limits if the application is activated that is the reason why i updated the logs like .

        LOG.info("Not activating " + applicationId
        	              + ". If application activated usedAMResource " + amIfStarted
        	              + " will exceed amLimit " + amLimit);
        

        If 004-YARN-3789 is also still confusing will surely update log message.
        I will also handle unused imports as part of next patch after your reply.

        Show
        bibinchundatt Bibin A Chundatt added a comment - Devaraj K Thnks for review . Seems you have reviewed based on 003- YARN-3789 . In activateApplications() its checks for new AM limits if the application is activated that is the reason why i updated the logs like . LOG.info( "Not activating " + applicationId + ". If application activated usedAMResource " + amIfStarted + " will exceed amLimit " + amLimit); If 004- YARN-3789 is also still confusing will surely update log message. I will also handle unused imports as part of next patch after your reply.
        Hide
        devaraj.k Devaraj K added a comment -

        Thanks Bibin A Chundatt for the patch.

        1.

        +          LOG.info("Not activating " + applicationId
        +              + " if application activated usedAMResource " + amIfStarted
        +              + " exceeds amLimit " + amLimit);
        
        +          LOG.info("Not activating " + applicationId + " for user " + user
        +              + " if application activated usedUserAMResource  "
        +              + userAmIfStarted + " exceeds userAmLimit " + userAMLimit);
        

        These logs are still confusing(atleast to me), can you make some thing like this or anything better,

        Not activating application <applicationId> as amIfStarted: <amIfStarted> exceeds amLimit: <amLimit>.
        
        Not activating application <applicationId> for user: <user> as amIfStarted: <amIfStarted> exceeds userAmLimit: <userAMLimit>.
        

        2. Can you also remove the unused imports in the same file LeafQueue.java as part of this patch?

        Show
        devaraj.k Devaraj K added a comment - Thanks Bibin A Chundatt for the patch. 1. + LOG.info( "Not activating " + applicationId + + " if application activated usedAMResource " + amIfStarted + + " exceeds amLimit " + amLimit); + LOG.info( "Not activating " + applicationId + " for user " + user + + " if application activated usedUserAMResource " + + userAmIfStarted + " exceeds userAmLimit " + userAMLimit); These logs are still confusing(atleast to me), can you make some thing like this or anything better, Not activating application <applicationId> as amIfStarted: <amIfStarted> exceeds amLimit: <amLimit> . Not activating application <applicationId> for user: <user> as amIfStarted: <amIfStarted> exceeds userAmLimit: <userAMLimit> . 2. Can you also remove the unused imports in the same file LeafQueue.java as part of this patch?
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        +1(non-binding)

        Show
        rohithsharma Rohith Sharma K S added a comment - +1(non-binding)
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 56s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 46s There were no new javac warning messages.
        +1 javadoc 9m 55s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 48s The applied patch generated 1 new checkstyle issues (total was 153, now 152).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 50m 51s Tests failed in hadoop-yarn-server-resourcemanager.
            92m 23s  



        Reason Tests
        Failed unit tests hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12739547/0004-YARN-3789.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 4c5da9b
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8250/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8250/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8250/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8250/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 56s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 46s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 48s The applied patch generated 1 new checkstyle issues (total was 153, now 152). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 50m 51s Tests failed in hadoop-yarn-server-resourcemanager.     92m 23s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739547/0004-YARN-3789.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4c5da9b checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8250/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8250/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8250/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8250/console This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Rohith Sharma K S and Devaraj K .Please review the patch submitted. As mentioned earlier the check style issue seems unrelated and testcase addition not required since its just log updation.

        Show
        bibinchundatt Bibin A Chundatt added a comment - Rohith Sharma K S and Devaraj K .Please review the patch submitted. As mentioned earlier the check style issue seems unrelated and testcase addition not required since its just log updation.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        With this patch there is no increase in number of lines. Checkstyle issue seems unrelated

        Show
        bibinchundatt Bibin A Chundatt added a comment - With this patch there is no increase in number of lines. Checkstyle issue seems unrelated
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Rohith Sharma K S have handled the review comments.
        Test cases not added since patch updates only logs

        Show
        bibinchundatt Bibin A Chundatt added a comment - Rohith Sharma K S have handled the review comments. Test cases not added since patch updates only logs
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 57s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 36s There were no new javac warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 47s The applied patch generated 1 new checkstyle issues (total was 153, now 152).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 50m 51s Tests failed in hadoop-yarn-server-resourcemanager.
            88m 47s  



        Reason Tests
        Failed unit tests hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12738690/0003-YARN-3789.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 3c2397c
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8230/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8230/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8230/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8230/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 57s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 47s The applied patch generated 1 new checkstyle issues (total was 153, now 152). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 50m 51s Tests failed in hadoop-yarn-server-resourcemanager.     88m 47s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738690/0003-YARN-3789.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3c2397c checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/8230/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8230/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8230/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8230/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 0s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 37s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 46s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 24s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 yarn tests 50m 58s Tests failed in hadoop-yarn-server-resourcemanager.
            88m 54s  



        Reason Tests
        Failed unit tests hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12738603/0001-YARN-3789.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 8d0ef31
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8228/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8228/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/8228/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 0s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 46s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 24s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 yarn tests 50m 58s Tests failed in hadoop-yarn-server-resourcemanager.     88m 54s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738603/0001-YARN-3789.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8d0ef31 hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8228/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8228/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8228/console This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        I think, instead of Not starting, Not activating the application would make more meaningful.

        Show
        rohithsharma Rohith Sharma K S added a comment - I think, instead of Not starting , Not activating the application would make more meaningful.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Thanks Bibin A Chundatt for reporting and providing patch
        Some comments

        1. Log message can be made more clear for log analysis. The messages can be like
          1. Not starting the application <applicationId> as usedAMResource < amIfStarted > exceeds AMResourceLimit <amLimit>
          2. Not starting the application <applicationId> for the user <user> as usedUserAMResource < userAmIfStarted > exceeds userAMResourceLimit < userAMLimit >
        2. Can you update issue summary and description as real problem i.e issue is in log message correction, not removing duplicate logging.
        Show
        rohithsharma Rohith Sharma K S added a comment - Thanks Bibin A Chundatt for reporting and providing patch Some comments Log message can be made more clear for log analysis. The messages can be like Not starting the application <applicationId> as usedAMResource < amIfStarted > exceeds AMResourceLimit <amLimit> Not starting the application <applicationId> for the user <user> as usedUserAMResource < userAmIfStarted > exceeds userAMResourceLimit < userAMLimit > Can you update issue summary and description as real problem i.e issue is in log message correction, not removing duplicate logging.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Attaching patch for review

        Show
        bibinchundatt Bibin A Chundatt added a comment - Attaching patch for review

          People

          • Assignee:
            bibinchundatt Bibin A Chundatt
            Reporter:
            bibinchundatt Bibin A Chundatt
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development