Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3751

TestAHSWebServices fails after YARN-3467

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      YARN-3467 changed AppInfo and assumed that used resource is not null. It's not true as this information is not published to timeline server.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2164 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2164/)
          YARN-3751. Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2164 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2164/ ) YARN-3751 . Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #216 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/216/)
          YARN-3751. Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #216 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/216/ ) YARN-3751 . Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #207 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/207/)
          YARN-3751. Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #207 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/207/ ) YARN-3751 . Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2146 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2146/)
          YARN-3751. Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2146 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2146/ ) YARN-3751 . Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #948 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/948/)
          YARN-3751. Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #948 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/948/ ) YARN-3751 . Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #218 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/218/)
          YARN-3751. Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #218 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/218/ ) YARN-3751 . Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7952 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7952/)
          YARN-3751. Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7952 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7952/ ) YARN-3751 . Fixed AppInfo to check if used resources are null. Contributed by Sunil G. (zjshen: rev dbc4f64937ea2b4c941a3ac49afc4eeba3f5b763) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/webapp/dao/AppInfo.java hadoop-yarn-project/CHANGES.txt
          Hide
          sunilg Sunil G added a comment -

          Thank you Zhijie Shen for committing the patch!

          Show
          sunilg Sunil G added a comment - Thank you Zhijie Shen for committing the patch!
          Hide
          zjshen Zhijie Shen added a comment -

          Committed the patch to trunk/branch-2. Thanks, Sunil!

          Show
          zjshen Zhijie Shen added a comment - Committed the patch to trunk/branch-2. Thanks, Sunil!
          Hide
          zjshen Zhijie Shen added a comment -

          +1 LGTM

          No more test case is required, while the existing one covers the code already.

          Will commit the patch.

          Show
          zjshen Zhijie Shen added a comment - +1 LGTM No more test case is required, while the existing one covers the code already. Will commit the patch.
          Hide
          sunilg Sunil G added a comment -

          Hi Zhijie Shen
          I checked the patch and the tests are getting passed now. Please check if this is fine.

          Show
          sunilg Sunil G added a comment - Hi Zhijie Shen I checked the patch and the tests are getting passed now. Please check if this is fine.
          Hide
          sunilg Sunil G added a comment -

          Hi

          Show
          sunilg Sunil G added a comment - Hi
          Hide
          sunilg Sunil G added a comment -

          Findbugs warning can be skipped as exception handling is done in another method in WebServices.java and giving here as false positive.

          Existing test case in TestAHSWebServices covers this scenario.

          Show
          sunilg Sunil G added a comment - Findbugs warning can be skipped as exception handling is done in another method in WebServices.java and giving here as false positive. Existing test case in TestAHSWebServices covers this scenario.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 15m 56s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 54s There were no new javac warning messages.
          +1 javadoc 9m 55s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 35s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 31s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 1s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 yarn tests 0m 23s Tests passed in hadoop-yarn-server-common.
              38m 16s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12736418/0001-YARN-3751.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 63e3fee
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/8153/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html
          hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8153/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8153/testReport/
          Java 1.7.0_55
          uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8153/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 56s Pre-patch trunk has 3 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 54s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 35s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 1s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 0m 23s Tests passed in hadoop-yarn-server-common.     38m 16s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736418/0001-YARN-3751.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 63e3fee Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-YARN-Build/8153/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-common.html hadoop-yarn-server-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8153/artifact/patchprocess/testrun_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8153/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8153/console This message was automatically generated.
          Hide
          adhoot Anubhav Dhoot added a comment -

          There was no failure for this class in the jenkins run for YARN-3467.
          The change LGTM.

          Show
          adhoot Anubhav Dhoot added a comment - There was no failure for this class in the jenkins run for YARN-3467 . The change LGTM.
          Hide
          sunilg Sunil G added a comment -

          Zhijie Shen and Anubhav Dhoot

          ApplicationResourceUsageReportPBImpl.java
          
            public synchronized Resource getUsedResources() 
          

          This can return null also. Hence its better to have a check there in AppInfo.
          Sharing a patch for same.

          Show
          sunilg Sunil G added a comment - Zhijie Shen and Anubhav Dhoot ApplicationResourceUsageReportPBImpl.java public synchronized Resource getUsedResources() This can return null also. Hence its better to have a check there in AppInfo. Sharing a patch for same.
          Hide
          zjshen Zhijie Shen added a comment -
          Show
          zjshen Zhijie Shen added a comment - Link YARN-3467 /cc Anubhav Dhoot

            People

            • Assignee:
              sunilg Sunil G
              Reporter:
              zjshen Zhijie Shen
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development