[YARN-3713] Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition - ASF JIRA

Details

Type: Improvement
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.7.0
Fix Version/s: 2.8.0, 3.0.0-alpha1
Component/s: nodemanager
Labels:
- cleanup

Hadoop Flags:

Reviewed

Description

remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition. storeContainerDiagnostics is already called at ContainerImpl#addDiagnostics.

  private void addDiagnostics(String... diags) {
    for (String s : diags) {
      this.diagnostics.append(s);
    }
    try {
      stateStore.storeContainerDiagnostics(containerId, diagnostics);
    } catch (IOException e) {
      LOG.warn("Unable to update diagnostics in state store for "
          + containerId, e);
    }
  }

So we don't need call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition#transition.

      container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n");
      try {
        container.stateStore.storeContainerDiagnostics(container.containerId,
            container.diagnostics);
      } catch (IOException e) {
        LOG.warn("Unable to update state store diagnostics for "
            + container.containerId, e);
      }

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

YARN-3713.000.patch

26/May/15 07:29

1 kB

zhihai xu

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Hadoop QA added a comment - 26/May/15 08:13

-1 overall

Vote	Subsystem	Runtime	Comment
0	pre-patch	14m 44s	Pre-patch trunk compilation is healthy.
+1	@author	0m 0s	The patch does not contain any @author tags.
-1	tests included	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
+1	javac	7m 37s	There were no new javac warning messages.
+1	javadoc	9m 34s	There were no new javadoc warning messages.
+1	release audit	0m 23s	The applied patch does not increase the total number of release audit warnings.
+1	checkstyle	0m 51s	There were no new checkstyle issues.
+1	whitespace	0m 0s	The patch has no lines that end in whitespace.
+1	install	1m 34s	mvn install still works.
+1	eclipse:eclipse	0m 36s	The patch built with eclipse:eclipse.
+1	findbugs	1m 3s	The patch does not introduce any new Findbugs (version 3.0.0) warnings.
+1	yarn tests	6m 11s	Tests passed in hadoop-yarn-server-nodemanager.
		42m 36s

Subsystem	Report/Notes
Patch URL	http://issues.apache.org/jira/secure/attachment/12735265/YARN-3713.000.patch
Optional Tests	javadoc javac unit findbugs checkstyle
git revision	trunk / 56996a6
hadoop-yarn-server-nodemanager test log	https://builds.apache.org/job/PreCommit-YARN-Build/8080/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
Test Results	https://builds.apache.org/job/PreCommit-YARN-Build/8080/testReport/
Java	1.7.0_55
uname	Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
Console output	https://builds.apache.org/job/PreCommit-YARN-Build/8080/console

This message was automatically generated.

Show

Hadoop QA added a comment - 26/May/15 08:13 -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 44s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 51s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 1m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 yarn tests 6m 11s Tests passed in hadoop-yarn-server-nodemanager. 42m 36s Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735265/YARN-3713.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 56996a6 hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/8080/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8080/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8080/console This message was automatically generated.

Hide

Permalink

Robert Kanter added a comment - 29/May/15 01:11

Show

Robert Kanter added a comment - 29/May/15 01:11 +1

Hide

Permalink

Robert Kanter added a comment - 29/May/15 22:37

Thanks Zhihai. Committed to trunk and branch-2!

Show

Robert Kanter added a comment - 29/May/15 22:37 Thanks Zhihai. Committed to trunk and branch-2!

Hide

Permalink

Hudson added a comment - 29/May/15 22:46

FAILURE: Integrated in Hadoop-trunk-Commit #7929 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7929/)
~~YARN-3713~~. Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba)

hadoop-yarn-project/CHANGES.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java

Show

Hudson added a comment - 29/May/15 22:46 FAILURE: Integrated in Hadoop-trunk-Commit #7929 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7929/ ) YARN-3713 . Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java

Hide

Permalink

zhihai xu added a comment - 29/May/15 23:54

thanks Robert Kanter for the review and committing the patch.

Show

zhihai xu added a comment - 29/May/15 23:54 thanks Robert Kanter for the review and committing the patch.

Hide

Permalink

Hudson added a comment - 30/May/15 10:48

FAILURE: Integrated in Hadoop-Yarn-trunk #943 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/943/)
~~YARN-3713~~. Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba)

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
hadoop-yarn-project/CHANGES.txt

Show

Hudson added a comment - 30/May/15 10:48 FAILURE: Integrated in Hadoop-Yarn-trunk #943 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/943/ ) YARN-3713 . Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java hadoop-yarn-project/CHANGES.txt

Hide

Permalink

Hudson added a comment - 30/May/15 11:55

SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #213 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/213/)
~~YARN-3713~~. Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba)

hadoop-yarn-project/CHANGES.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java

Show

Hudson added a comment - 30/May/15 11:55 SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #213 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/213/ ) YARN-3713 . Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java

Hide

Permalink

Hudson added a comment - 30/May/15 14:33

SUCCESS: Integrated in Hadoop-Hdfs-trunk #2141 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2141/)
~~YARN-3713~~. Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba)

hadoop-yarn-project/CHANGES.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java

Show

Hudson added a comment - 30/May/15 14:33 SUCCESS: Integrated in Hadoop-Hdfs-trunk #2141 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2141/ ) YARN-3713 . Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java

Hide

Permalink

Hudson added a comment - 30/May/15 14:45

SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/202/)
~~YARN-3713~~. Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba)

hadoop-yarn-project/CHANGES.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java

Show

Hudson added a comment - 30/May/15 14:45 SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/202/ ) YARN-3713 . Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java

Hide

Permalink

Hudson added a comment - 30/May/15 15:17

SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #211 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/211/)
~~YARN-3713~~. Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba)

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
hadoop-yarn-project/CHANGES.txt

Show

Hudson added a comment - 30/May/15 15:17 SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #211 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/211/ ) YARN-3713 . Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java hadoop-yarn-project/CHANGES.txt

Hide

Permalink

Hudson added a comment - 30/May/15 15:35

SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2159/)
~~YARN-3713~~. Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba)

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
hadoop-yarn-project/CHANGES.txt

Show

Hudson added a comment - 30/May/15 15:35 SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2159/ ) YARN-3713 . Remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition (zxu via rkanter) (rkanter: rev 6aec13cb338b0fe62ca915f78aa729c9b0b86fba) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java hadoop-yarn-project/CHANGES.txt

People

Assignee:

zhihai xu

Reporter:

zhihai xu

Votes:

0 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

26/May/15 07:16

Updated:

30/Aug/16 01:21

Resolved:

29/May/15 22:37

Development

Agile

View on Board