-
Type:
Improvement
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.7.0
-
Fix Version/s: 2.8.0, 3.0.0-alpha1
-
Component/s: nodemanager
-
Labels:
-
Hadoop Flags:Reviewed
remove duplicate function call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition. storeContainerDiagnostics is already called at ContainerImpl#addDiagnostics.
private void addDiagnostics(String... diags) { for (String s : diags) { this.diagnostics.append(s); } try { stateStore.storeContainerDiagnostics(containerId, diagnostics); } catch (IOException e) { LOG.warn("Unable to update diagnostics in state store for " + containerId, e); } }
So we don't need call storeContainerDiagnostics in ContainerDiagnosticsUpdateTransition#transition.
container.addDiagnostics(updateEvent.getDiagnosticsUpdate(), "\n"); try { container.stateStore.storeContainerDiagnostics(container.containerId, container.diagnostics); } catch (IOException e) { LOG.warn("Unable to update state store diagnostics for " + container.containerId, e); }