[YARN-3648] ContainerExecutor interface methods are too brittle

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Sidharta Seethana
• Reporter: Sidharta Seethana
• Created: 14/May/15 21:42
• Updated: 19/May/15 21:28

Description

The ContainerExecutor interface today does not encapsulate method arguments in any way - this makes it brittle when executor implementations need additional arguments in order to implement certain functionality. A couple of example methods where this is a problem : startLocalizer , launchContainer - additional arguments would break the existing interface and would require changes to all executor implementations in YARN. In order to make this interface less brittle in the future, it would make sense to encapsulate arguments in some kind of a ‘context’ object which could be modified/extended without breaking the ContainerExecutor interface in the future.

Edit as per comment below : Along with this, we should also cleanup the abstraction to look more like an abstraction instead of a bolt-on--and-add-what-you-want kind of interface.

Sub-Tasks

• Decouple PID-file management from ContainerExecutor: Patch Available
• Create an abstraction in ContainerExecutor for Container-script generation: Open
• Change ContainerExecutor's primary lifecycle methods to use a more extensible mechanism for passing information.: Resolved
• NodeManager unnecessarily knows about classpath-jars due to Windows limitations: Open