Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3584

[Log mesage correction] : MIssing space in Diagnostics message

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      For more detailed output, check application tracking page: Then" class="external-link" rel="nofollow">https://szxciitslx17640:26001/cluster/app/application_1430810985970_0020Then, click on links to logs of each attempt.

      In this Then is not part of thr URL. Better to use a space in between so that the URL can be copied directly for analysis

      1. YARN-3584-1.patch
        1 kB
        nijel
      2. YARN-3584-2.patch
        2 kB
        nijel

        Activity

        Hide
        nijel nijel added a comment -

        Attached the change. Please review

        Show
        nijel nijel added a comment - Attached the change. Please review
        Hide
        nijel nijel added a comment -

        one more correction, will reapply the patch

        Show
        nijel nijel added a comment - one more correction, will reapply the patch
        Hide
        nijel nijel added a comment -

        updated patch

        Show
        nijel nijel added a comment - updated patch
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 16s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 45s There were no new javac warning messages.
        +1 javadoc 9m 57s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 47s The applied patch generated 2 new checkstyle issues (total was 123, now 123).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 16s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        -1 yarn tests 50m 55s Tests failed in hadoop-yarn-server-resourcemanager.
            88m 32s  



        Reason Tests
        Failed unit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService
          hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730719/YARN-3584-1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a583a40
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7728/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7728/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7728/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7728/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 16s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 9m 57s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 47s The applied patch generated 2 new checkstyle issues (total was 123, now 123). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 16s The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 yarn tests 50m 55s Tests failed in hadoop-yarn-server-resourcemanager.     88m 32s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService   hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesAppsModification Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730719/YARN-3584-1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a583a40 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7728/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7728/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7728/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7728/console This message was automatically generated.
        Hide
        nijel nijel added a comment -

        Test failures are not related to this patch
        Checkstyle is showing wrong warning i think. The lines starting at indent 10.

        Show
        nijel nijel added a comment - Test failures are not related to this patch Checkstyle is showing wrong warning i think. The lines starting at indent 10.
        Hide
        jianhe Jian He added a comment -

        thanks nijel for the patch. to make it more clear, could you flip below order ? append the "Diagnostics" first, then append "For more detailed output..."

            if (this.getTrackingUrl() != null) {
              diagnosticsBuilder.append("For more detailed output,").append(
                " check application tracking page: ").append(
                this.getTrackingUrl()).append(
                " Then, click on links to logs of each attempt.\n");
            }
            diagnosticsBuilder.append("Diagnostics: ").append(status.getDiagnostics())
                .append("Failing this attempt");
            return diagnosticsBuilder.toString();
        
        Show
        jianhe Jian He added a comment - thanks nijel for the patch. to make it more clear, could you flip below order ? append the "Diagnostics" first, then append "For more detailed output..." if ( this .getTrackingUrl() != null ) { diagnosticsBuilder.append( "For more detailed output," ).append( " check application tracking page: " ).append( this .getTrackingUrl()).append( " Then, click on links to logs of each attempt.\n" ); } diagnosticsBuilder.append( "Diagnostics: " ).append(status.getDiagnostics()) .append( "Failing this attempt" ); return diagnosticsBuilder.toString();
        Hide
        nijel nijel added a comment -

        Thanks Jian He
        Updated patch to fix the comment.

        Show
        nijel nijel added a comment - Thanks Jian He Updated patch to fix the comment.
        Hide
        jianhe Jian He added a comment -

        committed to trunk and branch-2, thanks nijel !

        Show
        jianhe Jian He added a comment - committed to trunk and branch-2, thanks nijel !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7762 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7762/)
        YARN-3584. Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7762 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7762/ ) YARN-3584 . Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #188 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/188/)
        YARN-3584. Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #188 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/188/ ) YARN-3584 . Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #188 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/188/)
        YARN-3584. Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #188 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/188/ ) YARN-3584 . Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #178 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/178/)
        YARN-3584. Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #178 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/178/ ) YARN-3584 . Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/)
        YARN-3584. Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #921 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/921/ ) YARN-3584 . Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/)
        YARN-3584. Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2119 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2119/ ) YARN-3584 . Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/)
        YARN-3584. Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2137 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2137/ ) YARN-3584 . Fixed attempt diagnostics format shown on the UI. Contributed by nijel (jianhe: rev b88700dcd0b9aa47662009241dfb83bc4446548d) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java

          People

          • Assignee:
            nijel nijel
            Reporter:
            nijel nijel
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development