Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3573

MiniMRYarnCluster constructor that starts the timeline server using a boolean should be marked deprecated

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: timelineserver
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS)

      starts the timeline server using boolean enableAHS. It is better to have the timelineserver started based on the config value.
      We should mark this constructor as deprecated to avoid its future use.

      1. YARN-3573.patch
        1 kB
        Brahma Reddy Battula
      2. YARN-3573-002.patch
        2 kB
        Brahma Reddy Battula

        Issue Links

          Activity

          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Mit Desai Thanks for reporting, Attached the patch kindly review..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Mit Desai Thanks for reporting, Attached the patch kindly review..
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 5m 9s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 28s There were no new javac warning messages.
          +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 32s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
          +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 mapreduce tests 106m 29s Tests passed in hadoop-mapreduce-client-jobclient.
              122m 45s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12730327/YARN-3573.patch
          Optional Tests javac unit findbugs checkstyle
          git revision trunk / 551615f
          hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/7699/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7699/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7699/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 9s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 32s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 0m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 mapreduce tests 106m 29s Tests passed in hadoop-mapreduce-client-jobclient.     122m 45s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730327/YARN-3573.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 551615f hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/7699/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7699/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7699/console This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          Before we deprecated this method, we should try to replace the calling on existing method with setting configuration explicitly and check if that works as expected. If that still works fine, then we are more comfortable to deprecated it.

          Show
          djp Junping Du added a comment - Before we deprecated this method, we should try to replace the calling on existing method with setting configuration explicitly and check if that works as expected. If that still works fine, then we are more comfortable to deprecated it.
          Hide
          mitdesai Mit Desai added a comment -

          Junping Du, YARN-2890 takes care of that concern.
          Brahma Reddy Battula, thanks for picking this Jira. I think there should be a similar change to MiniYARNCluster.

          public MiniYARNCluster(
                String testName, int numResourceManagers, int numNodeManagers,
                int numLocalDirs, int numLogDirs, boolean enableAHS) {
          

          This method is ultimately called by MiniMRYarnCluster.

          Show
          mitdesai Mit Desai added a comment - Junping Du , YARN-2890 takes care of that concern. Brahma Reddy Battula , thanks for picking this Jira. I think there should be a similar change to MiniYARNCluster. public MiniYARNCluster( String testName, int numResourceManagers, int numNodeManagers, int numLocalDirs, int numLogDirs, boolean enableAHS) { This method is ultimately called by MiniMRYarnCluster.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Junping Du Thanks for taking a look into this issue..YARN-2890 is addressed the same..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Junping Du Thanks for taking a look into this issue.. YARN-2890 is addressed the same..
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Yes, I will update in {{ MiniYARNCluster}} also.. thanks

          Show
          brahmareddy Brahma Reddy Battula added a comment - Yes, I will update in {{ MiniYARNCluster}} also.. thanks
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Attached the patch..kindly review..sorry for delay..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Attached the patch..kindly review..sorry for delay..
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          LGTM, pending for Jenkins.

          Show
          ozawa Tsuyoshi Ozawa added a comment - LGTM, pending for Jenkins.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Kicking Jenkins.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Kicking Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 7m 53s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          -1 javac 8m 58s The applied patch generated 4 additional warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 3s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 37s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 1m 43s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 mapreduce tests 105m 51s Tests failed in hadoop-mapreduce-client-jobclient.
          +1 yarn tests 2m 24s Tests passed in hadoop-yarn-server-tests.
              130m 30s  



          Reason Tests
          Failed unit tests hadoop.mapred.TestMiniMRClientCluster
            hadoop.mapreduce.v2.TestMRAMWithNonNormalizedCapabilities
            hadoop.mapreduce.TestMapReduceLazyOutput
            hadoop.mapreduce.v2.TestNonExistentJob
            hadoop.mapreduce.v2.TestMRAppWithCombiner
            hadoop.mapreduce.v2.TestUberAM
            hadoop.mapreduce.v2.TestMRJobsWithHistoryService
          Timed out tests org.apache.hadoop.mapreduce.v2.TestMRJobs



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12751672/YARN-3573-002.patch
          Optional Tests javac unit findbugs checkstyle
          git revision trunk / 5acdde4
          javac https://builds.apache.org/job/PreCommit-YARN-Build/9574/artifact/patchprocess/diffJavacWarnings.txt
          hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/9574/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
          hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/9574/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9574/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/9574/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 7m 53s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. -1 javac 8m 58s The applied patch generated 4 additional warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 3s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 1m 43s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 105m 51s Tests failed in hadoop-mapreduce-client-jobclient. +1 yarn tests 2m 24s Tests passed in hadoop-yarn-server-tests.     130m 30s   Reason Tests Failed unit tests hadoop.mapred.TestMiniMRClientCluster   hadoop.mapreduce.v2.TestMRAMWithNonNormalizedCapabilities   hadoop.mapreduce.TestMapReduceLazyOutput   hadoop.mapreduce.v2.TestNonExistentJob   hadoop.mapreduce.v2.TestMRAppWithCombiner   hadoop.mapreduce.v2.TestUberAM   hadoop.mapreduce.v2.TestMRJobsWithHistoryService Timed out tests org.apache.hadoop.mapreduce.v2.TestMRJobs Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12751672/YARN-3573-002.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 5acdde4 javac https://builds.apache.org/job/PreCommit-YARN-Build/9574/artifact/patchprocess/diffJavacWarnings.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-YARN-Build/9574/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt hadoop-yarn-server-tests test log https://builds.apache.org/job/PreCommit-YARN-Build/9574/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9574/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/9574/console This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Testcase failures are unrelated.. I had seen ,these are failing in pre-commit builds ..[~ozawa] kindly review..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Testcase failures are unrelated.. I had seen ,these are failing in pre-commit builds ..[~ozawa] kindly review..
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Brahma Reddy Battula I think one of the test failures are related. Could you fix it?

          TestMiniMRClientCluster.testRestart:146 Address before restart: asf909.gq1.ygridcore.net:0 is different from new address: asf909.gq1.ygridcore.net:48695 expected:<...9.gq1.ygridcore.net:[0]> but was:<...9.gq1.ygridcore.net:[48695]>

          Show
          ozawa Tsuyoshi Ozawa added a comment - Brahma Reddy Battula I think one of the test failures are related. Could you fix it? TestMiniMRClientCluster.testRestart:146 Address before restart: asf909.gq1.ygridcore.net:0 is different from new address: asf909.gq1.ygridcore.net:48695 expected:<...9.gq1.ygridcore.net: [0] > but was:<...9.gq1.ygridcore.net: [48695] >
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Is the problem I mentioned same to MAPREDUCE-6525?

          Show
          ozawa Tsuyoshi Ozawa added a comment - Is the problem I mentioned same to MAPREDUCE-6525 ?
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Yes, it is same.It's not related to this jira.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Yes, it is same.It's not related to this jira.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Make sense.

          +1, checking this in.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Make sense. +1, checking this in.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for your contribution and thanks Junping Du and Mit Desai for your review and reporting.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for your contribution and thanks Junping Du and Mit Desai for your review and reporting.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #589 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/589/)
          YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #589 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/589/ ) YARN-3573 . MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8712 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8712/)
          YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8712 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8712/ ) YARN-3573 . MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) hadoop-yarn-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #601 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/601/)
          YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #601 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/601/ ) YARN-3573 . MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) hadoop-yarn-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #541 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/541/)
          YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #541 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/541/ ) YARN-3573 . MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java hadoop-yarn-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1325 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1325/)
          YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1325 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1325/ ) YARN-3573 . MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2479 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2479/)
          YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2479 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2479/ ) YARN-3573 . MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java hadoop-yarn-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2532 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2532/)
          YARN-3573. MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2532 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2532/ ) YARN-3573 . MiniMRYarnCluster constructor that starts the timeline server (ozawa: rev 96677bef00b03057038157efeb3c2ad4702914da) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/MiniMRYarnCluster.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests/src/test/java/org/apache/hadoop/yarn/server/MiniYARNCluster.java hadoop-yarn-project/CHANGES.txt
          Hide
          boky01 Andras Bokor added a comment -

          Hi All,

          I run into this JIRA. I do not really understand the purpose of this fix. If the constructor is deprecated what is the preferred way to create a MiniYARNCluster object?

          Show
          boky01 Andras Bokor added a comment - Hi All, I run into this JIRA. I do not really understand the purpose of this fix. If the constructor is deprecated what is the preferred way to create a MiniYARNCluster object?
          Hide
          boky01 Andras Bokor added a comment -

          Anybody who can help me?

          Show
          boky01 Andras Bokor added a comment - Anybody who can help me?
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Earlier:

          MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS)

          Now:

          MiniMRYarnCluster(String testName, int noOfNMs)

          timelineserver startup wiil be based on the config value instead passing as Boolean param..

          Please refer YARN-2890 for more details...Hope this helps..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Earlier: MiniMRYarnCluster( String testName, int noOfNMs, boolean enableAHS) Now: MiniMRYarnCluster( String testName, int noOfNMs) timelineserver startup wiil be based on the config value instead passing as Boolean param.. Please refer YARN-2890 for more details...Hope this helps..
          Hide
          boky01 Andras Bokor added a comment -

          Brahma Reddy Battula Thanks for getting back to me. I meant MiniYARNCluster not MiniMRYarnCluster.
          Actually what I see is that through the other constructors we call the deprecated constructor. So finally we cannot avoid to call a deprecated method. It can be confusing at first time. Is it considered to remove?

          Show
          boky01 Andras Bokor added a comment - Brahma Reddy Battula Thanks for getting back to me. I meant MiniYARNCluster not MiniMRYarnCluster. Actually what I see is that through the other constructors we call the deprecated constructor. So finally we cannot avoid to call a deprecated method. It can be confusing at first time. Is it considered to remove?
          Hide
          djp Junping Du added a comment -

          I still doubt the necessary of this deprecation especially I learnt from TEZ-3694 where we build Tez against Hadoop 3. The constructor could be widely used by downstream projects and deprecation on these methods doesn't make sense unless we have significant gains here.

          Show
          djp Junping Du added a comment - I still doubt the necessary of this deprecation especially I learnt from TEZ-3694 where we build Tez against Hadoop 3. The constructor could be widely used by downstream projects and deprecation on these methods doesn't make sense unless we have significant gains here.

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              mitdesai Mit Desai
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development