Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      AM log links should always be present ( for both running and completed apps).

      Likewise node info is also empty. This is usually quite crucial when trying to debug where an AM was launched and a pointer to which NM's logs to look at if the AM failed to launch.

      1. YARN-3544-branch-2.7-1.patch
        10 kB
        Xuan Gong
      2. YARN-3544-branch-2.7-1.2.patch
        6 kB
        Xuan Gong
      3. YARN-3544-branch-2.6.1.txt
        8 kB
        Vinod Kumar Vavilapalli
      4. YARN-3544.1.patch
        6 kB
        Xuan Gong
      5. Screen Shot 2015-04-27 at 6.24.05 PM.png
        161 kB
        Xuan Gong

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2348 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2348/)
        CHANGES.txt: Moving YARN-1884, YARN-3171, YARN-3740, YARN-3248, YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2348 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2348/ ) CHANGES.txt: Moving YARN-1884 , YARN-3171 , YARN-3740 , YARN-3248 , YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc) hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2375 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2375/)
        CHANGES.txt: Moving YARN-1884, YARN-3171, YARN-3740, YARN-3248, YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2375 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2375/ ) CHANGES.txt: Moving YARN-1884 , YARN-3171 , YARN-3740 , YARN-3248 , YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc) hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #409 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/409/)
        CHANGES.txt: Moving YARN-1884, YARN-3171, YARN-3740, YARN-3248, YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #409 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/409/ ) CHANGES.txt: Moving YARN-1884 , YARN-3171 , YARN-3740 , YARN-3248 , YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc) hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1169 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1169/)
        CHANGES.txt: Moving YARN-1884, YARN-3171, YARN-3740, YARN-3248, YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1169 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1169/ ) CHANGES.txt: Moving YARN-1884 , YARN-3171 , YARN-3740 , YARN-3248 , YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc) hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #429 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/429/)
        CHANGES.txt: Moving YARN-1884, YARN-3171, YARN-3740, YARN-3248, YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #429 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/429/ ) CHANGES.txt: Moving YARN-1884 , YARN-3171 , YARN-3740 , YARN-3248 , YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc) hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #436 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/436/)
        CHANGES.txt: Moving YARN-1884, YARN-3171, YARN-3740, YARN-3248, YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #436 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/436/ ) CHANGES.txt: Moving YARN-1884 , YARN-3171 , YARN-3740 , YARN-3248 , YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc) hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8505 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8505/)
        CHANGES.txt: Moving YARN-1884, YARN-3171, YARN-3740, YARN-3248, YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc)

        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8505 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8505/ ) CHANGES.txt: Moving YARN-1884 , YARN-3171 , YARN-3740 , YARN-3248 , YARN-3544 to 2.6.1 given the backport. (vinodkv: rev f3e5bc67661ebc7e14509f2a267131ae314699dc) hadoop-yarn-project/CHANGES.txt
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Attaching patch that I pushed into 2.6.1.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Attaching patch that I pushed into 2.6.1.
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Pulled this into 2.6.1 as a dependency for other UI fixes following YARN-1809.

        The patch had minor merge and import conflicts, fixed them.

        Ran compilation before the push.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Pulled this into 2.6.1 as a dependency for other UI fixes following YARN-1809 . The patch had minor merge and import conflicts, fixed them. Ran compilation before the push.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2130 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2130/)
        YARN-3544. Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2130 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2130/ ) YARN-3544 . Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #181 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/181/)
        YARN-3544. Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #181 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/181/ ) YARN-3544 . Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #171 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/171/)
        YARN-3544. Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #171 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/171/ ) YARN-3544 . Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2112 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2112/)
        YARN-3544. Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2112 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2112/ ) YARN-3544 . Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #914 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/914/)
        YARN-3544. Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #914 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/914/ ) YARN-3544 . Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/180/)
        YARN-3544. Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/180/ ) YARN-3544 . Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7707 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7707/)
        YARN-3544. Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7707 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7707/ ) YARN-3544 . Got back AM logs link on the RM web UI for a completed app. Contributed by Xuan Gong. (zjshen: rev 7e8639fda40c13fe163128d7a725fcd0f2fce3c5) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/RMAppBlock.java
        Hide
        zjshen Zhijie Shen added a comment -

        Committed to trunk/branch-2/branch-2.7. Thanks, Xuan!

        Show
        zjshen Zhijie Shen added a comment - Committed to trunk/branch-2/branch-2.7. Thanks, Xuan!
        Hide
        zjshen Zhijie Shen added a comment -

        Verified 2.7 branch patch. It works fine too. Will commit it.

        Show
        zjshen Zhijie Shen added a comment - Verified 2.7 branch patch. It works fine too. Will commit it.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 0s Pre-patch branch-2.7 compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        -1 patch 0m 0s The patch command could not apply the patch.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729519/YARN-3544-branch-2.7-1.2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision branch-2.7 / 185a1ff
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7555/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 0s Pre-patch branch-2.7 compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. -1 patch 0m 0s The patch command could not apply the patch. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729519/YARN-3544-branch-2.7-1.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision branch-2.7 / 185a1ff Console output https://builds.apache.org/job/PreCommit-YARN-Build/7555/console This message was automatically generated.
        Hide
        xgong Xuan Gong added a comment -

        One nit: maybe we should place createApplicationAttemptTable before clarifyAppState to minimize diff.

        DONE

        Show
        xgong Xuan Gong added a comment - One nit: maybe we should place createApplicationAttemptTable before clarifyAppState to minimize diff. DONE
        Hide
        zjshen Zhijie Shen added a comment -

        Thanks for creating the branch-2.7 patch. One nit: maybe we should place createApplicationAttemptTable before clarifyAppState to minimize diff.

        Show
        zjshen Zhijie Shen added a comment - Thanks for creating the branch-2.7 patch. One nit: maybe we should place createApplicationAttemptTable before clarifyAppState to minimize diff.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 4s Pre-patch branch-2.7 compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        -1 patch 0m 0s The patch command could not apply the patch.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729366/YARN-3544-branch-2.7-1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision branch-2.7 / 6ac2b57
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7548/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 4s Pre-patch branch-2.7 compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. -1 patch 0m 0s The patch command could not apply the patch. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729366/YARN-3544-branch-2.7-1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision branch-2.7 / 6ac2b57 Console output https://builds.apache.org/job/PreCommit-YARN-Build/7548/console This message was automatically generated.
        Hide
        xgong Xuan Gong added a comment -

        the patch doesn't apply for branch-2.7. It seems to be non-trivial conflict merge. Would you please take a look?

        Uploaded a new patch for branch-2.7.

        Show
        xgong Xuan Gong added a comment - the patch doesn't apply for branch-2.7. It seems to be non-trivial conflict merge. Would you please take a look? Uploaded a new patch for branch-2.7.
        Hide
        zjshen Zhijie Shen added a comment -

        Xuan Gong, the patch doesn't apply for branch-2.7. It seems to be non-trivial conflict merge. Would you please take a look?

        Show
        zjshen Zhijie Shen added a comment - Xuan Gong , the patch doesn't apply for branch-2.7. It seems to be non-trivial conflict merge. Would you please take a look?
        Hide
        zjshen Zhijie Shen added a comment -

        Doesnt the NM log link redirect the log server after the logs have been aggregated?

        Thanks, Hitesh! I didn't notice this option before. Tried it locally, and the whole process of the completed log is working fine now.

        Will commit the patch late today unless there's further comment.

        Show
        zjshen Zhijie Shen added a comment - Doesnt the NM log link redirect the log server after the logs have been aggregated? Thanks, Hitesh! I didn't notice this option before. Tried it locally, and the whole process of the completed log is working fine now. Will commit the patch late today unless there's further comment.
        Hide
        hitesh Hitesh Shah added a comment -

        I meant "redirect to the log server"

        Show
        hitesh Hitesh Shah added a comment - I meant "redirect to the log server"
        Hide
        hitesh Hitesh Shah added a comment -

        Doesnt the NM log link redirect the log server after the logs have been aggregated?

        Show
        hitesh Hitesh Shah added a comment - Doesnt the NM log link redirect the log server after the logs have been aggregated?
        Hide
        zjshen Zhijie Shen added a comment -

        Xuan, thanks for the patch. I've tried your patch locally, and it brought the content back to the web UI. However, I've one concern. It seems that the link to the local log on NM is not useful after the app is finished, because the log is not supposed to be there any longer. So is this jira supposed to fix the regression, or ultimately provide a useful link to AM container log? Those seem to be different goals.

        /cc Hitesh Shah

        Show
        zjshen Zhijie Shen added a comment - Xuan, thanks for the patch. I've tried your patch locally, and it brought the content back to the web UI. However, I've one concern. It seems that the link to the local log on NM is not useful after the app is finished, because the log is not supposed to be there any longer. So is this jira supposed to fix the regression, or ultimately provide a useful link to AM container log? Those seem to be different goals. /cc Hitesh Shah
        Hide
        xgong Xuan Gong added a comment -

        Original, we are calling getContainerReport to AMContainer information (such as container log url, nm address, startTime, etc). It works fine when the Application is running, and the container is running. But when the application is finished, we will not keep finished container info. In that case, we could not get any finished container report from RM. That is why we see the AM logs link in web ui as "N/A" as well as other related attempt information.

        In this patch, instead of querying from container Report, we directly get attempt(AM Container) information from AttemptInfo which is from RMAttempt. So, no matter the application is running or is finished, we could get related information and show them in the web ui

        Show
        xgong Xuan Gong added a comment - Original, we are calling getContainerReport to AMContainer information (such as container log url, nm address, startTime, etc). It works fine when the Application is running, and the container is running. But when the application is finished, we will not keep finished container info. In that case, we could not get any finished container report from RM. That is why we see the AM logs link in web ui as "N/A" as well as other related attempt information. In this patch, instead of querying from container Report, we directly get attempt(AM Container) information from AttemptInfo which is from RMAttempt. So, no matter the application is running or is finished, we could get related information and show them in the web ui
        Hide
        xgong Xuan Gong added a comment -

        This is the web ui changes. That is why I do not add any test cases. Uploaded the app wen ui screenshot for a killed job after the patch is applied

        Show
        xgong Xuan Gong added a comment - This is the web ui changes. That is why I do not add any test cases. Uploaded the app wen ui screenshot for a killed job after the patch is applied
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Can you add a test-case?

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Can you add a test-case?
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Seems like a regression. Marking it as a blocker.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Seems like a regression. Marking it as a blocker.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 38s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 javac 7m 32s There were no new javac warning messages.
        +1 javadoc 9m 34s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 7m 40s The applied patch generated 1 additional checkstyle issues.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 15s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        -1 yarn tests 54m 43s Tests failed in hadoop-yarn-server-resourcemanager.
            97m 52s  



        Reason Tests
        Failed unit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12728109/YARN-3544.1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 78c6b46
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7498/artifact/patchprocess/checkstyle-result-diff.txt
        hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7498/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7498/testReport/
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7498/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 7m 40s The applied patch generated 1 additional checkstyle issues. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 15s The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 yarn tests 54m 43s Tests failed in hadoop-yarn-server-resourcemanager.     97m 52s   Reason Tests Failed unit tests hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728109/YARN-3544.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 78c6b46 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7498/artifact/patchprocess/checkstyle-result-diff.txt hadoop-yarn-server-resourcemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7498/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7498/testReport/ Console output https://builds.apache.org/job/PreCommit-YARN-Build/7498/console This message was automatically generated.

          People

          • Assignee:
            xgong Xuan Gong
            Reporter:
            hitesh Hitesh Shah
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development