Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3538

TimelineServer doesn't catch/translate all exceptions raised

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Not all exceptions in TimelineServer are uprated to web exceptions; only IOEs

      1. YARN-3538.002.patch
        1 kB
        Tsuyoshi Ozawa
      2. YARN-3538-001.patch
        1 kB
        Steve Loughran

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10858 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10858/)
          YARN-3538. TimelineWebService doesn't catch runtime exception. (junping_du: rev f05a9ceb4a9623517aa1c8d995805e26ae1bde5a)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/TimelineWebServices.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10858 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10858/ ) YARN-3538 . TimelineWebService doesn't catch runtime exception. (junping_du: rev f05a9ceb4a9623517aa1c8d995805e26ae1bde5a) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/TimelineWebServices.java
          Hide
          djp Junping Du added a comment -

          I have commit the patch to trunk and branch-2. Thanks Steve Loughran and Tsuyoshi Ozawa for patch contribution and others for review and comments!

          Show
          djp Junping Du added a comment - I have commit the patch to trunk and branch-2. Thanks Steve Loughran and Tsuyoshi Ozawa for patch contribution and others for review and comments!
          Hide
          djp Junping Du added a comment -

          Sorry for slow response as in relocation... the v2 patch LGTM. +1. Will commit it tomorrow if no further comments!

          Show
          djp Junping Du added a comment - Sorry for slow response as in relocation... the v2 patch LGTM. +1. Will commit it tomorrow if no further comments!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 9m 4s trunk passed
          +1 compile 0m 24s trunk passed
          +1 checkstyle 0m 17s trunk passed
          +1 mvnsite 0m 26s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 0m 39s trunk passed
          +1 javadoc 0m 16s trunk passed
          +1 mvninstall 0m 22s the patch passed
          +1 compile 0m 20s the patch passed
          +1 javac 0m 20s the patch passed
          +1 checkstyle 0m 13s the patch passed
          +1 mvnsite 0m 21s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 42s the patch passed
          +1 javadoc 0m 16s the patch passed
          +1 unit 3m 34s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          19m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue YARN-3538
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835952/YARN-3538.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 231667bf2dc6 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ebb8823
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13662/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13662/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 4s trunk passed +1 compile 0m 24s trunk passed +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 26s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 39s trunk passed +1 javadoc 0m 16s trunk passed +1 mvninstall 0m 22s the patch passed +1 compile 0m 20s the patch passed +1 javac 0m 20s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 42s the patch passed +1 javadoc 0m 16s the patch passed +1 unit 3m 34s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 19m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-3538 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835952/YARN-3538.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 231667bf2dc6 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ebb8823 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13662/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice Console output https://builds.apache.org/job/PreCommit-YARN-Build/13662/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Updating the patch based on the discussion.

          Junping Du could you check the patch?

          Show
          ozawa Tsuyoshi Ozawa added a comment - Updating the patch based on the discussion. Junping Du could you check the patch?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 1s trunk passed
          +1 compile 0m 21s trunk passed
          +1 checkstyle 0m 12s trunk passed
          +1 mvnsite 0m 24s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 31s trunk passed
          +1 javadoc 0m 14s trunk passed
          +1 mvninstall 0m 17s the patch passed
          +1 compile 0m 15s the patch passed
          +1 javac 0m 15s the patch passed
          -0 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
          +1 mvnsite 0m 23s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 49s the patch passed
          +1 javadoc 0m 12s the patch passed
          +1 unit 2m 44s hadoop-yarn-server-applicationhistoryservice in the patch passed.
          +1 asflicense 0m 14s The patch does not generate ASF License warnings.
          16m 38s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue YARN-3538
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12727879/YARN-3538-001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e8d63988391d 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 022bf78
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13606/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13606/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13606/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 1s trunk passed +1 compile 0m 21s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 31s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 17s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed -0 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 49s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 2m 44s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 16m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue YARN-3538 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12727879/YARN-3538-001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e8d63988391d 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 022bf78 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13606/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-applicationhistoryservice.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13606/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice Console output https://builds.apache.org/job/PreCommit-YARN-Build/13606/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          gtCarrera9 Li Lu added a comment -

          It's a little bit surprising that this patch still applies after 18 months... I'm fine with catching general exceptions but not RuntimeExceptions since they're unchecked exceptions? +1 for the current patch.

          Show
          gtCarrera9 Li Lu added a comment - It's a little bit surprising that this patch still applies after 18 months... I'm fine with catching general exceptions but not RuntimeExceptions since they're unchecked exceptions? +1 for the current patch.
          Hide
          djp Junping Du added a comment -

          May be it sounds slightly better if we handle RuntimeException in the same way as IOException here? At least, we add "Error putting domain" info.

          Show
          djp Junping Du added a comment - May be it sounds slightly better if we handle RuntimeException in the same way as IOException here? At least, we add "Error putting domain" info.
          Hide
          zjshen Zhijie Shen added a comment -

          Only RuntimeException will not be caught, and GenericExceptionHandler should map it to 500 and record a warn log, no?

          Show
          zjshen Zhijie Shen added a comment - Only RuntimeException will not be caught, and GenericExceptionHandler should map it to 500 and record a warn log, no?
          Hide
          stevel@apache.org Steve Loughran added a comment -

          No tests; would need a fair amount of mock pain to get coverage

          Show
          stevel@apache.org Steve Loughran added a comment - No tests; would need a fair amount of mock pain to get coverage
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 35s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 33s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 7m 52s The applied patch generated 1 additional checkstyle issues.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 45s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 yarn tests 2m 49s Tests passed in hadoop-yarn-server-applicationhistoryservice.
              45m 39s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727879/YARN-3538-001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / c8d7290
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7491/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/7491/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7491/testReport/
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/7491/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 7m 52s The applied patch generated 1 additional checkstyle issues. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 45s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 2m 49s Tests passed in hadoop-yarn-server-applicationhistoryservice.     45m 39s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727879/YARN-3538-001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c8d7290 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/7491/artifact/patchprocess/checkstyle-result-diff.txt hadoop-yarn-server-applicationhistoryservice test log https://builds.apache.org/job/PreCommit-YARN-Build/7491/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7491/testReport/ Console output https://builds.apache.org/job/PreCommit-YARN-Build/7491/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          patch 001; all Exceptions are converted to web 500 exceptions, rather than handled in jersey itself, which is a lot less informative

          Show
          stevel@apache.org Steve Loughran added a comment - patch 001; all Exceptions are converted to web 500 exceptions, rather than handled in jersey itself, which is a lot less informative

            People

            • Assignee:
              stevel@apache.org Steve Loughran
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development