Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3466

Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The ResourceManager does not support sorting by the node HTTP address, container count and node label column on the cluster nodes page.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2109 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2109/)
          YARN-3466. Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2109 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2109/ ) YARN-3466 . Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          jlowe Jason Lowe added a comment -

          I committed this to branch-2.7 as well. Thanks to Wangda for reviewing!

          Show
          jlowe Jason Lowe added a comment - I committed this to branch-2.7 as well. Thanks to Wangda for reviewing!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #160 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/160/)
          YARN-3466. Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #160 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/160/ ) YARN-3466 . Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #150 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/150/)
          YARN-3466. Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #150 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/150/ ) YARN-3466 . Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2091 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2091/)
          YARN-3466. Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2091 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2091/ ) YARN-3466 . Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #159 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/159/)
          YARN-3466. Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #159 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/159/ ) YARN-3466 . Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #893 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/893/)
          YARN-3466. Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #893 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/893/ ) YARN-3466 . Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          Hide
          jlowe Jason Lowe added a comment -

          This is really low risk, and Wangda and I both manually tested the fix. This was broken in 2.7 and it would be great to fix it in the same release so we don't regress in a public release.

          Show
          jlowe Jason Lowe added a comment - This is really low risk, and Wangda and I both manually tested the fix. This was broken in 2.7 and it would be great to fix it in the same release so we don't regress in a public release.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7547 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7547/)
          YARN-3466. Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java
          • hadoop-yarn-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7547 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7547/ ) YARN-3466 . Fix RM nodes web page to sort by node HTTP-address, #containers and node-label column. (Jason Lowe via wangda) (wangda: rev 1885141e90837252934192040a40047c7adbc1b5) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/NodesPage.java hadoop-yarn-project/CHANGES.txt
          Hide
          leftnoteasy Wangda Tan added a comment -

          Just committed to trunk/branch-2, Jason Lowe, Vinod Kumar Vavilapalli, please let me know when you figure out whether we need put to 2.7.x.

          Show
          leftnoteasy Wangda Tan added a comment - Just committed to trunk/branch-2, Jason Lowe , Vinod Kumar Vavilapalli , please let me know when you figure out whether we need put to 2.7.x.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          It would be nice to get this into 2.7.

          Seeing as how long 2.7.0 release has taken, I propose that we put this in 2.7.1. I'll start a discussion on the dev lists to immediately follow up 2.7.0 with a 2.7.1 within 2-3 weeks. That works?

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - It would be nice to get this into 2.7. Seeing as how long 2.7.0 release has taken, I propose that we put this in 2.7.1. I'll start a discussion on the dev lists to immediately follow up 2.7.0 with a 2.7.1 within 2-3 weeks. That works?
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723947/YARN-3466.001.patch
          against trunk revision 265ed1f.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7264//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7264//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723947/YARN-3466.001.patch against trunk revision 265ed1f. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7264//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7264//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723947/YARN-3466.001.patch
          against trunk revision 265ed1f.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7263//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7263//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723947/YARN-3466.001.patch against trunk revision 265ed1f. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7263//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7263//console This message is automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Updated title and description, added node-label column to reflect changes in the patch.

          Show
          leftnoteasy Wangda Tan added a comment - Updated title and description, added node-label column to reflect changes in the patch.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Tried in a local cluster, HTTP address, #containers and node-label sorting all work. +1.

          Pending Jenkins.

          Show
          leftnoteasy Wangda Tan added a comment - Tried in a local cluster, HTTP address, #containers and node-label sorting all work. +1. Pending Jenkins.
          Hide
          jlowe Jason Lowe added a comment -

          Patch to bump the column indices to take into account the new node label column. This also restores the formatting of the code where the columns are defined so it's easier to see the column order and count them.

          Wangda Tan or Jian He please review. It would be nice to get this into 2.7.

          Show
          jlowe Jason Lowe added a comment - Patch to bump the column indices to take into account the new node label column. This also restores the formatting of the code where the columns are defined so it's easier to see the column order and count them. Wangda Tan or Jian He please review. It would be nice to get this into 2.7.
          Hide
          jlowe Jason Lowe added a comment -

          This was caused by YARN-2943. A new column was added at the beginning of the table but table indices in the sorting metadata for the javascript were not updated accordingly.

          Show
          jlowe Jason Lowe added a comment - This was caused by YARN-2943 . A new column was added at the beginning of the table but table indices in the sorting metadata for the javascript were not updated accordingly.

            People

            • Assignee:
              jlowe Jason Lowe
              Reporter:
              jlowe Jason Lowe
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development