[YARN-3464] Race condition in LocalizerRunner kills localizer before localizing all resources

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.6.1, 2.8.0, 2.7.1, 3.0.0-alpha1
• Component/s: nodemanager
• Labels: 2.6.1-candidate
• Hadoop Flags: Reviewed
• Assignee: Zhihai Xu
• Reporter: Zhihai Xu
• Created: 08/Apr/15 08:00
• Updated: 06/Jan/17 00:49
• Resolved: 26/Apr/15 16:39

Description

Race condition in LocalizerRunner causes container localization timeout.
Currently LocalizerRunner will kill the ContainerLocalizer when pending list for LocalizerResourceRequestEvent is empty.

      } else if (pending.isEmpty()) {
        action = LocalizerAction.DIE;
      }

If a LocalizerResourceRequestEvent is added after LocalizerRunner kill the ContainerLocalizer due to empty pending list, this LocalizerResourceRequestEvent will never be handled.
Without ContainerLocalizer, LocalizerRunner#update will never be called.
The container will stay at LOCALIZING state, until the container is killed by AM due to TASK_TIMEOUT.