Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3462

Patches applied for YARN-2424 are inconsistent between trunk and branch-2

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 2.7.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It looks like the changes for YARN-2424 are not the same for trunk (commit 7e75226e68715c3eca9d346c8eaf2f265aa70d23) and branch-2 (commit 5d965f2f3cf97a87603720948aacd4f7877d73c4) . Branch-2 has a missing warning and documentation is a bit different as well.

        Activity

        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for reviewing and Commiting , Harsh J & Sidharta Seethana

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for reviewing and Commiting , Harsh J & Sidharta Seethana
        Hide
        qwertymaniac Harsh J added a comment -

        Pushed to branch-2 (For 2.8.0+) and branch-2.7 (For 2.7.1+).

        Show
        qwertymaniac Harsh J added a comment - Pushed to branch-2 (For 2.8.0+) and branch-2.7 (For 2.7.1+).
        Hide
        qwertymaniac Harsh J added a comment -

        Thanks Naganarasimha G R, lgtm, +1. Committing shortly.

        Show
        qwertymaniac Harsh J added a comment - Thanks Naganarasimha G R , lgtm, +1. Committing shortly.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi Harsh J, hope you can take a look at this patch ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi Harsh J , hope you can take a look at this patch ?
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Harsh J/Allen Wittenauer
        Can you guys take a look at this patch ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Harsh J / Allen Wittenauer Can you guys take a look at this patch ?
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        thanks for reviewing Sidharta Seethana , yes i have compiled the patch in Branch2 and it was compiling fine.

        Show
        Naganarasimha Naganarasimha G R added a comment - thanks for reviewing Sidharta Seethana , yes i have compiled the patch in Branch2 and it was compiling fine.
        Hide
        sidharta-s Sidharta Seethana added a comment -

        Naganarasimha G R, Thanks for the patch. I am assuming the patch application failure is because it got applied to trunk.

        The patch looks good to me.

        Show
        sidharta-s Sidharta Seethana added a comment - Naganarasimha G R , Thanks for the patch. I am assuming the patch application failure is because it got applied to trunk. The patch looks good to me.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12723784/YARN-3462.20150508-1.patch
        against trunk revision 5b8a3ae.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7249//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723784/YARN-3462.20150508-1.patch against trunk revision 5b8a3ae. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7249//console This message is automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Sidharta Seethana , can you take a look at the patch ?

        Show
        Naganarasimha Naganarasimha G R added a comment - Sidharta Seethana , can you take a look at the patch ?
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Attaching a patch with corrections in branch2

        Show
        Naganarasimha Naganarasimha G R added a comment - Attaching a patch with corrections in branch2

          People

          • Assignee:
            Naganarasimha Naganarasimha G R
            Reporter:
            sidharta-s Sidharta Seethana
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development