Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3456

Improve handling of incomplete TimelineEntities

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: timelineserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If an incomplete TimelineEntity is posted, it isn't checked client side ... it gets all the way to the far end before triggering an NPE in the store.

      1. YARN-3456.01.patch
        7 kB
        Varun Saxena
      2. YARN-3456.02.patch
        7 kB
        Varun Saxena

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #672 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/672/)
        YARN-3456. Improve handling of incomplete TimelineEntities. (Varun (rohithsharmaks: rev 01a641bc447c464b2830d58addd482f47dbd92ae)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineClient.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/TimelineWebServices.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestTimelineWebServices.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/TimelineDataManager.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #672 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/672/ ) YARN-3456 . Improve handling of incomplete TimelineEntities. (Varun (rohithsharmaks: rev 01a641bc447c464b2830d58addd482f47dbd92ae) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineClient.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/TimelineWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestTimelineWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/TimelineDataManager.java hadoop-yarn-project/CHANGES.txt
        Hide
        varun_saxena Varun Saxena added a comment -

        Thanks Rohith Sharma K S for the review and commit.

        Show
        varun_saxena Varun Saxena added a comment - Thanks Rohith Sharma K S for the review and commit.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8932 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8932/)
        YARN-3456. Improve handling of incomplete TimelineEntities. (Varun (rohithsharmaks: rev 01a641bc447c464b2830d58addd482f47dbd92ae)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineClient.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestTimelineWebServices.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/TimelineDataManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/TimelineWebServices.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8932 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8932/ ) YARN-3456 . Improve handling of incomplete TimelineEntities. (Varun (rohithsharmaks: rev 01a641bc447c464b2830d58addd482f47dbd92ae) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineClient.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/test/java/org/apache/hadoop/yarn/server/timeline/webapp/TestTimelineWebServices.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/TimelineDataManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/webapp/TimelineWebServices.java
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Committed to trunk/branch-2/branch-2.8 Thanks Varun for your contributions!!

        Show
        rohithsharma Rohith Sharma K S added a comment - Committed to trunk/branch-2/branch-2.8 Thanks Varun for your contributions!!
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        committing shortly

        Show
        rohithsharma Rohith Sharma K S added a comment - committing shortly
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 36s trunk passed
        +1 compile 1m 51s trunk passed with JDK v1.8.0_66
        +1 compile 2m 8s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 27s trunk passed
        +1 findbugs 1m 53s trunk passed
        +1 javadoc 0m 43s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 50s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 51s the patch passed
        +1 compile 1m 48s the patch passed with JDK v1.8.0_66
        +1 javac 1m 48s the patch passed
        +1 compile 2m 8s the patch passed with JDK v1.7.0_91
        +1 javac 2m 8s the patch passed
        +1 checkstyle 0m 26s the patch passed
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 26s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 9s the patch passed
        +1 javadoc 0m 44s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 50s the patch passed with JDK v1.7.0_91
        +1 unit 1m 53s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
        +1 unit 3m 42s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_66.
        +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
        +1 unit 3m 54s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_91.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        40m 22s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773739/YARN-3456.02.patch
        JIRA Issue YARN-3456
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 423d083167f5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 65f3952
        findbugs v3.0.0
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9883/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn
        Max memory used 75MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9883/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 36s trunk passed +1 compile 1m 51s trunk passed with JDK v1.8.0_66 +1 compile 2m 8s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 0m 43s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 50s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 51s the patch passed +1 compile 1m 48s the patch passed with JDK v1.8.0_66 +1 javac 1m 48s the patch passed +1 compile 2m 8s the patch passed with JDK v1.7.0_91 +1 javac 2m 8s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 9s the patch passed +1 javadoc 0m 44s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 50s the patch passed with JDK v1.7.0_91 +1 unit 1m 53s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 3m 42s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_66. +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 unit 3m 54s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 40m 22s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773739/YARN-3456.02.patch JIRA Issue YARN-3456 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 423d083167f5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 65f3952 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9883/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9883/console This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        I will wait for a day before committing it.

        Show
        rohithsharma Rohith Sharma K S added a comment - I will wait for a day before committing it.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        +1 lgtm..

        Show
        rohithsharma Rohith Sharma K S added a comment - +1 lgtm..
        Hide
        varun_saxena Varun Saxena added a comment -

        Findbugs to be handled by YARN-4298

        Show
        varun_saxena Varun Saxena added a comment - Findbugs to be handled by YARN-4298
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 9m 30s trunk passed
        +1 compile 2m 46s trunk passed with JDK v1.8.0_66
        +1 compile 2m 41s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 33s trunk passed
        +1 mvnsite 1m 6s trunk passed
        +1 mvneclipse 0m 31s trunk passed
        -1 findbugs 1m 33s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
        +1 javadoc 0m 59s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 1s trunk passed with JDK v1.7.0_85
        +1 mvninstall 1m 1s the patch passed
        +1 compile 2m 43s the patch passed with JDK v1.8.0_66
        +1 javac 2m 43s the patch passed
        +1 compile 2m 40s the patch passed with JDK v1.7.0_85
        +1 javac 2m 40s the patch passed
        +1 checkstyle 0m 33s the patch passed
        +1 mvnsite 1m 8s the patch passed
        +1 mvneclipse 0m 31s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 42s the patch passed
        +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 2s the patch passed with JDK v1.7.0_85
        -1 unit 2m 22s hadoop-yarn-common in the patch failed with JDK v1.8.0_66.
        +1 unit 4m 20s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_66.
        +1 unit 2m 35s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
        +1 unit 4m 11s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_85.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        50m 3s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogDeletionService



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773739/YARN-3456.02.patch
        JIRA Issue YARN-3456
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2a232ea16cd5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a6f20d8
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9761/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
        unit https://builds.apache.org/job/PreCommit-YARN-Build/9761/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9761/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9761/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn
        Max memory used 75MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9761/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 9m 30s trunk passed +1 compile 2m 46s trunk passed with JDK v1.8.0_66 +1 compile 2m 41s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 31s trunk passed -1 findbugs 1m 33s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 0m 59s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 1s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 1s the patch passed +1 compile 2m 43s the patch passed with JDK v1.8.0_66 +1 javac 2m 43s the patch passed +1 compile 2m 40s the patch passed with JDK v1.7.0_85 +1 javac 2m 40s the patch passed +1 checkstyle 0m 33s the patch passed +1 mvnsite 1m 8s the patch passed +1 mvneclipse 0m 31s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 42s the patch passed +1 javadoc 0m 58s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_85 -1 unit 2m 22s hadoop-yarn-common in the patch failed with JDK v1.8.0_66. +1 unit 4m 20s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_66. +1 unit 2m 35s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. +1 unit 4m 11s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 50m 3s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.logaggregation.TestAggregatedLogDeletionService Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773739/YARN-3456.02.patch JIRA Issue YARN-3456 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2a232ea16cd5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a6f20d8 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9761/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html unit https://builds.apache.org/job/PreCommit-YARN-Build/9761/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/9761/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdk1.8.0_66.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9761/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9761/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 8m 56s trunk passed
        +1 compile 2m 17s trunk passed with JDK v1.8.0_66
        +1 compile 2m 26s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvneclipse 0m 29s trunk passed
        -1 findbugs 1m 31s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings.
        +1 javadoc 0m 53s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 1s trunk passed with JDK v1.7.0_85
        +1 mvninstall 1m 1s the patch passed
        +1 compile 2m 31s the patch passed with JDK v1.8.0_66
        +1 javac 2m 31s the patch passed
        +1 compile 2m 34s the patch passed with JDK v1.7.0_85
        +1 javac 2m 34s the patch passed
        -1 checkstyle 0m 33s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 36, now 37).
        +1 mvnsite 1m 6s the patch passed
        +1 mvneclipse 0m 31s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 35s the patch passed
        +1 javadoc 0m 54s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 2s the patch passed with JDK v1.7.0_85
        +1 unit 2m 19s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
        +1 unit 4m 3s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_66.
        +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.7.0_85.
        +1 unit 4m 5s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_85.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        47m 18s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773734/YARN-3456.01.patch
        JIRA Issue YARN-3456
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9cc83d0d16cc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a6f20d8
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9758/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9758/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9758/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/9758/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 56s trunk passed +1 compile 2m 17s trunk passed with JDK v1.8.0_66 +1 compile 2m 26s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 29s trunk passed -1 findbugs 1m 31s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 3 extant Findbugs warnings. +1 javadoc 0m 53s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 1s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 1s the patch passed +1 compile 2m 31s the patch passed with JDK v1.8.0_66 +1 javac 2m 31s the patch passed +1 compile 2m 34s the patch passed with JDK v1.7.0_85 +1 javac 2m 34s the patch passed -1 checkstyle 0m 33s Patch generated 1 new checkstyle issues in hadoop-yarn-project/hadoop-yarn (total was 36, now 37). +1 mvnsite 1m 6s the patch passed +1 mvneclipse 0m 31s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 35s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_85 +1 unit 2m 19s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. +1 unit 4m 3s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_66. +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.7.0_85. +1 unit 4m 5s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 47m 18s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773734/YARN-3456.01.patch JIRA Issue YARN-3456 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9cc83d0d16cc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a6f20d8 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/9758/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/9758/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/9758/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/9758/console This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        Updated a patch. Added checks at both client and server side.

        Show
        varun_saxena Varun Saxena added a comment - Updated a patch. Added checks at both client and server side.
        Hide
        varun_saxena Varun Saxena added a comment -

        Sorry Kuhu. Had missed your comment.
        I will have bandwidth to handle this JIRA. Its a straightforward fix. Will update a patch shortly.

        Show
        varun_saxena Varun Saxena added a comment - Sorry Kuhu. Had missed your comment. I will have bandwidth to handle this JIRA. Its a straightforward fix. Will update a patch shortly.
        Hide
        kshukla Kuhu Shukla added a comment -

        Hello Varun Saxena , are you currently working on this issue?

        Show
        kshukla Kuhu Shukla added a comment - Hello Varun Saxena , are you currently working on this issue?
        Hide
        stevel@apache.org Steve Loughran added a comment -

        Stack trace when an entity with a null type is posted by the client. Client side preflight checking could prevent some of this, REST API validation be even stronger

        2015-04-07 12:23:40,290 [614480043@qtp-2026808370-0] INFO  container.GuiceComponentProviderFactory (GuiceComponentProviderFactory.java:getComponentProvider(159)) - Binding org.apache.hadoop.yarn.server.timeline.webapp.TimelineWebServices to GuiceManagedComponentProvider with the scope "Singleton"
        2015-04-07 12:23:40,632 [614480043@qtp-2026808370-0] ERROR timeline.TimelineDataManager (TimelineDataManager.java:postEntities(275)) - Skip the timeline entity: { id: post, type: null }
        java.lang.NullPointerException
        	at org.apache.hadoop.yarn.server.timeline.LeveldbTimelineStore$KeyBuilder.add(LeveldbTimelineStore.java:352)
        	at org.apache.hadoop.yarn.server.timeline.LeveldbTimelineStore.createStartTimeLookupKey(LeveldbTimelineStore.java:1188)
        	at org.apache.hadoop.yarn.server.timeline.LeveldbTimelineStore.getStartTimeLong(LeveldbTimelineStore.java:1081)
        	at org.apache.hadoop.yarn.server.timeline.LeveldbTimelineStore.getEntity(LeveldbTimelineStore.java:433)
        	at org.apache.hadoop.yarn.server.timeline.TimelineDataManager.postEntities(TimelineDataManager.java:257)
        	at org.apache.hadoop.yarn.server.timeline.webapp.TimelineWebServices.postEntities(TimelineWebServices.java:259)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:606)
        	at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
        	at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185)
        	at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
        	at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:288)
        	at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
        	at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
        	at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
        	at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1469)
        	at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1400)
        	at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1349)
        	at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1339)
        	at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:416)
        	at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
        	at com.sun.jersey.spi.container.servlet.ServletContainer.doFilter(ServletContainer.java:886)
        	at com.sun.jersey.spi.container.servlet.ServletContainer.doFilter(ServletContainer.java:834)
        	at com.sun.jersey.spi.container.servlet.ServletContainer.doFilter(ServletContainer.java:795)
        	at com.google.inject.servlet.FilterDefinition.doFilter(FilterDefinition.java:163)
        	at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:58)
        	at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:118)
        	at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:113)
        	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
        	at org.apache.hadoop.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:96)
        	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
        	at org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:572)
        	at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticationFilter.doFilter(DelegationTokenAuthenticationFilter.java:269)
        	at org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:542)
        	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
        	at org.apache.hadoop.http.HttpServer2$QuotingInputFilter.doFilter(HttpServer2.java:1224)
        	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
        	at org.apache.hadoop.http.NoCacheFilter.doFilter(NoCacheFilter.java:45)
        	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212)
        	at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399)
        	at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
        	at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182)
        	at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
        	at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450)
        	at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
        	at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
        	at org.mortbay.jetty.Server.handle(Server.java:326)
        	at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542)
        	at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:945)
        	at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:756)
        	at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218)
        	at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404)
        	at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410)
        	at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)
        
        Show
        stevel@apache.org Steve Loughran added a comment - Stack trace when an entity with a null type is posted by the client. Client side preflight checking could prevent some of this, REST API validation be even stronger 2015-04-07 12:23:40,290 [614480043@qtp-2026808370-0] INFO container.GuiceComponentProviderFactory (GuiceComponentProviderFactory.java:getComponentProvider(159)) - Binding org.apache.hadoop.yarn.server.timeline.webapp.TimelineWebServices to GuiceManagedComponentProvider with the scope "Singleton" 2015-04-07 12:23:40,632 [614480043@qtp-2026808370-0] ERROR timeline.TimelineDataManager (TimelineDataManager.java:postEntities(275)) - Skip the timeline entity: { id: post, type: null } java.lang.NullPointerException at org.apache.hadoop.yarn.server.timeline.LeveldbTimelineStore$KeyBuilder.add(LeveldbTimelineStore.java:352) at org.apache.hadoop.yarn.server.timeline.LeveldbTimelineStore.createStartTimeLookupKey(LeveldbTimelineStore.java:1188) at org.apache.hadoop.yarn.server.timeline.LeveldbTimelineStore.getStartTimeLong(LeveldbTimelineStore.java:1081) at org.apache.hadoop.yarn.server.timeline.LeveldbTimelineStore.getEntity(LeveldbTimelineStore.java:433) at org.apache.hadoop.yarn.server.timeline.TimelineDataManager.postEntities(TimelineDataManager.java:257) at org.apache.hadoop.yarn.server.timeline.webapp.TimelineWebServices.postEntities(TimelineWebServices.java:259) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) at com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185) at com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75) at com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:288) at com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108) at com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147) at com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84) at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1469) at com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1400) at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1349) at com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1339) at com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:416) at com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537) at com.sun.jersey.spi.container.servlet.ServletContainer.doFilter(ServletContainer.java:886) at com.sun.jersey.spi.container.servlet.ServletContainer.doFilter(ServletContainer.java:834) at com.sun.jersey.spi.container.servlet.ServletContainer.doFilter(ServletContainer.java:795) at com.google.inject.servlet.FilterDefinition.doFilter(FilterDefinition.java:163) at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:58) at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:118) at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:113) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.apache.hadoop.http.lib.StaticUserWebFilter$StaticUserFilter.doFilter(StaticUserWebFilter.java:96) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:572) at org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticationFilter.doFilter(DelegationTokenAuthenticationFilter.java:269) at org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:542) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.apache.hadoop.http.HttpServer2$QuotingInputFilter.doFilter(HttpServer2.java:1224) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.apache.hadoop.http.NoCacheFilter.doFilter(NoCacheFilter.java:45) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1212) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:399) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:450) at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:542) at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnection.java:945) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:756) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404) at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:410) at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582)

          People

          • Assignee:
            varun_saxena Varun Saxena
            Reporter:
            stevel@apache.org Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development