Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Maybe we'd like to extend our current jdiff tool for hadoop-common and hdfs to YARN as well.

      1. YARN-3426-040615.patch
        1005 kB
        Li Lu
      2. YARN-3426-040615-1.patch
        1005 kB
        Li Lu
      3. YARN-3426-040715.patch
        1009 kB
        Li Lu
      4. YARN-3426-040815.patch
        923 kB
        Li Lu
      5. YARN-3426-05-12-2016.txt
        1.83 MB
        Vinod Kumar Vavilapalli
      6. YARN-3426-06-09-2016.txt
        1.83 MB
        Wangda Tan
      7. YARN-3426-branch-2.005.patch
        1.83 MB
        Wangda Tan
      8. YARN-3426-branch-2.8.005.patch
        1.83 MB
        Wangda Tan

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Junping Du, updated fix version to 2.7.3, but please note that I only backported doclet changes to 2.7.3, jdiff files are not required.

          Show
          leftnoteasy Wangda Tan added a comment - Junping Du , updated fix version to 2.7.3, but please note that I only backported doclet changes to 2.7.3, jdiff files are not required.
          Hide
          djp Junping Du added a comment -

          This JIRA has few changes to doclet that we need to backport to branch-2.7 and branch-2.7.3, otherwise generated jdiff is wrong.

          We should set fix version to 2.7.3. Isn't it?

          Show
          djp Junping Du added a comment - This JIRA has few changes to doclet that we need to backport to branch-2.7 and branch-2.7.3, otherwise generated jdiff is wrong. We should set fix version to 2.7.3. Isn't it?
          Hide
          leftnoteasy Wangda Tan added a comment -

          Back ported doclet changes to branch-2.7 and branch-2.7.3

          Show
          leftnoteasy Wangda Tan added a comment - Back ported doclet changes to branch-2.7 and branch-2.7.3
          Hide
          leftnoteasy Wangda Tan added a comment -

          This JIRA has few changes to doclet that we need to backport to branch-2.7 and branch-2.7.3, otherwise generated jdiff is wrong.

          Show
          leftnoteasy Wangda Tan added a comment - This JIRA has few changes to doclet that we need to backport to branch-2.7 and branch-2.7.3, otherwise generated jdiff is wrong.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9945 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9945/)
          YARN-3426. Add jdiff support to YARN. (vinodkv via wangda) (wangda: rev 03fc6b1bb0f5c0844cd5477ffba43de8a14d4d60)

          • hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_Common_2.7.2.xml
          • hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_Client_2.7.2.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/pom.xml
          • hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_Server_Common_2.7.2.xml
          • hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_API_2.6.0.xml
          • hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Null.java
          • hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_Server_Common_2.6.0.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml
          • hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_Common_2.6.0.xml
          • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
          • hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_API_2.7.2.xml
          • hadoop-yarn-project/hadoop-yarn/pom.xml
          • hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_Client.2.6.0.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9945 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9945/ ) YARN-3426 . Add jdiff support to YARN. (vinodkv via wangda) (wangda: rev 03fc6b1bb0f5c0844cd5477ffba43de8a14d4d60) hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_Common_2.7.2.xml hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_Client_2.7.2.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/pom.xml hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_Server_Common_2.7.2.xml hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_API_2.6.0.xml hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Null.java hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_Server_Common_2.6.0.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/pom.xml hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_Common_2.6.0.xml hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_API_2.7.2.xml hadoop-yarn-project/hadoop-yarn/pom.xml hadoop-yarn-project/hadoop-yarn/dev-support/jdiff/Apache_Hadoop_YARN_Client.2.6.0.xml
          Hide
          leftnoteasy Wangda Tan added a comment -

          Committed to trunk and branch-2.

          Thanks Li Lu and Vinod Kumar Vavilapalli!

          Show
          leftnoteasy Wangda Tan added a comment - Committed to trunk and branch-2. Thanks Li Lu and Vinod Kumar Vavilapalli !
          Hide
          leftnoteasy Wangda Tan added a comment -

          Failed tests are tracked by YARN-5208. Committing now..

          Show
          leftnoteasy Wangda Tan added a comment - Failed tests are tracked by YARN-5208 . Committing now..
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 2m 26s Maven dependency ordering for branch
          +1 mvninstall 7m 0s branch-2.8 passed
          +1 compile 5m 41s branch-2.8 passed with JDK v1.8.0_91
          +1 compile 6m 36s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 1m 7s branch-2.8 passed
          +1 mvnsite 4m 29s branch-2.8 passed
          +1 mvneclipse 1m 24s branch-2.8 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 4m 2s branch-2.8 passed
          +1 javadoc 2m 34s branch-2.8 passed with JDK v1.8.0_91
          +1 javadoc 3m 2s branch-2.8 passed with JDK v1.7.0_101
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 3m 42s the patch passed
          +1 compile 5m 41s the patch passed with JDK v1.8.0_91
          +1 javac 5m 41s the patch passed
          +1 compile 6m 34s the patch passed with JDK v1.7.0_101
          +1 javac 6m 34s the patch passed
          +1 checkstyle 1m 3s the patch passed
          +1 mvnsite 4m 30s the patch passed
          +1 mvneclipse 1m 20s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 6s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 4m 54s the patch passed
          +1 javadoc 2m 33s the patch passed with JDK v1.8.0_91
          +1 javadoc 3m 5s the patch passed with JDK v1.7.0_101
          +1 unit 0m 9s hadoop-annotations in the patch passed with JDK v1.8.0_91.
          -1 unit 82m 59s hadoop-yarn in the patch failed with JDK v1.8.0_91.
          +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_91.
          +1 unit 2m 3s hadoop-yarn-common in the patch passed with JDK v1.8.0_91.
          +1 unit 0m 21s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_91.
          -1 unit 65m 43s hadoop-yarn-client in the patch failed with JDK v1.8.0_91.
          +1 unit 0m 11s hadoop-annotations in the patch passed with JDK v1.7.0_101.
          -1 unit 85m 38s hadoop-yarn in the patch failed with JDK v1.7.0_101.
          +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_101.
          +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.7.0_101.
          +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_101.
          -1 unit 65m 58s hadoop-yarn-client in the patch failed with JDK v1.7.0_101.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          381m 15s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.TestGetGroups
            hadoop.yarn.server.nodemanager.containermanager.TestNMProxy
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.TestGetGroups
          JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_101 Failed junit tests hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.TestGetGroups
            hadoop.yarn.server.nodemanager.containermanager.TestNMProxy
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.TestGetGroups
          JDK v1.7.0_101 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c60792e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809299/YARN-3426-branch-2.8.005.patch
          JIRA Issue YARN-3426
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 662175a4d497 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / faf9a9f
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11950/testReport/
          modules C: hadoop-common-project/hadoop-annotations hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11950/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 2m 26s Maven dependency ordering for branch +1 mvninstall 7m 0s branch-2.8 passed +1 compile 5m 41s branch-2.8 passed with JDK v1.8.0_91 +1 compile 6m 36s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 1m 7s branch-2.8 passed +1 mvnsite 4m 29s branch-2.8 passed +1 mvneclipse 1m 24s branch-2.8 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 4m 2s branch-2.8 passed +1 javadoc 2m 34s branch-2.8 passed with JDK v1.8.0_91 +1 javadoc 3m 2s branch-2.8 passed with JDK v1.7.0_101 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 3m 42s the patch passed +1 compile 5m 41s the patch passed with JDK v1.8.0_91 +1 javac 5m 41s the patch passed +1 compile 6m 34s the patch passed with JDK v1.7.0_101 +1 javac 6m 34s the patch passed +1 checkstyle 1m 3s the patch passed +1 mvnsite 4m 30s the patch passed +1 mvneclipse 1m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 6s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 4m 54s the patch passed +1 javadoc 2m 33s the patch passed with JDK v1.8.0_91 +1 javadoc 3m 5s the patch passed with JDK v1.7.0_101 +1 unit 0m 9s hadoop-annotations in the patch passed with JDK v1.8.0_91. -1 unit 82m 59s hadoop-yarn in the patch failed with JDK v1.8.0_91. +1 unit 0m 21s hadoop-yarn-api in the patch passed with JDK v1.8.0_91. +1 unit 2m 3s hadoop-yarn-common in the patch passed with JDK v1.8.0_91. +1 unit 0m 21s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_91. -1 unit 65m 43s hadoop-yarn-client in the patch failed with JDK v1.8.0_91. +1 unit 0m 11s hadoop-annotations in the patch passed with JDK v1.7.0_101. -1 unit 85m 38s hadoop-yarn in the patch failed with JDK v1.7.0_101. +1 unit 0m 24s hadoop-yarn-api in the patch passed with JDK v1.7.0_101. +1 unit 2m 20s hadoop-yarn-common in the patch passed with JDK v1.7.0_101. +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_101. -1 unit 65m 58s hadoop-yarn-client in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 381m 15s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.TestGetGroups   hadoop.yarn.server.nodemanager.containermanager.TestNMProxy   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.TestGetGroups JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_101 Failed junit tests hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.TestGetGroups   hadoop.yarn.server.nodemanager.containermanager.TestNMProxy   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.TestGetGroups JDK v1.7.0_101 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:c60792e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809299/YARN-3426-branch-2.8.005.patch JIRA Issue YARN-3426 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 662175a4d497 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / faf9a9f Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/11950/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11950/testReport/ modules C: hadoop-common-project/hadoop-annotations hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11950/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment - - edited

          Failed tests are not related, this is a doc-only patch.

          Show
          leftnoteasy Wangda Tan added a comment - - edited Failed tests are not related, this is a doc-only patch.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Attached patch for branch-2/branch-2.8

          Show
          leftnoteasy Wangda Tan added a comment - Attached patch for branch-2/branch-2.8
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 34s Maven dependency ordering for branch
          +1 mvninstall 7m 43s trunk passed
          +1 compile 8m 37s trunk passed
          +1 checkstyle 1m 18s trunk passed
          +1 mvnsite 4m 7s trunk passed
          +1 mvneclipse 1m 12s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 3m 10s trunk passed
          +1 javadoc 2m 34s trunk passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 3m 18s the patch passed
          +1 compile 6m 20s the patch passed
          +1 javac 6m 20s the patch passed
          +1 checkstyle 1m 21s the patch passed
          +1 mvnsite 4m 24s the patch passed
          +1 mvneclipse 1m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 16s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 3m 42s the patch passed
          +1 javadoc 2m 34s the patch passed
          +1 unit 0m 10s hadoop-annotations in the patch passed.
          -1 unit 49m 0s hadoop-yarn in the patch failed.
          +1 unit 0m 23s hadoop-yarn-api in the patch passed.
          +1 unit 2m 7s hadoop-yarn-common in the patch passed.
          +1 unit 0m 23s hadoop-yarn-server-common in the patch passed.
          -1 unit 67m 42s hadoop-yarn-client in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          174m 7s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart
            hadoop.yarn.client.api.impl.TestDistributedScheduling
            hadoop.yarn.client.TestGetGroups
            hadoop.yarn.client.cli.TestLogsCLI
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.api.impl.TestDistributedScheduling
            hadoop.yarn.client.TestGetGroups
            hadoop.yarn.client.cli.TestLogsCLI
            hadoop.yarn.client.api.impl.TestAMRMProxy
          Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809236/YARN-3426-06-09-2016.txt
          JIRA Issue YARN-3426
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 75036c3caa7e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 656c460
          Default Java 1.8.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11941/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11941/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11941/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt https://builds.apache.org/job/PreCommit-YARN-Build/11941/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11941/testReport/
          modules C: hadoop-common-project/hadoop-annotations hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11941/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 34s Maven dependency ordering for branch +1 mvninstall 7m 43s trunk passed +1 compile 8m 37s trunk passed +1 checkstyle 1m 18s trunk passed +1 mvnsite 4m 7s trunk passed +1 mvneclipse 1m 12s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 3m 10s trunk passed +1 javadoc 2m 34s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 3m 18s the patch passed +1 compile 6m 20s the patch passed +1 javac 6m 20s the patch passed +1 checkstyle 1m 21s the patch passed +1 mvnsite 4m 24s the patch passed +1 mvneclipse 1m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 16s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 3m 42s the patch passed +1 javadoc 2m 34s the patch passed +1 unit 0m 10s hadoop-annotations in the patch passed. -1 unit 49m 0s hadoop-yarn in the patch failed. +1 unit 0m 23s hadoop-yarn-api in the patch passed. +1 unit 2m 7s hadoop-yarn-common in the patch passed. +1 unit 0m 23s hadoop-yarn-server-common in the patch passed. -1 unit 67m 42s hadoop-yarn-client in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 174m 7s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestWorkPreservingRMRestart   hadoop.yarn.client.api.impl.TestDistributedScheduling   hadoop.yarn.client.TestGetGroups   hadoop.yarn.client.cli.TestLogsCLI   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.api.impl.TestDistributedScheduling   hadoop.yarn.client.TestGetGroups   hadoop.yarn.client.cli.TestLogsCLI   hadoop.yarn.client.api.impl.TestAMRMProxy Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809236/YARN-3426-06-09-2016.txt JIRA Issue YARN-3426 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 75036c3caa7e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 656c460 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/11941/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11941/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11941/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt https://builds.apache.org/job/PreCommit-YARN-Build/11941/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11941/testReport/ modules C: hadoop-common-project/hadoop-annotations hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11941/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Attached patch with apache rat exclusions.

          Show
          leftnoteasy Wangda Tan added a comment - Attached patch with apache rat exclusions.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 27s Docker mode activated.
          0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 11s Maven dependency ordering for branch
          +1 mvninstall 6m 2s trunk passed
          +1 compile 6m 12s trunk passed
          +1 checkstyle 1m 20s trunk passed
          +1 mvnsite 4m 5s trunk passed
          +1 mvneclipse 1m 12s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn
          -1 findbugs 0m 58s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api in trunk has 1 extant Findbugs warnings.
          +1 javadoc 2m 38s trunk passed
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 3m 24s the patch passed
          +1 compile 6m 9s the patch passed
          +1 javac 6m 9s the patch passed
          +1 checkstyle 1m 18s the patch passed
          +1 mvnsite 4m 6s the patch passed
          +1 mvneclipse 1m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 16s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 3m 42s the patch passed
          +1 javadoc 2m 37s the patch passed
          +1 unit 0m 10s hadoop-annotations in the patch passed.
          -1 unit 55m 46s hadoop-yarn in the patch failed.
          +1 unit 0m 29s hadoop-yarn-api in the patch passed.
          +1 unit 2m 19s hadoop-yarn-common in the patch passed.
          +1 unit 0m 29s hadoop-yarn-server-common in the patch passed.
          -1 unit 67m 51s hadoop-yarn-client in the patch failed.
          -1 asflicense 0m 25s The patch generated 4 ASF License warnings.
          176m 53s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.api.impl.TestDistributedScheduling
            hadoop.yarn.client.TestGetGroups
            hadoop.yarn.client.cli.TestLogsCLI
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.api.impl.TestDistributedScheduling
            hadoop.yarn.client.TestGetGroups
            hadoop.yarn.client.cli.TestLogsCLI
          Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803784/YARN-3426-05-12-2016.txt
          JIRA Issue YARN-3426
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 299e771d9db4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6de9213
          Default Java 1.8.0_91
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11865/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-warnings.html
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11865/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11865/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11865/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt https://builds.apache.org/job/PreCommit-YARN-Build/11865/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11865/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/11865/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-annotations hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11865/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. 0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 6m 2s trunk passed +1 compile 6m 12s trunk passed +1 checkstyle 1m 20s trunk passed +1 mvnsite 4m 5s trunk passed +1 mvneclipse 1m 12s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn -1 findbugs 0m 58s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api in trunk has 1 extant Findbugs warnings. +1 javadoc 2m 38s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 3m 24s the patch passed +1 compile 6m 9s the patch passed +1 javac 6m 9s the patch passed +1 checkstyle 1m 18s the patch passed +1 mvnsite 4m 6s the patch passed +1 mvneclipse 1m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 16s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 3m 42s the patch passed +1 javadoc 2m 37s the patch passed +1 unit 0m 10s hadoop-annotations in the patch passed. -1 unit 55m 46s hadoop-yarn in the patch failed. +1 unit 0m 29s hadoop-yarn-api in the patch passed. +1 unit 2m 19s hadoop-yarn-common in the patch passed. +1 unit 0m 29s hadoop-yarn-server-common in the patch passed. -1 unit 67m 51s hadoop-yarn-client in the patch failed. -1 asflicense 0m 25s The patch generated 4 ASF License warnings. 176m 53s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.api.impl.TestDistributedScheduling   hadoop.yarn.client.TestGetGroups   hadoop.yarn.client.cli.TestLogsCLI   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.api.impl.TestDistributedScheduling   hadoop.yarn.client.TestGetGroups   hadoop.yarn.client.cli.TestLogsCLI Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803784/YARN-3426-05-12-2016.txt JIRA Issue YARN-3426 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 299e771d9db4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6de9213 Default Java 1.8.0_91 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11865/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-warnings.html unit https://builds.apache.org/job/PreCommit-YARN-Build/11865/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11865/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11865/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt https://builds.apache.org/job/PreCommit-YARN-Build/11865/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11865/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/11865/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-annotations hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11865/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Latest patch looks good, tried this on trunk and branch-2.8, both works and jdiff site file can be generated.

          Findbugs warnings should not related, since this is a doc only change, just triggered Jenkins run to verify.

          Will commit once Jenkins get back.

          Show
          leftnoteasy Wangda Tan added a comment - Latest patch looks good, tried this on trunk and branch-2.8, both works and jdiff site file can be generated. Findbugs warnings should not related, since this is a doc only change, just triggered Jenkins run to verify. Will commit once Jenkins get back.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 40s Maven dependency ordering for branch
          +1 mvninstall 6m 49s trunk passed
          +1 compile 6m 39s trunk passed with JDK v1.8.0_91
          +1 compile 7m 1s trunk passed with JDK v1.7.0_101
          +1 checkstyle 1m 24s trunk passed
          +1 mvnsite 4m 40s trunk passed
          +1 mvneclipse 1m 23s trunk passed
          0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn
          -1 findbugs 1m 8s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings.
          -1 findbugs 0m 44s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common in trunk has 3 extant Findbugs warnings.
          +1 javadoc 3m 56s trunk passed with JDK v1.8.0_91
          +1 javadoc 9m 6s trunk passed with JDK v1.7.0_101
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 3m 47s the patch passed
          +1 compile 6m 2s the patch passed with JDK v1.8.0_91
          +1 javac 6m 2s the patch passed
          +1 compile 6m 48s the patch passed with JDK v1.7.0_101
          +1 javac 6m 48s the patch passed
          +1 checkstyle 1m 24s the patch passed
          +1 mvnsite 4m 33s the patch passed
          +1 mvneclipse 1m 24s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 7s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn
          +1 findbugs 5m 4s the patch passed
          +1 javadoc 3m 43s the patch passed with JDK v1.8.0_91
          +1 javadoc 9m 5s the patch passed with JDK v1.7.0_101
          +1 unit 0m 10s hadoop-annotations in the patch passed with JDK v1.8.0_91.
          -1 unit 19m 1s hadoop-yarn in the patch failed with JDK v1.8.0_91.
          +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_91.
          +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.8.0_91.
          +1 unit 0m 25s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_91.
          -1 unit 66m 6s hadoop-yarn-client in the patch failed with JDK v1.8.0_91.
          +1 unit 0m 11s hadoop-annotations in the patch passed with JDK v1.7.0_101.
          -1 unit 20m 14s hadoop-yarn in the patch failed with JDK v1.7.0_101.
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_101.
          +1 unit 2m 22s hadoop-yarn-common in the patch passed with JDK v1.7.0_101.
          +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_101.
          -1 unit 66m 20s hadoop-yarn-client in the patch failed with JDK v1.7.0_101.
          -1 asflicense 0m 27s Patch generated 4 ASF License warnings.
          268m 44s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.yarn.server.applicationhistoryservice.TestFileSystemApplicationHistoryStore
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.TestGetGroups
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.TestGetGroups
          JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient
          JDK v1.7.0_101 Failed junit tests hadoop.yarn.server.applicationhistoryservice.TestFileSystemApplicationHistoryStore
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.TestGetGroups
            hadoop.yarn.client.api.impl.TestAMRMProxy
            hadoop.yarn.client.TestGetGroups
          JDK v1.7.0_101 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI
            org.apache.hadoop.yarn.client.api.impl.TestAMRMClient
            org.apache.hadoop.yarn.client.api.impl.TestYarnClient
            org.apache.hadoop.yarn.client.api.impl.TestNMClient



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803784/YARN-3426-05-12-2016.txt
          JIRA Issue YARN-3426
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 3cf2fe14235c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7be53b6
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11473/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-annotations hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11473/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 40s Maven dependency ordering for branch +1 mvninstall 6m 49s trunk passed +1 compile 6m 39s trunk passed with JDK v1.8.0_91 +1 compile 7m 1s trunk passed with JDK v1.7.0_101 +1 checkstyle 1m 24s trunk passed +1 mvnsite 4m 40s trunk passed +1 mvneclipse 1m 23s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn -1 findbugs 1m 8s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings. -1 findbugs 0m 44s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common in trunk has 3 extant Findbugs warnings. +1 javadoc 3m 56s trunk passed with JDK v1.8.0_91 +1 javadoc 9m 6s trunk passed with JDK v1.7.0_101 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 3m 47s the patch passed +1 compile 6m 2s the patch passed with JDK v1.8.0_91 +1 javac 6m 2s the patch passed +1 compile 6m 48s the patch passed with JDK v1.7.0_101 +1 javac 6m 48s the patch passed +1 checkstyle 1m 24s the patch passed +1 mvnsite 4m 33s the patch passed +1 mvneclipse 1m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 7s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 5m 4s the patch passed +1 javadoc 3m 43s the patch passed with JDK v1.8.0_91 +1 javadoc 9m 5s the patch passed with JDK v1.7.0_101 +1 unit 0m 10s hadoop-annotations in the patch passed with JDK v1.8.0_91. -1 unit 19m 1s hadoop-yarn in the patch failed with JDK v1.8.0_91. +1 unit 0m 23s hadoop-yarn-api in the patch passed with JDK v1.8.0_91. +1 unit 2m 9s hadoop-yarn-common in the patch passed with JDK v1.8.0_91. +1 unit 0m 25s hadoop-yarn-server-common in the patch passed with JDK v1.8.0_91. -1 unit 66m 6s hadoop-yarn-client in the patch failed with JDK v1.8.0_91. +1 unit 0m 11s hadoop-annotations in the patch passed with JDK v1.7.0_101. -1 unit 20m 14s hadoop-yarn in the patch failed with JDK v1.7.0_101. +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.7.0_101. +1 unit 2m 22s hadoop-yarn-common in the patch passed with JDK v1.7.0_101. +1 unit 0m 27s hadoop-yarn-server-common in the patch passed with JDK v1.7.0_101. -1 unit 66m 20s hadoop-yarn-client in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 27s Patch generated 4 ASF License warnings. 268m 44s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.yarn.server.applicationhistoryservice.TestFileSystemApplicationHistoryStore   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.TestGetGroups   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.TestGetGroups JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient JDK v1.7.0_101 Failed junit tests hadoop.yarn.server.applicationhistoryservice.TestFileSystemApplicationHistoryStore   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.TestGetGroups   hadoop.yarn.client.api.impl.TestAMRMProxy   hadoop.yarn.client.TestGetGroups JDK v1.7.0_101 Timed out junit tests org.apache.hadoop.yarn.client.cli.TestYarnCLI   org.apache.hadoop.yarn.client.api.impl.TestAMRMClient   org.apache.hadoop.yarn.client.api.impl.TestYarnClient   org.apache.hadoop.yarn.client.api.impl.TestNMClient Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803784/YARN-3426-05-12-2016.txt JIRA Issue YARN-3426 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 3cf2fe14235c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7be53b6 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html findbugs https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-warnings.html unit https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11473/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/11473/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-annotations hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/11473/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          The problem for the current solution is we're duplicating many maven code for hadoop-common/hdfs and yarn. We're also introducing duplications to mapreduce in the current approach.

          Going back and forth on this one.

          At this point, having this for 2.8.0 with duplicate code is better than not having it.

          I'm uploading an updated patch for this and am going to split the de-duplication to a separate JIRA. Also generating the 2.7.2 files and bumping up the latest stable version to 2.6.0.

          /cc Wangda Tan / Jian He, please review, thanks!

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - The problem for the current solution is we're duplicating many maven code for hadoop-common/hdfs and yarn. We're also introducing duplications to mapreduce in the current approach. Going back and forth on this one. At this point, having this for 2.8.0 with duplicate code is better than not having it. I'm uploading an updated patch for this and am going to split the de-duplication to a separate JIRA. Also generating the 2.7.2 files and bumping up the latest stable version to 2.6.0. /cc Wangda Tan / Jian He , please review, thanks!
          Hide
          gtCarrera9 Li Lu added a comment -

          Sure. I'll cancel the patch.

          Show
          gtCarrera9 Li Lu added a comment - Sure. I'll cancel the patch.
          Hide
          djp Junping Du added a comment -

          The problem for the current solution is we're duplicating many maven code for hadoop-common/hdfs and yarn. We're also introducing duplications to mapreduce in the current approach. The next step for this work should be removing the duplications for those maven code.

          Hi Li Lu, shall we cancel the patch here until we figured out these problems?

          Show
          djp Junping Du added a comment - The problem for the current solution is we're duplicating many maven code for hadoop-common/hdfs and yarn. We're also introducing duplications to mapreduce in the current approach. The next step for this work should be removing the duplications for those maven code. Hi Li Lu , shall we cancel the patch here until we figured out these problems?
          Hide
          gtCarrera9 Li Lu added a comment -

          The problem for the current solution is we're duplicating many maven code for hadoop-common/hdfs and yarn. We're also introducing duplications to mapreduce in the current approach. The next step for this work should be removing the duplications for those maven code. Meanwhile, for YARN, we may want to add maven codes to generate javadocs for public APIs only, similar to hadoop-common/hdfs.

          Show
          gtCarrera9 Li Lu added a comment - The problem for the current solution is we're duplicating many maven code for hadoop-common/hdfs and yarn. We're also introducing duplications to mapreduce in the current approach. The next step for this work should be removing the duplications for those maven code. Meanwhile, for YARN, we may want to add maven codes to generate javadocs for public APIs only, similar to hadoop-common/hdfs.
          Hide
          gtCarrera9 Li Lu added a comment -

          Fixed the problem in hadoop-annotate for our javadoc doclet (missing some @Private tags for some methods). Upload the new patch with new API xmls.

          Show
          gtCarrera9 Li Lu added a comment - Fixed the problem in hadoop-annotate for our javadoc doclet (missing some @Private tags for some methods). Upload the new patch with new API xmls.
          Hide
          gtCarrera9 Li Lu added a comment -

          Thanks Vinod Kumar Vavilapalli for the review! For the second point, I traced into the code of our ExcludePrivateAnnotationsJDiffDoclet, and found this may actually be a bug for RootDocProcessor. Specifically, we are instrumenting each methods(true) call to a Doc entry, but we're not instrumenting methods() calls. methods() calls have exactly the same meaning as method(true) according to http://docs.oracle.com/javase/7/docs/jdk/api/javadoc/doclet/com/sun/javadoc/ClassDoc.html . I'll post a patch to fix this soon.

          Show
          gtCarrera9 Li Lu added a comment - Thanks Vinod Kumar Vavilapalli for the review! For the second point, I traced into the code of our ExcludePrivateAnnotationsJDiffDoclet, and found this may actually be a bug for RootDocProcessor. Specifically, we are instrumenting each methods(true) call to a Doc entry, but we're not instrumenting methods() calls. methods() calls have exactly the same meaning as method(true) according to http://docs.oracle.com/javase/7/docs/jdk/api/javadoc/doclet/com/sun/javadoc/ClassDoc.html . I'll post a patch to fix this soon.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          The bigger question is the duplication of the maven code across Common, YARN and MAPREDUCE. But this may take more time to cleanup.

          Removing it from 2.7.0 as the effort needed for this cleanup is huge.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - The bigger question is the duplication of the maven code across Common, YARN and MAPREDUCE. But this may take more time to cleanup. Removing it from 2.7.0 as the effort needed for this cleanup is huge.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Comments on the patch

          • The API links are broken. Changing it to apidocs works. <param name="-javadocnew" value="$ {project.build.directory}

            /site/api/"/>

          • Many private APIs are showing up in javadoc. For e.g., ContainerReport.newInstance is private but it shows up in jdiff and API docs.

          The bigger question is the duplication of the maven code across Common, YARN and MAPREDUCE. But this may take more time to cleanup. I'll use the output from this patch to figure out compatibility issues with 2.7.0, but remove this patch itself from 2.7.0.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Comments on the patch The API links are broken. Changing it to apidocs works. <param name="-javadocnew" value="$ {project.build.directory} /site/api/"/> Many private APIs are showing up in javadoc. For e.g., ContainerReport.newInstance is private but it shows up in jdiff and API docs. The bigger question is the duplication of the maven code across Common, YARN and MAPREDUCE. But this may take more time to cleanup. I'll use the output from this patch to figure out compatibility issues with 2.7.0, but remove this patch itself from 2.7.0.
          Hide
          gtCarrera9 Li Lu added a comment -

          Could not reproduce the mvn eclipse:eclipse failure locally. The failure looks to be irrelevant.

          Show
          gtCarrera9 Li Lu added a comment - Could not reproduce the mvn eclipse:eclipse failure locally. The failure looks to be irrelevant.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723684/YARN-3426-040715.patch
          against trunk revision d27e924.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          -1 eclipse:eclipse. The patch failed to build with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7247//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7247//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723684/YARN-3426-040715.patch against trunk revision d27e924. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 eclipse:eclipse . The patch failed to build with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7247//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7247//console This message is automatically generated.
          Hide
          gtCarrera9 Li Lu added a comment -

          Added license information to the four .xml API files.

          Show
          gtCarrera9 Li Lu added a comment - Added license information to the four .xml API files.
          Hide
          gtCarrera9 Li Lu added a comment -

          The failed unit test also breaks in trunk. Will file a blocker on this.

          Show
          gtCarrera9 Li Lu added a comment - The failed unit test also breaks in trunk. Will file a blocker on this.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723488/YARN-3426-040615-1.patch
          against trunk revision 3fb5abf.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 4 release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common:

          org.apache.hadoop.yarn.util.TestLog4jWarningErrorMetricsAppender

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7229//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7229//artifact/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7229//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7229//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723488/YARN-3426-040615-1.patch against trunk revision 3fb5abf. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 4 release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: org.apache.hadoop.yarn.util.TestLog4jWarningErrorMetricsAppender Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7229//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7229//artifact/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7229//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7229//console This message is automatically generated.
          Hide
          gtCarrera9 Li Lu added a comment -

          renamed one property for dev-support directory location.

          Show
          gtCarrera9 Li Lu added a comment - renamed one property for dev-support directory location.
          Hide
          gtCarrera9 Li Lu added a comment -

          The findbugs warnings are unrelated here. Reopened YARN-2901 to trace it.

          Show
          gtCarrera9 Li Lu added a comment - The findbugs warnings are unrelated here. Reopened YARN-2901 to trace it.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12723432/YARN-3426-040615.patch
          against trunk revision 28bebc8.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings.

          -1 release audit. The applied patch generated 4 release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7227//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7227//artifact/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7227//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7227//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723432/YARN-3426-040615.patch against trunk revision 28bebc8. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 4 release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7227//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7227//artifact/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-YARN-Build/7227//artifact/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7227//console This message is automatically generated.
          Hide
          gtCarrera9 Li Lu added a comment -

          In this patch I added jdiff support to YARN maven file. We're checking API compatibility for yarn-api, yarn-common, yarn-client and yarn-server-common now. I'm also attaching standard API file for those four components.

          jdiff result is generated via mvn package -Pdocs, same as hadoop-common and hadoop-hdfs.

          Show
          gtCarrera9 Li Lu added a comment - In this patch I added jdiff support to YARN maven file. We're checking API compatibility for yarn-api, yarn-common, yarn-client and yarn-server-common now. I'm also attaching standard API file for those four components. jdiff result is generated via mvn package -Pdocs , same as hadoop-common and hadoop-hdfs.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          HADOOP-11776 is in. I'd like this in for 2.7.0 so as to be able to reason about any incompatibilities introduced. Marking it as a blocker.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - HADOOP-11776 is in. I'd like this in for 2.7.0 so as to be able to reason about any incompatibilities introduced. Marking it as a blocker.

            People

            • Assignee:
              gtCarrera9 Li Lu
              Reporter:
              gtCarrera9 Li Lu
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development