Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3396

Handle URISyntaxException in ResourceLocalizationService

    Details

    • Hadoop Flags:
      Reviewed

      Description

      There are two occurrences of the following code snippet:

      //TODO fail? Already translated several times...
      

      It should be handled correctly in case that the resource URI is incorrect.

      1. YARN-3396.patch
        2 kB
        Brahma Reddy Battula
      2. YARN-3396-002.patch
        2 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        There are two occurrences of the following code snippet:

        Actually there are three occurences ,line num : 951,974, 1014

         } catch (URISyntaxException e) {
                    // TODO fail? Already translated several times...
                  }
        
        
        Show
        brahmareddy Brahma Reddy Battula added a comment - There are two occurrences of the following code snippet: Actually there are three occurences ,line num : 951,974, 1014 } catch (URISyntaxException e) { // TODO fail? Already translated several times... }
        Hide
        chengbing.liu Chengbing Liu added a comment -

        Can you check if you are using the latest code?

        Show
        chengbing.liu Chengbing Liu added a comment - Can you check if you are using the latest code?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        I referred 2.6 code,, Yes, it's there Only two places..will upload patch soon..

        Show
        brahmareddy Brahma Reddy Battula added a comment - I referred 2.6 code,, Yes, it's there Only two places..will upload patch soon..
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12707729/YARN-3396.patch
        against trunk revision af618f2.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:

        org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7121//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7121//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707729/YARN-3396.patch against trunk revision af618f2. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.TestResourceLocalizationService Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7121//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7121//console This message is automatically generated.
        Hide
        djp Junping Du added a comment -

        Thanks Brahma Reddy Battula for delivering a patch here. Several quick feedback here:
        1. Why we are setting log level to INFO in the first case while setting ERROR for the second case? I think we should keep consistent here, probably ERROR is suitable for both cases.
        2. This particular exception get thrown when decoding path from URL it contains, so we should put rsrc.getResource() and next.getResource() there instead of others you are putting now.
        3. More informative words than just "Got exception parsing." - may be something like "Got exception in parsing URL of LocalResource: " + next.getResource()?

        Show
        djp Junping Du added a comment - Thanks Brahma Reddy Battula for delivering a patch here. Several quick feedback here: 1. Why we are setting log level to INFO in the first case while setting ERROR for the second case? I think we should keep consistent here, probably ERROR is suitable for both cases. 2. This particular exception get thrown when decoding path from URL it contains, so we should put rsrc.getResource() and next.getResource() there instead of others you are putting now. 3. More informative words than just "Got exception parsing." - may be something like "Got exception in parsing URL of LocalResource: " + next.getResource()?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Junping Du thanks for taking a look into this issue..Updated the patch based on your comments..Kindly review!!

        Show
        brahmareddy Brahma Reddy Battula added a comment - Junping Du thanks for taking a look into this issue..Updated the patch based on your comments..Kindly review!!
        Hide
        djp Junping Du added a comment -

        Thanks Brahma Reddy Battula for updating the patch!
        v2 patch LGTM. +1 based on Jenkins' result.

        Show
        djp Junping Du added a comment - Thanks Brahma Reddy Battula for updating the patch! v2 patch LGTM. +1 based on Jenkins' result.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 43s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 33s There were no new javac warning messages.
        +1 javadoc 9m 30s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 35s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 yarn tests 5m 57s Tests passed in hadoop-yarn-server-nodemanager.
            41m 52s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730476/YARN-3396-002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 318081c
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7706/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7706/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7706/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 43s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 30s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 35s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 5m 57s Tests passed in hadoop-yarn-server-nodemanager.     41m 52s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730476/YARN-3396-002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 318081c hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7706/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7706/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7706/console This message was automatically generated.
        Hide
        djp Junping Du added a comment -

        This is a simple fix which doesn't need unit test. I will go ahead to commit this later today.

        Show
        djp Junping Du added a comment - This is a simple fix which doesn't need unit test. I will go ahead to commit this later today.
        Hide
        djp Junping Du added a comment -

        I have commit latest patch to trunk and branch-2. Thanks Brahma Reddy Battula for contributing the patch!

        Show
        djp Junping Du added a comment - I have commit latest patch to trunk and branch-2. Thanks Brahma Reddy Battula for contributing the patch!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7734 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7734/)
        YARN-3396. Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7734 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7734/ ) YARN-3396 . Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #185 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/185/)
        YARN-3396. Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #185 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/185/ ) YARN-3396 . Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #919 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/919/)
        YARN-3396. Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #919 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/919/ ) YARN-3396 . Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2117/)
        YARN-3396. Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2117/ ) YARN-3396 . Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/176/)
        YARN-3396. Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/176/ ) YARN-3396 . Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2135/)
        YARN-3396. Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2135/ ) YARN-3396 . Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/186/)
        YARN-3396. Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/186/ ) YARN-3396 . Handle URISyntaxException in ResourceLocalizationService. (Contributed by Brahma Reddy Battula) (junping_du: rev 38102420621308f5ba91cdeb6a18a63aa5acf640) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java hadoop-yarn-project/CHANGES.txt

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            chengbing.liu Chengbing Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development