Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-3382

Some of UserMetricsInfo metrics are incorrectly set to root queue metrics

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.0, 2.3.0, 2.4.0, 2.5.0, 2.6.0
    • Fix Version/s: 2.8.0, 2.7.1, 3.0.0-alpha1
    • Component/s: webapp
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      appsCompleted, appsPending, appsRunning etc. in UserMetricsInfo are incorrectly set to the root queue's value instead of the user's value.

      1. YARN-3382.patch
        2 kB
        Rohit Agarwal

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2124 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2124/)
        Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2124 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2124/ ) Moving YARN-3351 , YARN-3382 , YARN-3472 , MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1) hadoop-mapreduce-project/CHANGES.txt hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/175/)
        Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/175/ ) Moving YARN-3351 , YARN-3382 , YARN-3472 , MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1) hadoop-yarn-project/CHANGES.txt hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #165 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/165/)
        Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #165 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/165/ ) Moving YARN-3351 , YARN-3382 , YARN-3472 , MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1) hadoop-yarn-project/CHANGES.txt hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2106 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2106/)
        Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2106 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2106/ ) Moving YARN-3351 , YARN-3382 , YARN-3472 , MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1) hadoop-yarn-project/CHANGES.txt hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #908 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/908/)
        Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #908 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/908/ ) Moving YARN-3351 , YARN-3382 , YARN-3472 , MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1) hadoop-yarn-project/CHANGES.txt hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/174/)
        Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/174/ ) Moving YARN-3351 , YARN-3382 , YARN-3472 , MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1) hadoop-mapreduce-project/CHANGES.txt hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7673 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7673/)
        Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7673 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7673/ ) Moving YARN-3351 , YARN-3382 , YARN-3472 , MAPREDUCE-6238 to the 2.7.1 CHANGES.txt (vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1) hadoop-mapreduce-project/CHANGES.txt hadoop-yarn-project/CHANGES.txt
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        This seems like an important fix. I merged this into branch-2.7.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - This seems like an important fix. I merged this into branch-2.7.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2113 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2113/)
        YARN-3382. Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2113 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2113/ ) YARN-3382 . Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #164 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/164/)
        YARN-3382. Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #164 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/164/ ) YARN-3382 . Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #154 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/154/)
        YARN-3382. Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #154 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/154/ ) YARN-3382 . Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #897 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/897/)
        YARN-3382. Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #897 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/897/ ) YARN-3382 . Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2095 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2095/)
        YARN-3382. Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2095 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2095/ ) YARN-3382 . Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #163 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/163/)
        YARN-3382. Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #163 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/163/ ) YARN-3382 . Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7573 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7573/)
        YARN-3382. Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7573 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7573/ ) YARN-3382 . Some of UserMetricsInfo metrics are incorrectly set to root queue metrics. Contributed by Rohit Agarwal (jianhe: rev 944a16579fdb54c1c420162ef830ef2ac5451c69) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/UserMetricsInfo.java
        Hide
        jianhe Jian He added a comment -

        Committed to trunk and branch-2, thanks Rohit Agarwal !

        Show
        jianhe Jian He added a comment - Committed to trunk and branch-2, thanks Rohit Agarwal !
        Hide
        jianhe Jian He added a comment -

        lgtm, +1

        Show
        jianhe Jian He added a comment - lgtm, +1
        Hide
        ragarwal Rohit Agarwal added a comment -

        Can someone review/merge this?

        Show
        ragarwal Rohit Agarwal added a comment - Can someone review/merge this?
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12705811/YARN-3382.patch
        against trunk revision e37ca22.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7036//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7036//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705811/YARN-3382.patch against trunk revision e37ca22. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7036//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7036//console This message is automatically generated.
        Hide
        ragarwal Rohit Agarwal added a comment -

        Patch attached.

        Show
        ragarwal Rohit Agarwal added a comment - Patch attached.

          People

          • Assignee:
            ragarwal Rohit Agarwal
            Reporter:
            ragarwal Rohit Agarwal
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development